)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2bd192fb9650d54c7145943b21d6a1e97bb084fe","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The review allows related non-scenario tests which create"},{"line_number":10,"context_line":"volumes and servers to read and use"},{"line_number":11,"context_line":"CONF.scenario.default_availability_zone."},{"line_number":12,"context_line":"If the tests don\u0027t use the option and tested environment has"},{"line_number":13,"context_line":"multiple availability_zones, the tests fail."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9fb8cfa7_0746f750","line":11,"range":{"start_line":11,"start_character":14,"end_line":11,"end_character":39},"updated":"2019-06-18 11:28:15.000000000","message":"compute_volume_common_az","commit_id":"05e44507a8721760f1e3590ac635af1fb6b85a75"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2b1f3e6e05d9130c8a45f350e8e6f16decde85c5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The review allows related non-scenario tests which create"},{"line_number":10,"context_line":"volumes and servers to read and use"},{"line_number":11,"context_line":"CONF.scenario.default_availability_zone."},{"line_number":12,"context_line":"If the tests don\u0027t use the option and tested environment has"},{"line_number":13,"context_line":"multiple availability_zones, the tests fail."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9fb8cfa7_e76ba382","line":11,"range":{"start_line":11,"start_character":14,"end_line":11,"end_character":39},"in_reply_to":"9fb8cfa7_0746f750","updated":"2019-06-18 11:41:01.000000000","message":"oh, i forgot this, I\u0027ll change it.","commit_id":"05e44507a8721760f1e3590ac635af1fb6b85a75"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6bb4c63177e4b53c21a5675fb2932139221d5b47","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The review allows related non-scenario tests which create"},{"line_number":10,"context_line":"volumes and servers to read and use"},{"line_number":11,"context_line":"CONF.compute.compute_volume_common_az."},{"line_number":12,"context_line":"If the tests don\u0027t use the option and tested environment has"},{"line_number":13,"context_line":"multiple availability_zones, the tests fail."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Related-bug: #1647999"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fb8cfa7_4016b44b","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":44},"updated":"2019-06-24 19:06:13.000000000","message":"This is missing a bit of important context which is this should only fail if nova is configured with [cinder]/cross_az_attach\u003dFalse, which is not the default configuration:\n\nhttps://docs.openstack.org/nova/latest/configuration/config.html#cinder.cross_az_attach","commit_id":"00e6d6c2e9982db5438e21ef29b5e7cee885dfcf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2b9f94e7eb217b8c1c008768763f148e5021de66","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The review allows related non-scenario tests which create"},{"line_number":10,"context_line":"volumes and servers to read and use"},{"line_number":11,"context_line":"CONF.compute.compute_volume_common_az."},{"line_number":12,"context_line":"If the tests don\u0027t use the option and tested environment has"},{"line_number":13,"context_line":"multiple availability_zones, the tests fail."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Related-bug: #1647999"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fb8cfa7_e3580d32","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":44},"in_reply_to":"9fb8cfa7_4016b44b","updated":"2019-06-25 01:56:35.000000000","message":"true. These failures were with cross_az_attach\u003dFalse config setting.","commit_id":"00e6d6c2e9982db5438e21ef29b5e7cee885dfcf"}],"tempest/api/compute/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2bd192fb9650d54c7145943b21d6a1e97bb084fe","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            kwargs[\u0027display_name\u0027] \u003d vol_name"},{"line_number":488,"context_line":"        if image_ref is not None:"},{"line_number":489,"context_line":"            kwargs[\u0027imageRef\u0027] \u003d image_ref"},{"line_number":490,"context_line":"        if CONF.compute.compute_volume_common_az:"},{"line_number":491,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"},{"line_number":492,"context_line":"                              CONF.compute.compute_volume_common_az)"},{"line_number":493,"context_line":"        volume \u003d cls.volumes_client.create_volume(**kwargs)[\u0027volume\u0027]"},{"line_number":494,"context_line":"        cls.addClassResourceCleanup("},{"line_number":495,"context_line":"            cls.volumes_client.wait_for_resource_deletion, volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_c750df0d","line":492,"range":{"start_line":490,"start_character":0,"end_line":492,"end_character":68},"updated":"2019-06-18 11:28:15.000000000","message":"it will override the AZ if any test trying to explicitly test the AZ in kwargs. let\u0027s add AZ if not present in kwargs.\n\nif \u0027availability_zone\u0027 not in kwargs and CONF.compute.compute_volume_common_az:\n                kwargs.setdefault(\u0027availability_zone\u0027,\n                              CONF.compute.compute_volume_common_az)","commit_id":"05e44507a8721760f1e3590ac635af1fb6b85a75"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d5ae540c8b1fcb98daf0c50ccd09e8208403bba2","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            kwargs[\u0027display_name\u0027] \u003d vol_name"},{"line_number":488,"context_line":"        if image_ref is not None:"},{"line_number":489,"context_line":"            kwargs[\u0027imageRef\u0027] \u003d image_ref"},{"line_number":490,"context_line":"        if CONF.compute.compute_volume_common_az:"},{"line_number":491,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"},{"line_number":492,"context_line":"                              CONF.compute.compute_volume_common_az)"},{"line_number":493,"context_line":"        volume \u003d cls.volumes_client.create_volume(**kwargs)[\u0027volume\u0027]"},{"line_number":494,"context_line":"        cls.addClassResourceCleanup("},{"line_number":495,"context_line":"            cls.volumes_client.wait_for_resource_deletion, volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_e4db8a4c","line":492,"range":{"start_line":490,"start_character":0,"end_line":492,"end_character":68},"in_reply_to":"9fb8cfa7_675813fa","updated":"2019-06-19 11:17:32.000000000","message":"ahh, did not notice the setdefault() method. thanks","commit_id":"05e44507a8721760f1e3590ac635af1fb6b85a75"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2b1f3e6e05d9130c8a45f350e8e6f16decde85c5","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            kwargs[\u0027display_name\u0027] \u003d vol_name"},{"line_number":488,"context_line":"        if image_ref is not None:"},{"line_number":489,"context_line":"            kwargs[\u0027imageRef\u0027] \u003d image_ref"},{"line_number":490,"context_line":"        if CONF.compute.compute_volume_common_az:"},{"line_number":491,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"},{"line_number":492,"context_line":"                              CONF.compute.compute_volume_common_az)"},{"line_number":493,"context_line":"        volume \u003d cls.volumes_client.create_volume(**kwargs)[\u0027volume\u0027]"},{"line_number":494,"context_line":"        cls.addClassResourceCleanup("},{"line_number":495,"context_line":"            cls.volumes_client.wait_for_resource_deletion, volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_675813fa","line":492,"range":{"start_line":490,"start_character":0,"end_line":492,"end_character":68},"in_reply_to":"9fb8cfa7_c750df0d","updated":"2019-06-18 11:41:01.000000000","message":".setdefault shouldn\u0027t override the value. It will set the value only if it wasn\u0027t set before otherwise the new value will be ignored.","commit_id":"05e44507a8721760f1e3590ac635af1fb6b85a75"}],"tempest/api/volume/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2bd192fb9650d54c7145943b21d6a1e97bb084fe","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            name \u003d data_utils.rand_name(cls.__name__ + \u0027-Volume\u0027)"},{"line_number":125,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        if CONF.compute.compute_volume_common_az:"},{"line_number":128,"context_line":"            kwargs.setdefault(\u0027availability_zone\u0027,"},{"line_number":129,"context_line":"                              CONF.compute.compute_volume_common_az)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        volume \u003d cls.volumes_client.create_volume(**kwargs)[\u0027volume\u0027]"},{"line_number":132,"context_line":"        cls.addClassResourceCleanup(test_utils.call_and_ignore_notfound_exc,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_875ae727","line":129,"range":{"start_line":127,"start_character":0,"end_line":129,"end_character":68},"updated":"2019-06-18 11:28:15.000000000","message":"ditto","commit_id":"05e44507a8721760f1e3590ac635af1fb6b85a75"}],"tempest/common/compute.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2bd192fb9650d54c7145943b21d6a1e97bb084fe","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        # to be specified."},{"line_number":197,"context_line":"        image_id \u003d \u0027\u0027"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    if CONF.compute.compute_volume_common_az:"},{"line_number":200,"context_line":"        kwargs.setdefault(\u0027availability_zone\u0027,"},{"line_number":201,"context_line":"                          CONF.compute.compute_volume_common_az)"},{"line_number":202,"context_line":"    body \u003d clients.servers_client.create_server(name\u003dname, imageRef\u003dimage_id,"},{"line_number":203,"context_line":"                                                flavorRef\u003dflavor,"},{"line_number":204,"context_line":"                                                **kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_273f7bb6","line":201,"range":{"start_line":199,"start_character":0,"end_line":201,"end_character":64},"updated":"2019-06-18 11:28:15.000000000","message":"ditto","commit_id":"05e44507a8721760f1e3590ac635af1fb6b85a75"}]}