)]}'
{"tempest/api/compute/servers/test_servers.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"e93f6accf2418ed25801c4c66219d8e1239dbb99","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                          \u0027Image certificate validation not available.\u0027)"},{"line_number":192,"context_line":"    @decorators.idempotent_id(\u002771b8e3d5-11d2-494f-b917-b094a4afed3c\u0027)"},{"line_number":193,"context_line":"    def test_show_update_rebuild_list_server(self):"},{"line_number":194,"context_line":"        trusted_certs \u003d CONF.compute.image_cert_validation_trusted_certs"},{"line_number":195,"context_line":"        server \u003d self.create_test_server("},{"line_number":196,"context_line":"            imageRef\u003dCONF.compute.image_cert_validation_ref,"},{"line_number":197,"context_line":"            trusted_image_certificates\u003dtrusted_certs,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_2476cf71","line":194,"range":{"start_line":194,"start_character":23,"end_line":194,"end_character":72},"updated":"2019-06-14 09:01:22.000000000","message":"Can \"[\u0027test-cert-1\u0027, \u0027test-cert-2\u0027]\" work?","commit_id":"6f630b1ed9dbcc942d2d4da01c04aa74c99154f6"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"71467fb20338e07c55e62e09d7a829f0e33a4c43","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                          \u0027Image certificate validation not available.\u0027)"},{"line_number":192,"context_line":"    @decorators.idempotent_id(\u002771b8e3d5-11d2-494f-b917-b094a4afed3c\u0027)"},{"line_number":193,"context_line":"    def test_show_update_rebuild_list_server(self):"},{"line_number":194,"context_line":"        trusted_certs \u003d CONF.compute.image_cert_validation_trusted_certs"},{"line_number":195,"context_line":"        server \u003d self.create_test_server("},{"line_number":196,"context_line":"            imageRef\u003dCONF.compute.image_cert_validation_ref,"},{"line_number":197,"context_line":"            trusted_image_certificates\u003dtrusted_certs,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_5a5ab882","line":194,"range":{"start_line":194,"start_character":23,"end_line":194,"end_character":72},"in_reply_to":"9fb8cfa7_2476cf71","updated":"2019-06-14 11:56:38.000000000","message":"No, these values are useless and have only worked in the past thanks to other tests running first, caching the image and allowing the validation of these supposed certificates to be skipped. The test itself is pretty pointless without valid certificates being provided.","commit_id":"6f630b1ed9dbcc942d2d4da01c04aa74c99154f6"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"eae918ec511b53633d4ebc1ed2d68d58e9bc256a","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @testtools.skipUnless(CONF.compute.certified_image_ref,"},{"line_number":190,"context_line":"                          \u0027Image certificate validation not available.\u0027)"},{"line_number":191,"context_line":"    @testtools.skipUnless(CONF.compute.certified_image_trusted_certs,"},{"line_number":192,"context_line":"                          \u0027Image certificate validation not available.\u0027)"},{"line_number":193,"context_line":"    @decorators.idempotent_id(\u002771b8e3d5-11d2-494f-b917-b094a4afed3c\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_916e93c7","line":190,"range":{"start_line":190,"start_character":26,"end_line":190,"end_character":70},"updated":"2019-06-19 04:05:39.000000000","message":"Shall we put more accurate skip reason?","commit_id":"31c4da83594dad13151f7b26c5d3adc7053fd958"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"eae918ec511b53633d4ebc1ed2d68d58e9bc256a","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    @testtools.skipUnless(CONF.compute.certified_image_ref,"},{"line_number":190,"context_line":"                          \u0027Image certificate validation not available.\u0027)"},{"line_number":191,"context_line":"    @testtools.skipUnless(CONF.compute.certified_image_trusted_certs,"},{"line_number":192,"context_line":"                          \u0027Image certificate validation not available.\u0027)"},{"line_number":193,"context_line":"    @decorators.idempotent_id(\u002771b8e3d5-11d2-494f-b917-b094a4afed3c\u0027)"},{"line_number":194,"context_line":"    def test_show_update_rebuild_list_server(self):"},{"line_number":195,"context_line":"        trusted_certs \u003d CONF.compute.certified_image_trusted_certs"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_b17397b1","line":192,"range":{"start_line":192,"start_character":26,"end_line":192,"end_character":71},"updated":"2019-06-19 04:05:39.000000000","message":"ditto","commit_id":"31c4da83594dad13151f7b26c5d3adc7053fd958"}],"tempest/config.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bbcaf48f5f9c0a1201831eab7eaca4ea271a8854","unresolved":false,"context_lines":[{"line_number":271,"context_line":"               help\u003d\"Valid secondary image reference to be used in tests. \""},{"line_number":272,"context_line":"                    \"This is a required option, but if only one image is \""},{"line_number":273,"context_line":"                    \"available duplicate the value of image_ref above\"),"},{"line_number":274,"context_line":"    cfg.StrOpt(\u0027image_cert_validation_ref\u0027,"},{"line_number":275,"context_line":"               help\u003d\"Valid image reference to be used in image certificate \""},{"line_number":276,"context_line":"                    \"validation tests when enabled. This image should also \""},{"line_number":277,"context_line":"                    \"have the required img_signature_* properties set.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_0c461c51","line":274,"range":{"start_line":274,"start_character":16,"end_line":274,"end_character":41},"updated":"2019-06-18 10:39:40.000000000","message":"name is not so clear. can we change this to \u0027certified_image_ref\u0027","commit_id":"6f630b1ed9dbcc942d2d4da01c04aa74c99154f6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bbcaf48f5f9c0a1201831eab7eaca4ea271a8854","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                    \"available duplicate the value of image_ref above\"),"},{"line_number":274,"context_line":"    cfg.StrOpt(\u0027image_cert_validation_ref\u0027,"},{"line_number":275,"context_line":"               help\u003d\"Valid image reference to be used in image certificate \""},{"line_number":276,"context_line":"                    \"validation tests when enabled. This image should also \""},{"line_number":277,"context_line":"                    \"have the required img_signature_* properties set.\"),"},{"line_number":278,"context_line":"    cfg.ListOpt(\u0027image_cert_validation_trusted_certs\u0027,"},{"line_number":279,"context_line":"                help\u003d\"A list of trusted certificates to be used when the \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_ec6148d5","line":276,"range":{"start_line":276,"start_character":63,"end_line":276,"end_character":69},"updated":"2019-06-18 10:39:40.000000000","message":"s/should/must","commit_id":"6f630b1ed9dbcc942d2d4da01c04aa74c99154f6"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"e93f6accf2418ed25801c4c66219d8e1239dbb99","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    cfg.StrOpt(\u0027image_cert_validation_ref\u0027,"},{"line_number":275,"context_line":"               help\u003d\"Valid image reference to be used in image certificate \""},{"line_number":276,"context_line":"                    \"validation tests when enabled. This image should also \""},{"line_number":277,"context_line":"                    \"have the required img_signature_* properties set.\"),"},{"line_number":278,"context_line":"    cfg.ListOpt(\u0027image_cert_validation_trusted_certs\u0027,"},{"line_number":279,"context_line":"                help\u003d\"A list of trusted certificates to be used when the \""},{"line_number":280,"context_line":"                     \"image certificate validation feature is enabled.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_8429bb37","line":277,"range":{"start_line":277,"start_character":21,"end_line":277,"end_character":69},"updated":"2019-06-14 09:01:22.000000000","message":"Can we create an image in the testcase, and set the required properties? So we can omit image_cert_validation_ref config item.","commit_id":"6f630b1ed9dbcc942d2d4da01c04aa74c99154f6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bbcaf48f5f9c0a1201831eab7eaca4ea271a8854","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    cfg.StrOpt(\u0027image_cert_validation_ref\u0027,"},{"line_number":275,"context_line":"               help\u003d\"Valid image reference to be used in image certificate \""},{"line_number":276,"context_line":"                    \"validation tests when enabled. This image should also \""},{"line_number":277,"context_line":"                    \"have the required img_signature_* properties set.\"),"},{"line_number":278,"context_line":"    cfg.ListOpt(\u0027image_cert_validation_trusted_certs\u0027,"},{"line_number":279,"context_line":"                help\u003d\"A list of trusted certificates to be used when the \""},{"line_number":280,"context_line":"                     \"image certificate validation feature is enabled.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_ac9910d1","line":277,"range":{"start_line":277,"start_character":21,"end_line":277,"end_character":69},"in_reply_to":"9fb8cfa7_8401bb6c","updated":"2019-06-18 10:39:40.000000000","message":"+1 on adding the ref","commit_id":"6f630b1ed9dbcc942d2d4da01c04aa74c99154f6"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"71467fb20338e07c55e62e09d7a829f0e33a4c43","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    cfg.StrOpt(\u0027image_cert_validation_ref\u0027,"},{"line_number":275,"context_line":"               help\u003d\"Valid image reference to be used in image certificate \""},{"line_number":276,"context_line":"                    \"validation tests when enabled. This image should also \""},{"line_number":277,"context_line":"                    \"have the required img_signature_* properties set.\"),"},{"line_number":278,"context_line":"    cfg.ListOpt(\u0027image_cert_validation_trusted_certs\u0027,"},{"line_number":279,"context_line":"                help\u003d\"A list of trusted certificates to be used when the \""},{"line_number":280,"context_line":"                     \"image certificate validation feature is enabled.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_8401bb6c","line":277,"range":{"start_line":277,"start_character":21,"end_line":277,"end_character":69},"in_reply_to":"9fb8cfa7_8429bb37","updated":"2019-06-14 11:56:38.000000000","message":"No I don\u0027t think so. That would require downloading the image locally, generating the required certs, signing the image and finally calculating the signature etc.\n\nhttps://docs.openstack.org/nova/latest/user/certificate-validation.html\n\n^ I should really respin to include this reference.\n\nAdditionally, these properties would then be set against the image whilst it\u0027s used by other tests, that could easily lead to undesirable races etc.","commit_id":"6f630b1ed9dbcc942d2d4da01c04aa74c99154f6"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"e93f6accf2418ed25801c4c66219d8e1239dbb99","unresolved":false,"context_lines":[{"line_number":275,"context_line":"               help\u003d\"Valid image reference to be used in image certificate \""},{"line_number":276,"context_line":"                    \"validation tests when enabled. This image should also \""},{"line_number":277,"context_line":"                    \"have the required img_signature_* properties set.\"),"},{"line_number":278,"context_line":"    cfg.ListOpt(\u0027image_cert_validation_trusted_certs\u0027,"},{"line_number":279,"context_line":"                help\u003d\"A list of trusted certificates to be used when the \""},{"line_number":280,"context_line":"                     \"image certificate validation feature is enabled.\"),"},{"line_number":281,"context_line":"    cfg.StrOpt(\u0027flavor_ref\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_e400b7ad","line":278,"range":{"start_line":278,"start_character":17,"end_line":278,"end_character":52},"updated":"2019-06-14 09:01:22.000000000","message":"This has no default value, so I wonder whether the end user knows how to set this value.","commit_id":"6f630b1ed9dbcc942d2d4da01c04aa74c99154f6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bbcaf48f5f9c0a1201831eab7eaca4ea271a8854","unresolved":false,"context_lines":[{"line_number":275,"context_line":"               help\u003d\"Valid image reference to be used in image certificate \""},{"line_number":276,"context_line":"                    \"validation tests when enabled. This image should also \""},{"line_number":277,"context_line":"                    \"have the required img_signature_* properties set.\"),"},{"line_number":278,"context_line":"    cfg.ListOpt(\u0027image_cert_validation_trusted_certs\u0027,"},{"line_number":279,"context_line":"                help\u003d\"A list of trusted certificates to be used when the \""},{"line_number":280,"context_line":"                     \"image certificate validation feature is enabled.\"),"},{"line_number":281,"context_line":"    cfg.StrOpt(\u0027flavor_ref\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_8ca8ccdb","line":278,"range":{"start_line":278,"start_character":17,"end_line":278,"end_character":52},"updated":"2019-06-18 10:39:40.000000000","message":"this also, can we change to \u0027certified_image_trusted_certs\u0027","commit_id":"6f630b1ed9dbcc942d2d4da01c04aa74c99154f6"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"71467fb20338e07c55e62e09d7a829f0e33a4c43","unresolved":false,"context_lines":[{"line_number":275,"context_line":"               help\u003d\"Valid image reference to be used in image certificate \""},{"line_number":276,"context_line":"                    \"validation tests when enabled. This image should also \""},{"line_number":277,"context_line":"                    \"have the required img_signature_* properties set.\"),"},{"line_number":278,"context_line":"    cfg.ListOpt(\u0027image_cert_validation_trusted_certs\u0027,"},{"line_number":279,"context_line":"                help\u003d\"A list of trusted certificates to be used when the \""},{"line_number":280,"context_line":"                     \"image certificate validation feature is enabled.\"),"},{"line_number":281,"context_line":"    cfg.StrOpt(\u0027flavor_ref\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_7aebfc76","line":278,"range":{"start_line":278,"start_character":17,"end_line":278,"end_character":52},"in_reply_to":"9fb8cfa7_e400b7ad","updated":"2019-06-14 11:56:38.000000000","message":"We can\u0027t be expected to set a default when this value is entirely dependant on what images are being provided.","commit_id":"6f630b1ed9dbcc942d2d4da01c04aa74c99154f6"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"e93f6accf2418ed25801c4c66219d8e1239dbb99","unresolved":false,"context_lines":[{"line_number":554,"context_line":"                help\u003d\u0027Does the test environment support attaching a volume to \u0027"},{"line_number":555,"context_line":"                     \u0027more than one instance? This depends on hypervisor and \u0027"},{"line_number":556,"context_line":"                     \u0027volume backend/type and compute API version 2.60.\u0027),"},{"line_number":557,"context_line":"    cfg.BoolOpt(\u0027image_certificate_validation\u0027,"},{"line_number":558,"context_line":"                default\u003dFalse,"},{"line_number":559,"context_line":"                help\u003d\u0027Does the test environment support image certificate \u0027"},{"line_number":560,"context_line":"                     \u0027validation? This depends on compute API version 2.63, \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_e46bd781","line":557,"range":{"start_line":557,"start_character":16,"end_line":557,"end_character":47},"updated":"2019-06-14 09:01:22.000000000","message":"Three config items are added for one testcase, which seems a little too many:)\nSo, I wonder can we skip the testcase if image_cert_validation_ref not set, so image_certificate_validation is not needed.","commit_id":"6f630b1ed9dbcc942d2d4da01c04aa74c99154f6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bbcaf48f5f9c0a1201831eab7eaca4ea271a8854","unresolved":false,"context_lines":[{"line_number":554,"context_line":"                help\u003d\u0027Does the test environment support attaching a volume to \u0027"},{"line_number":555,"context_line":"                     \u0027more than one instance? This depends on hypervisor and \u0027"},{"line_number":556,"context_line":"                     \u0027volume backend/type and compute API version 2.60.\u0027),"},{"line_number":557,"context_line":"    cfg.BoolOpt(\u0027image_certificate_validation\u0027,"},{"line_number":558,"context_line":"                default\u003dFalse,"},{"line_number":559,"context_line":"                help\u003d\u0027Does the test environment support image certificate \u0027"},{"line_number":560,"context_line":"                     \u0027validation? This depends on compute API version 2.63, \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_ac827051","line":557,"range":{"start_line":557,"start_character":16,"end_line":557,"end_character":47},"in_reply_to":"9fb8cfa7_e46bd781","updated":"2019-06-18 10:39:40.000000000","message":"+1. if other options are not set then we can skip the test. That will avoid including this config option.","commit_id":"6f630b1ed9dbcc942d2d4da01c04aa74c99154f6"}]}