)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"4b402e17be9876b82d2083eadea6de6253e281f7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-01-11 08:38:48 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve the extra routes test on router"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I62891ebc522b1aa9689d9b4c0c8f88d9b4910c8b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2B9Tk%3D","line":8,"updated":"2014-01-20 12:18:24.000000000","message":"Commit message should contain more information.","commit_id":"664ad534ab2347f80b4419f5469c4b0d4777efb3"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"d5be3013f9537cf8e6434a19ee0ca80809b40fd1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve the extra routes test on router"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Insures that the values returned by the"},{"line_number":10,"context_line":"update_extra_routes method are correct and that"},{"line_number":11,"context_line":"the show_router method returns the extra route"},{"line_number":12,"context_line":"informatations."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUH%2F%2Bv0g%3D","line":9,"updated":"2014-01-22 15:14:49.000000000","message":"Insures -\u003e Insure","commit_id":"e5b8e5c1b1b3d98503e6db05dbe922dd7ba41ce1"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"d5be3013f9537cf8e6434a19ee0ca80809b40fd1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Insures that the values returned by the"},{"line_number":10,"context_line":"update_extra_routes method are correct and that"},{"line_number":11,"context_line":"the show_router method returns the extra route"},{"line_number":12,"context_line":"informatations."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I62891ebc522b1aa9689d9b4c0c8f88d9b4910c8b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUH%2F%2Bv0I%3D","line":12,"updated":"2014-01-22 15:14:49.000000000","message":"informations -\u003e information","commit_id":"e5b8e5c1b1b3d98503e6db05dbe922dd7ba41ce1"}],"tempest/api/network/test_routers.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3559ed1e0e0c81b609322748a14f26353fb5f1f3","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        # Update router extra route"},{"line_number":221,"context_line":"        cidr \u003d netaddr.IPNetwork(self.subnet[\u0027cidr\u0027])"},{"line_number":222,"context_line":"        resp, extra_route \u003d self.client.update_extra_routes("},{"line_number":223,"context_line":"            self.router[\u0027id\u0027], str(cidr[0]), str(self.subnet[\u0027cidr\u0027]))"},{"line_number":224,"context_line":"        self.assertEqual(str(self.subnet[\u0027cidr\u0027]),"},{"line_number":225,"context_line":"                         extra_route[\u0027router\u0027][\u0027routes\u0027][0][\u0027destination\u0027])"},{"line_number":226,"context_line":"        self.assertEqual(str(cidr[0]),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2FQLw%3D","line":223,"updated":"2014-03-07 08:48:15.000000000","message":"It is better to check the length of extra_route[\u0027router\u0027][\u0027routes\u0027] here.","commit_id":"69be8fbafff860e9e00f227ae00f397009caba04"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"e58513b47daeb5ed7da16f3b6ea21cb592b6cec0","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        # Update router extra route"},{"line_number":221,"context_line":"        cidr \u003d netaddr.IPNetwork(self.subnet[\u0027cidr\u0027])"},{"line_number":222,"context_line":"        resp, extra_route \u003d self.client.update_extra_routes("},{"line_number":223,"context_line":"            self.router[\u0027id\u0027], str(cidr[0]), str(self.subnet[\u0027cidr\u0027]))"},{"line_number":224,"context_line":"        self.assertEqual(str(self.subnet[\u0027cidr\u0027]),"},{"line_number":225,"context_line":"                         extra_route[\u0027router\u0027][\u0027routes\u0027][0][\u0027destination\u0027])"},{"line_number":226,"context_line":"        self.assertEqual(str(cidr[0]),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2B7Lo%3D","line":223,"in_reply_to":"AAAAVn%2F%2FQLw%3D","updated":"2014-03-11 08:58:51.000000000","message":"+1 can we check the response code and the length? Would be more obvious if something goes wrong in that part.","commit_id":"69be8fbafff860e9e00f227ae00f397009caba04"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6895d28b8b74b8aef9c1b13f394482337684fceb","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        # Update router extra route"},{"line_number":253,"context_line":"        cidr \u003d netaddr.IPNetwork(self.subnet[\u0027cidr\u0027])"},{"line_number":254,"context_line":"        resp, extra_route \u003d self.client.update_extra_routes("},{"line_number":255,"context_line":"            self.router[\u0027id\u0027], str(cidr[0]), str(self.subnet[\u0027cidr\u0027]))"},{"line_number":256,"context_line":"        self.assertEqual(1, len(extra_route[\u0027router\u0027][\u0027routes\u0027]))"},{"line_number":257,"context_line":"        self.assertEqual(str(self.subnet[\u0027cidr\u0027]),"},{"line_number":258,"context_line":"                         extra_route[\u0027router\u0027][\u0027routes\u0027][0][\u0027destination\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F29o%3D","line":255,"updated":"2014-03-13 10:29:15.000000000","message":"cidr[0] means first address of cidr, i.e., a network address of the cidr. It looks odd as next hop address. It is a good chance to change it.","commit_id":"009a1c6b1aa756716bb790b389d2029056231916"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"287510cddc950807fbd5f133e1b5502ed166649d","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        resp, show_body \u003d self.client.show_router(self.router[\u0027id\u0027])"},{"line_number":264,"context_line":"        self.assertEqual(str(self.subnet[\u0027cidr\u0027]),"},{"line_number":265,"context_line":"                         show_body[\u0027router\u0027][\u0027routes\u0027][0][\u0027destination\u0027])"},{"line_number":266,"context_line":"        self.assertEqual(str(cidr[0]),"},{"line_number":267,"context_line":"                         show_body[\u0027router\u0027][\u0027routes\u0027][0][\u0027nexthop\u0027])"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def _delete_extra_routes(self, router_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F9vuc%3D","line":266,"updated":"2014-04-02 12:38:17.000000000","message":"I think it should match L.255: cidr[2]","commit_id":"3e76c739812af72d41de661c74d59699d4663002"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"c0c4d2e3093742c1ace607a392a33e599c0266f6","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        next_hop \u003d str(cidr[2])"},{"line_number":256,"context_line":"        destination \u003d str(self.subnet[\u0027cidr\u0027])"},{"line_number":257,"context_line":"        resp, extra_route \u003d self.client.update_extra_routes("},{"line_number":258,"context_line":"            self.router[\u0027id\u0027], next_hop, destination)"},{"line_number":259,"context_line":"        self.assertEqual(1, len(extra_route[\u0027router\u0027][\u0027routes\u0027]))"},{"line_number":260,"context_line":"        self.assertEqual(destination,"},{"line_number":261,"context_line":"                         extra_route[\u0027router\u0027][\u0027routes\u0027][0][\u0027destination\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F9oig%3D","line":258,"updated":"2014-04-03 07:51:24.000000000","message":"Could you please add status code check here?","commit_id":"0870e46e6a2991482f2b0f314f069bed439476c2"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"c0c4d2e3093742c1ace607a392a33e599c0266f6","unresolved":false,"context_lines":[{"line_number":261,"context_line":"                         extra_route[\u0027router\u0027][\u0027routes\u0027][0][\u0027destination\u0027])"},{"line_number":262,"context_line":"        self.assertEqual(next_hop,"},{"line_number":263,"context_line":"                         extra_route[\u0027router\u0027][\u0027routes\u0027][0][\u0027nexthop\u0027])"},{"line_number":264,"context_line":"        resp, show_body \u003d self.client.show_router(self.router[\u0027id\u0027])"},{"line_number":265,"context_line":"        self.assertEqual(destination,"},{"line_number":266,"context_line":"                         show_body[\u0027router\u0027][\u0027routes\u0027][0][\u0027destination\u0027])"},{"line_number":267,"context_line":"        self.assertEqual(next_hop,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F9oic%3D","line":264,"updated":"2014-04-03 07:51:24.000000000","message":"Same here","commit_id":"0870e46e6a2991482f2b0f314f069bed439476c2"}]}