)]}'
{"tempest/common/waiters.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"5323075f61b32d0a40bfe415be218830c0d9d475","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                     time.time() - start_time)"},{"line_number":123,"context_line":"        if server_status \u003d\u003d \u0027ERROR\u0027 and not ignore_error:"},{"line_number":124,"context_line":"            raise lib_exc.DeleteErrorException("},{"line_number":125,"context_line":"                \"Server %s failed to delete and is in ERROR status\" %"},{"line_number":126,"context_line":"                server_id)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if int(time.time()) - start_time \u003e\u003d client.build_timeout:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_a4364450","line":125,"updated":"2019-06-14 02:01:17.000000000","message":"Do we have a room for improving DeleteErrorException class? Maybe, it can have more parameters like \u0027resource_type\u003d\"Resource\"\u0027, \u0027error_status\u003d\"ERROR\"\u0027.","commit_id":"0ded98ff6513c95a0691450c53f49f67e27062fb"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d14021adfe5213a869d56dcf48061ecbf2ce1356","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                     time.time() - start_time)"},{"line_number":123,"context_line":"        if server_status \u003d\u003d \u0027ERROR\u0027 and not ignore_error:"},{"line_number":124,"context_line":"            raise lib_exc.DeleteErrorException("},{"line_number":125,"context_line":"                \"Server %s failed to delete and is in ERROR status\" %"},{"line_number":126,"context_line":"                server_id)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if int(time.time()) - start_time \u003e\u003d client.build_timeout:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_817be0f2","line":125,"in_reply_to":"9fb8cfa7_64860cbc","updated":"2019-06-14 19:49:26.000000000","message":"Yep we will need to do that on all callers of this exception if changing the base message.\nThen are you fine to merge this instead of changing the base message, zhufl?","commit_id":"0ded98ff6513c95a0691450c53f49f67e27062fb"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"21ab6025da9654becbbdb39eda638a3e264f2b88","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                     time.time() - start_time)"},{"line_number":123,"context_line":"        if server_status \u003d\u003d \u0027ERROR\u0027 and not ignore_error:"},{"line_number":124,"context_line":"            raise lib_exc.DeleteErrorException("},{"line_number":125,"context_line":"                \"Server %s failed to delete and is in ERROR status\" %"},{"line_number":126,"context_line":"                server_id)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if int(time.time()) - start_time \u003e\u003d client.build_timeout:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_64860cbc","line":125,"in_reply_to":"9fb8cfa7_a4364450","updated":"2019-06-14 02:24:07.000000000","message":"Yes I have thought of that, but DeleteErrorException is in lib directory, adding more parameters for it may need modification of all callings.","commit_id":"0ded98ff6513c95a0691450c53f49f67e27062fb"}]}
