)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"949180df5a85b7c8a510ecf0320fc67163d9a326","unresolved":true,"context_lines":[{"line_number":17,"context_line":"In the multihost environment used by zuul there\u0027s only 1 physnet, so"},{"line_number":18,"context_line":"the tests can\u0027t add new segment for the 2nd host."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Related-Blueprint: blueprint routed-networks-scheduling"},{"line_number":21,"context_line":"Depends-On: https://review.opendev.org/c/openstack/nova/+/749068"},{"line_number":22,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron/+/777443"},{"line_number":23,"context_line":"Change-Id: Ie45e231441bb699fffffebe50b35921dbefccca2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"74660cc3_069dc0c9","line":20,"updated":"2021-03-04 09:42:51.000000000","message":"Implements: blueprint routed-networks-scheduling","commit_id":"56aa87442923e57fe4921029374e02f933393113"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"52c6407a391c1c8a4a18b1750fd4cf52e48c0d2c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"In the multihost environment used by zuul there\u0027s only 1 physnet, so"},{"line_number":18,"context_line":"the tests can\u0027t add new segment for the 2nd host."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Related-Blueprint: blueprint routed-networks-scheduling"},{"line_number":21,"context_line":"Depends-On: https://review.opendev.org/c/openstack/nova/+/749068"},{"line_number":22,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron/+/777443"},{"line_number":23,"context_line":"Change-Id: Ie45e231441bb699fffffebe50b35921dbefccca2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"4e92edbb_ff7f700e","line":20,"in_reply_to":"74660cc3_069dc0c9","updated":"2021-04-07 10:50:56.000000000","message":"Done","commit_id":"56aa87442923e57fe4921029374e02f933393113"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fdbb1abdee4cc6cd5a52cc89442b1ceb40e44233","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"acf0fe6b_07700190","updated":"2021-10-22 14:48:38.000000000","message":"recheck","commit_id":"7b04570a3a106fd3c9b141b792fd59076bd19f51"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"1688f454bb52c378c9d53dff9e7cf4d4561fc3fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"4e39870e_a9054377","updated":"2023-01-09 10:21:12.000000000","message":"I added a few comments regarding the docstrings.","commit_id":"25bf4007c4964adec1cbcdfe6c5b796ac078e3c9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3ca3b311c17fe3c589f9f4b509df316533f32a36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"076ea94b_b98e064b","updated":"2023-07-20 23:00:50.000000000","message":"sorry for the late response, these tests looks great. one comment online and please rebase to have the latest test result","commit_id":"25bf4007c4964adec1cbcdfe6c5b796ac078e3c9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"92d0277fa2b8e8113e55d8cbef4d4224839c001b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"5b55b16d_6532dec8","in_reply_to":"076ea94b_b98e064b","updated":"2023-07-25 09:01:41.000000000","message":"thanks, I have doubts if all of these work currently, but let\u0027s see, the current situation and merge what is working and we have better coverage.","commit_id":"25bf4007c4964adec1cbcdfe6c5b796ac078e3c9"}],"tempest/scenario/test_routed_provider_network.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d093217c2cf260e4c7ba0dcb8b5f075c0bca1305","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        ** Create IPv4 subnet with the segment_id (with allocation_pools"},{"line_number":47,"context_line":"        select a 1 ip wide range for easier testing)"},{"line_number":48,"context_line":"        ** Check that"},{"line_number":49,"context_line":"        *** aggregate for segment is created"},{"line_number":50,"context_line":"        *** resource provider for segment is created"},{"line_number":51,"context_line":"        *** IPV4_ADDRESS resoirce provider inventory is created for subnet"},{"line_number":52,"context_line":"        * Create another segment (for 2nd host\u0027s physnet for example)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_4a2ffdf5","line":49,"range":{"start_line":49,"start_character":12,"end_line":49,"end_character":21},"updated":"2019-06-19 13:42:59.000000000","message":"Placement aggregate, nova host aggregate, both?","commit_id":"e2f6604a6e65cf190b779bf64c3c4a7d424f762a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5047743ad044b45351a6f6697d33e32efbc0b0d8","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        ** Create IPv4 subnet with the segment_id (with allocation_pools"},{"line_number":47,"context_line":"        select a 1 ip wide range for easier testing)"},{"line_number":48,"context_line":"        ** Check that"},{"line_number":49,"context_line":"        *** aggregate for segment is created"},{"line_number":50,"context_line":"        *** resource provider for segment is created"},{"line_number":51,"context_line":"        *** IPV4_ADDRESS resoirce provider inventory is created for subnet"},{"line_number":52,"context_line":"        * Create another segment (for 2nd host\u0027s physnet for example)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_3803f044","line":49,"range":{"start_line":49,"start_character":12,"end_line":49,"end_character":21},"in_reply_to":"9fb8cfa7_4a2ffdf5","updated":"2019-06-20 07:54:46.000000000","message":"thanks, nova aggregate, at least it is now nova aggregate.","commit_id":"e2f6604a6e65cf190b779bf64c3c4a7d424f762a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d093217c2cf260e4c7ba0dcb8b5f075c0bca1305","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        ** Check that"},{"line_number":49,"context_line":"        *** aggregate for segment is created"},{"line_number":50,"context_line":"        *** resource provider for segment is created"},{"line_number":51,"context_line":"        *** IPV4_ADDRESS resoirce provider inventory is created for subnet"},{"line_number":52,"context_line":"        * Create another segment (for 2nd host\u0027s physnet for example)"},{"line_number":53,"context_line":"        ** Create an IPv4 subnet with the segment id (with allocation_pools"},{"line_number":54,"context_line":"        select a 1 ip wide range for easier testing)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_6a4761be","line":51,"range":{"start_line":51,"start_character":25,"end_line":51,"end_character":33},"updated":"2019-06-19 13:42:59.000000000","message":"nit:resource","commit_id":"e2f6604a6e65cf190b779bf64c3c4a7d424f762a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5047743ad044b45351a6f6697d33e32efbc0b0d8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        ** Check that"},{"line_number":49,"context_line":"        *** aggregate for segment is created"},{"line_number":50,"context_line":"        *** resource provider for segment is created"},{"line_number":51,"context_line":"        *** IPV4_ADDRESS resoirce provider inventory is created for subnet"},{"line_number":52,"context_line":"        * Create another segment (for 2nd host\u0027s physnet for example)"},{"line_number":53,"context_line":"        ** Create an IPv4 subnet with the segment id (with allocation_pools"},{"line_number":54,"context_line":"        select a 1 ip wide range for easier testing)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_58fee438","line":51,"range":{"start_line":51,"start_character":25,"end_line":51,"end_character":33},"in_reply_to":"9fb8cfa7_6a4761be","updated":"2019-06-20 07:54:46.000000000","message":"Done","commit_id":"e2f6604a6e65cf190b779bf64c3c4a7d424f762a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d093217c2cf260e4c7ba0dcb8b5f075c0bca1305","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        * Boot VM on the proivder network"},{"line_number":57,"context_line":"        ** Check that"},{"line_number":58,"context_line":"        ** the inventory of the given resource provider (the one for the"},{"line_number":59,"context_line":"        segment on which the VM was booted) reserved number is changed."},{"line_number":60,"context_line":"        * Boot another VM"},{"line_number":61,"context_line":"        ** Check that"},{"line_number":62,"context_line":"        ** it is booted on the other host/segment"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_4a661d54","line":59,"range":{"start_line":59,"start_character":44,"end_line":59,"end_character":70},"updated":"2019-06-19 13:42:59.000000000","message":"Does neutron change the reserved value of the IPV4_ADDRESS inventory when an IP is allocated fro the VM?","commit_id":"e2f6604a6e65cf190b779bf64c3c4a7d424f762a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5047743ad044b45351a6f6697d33e32efbc0b0d8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        * Boot VM on the proivder network"},{"line_number":57,"context_line":"        ** Check that"},{"line_number":58,"context_line":"        ** the inventory of the given resource provider (the one for the"},{"line_number":59,"context_line":"        segment on which the VM was booted) reserved number is changed."},{"line_number":60,"context_line":"        * Boot another VM"},{"line_number":61,"context_line":"        ** Check that"},{"line_number":62,"context_line":"        ** it is booted on the other host/segment"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_18294c9a","line":59,"range":{"start_line":59,"start_character":44,"end_line":59,"end_character":70},"in_reply_to":"9fb8cfa7_4a661d54","updated":"2019-06-20 07:54:46.000000000","message":"By code it changes (the code is there in neutron for changing the reserved number i.e.), but now it does not as port update notifications in neutron doesn\u0027t contain the fixed ip (I have  to double check that to be sure) there is no inventory update sent from neutron to placement.\nThis part is not clear, so more check is necessary.","commit_id":"e2f6604a6e65cf190b779bf64c3c4a7d424f762a"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5551433e06c13e6faf3f62183f2d5122f28431df","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        n_aggregates \u003d self.aggregates_client.list_aggregates()"},{"line_number":101,"context_line":"        is_aggregate_created \u003d False"},{"line_number":102,"context_line":"        for n_agg in n_aggregates[\u0027aggregates\u0027]:"},{"line_number":103,"context_line":"            if segment_id in n_agg[\u0027name\u0027]:"},{"line_number":104,"context_line":"                is_aggregate_created \u003d True"},{"line_number":105,"context_line":"        if not is_aggregate_created:"},{"line_number":106,"context_line":"            LOG.warning(\u0027No aggregate was created for segment!\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_7138a83c","line":103,"updated":"2020-02-27 02:25:49.000000000","message":"Per spec, a more correct comparison is:\n\nif n_agg[\u0027name\u0027].endswith(segment_id)\n\nbut, probably it doesn\u0027t matter too much","commit_id":"5c54539513a61b222fa58af2f1d59783987f9d3b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"73ce945adfdf1778fc797738f3814d3c69049c10","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        n_aggregates \u003d self.aggregates_client.list_aggregates()"},{"line_number":101,"context_line":"        is_aggregate_created \u003d False"},{"line_number":102,"context_line":"        for n_agg in n_aggregates[\u0027aggregates\u0027]:"},{"line_number":103,"context_line":"            if segment_id in n_agg[\u0027name\u0027]:"},{"line_number":104,"context_line":"                is_aggregate_created \u003d True"},{"line_number":105,"context_line":"        if not is_aggregate_created:"},{"line_number":106,"context_line":"            LOG.warning(\u0027No aggregate was created for segment!\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_5d69a41e","line":103,"in_reply_to":"1fa4df85_7138a83c","updated":"2020-03-04 12:55:45.000000000","message":"yeah, true, I can change that, that would give a more strict check.","commit_id":"5c54539513a61b222fa58af2f1d59783987f9d3b"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5551433e06c13e6faf3f62183f2d5122f28431df","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        \"\"\""},{"line_number":158,"context_line":"        # Note(lajoskatona): in multihost environment as I see devstacks used"},{"line_number":159,"context_line":"        # by zuul has 1 phsynet, so I can\u0027t add another segment for the 2nd"},{"line_number":160,"context_line":"        # host."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        self._create_net_and_add_segment_to_subnet()"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_116db431","line":160,"updated":"2020-02-27 02:25:49.000000000","message":"So basically, this test actually ends after doing a single subnet and a single VM boot (line 137-144, 149-152)?","commit_id":"5c54539513a61b222fa58af2f1d59783987f9d3b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"73ce945adfdf1778fc797738f3814d3c69049c10","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        \"\"\""},{"line_number":158,"context_line":"        # Note(lajoskatona): in multihost environment as I see devstacks used"},{"line_number":159,"context_line":"        # by zuul has 1 phsynet, so I can\u0027t add another segment for the 2nd"},{"line_number":160,"context_line":"        # host."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        self._create_net_and_add_segment_to_subnet()"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_18125a0a","line":160,"in_reply_to":"1fa4df85_116db431","updated":"2020-03-04 12:55:45.000000000","message":"yes, if we see that the feature starts to be working we can change this to work on multihost devstack and perhaps add other tests, like VM migrations or whatever.","commit_id":"5c54539513a61b222fa58af2f1d59783987f9d3b"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5551433e06c13e6faf3f62183f2d5122f28431df","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            status\u003d\u0027ACTIVE\u0027)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        port \u003d self.ports_client.list_ports(device_id\u003dserver[\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":180,"context_line":"        self.assertEqual(self.DEFERRED, port[\u0027ip_allocation\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        # Do we need to check this again?"},{"line_number":183,"context_line":"        test_utils.call_until_true("}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_112854e0","line":180,"updated":"2020-02-27 02:25:49.000000000","message":"I weirdly don\u0027t see this `ip_allocation` field on any ports in my cloud... I wanted to confirm it remained after the server went active, but i can\u0027t actually see it, so maybe it doesn\u0027t? or else maybe my version of nova is too old (still running Rocky, this may be a new field?)","commit_id":"5c54539513a61b222fa58af2f1d59783987f9d3b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"73ce945adfdf1778fc797738f3814d3c69049c10","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            status\u003d\u0027ACTIVE\u0027)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        port \u003d self.ports_client.list_ports(device_id\u003dserver[\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":180,"context_line":"        self.assertEqual(self.DEFERRED, port[\u0027ip_allocation\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        # Do we need to check this again?"},{"line_number":183,"context_line":"        test_utils.call_until_true("}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_bddc58e4","line":180,"in_reply_to":"1fa4df85_112854e0","updated":"2020-03-04 12:55:45.000000000","message":"It seems that is missing from osc....\nI tried with good-old neutron-client and voila....\nI check that","commit_id":"5c54539513a61b222fa58af2f1d59783987f9d3b"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5551433e06c13e6faf3f62183f2d5122f28431df","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        port \u003d self.ports_client.list_ports(device_id\u003dserver[\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":180,"context_line":"        self.assertEqual(self.DEFERRED, port[\u0027ip_allocation\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        # Do we need to check this again?"},{"line_number":183,"context_line":"        test_utils.call_until_true("},{"line_number":184,"context_line":"            self._check_if_basic_resources_created,"},{"line_number":185,"context_line":"            duration\u003d30, sleep_for\u003d5, segment_id\u003dself.segments[0][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_11db74ed","line":182,"updated":"2020-02-27 02:25:49.000000000","message":"No?","commit_id":"5c54539513a61b222fa58af2f1d59783987f9d3b"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5551433e06c13e6faf3f62183f2d5122f28431df","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # Check if we can reach the max number of the allocation pool. For this"},{"line_number":195,"context_line":"        # decrease the size of the subnet cidr to a few available IPs"},{"line_number":196,"context_line":"        # Is it a valid test?"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    @decorators.idempotent_id(\u00279eba5ffd-0474-468b-9471-5623301f9ca4\u0027)"},{"line_number":199,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_d1763c07","line":196,"updated":"2020-02-27 02:25:49.000000000","message":"So, since you did reduce the pool size to 1, this comment must be old?","commit_id":"5c54539513a61b222fa58af2f1d59783987f9d3b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"73ce945adfdf1778fc797738f3814d3c69049c10","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # Check if we can reach the max number of the allocation pool. For this"},{"line_number":195,"context_line":"        # decrease the size of the subnet cidr to a few available IPs"},{"line_number":196,"context_line":"        # Is it a valid test?"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    @decorators.idempotent_id(\u00279eba5ffd-0474-468b-9471-5623301f9ca4\u0027)"},{"line_number":199,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_fd9c100f","line":196,"in_reply_to":"1fa4df85_d1763c07","updated":"2020-03-04 12:55:45.000000000","message":"That is in the comments, but not in the code :-)\nThe allocation pool is now 16, which comes from tempest.conf, I started to check how I should push through the depths of tempest the info that I would like smaller subnets, but not that easy.\nI come back with that.","commit_id":"5c54539513a61b222fa58af2f1d59783987f9d3b"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5551433e06c13e6faf3f62183f2d5122f28431df","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                           \u0027After port creation there should be more reserved \u0027"},{"line_number":235,"context_line":"                           \u0027IPV4_ADDRESSes!\u0027)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # Do we need to check this again?"},{"line_number":238,"context_line":"        test_utils.call_until_true("},{"line_number":239,"context_line":"            self._check_if_basic_resources_created,"},{"line_number":240,"context_line":"            duration\u003d30, sleep_for\u003d5, segment_id\u003dself.segments[0][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_3151d063","line":237,"updated":"2020-02-27 02:25:49.000000000","message":"No?","commit_id":"5c54539513a61b222fa58af2f1d59783987f9d3b"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5551433e06c13e6faf3f62183f2d5122f28431df","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        # Boot VM with the precreated port"},{"line_number":243,"context_line":"        server \u003d self.create_server("},{"line_number":244,"context_line":"            networks\u003d[{\u0027uuid\u0027: self.prov_network[\u0027id\u0027]}])"},{"line_number":245,"context_line":"        waiters.wait_for_server_status("},{"line_number":246,"context_line":"            client\u003dself.os.servers_client, server_id\u003dserver[\u0027id\u0027],"},{"line_number":247,"context_line":"            status\u003d\u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_91c76413","line":244,"updated":"2020-02-27 02:25:49.000000000","message":"this is just passing network again, not using the port you created :/","commit_id":"5c54539513a61b222fa58af2f1d59783987f9d3b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"73ce945adfdf1778fc797738f3814d3c69049c10","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        # Boot VM with the precreated port"},{"line_number":243,"context_line":"        server \u003d self.create_server("},{"line_number":244,"context_line":"            networks\u003d[{\u0027uuid\u0027: self.prov_network[\u0027id\u0027]}])"},{"line_number":245,"context_line":"        waiters.wait_for_server_status("},{"line_number":246,"context_line":"            client\u003dself.os.servers_client, server_id\u003dserver[\u0027id\u0027],"},{"line_number":247,"context_line":"            status\u003d\u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_9df87c49","line":244,"in_reply_to":"1fa4df85_91c76413","updated":"2020-03-04 12:55:45.000000000","message":"thanks, that\u0027s true\nI have to change the clients to use admin creds for this, as the net and port was created as admin.","commit_id":"5c54539513a61b222fa58af2f1d59783987f9d3b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f160299b97b70a630bee5a30eab9c224c6acf8e0","unresolved":true,"context_lines":[{"line_number":158,"context_line":"        \"\"\""},{"line_number":159,"context_line":"        # Note(lajoskatona): in multihost environment as I see devstacks used"},{"line_number":160,"context_line":"        # by zuul has 1 phsynet, so I can\u0027t add another segment for the 2nd"},{"line_number":161,"context_line":"        # host."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        self._create_net_and_add_segment_to_subnet()"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"f8a7ddc5_32e3026f","line":161,"updated":"2021-02-25 08:18:38.000000000","message":"This is why the test description should be changed, to properly describe what is done in the test.","commit_id":"bcfd105a442953643e740da46eb5bf0a54be94e1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b04b8f7ecf2f2749aac534fceb279d49e2453e7b","unresolved":true,"context_lines":[{"line_number":158,"context_line":"        \"\"\""},{"line_number":159,"context_line":"        # Note(lajoskatona): in multihost environment as I see devstacks used"},{"line_number":160,"context_line":"        # by zuul has 1 phsynet, so I can\u0027t add another segment for the 2nd"},{"line_number":161,"context_line":"        # host."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        self._create_net_and_add_segment_to_subnet()"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"19601d3c_f785a155","line":161,"in_reply_to":"f8a7ddc5_32e3026f","updated":"2021-02-26 08:47:12.000000000","message":"Thanks I will fix the test description","commit_id":"bcfd105a442953643e740da46eb5bf0a54be94e1"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"949180df5a85b7c8a510ecf0320fc67163d9a326","unresolved":true,"context_lines":[{"line_number":26,"context_line":"CONF \u003d config.CONF"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class RoutedProviderNetworksTest(manager.NetworkScenarioTest):"},{"line_number":30,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":31,"context_line":"    required_extensions \u003d [\u0027segments\u0027]"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"b67621a4_1e62c57f","line":29,"updated":"2021-03-04 09:42:51.000000000","message":"It should be TestRoutedProviderNetworks. Please add docstring here explaining the whole test suite.","commit_id":"56aa87442923e57fe4921029374e02f933393113"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"52c6407a391c1c8a4a18b1750fd4cf52e48c0d2c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"CONF \u003d config.CONF"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class RoutedProviderNetworksTest(manager.NetworkScenarioTest):"},{"line_number":30,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":31,"context_line":"    required_extensions \u003d [\u0027segments\u0027]"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"0402c64b_3bcbae5b","line":29,"in_reply_to":"b67621a4_1e62c57f","updated":"2021-04-07 10:50:56.000000000","message":"Done\nThe detailed test descriptions are for the tests, is that OK?","commit_id":"56aa87442923e57fe4921029374e02f933393113"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"949180df5a85b7c8a510ecf0320fc67163d9a326","unresolved":true,"context_lines":[{"line_number":124,"context_line":"        return (self.alloc_pool_size[segment_id] \u003d\u003d"},{"line_number":125,"context_line":"                (ipv4_inventory[\u0027total\u0027] + ipv4_inventory[\u0027reserved\u0027]))"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _get_reserved_allocation(self, segment_id):"},{"line_number":128,"context_line":"        inventory \u003d self.rps_client.list_resource_provider_inventories("},{"line_number":129,"context_line":"            rp_uuid\u003dsegment_id)[\u0027inventories\u0027]"},{"line_number":130,"context_line":"        return inventory[self.IPV4_RESOURCE_CLASS][\u0027reserved\u0027]"}],"source_content_type":"text/x-python","patch_set":27,"id":"00eb8306_6516e848","line":127,"updated":"2021-03-04 09:42:51.000000000","message":"Method requires docstring.","commit_id":"56aa87442923e57fe4921029374e02f933393113"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"52c6407a391c1c8a4a18b1750fd4cf52e48c0d2c","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        return (self.alloc_pool_size[segment_id] \u003d\u003d"},{"line_number":125,"context_line":"                (ipv4_inventory[\u0027total\u0027] + ipv4_inventory[\u0027reserved\u0027]))"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _get_reserved_allocation(self, segment_id):"},{"line_number":128,"context_line":"        inventory \u003d self.rps_client.list_resource_provider_inventories("},{"line_number":129,"context_line":"            rp_uuid\u003dsegment_id)[\u0027inventories\u0027]"},{"line_number":130,"context_line":"        return inventory[self.IPV4_RESOURCE_CLASS][\u0027reserved\u0027]"}],"source_content_type":"text/x-python","patch_set":27,"id":"c3b0f6e7_f705271b","line":127,"in_reply_to":"00eb8306_6516e848","updated":"2021-04-07 10:50:56.000000000","message":"Done","commit_id":"56aa87442923e57fe4921029374e02f933393113"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"949180df5a85b7c8a510ecf0320fc67163d9a326","unresolved":true,"context_lines":[{"line_number":135,"context_line":"        \"\"\"Basic scenario for routed provider networks."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        Steps:"},{"line_number":138,"context_line":"        * Create provider network"},{"line_number":139,"context_line":"        ** Check that related segment was created"},{"line_number":140,"context_line":"        ** Create IPv4 subnet with the segment_id (with allocation_pools"},{"line_number":141,"context_line":"        select a 1 ip wide range for easier testing)"}],"source_content_type":"text/x-python","patch_set":27,"id":"ef052eb0_015c4e78","line":138,"updated":"2021-03-04 09:42:51.000000000","message":"Can we follow unique docstring style across all the scenario tests e.g\n1. Create provider network\n2. Check that related segment was created\n\nor\n\n* Create provider network\n* Check that related segment was created\n\nPlease refer the following links:-\n1. https://opendev.org/openstack/tempest/src/branch/master/tempest/scenario/test_network_v6.py#L32\n2. https://opendev.org/openstack/tempest/src/branch/master/tempest/scenario/test_network_advanced_server_ops.py#L30\n3. https://opendev.org/openstack/tempest/src/branch/master/tempest/scenario/test_encrypted_cinder_volumes.py#L33","commit_id":"56aa87442923e57fe4921029374e02f933393113"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"52c6407a391c1c8a4a18b1750fd4cf52e48c0d2c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        \"\"\"Basic scenario for routed provider networks."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        Steps:"},{"line_number":138,"context_line":"        * Create provider network"},{"line_number":139,"context_line":"        ** Check that related segment was created"},{"line_number":140,"context_line":"        ** Create IPv4 subnet with the segment_id (with allocation_pools"},{"line_number":141,"context_line":"        select a 1 ip wide range for easier testing)"}],"source_content_type":"text/x-python","patch_set":27,"id":"e6866bb2_823300e5","line":138,"in_reply_to":"ef052eb0_015c4e78","updated":"2021-04-07 10:50:56.000000000","message":"Done","commit_id":"56aa87442923e57fe4921029374e02f933393113"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"62868d410f9ff3a2ad527c4a3b9a97c32579e300","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":39,"id":"5a195541_9c188f64","updated":"2022-11-23 20:33:16.000000000","message":"In my local env these tests pass only if I execute them serially...","commit_id":"924218fcb81a27edd1254f32eb601daf7f01eaa5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"62868d410f9ff3a2ad527c4a3b9a97c32579e300","unresolved":true,"context_lines":[{"line_number":209,"context_line":"        self.assertEqual(self.DEFERRED, port[\u0027ip_allocation\u0027])"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        # # Check that the reserved number increased"},{"line_number":212,"context_line":"        # reserved_after_vm \u003d self._get_reserved_allocation("},{"line_number":213,"context_line":"        #     self.segments[0][\u0027id\u0027])"},{"line_number":214,"context_line":"        # self.assertGreater(reserved_after_vm, original_reserved,"},{"line_number":215,"context_line":"        #                    \u0027After VM boot there should be more reserved \u0027"},{"line_number":216,"context_line":"        #                    \u0027IPV4_ADDRESSes!\u0027)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        # Check if we can reach the max number of the allocation pool. For this"},{"line_number":219,"context_line":"        # decrease the size of the subnet cidr to a few available IPs"}],"source_content_type":"text/x-python","patch_set":39,"id":"4e06b87e_ca1adbc8","line":216,"range":{"start_line":212,"start_character":0,"end_line":216,"end_character":47},"updated":"2022-11-23 20:33:16.000000000","message":"I don\u0027t know why the reservation is not increased in my local env, I have to check that.","commit_id":"924218fcb81a27edd1254f32eb601daf7f01eaa5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"62868d410f9ff3a2ad527c4a3b9a97c32579e300","unresolved":true,"context_lines":[{"line_number":269,"context_line":"            status\u003d\u0027ACTIVE\u0027)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        # # Check that the reserved number remained the same"},{"line_number":272,"context_line":"        # reserved_after_vm \u003d self._get_reserved_allocation("},{"line_number":273,"context_line":"        #     self.segments[0][\u0027id\u0027])"},{"line_number":274,"context_line":"        # self.assertEqual(reserved_after_port, reserved_after_vm)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    @decorators.idempotent_id(\u002726c20982-681e-4d05-bcf5-283b9daa5d37\u0027)"},{"line_number":277,"context_line":"    @utils.services(\u0027compute\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":39,"id":"5fd70227_45540776","line":274,"range":{"start_line":272,"start_character":0,"end_line":274,"end_character":66},"updated":"2022-11-23 20:33:16.000000000","message":"ditto","commit_id":"924218fcb81a27edd1254f32eb601daf7f01eaa5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"221ddf34d37d45ff1b84c1c4b2eb82ce54fe36dc","unresolved":true,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    @decorators.idempotent_id(\u002726c20982-681e-4d05-bcf5-283b9daa5d37\u0027)"},{"line_number":277,"context_line":"    @utils.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":278,"context_line":"    def test_multiple_routed_provider_net_per_host(self):"},{"line_number":279,"context_line":"        if not utils.is_network_feature_enabled(\u0027multiple_segments_on_host\u0027):"},{"line_number":280,"context_line":"            raise self.skipException(\"Multiple routed provider segment per \""},{"line_number":281,"context_line":"                                     \"host must be enabled to execute this \""}],"source_content_type":"text/x-python","patch_set":41,"id":"fc751c1d_6cb1c58f","line":278,"updated":"2022-11-25 09:30:22.000000000","message":"Isn\u0027t: multiple segments on a routed provider net per host?","commit_id":"be7c3beae5bc3df82f2c609b23bac16e0510a7cb"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"221ddf34d37d45ff1b84c1c4b2eb82ce54fe36dc","unresolved":true,"context_lines":[{"line_number":308,"context_line":"            segment_2[\u0027id\u0027])"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        # Create port with fixed IP on first subnet:"},{"line_number":311,"context_line":"        port_1 \u003d self._create_port_with_fixed_ip_from_subnet(self.subnets[-1])"},{"line_number":312,"context_line":"        port_1 \u003d self.ports_client.show_port(port_1[\u0027id\u0027])[\u0027port\u0027]"},{"line_number":313,"context_line":"        self.assertEqual(self.IMMEDIATE, port_1[\u0027ip_allocation\u0027])"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"503524f4_ba09db95","line":311,"updated":"2022-11-25 09:30:22.000000000","message":"Just in case, Hum I\u0027m not sure this is going to work with a fixed IP. Nova will not be able to select the right segment based on the ip.\n\nhttps://bugs.launchpad.net/nova/+bug/1979959","commit_id":"be7c3beae5bc3df82f2c609b23bac16e0510a7cb"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"1688f454bb52c378c9d53dff9e7cf4d4561fc3fd","unresolved":true,"context_lines":[{"line_number":133,"context_line":"        1. aggregate is created for the segment"},{"line_number":134,"context_line":"        2. resource_provider (RP) is created for the segment"},{"line_number":135,"context_line":"        3. resource_provider inventory is created with IPV4_ADDRESS as"},{"line_number":136,"context_line":"           resource_class name."},{"line_number":137,"context_line":"        @param segment_id: The id of the segment"},{"line_number":138,"context_line":"        :return: True if aggregate, RP, and inventory with IPV4_ADDRESS as"},{"line_number":139,"context_line":"                 resource_class created for the segment, False otherwise."}],"source_content_type":"text/x-python","patch_set":42,"id":"ae75a7bc_4e25a33a","line":136,"range":{"start_line":136,"start_character":8,"end_line":136,"end_character":31},"updated":"2023-01-09 10:21:12.000000000","message":"A new line should be added here.","commit_id":"25bf4007c4964adec1cbcdfe6c5b796ac078e3c9"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"1b345d79342e9322eaef263ea5ddbcbd08e61c9b","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        1. aggregate is created for the segment"},{"line_number":134,"context_line":"        2. resource_provider (RP) is created for the segment"},{"line_number":135,"context_line":"        3. resource_provider inventory is created with IPV4_ADDRESS as"},{"line_number":136,"context_line":"           resource_class name."},{"line_number":137,"context_line":"        @param segment_id: The id of the segment"},{"line_number":138,"context_line":"        :return: True if aggregate, RP, and inventory with IPV4_ADDRESS as"},{"line_number":139,"context_line":"                 resource_class created for the segment, False otherwise."}],"source_content_type":"text/x-python","patch_set":42,"id":"3c2e639b_ad0b65ae","line":136,"range":{"start_line":136,"start_character":8,"end_line":136,"end_character":31},"in_reply_to":"ae75a7bc_4e25a33a","updated":"2023-07-31 09:31:48.000000000","message":"Done","commit_id":"25bf4007c4964adec1cbcdfe6c5b796ac078e3c9"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"1688f454bb52c378c9d53dff9e7cf4d4561fc3fd","unresolved":true,"context_lines":[{"line_number":134,"context_line":"        2. resource_provider (RP) is created for the segment"},{"line_number":135,"context_line":"        3. resource_provider inventory is created with IPV4_ADDRESS as"},{"line_number":136,"context_line":"           resource_class name."},{"line_number":137,"context_line":"        @param segment_id: The id of the segment"},{"line_number":138,"context_line":"        :return: True if aggregate, RP, and inventory with IPV4_ADDRESS as"},{"line_number":139,"context_line":"                 resource_class created for the segment, False otherwise."},{"line_number":140,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":42,"id":"cfd4e007_199c0646","line":137,"range":{"start_line":137,"start_character":8,"end_line":137,"end_character":26},"updated":"2023-01-09 10:21:12.000000000","message":"```\n\"@param segment_id:\" -\u003e \":param segment_id:\"\n```","commit_id":"25bf4007c4964adec1cbcdfe6c5b796ac078e3c9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f86f4cef8096f1336cc29893dab36450b6e8f437","unresolved":true,"context_lines":[{"line_number":134,"context_line":"        2. resource_provider (RP) is created for the segment"},{"line_number":135,"context_line":"        3. resource_provider inventory is created with IPV4_ADDRESS as"},{"line_number":136,"context_line":"           resource_class name."},{"line_number":137,"context_line":"        @param segment_id: The id of the segment"},{"line_number":138,"context_line":"        :return: True if aggregate, RP, and inventory with IPV4_ADDRESS as"},{"line_number":139,"context_line":"                 resource_class created for the segment, False otherwise."},{"line_number":140,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":42,"id":"ed66166c_b44d57b4","line":137,"range":{"start_line":137,"start_character":8,"end_line":137,"end_character":26},"in_reply_to":"2311e16e_6a6daa41","updated":"2023-08-18 11:48:53.000000000","message":"thanks, I missed this, and doctsting is not my favourite","commit_id":"25bf4007c4964adec1cbcdfe6c5b796ac078e3c9"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"1b345d79342e9322eaef263ea5ddbcbd08e61c9b","unresolved":true,"context_lines":[{"line_number":134,"context_line":"        2. resource_provider (RP) is created for the segment"},{"line_number":135,"context_line":"        3. resource_provider inventory is created with IPV4_ADDRESS as"},{"line_number":136,"context_line":"           resource_class name."},{"line_number":137,"context_line":"        @param segment_id: The id of the segment"},{"line_number":138,"context_line":"        :return: True if aggregate, RP, and inventory with IPV4_ADDRESS as"},{"line_number":139,"context_line":"                 resource_class created for the segment, False otherwise."},{"line_number":140,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":42,"id":"2311e16e_6a6daa41","line":137,"range":{"start_line":137,"start_character":8,"end_line":137,"end_character":26},"in_reply_to":"cfd4e007_199c0646","updated":"2023-07-31 09:31:48.000000000","message":"This still needs to be changed to `:param segment_id:`","commit_id":"25bf4007c4964adec1cbcdfe6c5b796ac078e3c9"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"1688f454bb52c378c9d53dff9e7cf4d4561fc3fd","unresolved":true,"context_lines":[{"line_number":175,"context_line":"    def test_routed_provider_net_basic(self):"},{"line_number":176,"context_line":"        \"\"\"Basic scenario for routed provider networks:"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        1. Create provider network:"},{"line_number":179,"context_line":"            1.1. Check that related segment was created"},{"line_number":180,"context_line":"            1.2. Create IPv4 subnet with the segment_id"},{"line_number":181,"context_line":"            1.3. Check that nova aggregate for segment is created and"},{"line_number":182,"context_line":"            resource provider for segment is created and IPV4_ADDRESS"},{"line_number":183,"context_line":"            resource provider inventory is created for subnet"},{"line_number":184,"context_line":"        2. Boot VM on the proivder network:"},{"line_number":185,"context_line":"            2.1. Check that the inventory of the given resource provider (the"},{"line_number":186,"context_line":"                 one for the segment on which the VM was booted) reserved"},{"line_number":187,"context_line":"                 number is changed. Would be good to create a new segment for"},{"line_number":188,"context_line":"                 the 2nd host, but zuul has only 1 physnet for the hosts"},{"line_number":189,"context_line":"        \"\"\""},{"line_number":190,"context_line":"        self._create_net_and_add_segment_to_subnet()"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"b641142e_3724f364","line":188,"range":{"start_line":178,"start_character":8,"end_line":188,"end_character":72},"updated":"2023-01-09 10:21:12.000000000","message":"This needs to be changed like this:\n\n```\n1. Create provider network:\n\n    1.1. Check that related segment was created\n\n    1.2. Create IPv4 subnet with the segment_id\n\n    1.3. Check that nova aggregate for segment is created and\n         resource provider for segment is created and IPV4_ADDRESS\n         resource provider inventory is created for subnet\n            \n2. Boot VM on the proivder network:\n\n    2.1. Check that the inventory of the given resource provider (the\n    one for the segment on which the VM was booted) reserved\n    number is changed. Would be good to create a new segment for\n    the 2nd host, but zuul has only 1 physnet for the hosts\n```\n\nOtherwise, the documentation won\u0027t be rendered correctly","commit_id":"25bf4007c4964adec1cbcdfe6c5b796ac078e3c9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b0583050783f15c597ed22084b5c78bd8fb6716e","unresolved":true,"context_lines":[{"line_number":175,"context_line":"    def test_routed_provider_net_basic(self):"},{"line_number":176,"context_line":"        \"\"\"Basic scenario for routed provider networks:"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        1. Create provider network:"},{"line_number":179,"context_line":"            1.1. Check that related segment was created"},{"line_number":180,"context_line":"            1.2. Create IPv4 subnet with the segment_id"},{"line_number":181,"context_line":"            1.3. Check that nova aggregate for segment is created and"},{"line_number":182,"context_line":"            resource provider for segment is created and IPV4_ADDRESS"},{"line_number":183,"context_line":"            resource provider inventory is created for subnet"},{"line_number":184,"context_line":"        2. Boot VM on the proivder network:"},{"line_number":185,"context_line":"            2.1. Check that the inventory of the given resource provider (the"},{"line_number":186,"context_line":"                 one for the segment on which the VM was booted) reserved"},{"line_number":187,"context_line":"                 number is changed. Would be good to create a new segment for"},{"line_number":188,"context_line":"                 the 2nd host, but zuul has only 1 physnet for the hosts"},{"line_number":189,"context_line":"        \"\"\""},{"line_number":190,"context_line":"        self._create_net_and_add_segment_to_subnet()"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"d89c908a_f04994e9","line":188,"range":{"start_line":178,"start_character":8,"end_line":188,"end_character":72},"in_reply_to":"b641142e_3724f364","updated":"2023-07-25 09:02:10.000000000","message":"thanks, I changed the doc string, I hope all is ok","commit_id":"25bf4007c4964adec1cbcdfe6c5b796ac078e3c9"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"1b345d79342e9322eaef263ea5ddbcbd08e61c9b","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    def test_routed_provider_net_basic(self):"},{"line_number":176,"context_line":"        \"\"\"Basic scenario for routed provider networks:"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        1. Create provider network:"},{"line_number":179,"context_line":"            1.1. Check that related segment was created"},{"line_number":180,"context_line":"            1.2. Create IPv4 subnet with the segment_id"},{"line_number":181,"context_line":"            1.3. Check that nova aggregate for segment is created and"},{"line_number":182,"context_line":"            resource provider for segment is created and IPV4_ADDRESS"},{"line_number":183,"context_line":"            resource provider inventory is created for subnet"},{"line_number":184,"context_line":"        2. Boot VM on the proivder network:"},{"line_number":185,"context_line":"            2.1. Check that the inventory of the given resource provider (the"},{"line_number":186,"context_line":"                 one for the segment on which the VM was booted) reserved"},{"line_number":187,"context_line":"                 number is changed. Would be good to create a new segment for"},{"line_number":188,"context_line":"                 the 2nd host, but zuul has only 1 physnet for the hosts"},{"line_number":189,"context_line":"        \"\"\""},{"line_number":190,"context_line":"        self._create_net_and_add_segment_to_subnet()"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"19c0ba41_f0c50e78","line":188,"range":{"start_line":178,"start_character":8,"end_line":188,"end_character":72},"in_reply_to":"d89c908a_f04994e9","updated":"2023-07-31 09:31:48.000000000","message":"Done","commit_id":"25bf4007c4964adec1cbcdfe6c5b796ac078e3c9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3ca3b311c17fe3c589f9f4b509df316533f32a36","unresolved":true,"context_lines":[{"line_number":199,"context_line":"        self._get_reserved_allocation("},{"line_number":200,"context_line":"            self.segments[0][\u0027id\u0027])"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        server \u003d self.create_server("},{"line_number":203,"context_line":"            networks\u003d[{\u0027uuid\u0027: self.prov_network[\u0027id\u0027]}])"},{"line_number":204,"context_line":"        waiters.wait_for_server_status("},{"line_number":205,"context_line":"            client\u003dself.os.servers_client, server_id\u003dserver[\u0027id\u0027],"},{"line_number":206,"context_line":"            status\u003d\u0027ACTIVE\u0027)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        port \u003d self.ports_client.list_ports(device_id\u003dserver[\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":209,"context_line":"        self.assertEqual(self.DEFERRED, port[\u0027ip_allocation\u0027])"}],"source_content_type":"text/x-python","patch_set":42,"id":"c1d9e0b6_dcc5d0f7","line":206,"range":{"start_line":202,"start_character":0,"end_line":206,"end_character":28},"updated":"2023-07-20 23:00:50.000000000","message":"self.create_server wait for server ACTIVE by default we do not need to wait here again","commit_id":"25bf4007c4964adec1cbcdfe6c5b796ac078e3c9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"92d0277fa2b8e8113e55d8cbef4d4224839c001b","unresolved":true,"context_lines":[{"line_number":199,"context_line":"        self._get_reserved_allocation("},{"line_number":200,"context_line":"            self.segments[0][\u0027id\u0027])"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        server \u003d self.create_server("},{"line_number":203,"context_line":"            networks\u003d[{\u0027uuid\u0027: self.prov_network[\u0027id\u0027]}])"},{"line_number":204,"context_line":"        waiters.wait_for_server_status("},{"line_number":205,"context_line":"            client\u003dself.os.servers_client, server_id\u003dserver[\u0027id\u0027],"},{"line_number":206,"context_line":"            status\u003d\u0027ACTIVE\u0027)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        port \u003d self.ports_client.list_ports(device_id\u003dserver[\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":209,"context_line":"        self.assertEqual(self.DEFERRED, port[\u0027ip_allocation\u0027])"}],"source_content_type":"text/x-python","patch_set":42,"id":"baf65bbe_aa53e3bc","line":206,"range":{"start_line":202,"start_character":0,"end_line":206,"end_character":28},"in_reply_to":"c1d9e0b6_dcc5d0f7","updated":"2023-07-25 09:01:41.000000000","message":"thanks, I removed the extra waits","commit_id":"25bf4007c4964adec1cbcdfe6c5b796ac078e3c9"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"1688f454bb52c378c9d53dff9e7cf4d4561fc3fd","unresolved":true,"context_lines":[{"line_number":222,"context_line":"    @decorators.idempotent_id(\u00279eba5ffd-0474-468b-9471-5623301f9ca4\u0027)"},{"line_number":223,"context_line":"    @utils.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":224,"context_line":"    def test_routed_provider_net_basic_with_precreated_port(self):"},{"line_number":225,"context_line":"        \"\"\"Boot VM on precreated port on routed provider network."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        The same scenario as previously, but instead of giving a network to"},{"line_number":228,"context_line":"        nova, let\u0027s create a port and boot VM on that one."}],"source_content_type":"text/x-python","patch_set":42,"id":"660e8a4c_4100f9e4","line":225,"range":{"start_line":225,"start_character":0,"end_line":225,"end_character":20},"updated":"2023-01-09 10:21:12.000000000","message":"This needs to be changed like this:\n\n```\nBoot VM on precreated port on routed provider network.\n\nThe same scenario as previously, but instead of giving a network to\nnova, let\u0027s create a port and boot VM on that one.\n\n1. Create provider network:\n\n    1.1. Check that related segment was created\n\n    1.2. Create IPv4 subnet with the segment_id\n\n    1.3. Check that nova aggregate for segment is created and\n    resource provider for segment is created and IPV4_ADDRESS\n    resource provider inventory is created for subnet\n\n2. Boot VM on the precreated port on the network:\n\n    2.1. Check that the inventory of the given resource provider (the\n    one for the segment on which the VM was booted) reserved\n    umber is changed. Would be good to create a new segment for\n    the 2nd host, but zuul has only 1 physnet for the hosts\n```\n\nOtherwise, the documentation won\u0027t be rendered correctly and sphinx-build will fail with \"Indentation Error\".","commit_id":"25bf4007c4964adec1cbcdfe6c5b796ac078e3c9"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"1b345d79342e9322eaef263ea5ddbcbd08e61c9b","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    @decorators.idempotent_id(\u00279eba5ffd-0474-468b-9471-5623301f9ca4\u0027)"},{"line_number":223,"context_line":"    @utils.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":224,"context_line":"    def test_routed_provider_net_basic_with_precreated_port(self):"},{"line_number":225,"context_line":"        \"\"\"Boot VM on precreated port on routed provider network."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        The same scenario as previously, but instead of giving a network to"},{"line_number":228,"context_line":"        nova, let\u0027s create a port and boot VM on that one."}],"source_content_type":"text/x-python","patch_set":42,"id":"ce846bb9_a218f8b1","line":225,"range":{"start_line":225,"start_character":0,"end_line":225,"end_character":20},"in_reply_to":"660e8a4c_4100f9e4","updated":"2023-07-31 09:31:48.000000000","message":"Done","commit_id":"25bf4007c4964adec1cbcdfe6c5b796ac078e3c9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3ca3b311c17fe3c589f9f4b509df316533f32a36","unresolved":true,"context_lines":[{"line_number":264,"context_line":"        # Boot VM with the precreated port"},{"line_number":265,"context_line":"        server \u003d self.create_server(clients\u003dself.os_adm,"},{"line_number":266,"context_line":"                                    networks\u003d[{\u0027port\u0027: port[\u0027id\u0027]}])"},{"line_number":267,"context_line":"        waiters.wait_for_server_status("},{"line_number":268,"context_line":"            client\u003dself.servers_client, server_id\u003dserver[\u0027id\u0027],"},{"line_number":269,"context_line":"            status\u003d\u0027ACTIVE\u0027)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        # # Check that the reserved number remained the same"},{"line_number":272,"context_line":"        # reserved_after_vm \u003d self._get_reserved_allocation("}],"source_content_type":"text/x-python","patch_set":42,"id":"c8d0ea0b_9f922c48","line":269,"range":{"start_line":267,"start_character":0,"end_line":269,"end_character":28},"updated":"2023-07-20 23:00:50.000000000","message":"ditto","commit_id":"25bf4007c4964adec1cbcdfe6c5b796ac078e3c9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"92d0277fa2b8e8113e55d8cbef4d4224839c001b","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        # Boot VM with the precreated port"},{"line_number":265,"context_line":"        server \u003d self.create_server(clients\u003dself.os_adm,"},{"line_number":266,"context_line":"                                    networks\u003d[{\u0027port\u0027: port[\u0027id\u0027]}])"},{"line_number":267,"context_line":"        waiters.wait_for_server_status("},{"line_number":268,"context_line":"            client\u003dself.servers_client, server_id\u003dserver[\u0027id\u0027],"},{"line_number":269,"context_line":"            status\u003d\u0027ACTIVE\u0027)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        # # Check that the reserved number remained the same"},{"line_number":272,"context_line":"        # reserved_after_vm \u003d self._get_reserved_allocation("}],"source_content_type":"text/x-python","patch_set":42,"id":"8d0039a5_ff640839","line":269,"range":{"start_line":267,"start_character":0,"end_line":269,"end_character":28},"in_reply_to":"c8d0ea0b_9f922c48","updated":"2023-07-25 09:01:41.000000000","message":"Done","commit_id":"25bf4007c4964adec1cbcdfe6c5b796ac078e3c9"}],"zuul.d/integrated-gate.yaml":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"368be00c83e1567b8ddc8b6b16c75ab43f836fe9","unresolved":true,"context_lines":[{"line_number":321,"context_line":"    timeout: 10800"},{"line_number":322,"context_line":"    branches: ^(?!stable/(ocata|pike|queens|rocky|stein|train)).*$"},{"line_number":323,"context_line":"    vars: *tempest_slow_vars"},{"line_number":324,"context_line":"      network_available_features: \u0026available_features"},{"line_number":325,"context_line":"        - multiple_segments_on_host"},{"line_number":326,"context_line":"      devstack_local_conf:"},{"line_number":327,"context_line":"        test-config:"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"f3358b5c_8463203b","line":324,"range":{"start_line":324,"start_character":35,"end_line":324,"end_character":53},"updated":"2022-12-08 09:59:26.000000000","message":"maybe this causes the zuul error? it\u0027s not used anyway","commit_id":"be7c3beae5bc3df82f2c609b23bac16e0510a7cb"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d1a338bd02d19bc20bbed2d9069db2bd4f7942f8","unresolved":true,"context_lines":[{"line_number":321,"context_line":"    timeout: 10800"},{"line_number":322,"context_line":"    branches: ^(?!stable/(ocata|pike|queens|rocky|stein|train)).*$"},{"line_number":323,"context_line":"    vars: *tempest_slow_vars"},{"line_number":324,"context_line":"      network_available_features: \u0026available_features"},{"line_number":325,"context_line":"        - multiple_segments_on_host"},{"line_number":326,"context_line":"      devstack_local_conf:"},{"line_number":327,"context_line":"        test-config:"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"5845475b_99b72e80","line":324,"range":{"start_line":324,"start_character":35,"end_line":324,"end_character":53},"in_reply_to":"f3358b5c_8463203b","updated":"2022-12-19 12:46:30.000000000","message":"yeah, it seems.\nThis availble feature for networking was introduced to enable tests which have no API extension, so I will check how to add it to detect from which branch we have multisegment support.","commit_id":"be7c3beae5bc3df82f2c609b23bac16e0510a7cb"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"62518e5902eaff0810b0bbd2830a4465a785c879","unresolved":true,"context_lines":[{"line_number":323,"context_line":"          ENABLE_VOLUME_MULTIATTACH: true"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"- job:"},{"line_number":326,"context_line":"    name: tempest-ovs-py3-routed-nets"},{"line_number":327,"context_line":"    parent: tempest-multinode-full-py3"},{"line_number":328,"context_line":"    # This job version is with swift enabled on py3"},{"line_number":329,"context_line":"    # as swift is ready on py3 from stable/ussuri onwards."}],"source_content_type":"text/x-yaml","patch_set":46,"id":"dc846f2f_4156f0cd","line":326,"updated":"2023-08-18 11:48:16.000000000","message":"temporary job, let\u0027s hope now I have all that is necessary.","commit_id":"449464a0b033c28f4cc15a49dc107961f1551ff1"}]}