)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"811c95d47f8c6b32e73e0e7d6e05910c3f12f1c3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ann Kamyshnikova \u003cakamyshnikova@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-03-12 12:39:45 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Vefify more information for member in lbaas api tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add checks for:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"AAAAWH%2F%2FtWg%3D","line":7,"updated":"2014-03-14 10:22:49.000000000","message":"Vefify-\u003eVerify","commit_id":"22c91311591977c55f0e26b9068f61a72c7e4903"}],"tempest/api/network/admin/test_load_balancer_admin_actions.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aa945866d5d5c48d862a92a3a788178d46b30c21","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        member \u003d body[\u0027member\u0027]"},{"line_number":113,"context_line":"        self.addCleanup(self.admin_client.delete_member, member[\u0027id\u0027])"},{"line_number":114,"context_line":"        self.assertIsNotNone(member[\u0027id\u0027])"},{"line_number":115,"context_line":"        self.assertEqual(member[\u0027tenant_id\u0027], self.tenant_id)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"class LoadBalancerAdminTestXML(LoadBalancerAdminTestJSON):"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAWH%2F%2Bi4s%3D","line":115,"updated":"2014-03-26 01:50:06.000000000","message":"same as https://review.openstack.org/#/c/65943/","commit_id":"30dd279c54d5c69a820f1c7362e3c9e17b314ece"}],"tempest/api/network/base.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"8d652b003399ac276eafd81447a7acbe365c9ea3","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        return member"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    @classmethod"},{"line_number":224,"context_line":"    def update_member(cls, admin_state_up):"},{"line_number":225,"context_line":"        resp, body \u003d cls.client.update_member(admin_state_up\u003dadmin_state_up)"},{"line_number":226,"context_line":"        member \u003d body[\u0027member\u0027]"},{"line_number":227,"context_line":"        return member"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FS%2B4%3D","line":224,"updated":"2014-01-15 11:11:41.000000000","message":"this method is not used in this patch","commit_id":"453d2f7d12a7355da352cb1ae1eb6830cfda1037"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"86d37026adfbf0b6057c0cc5388ba7ea7e7659a3","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        return member"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    @classmethod"},{"line_number":224,"context_line":"    def update_member(cls, admin_state_up):"},{"line_number":225,"context_line":"        resp, body \u003d cls.client.update_member(admin_state_up\u003dadmin_state_up)"},{"line_number":226,"context_line":"        member \u003d body[\u0027member\u0027]"},{"line_number":227,"context_line":"        return member"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FS7Q%3D","line":224,"in_reply_to":"AAAAUH%2F%2FS%2B4%3D","updated":"2014-01-15 11:33:11.000000000","message":"This is necessary change. It is part of update create_member and update_member.\nSame was done here for pool  https://review.openstack.org/62614","commit_id":"453d2f7d12a7355da352cb1ae1eb6830cfda1037"}],"tempest/api/network/test_load_balancer.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"8d652b003399ac276eafd81447a7acbe365c9ea3","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":256,"context_line":"        health_monitor \u003d body[\u0027health_monitor\u0027]"},{"line_number":257,"context_line":"        self.assertEqual(self.health_monitor[\u0027id\u0027], health_monitor[\u0027id\u0027])"},{"line_number":258,"context_line":"        self.assertEqual(self.health_monitor, health_monitor)"},{"line_number":259,"context_line":"        self.assertEqual(self.health_monitor[\u0027max_retries\u0027],"},{"line_number":260,"context_line":"                         health_monitor[\u0027max_retries\u0027])"},{"line_number":261,"context_line":"        self.assertEqual(self.health_monitor[\u0027type\u0027], health_monitor[\u0027type\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FTCs%3D","line":258,"updated":"2014-01-15 11:11:41.000000000","message":"if compare health_monitor, other items\u0027 comparison of health_monitor could be removed.","commit_id":"453d2f7d12a7355da352cb1ae1eb6830cfda1037"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"86d37026adfbf0b6057c0cc5388ba7ea7e7659a3","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":256,"context_line":"        health_monitor \u003d body[\u0027health_monitor\u0027]"},{"line_number":257,"context_line":"        self.assertEqual(self.health_monitor[\u0027id\u0027], health_monitor[\u0027id\u0027])"},{"line_number":258,"context_line":"        self.assertEqual(self.health_monitor, health_monitor)"},{"line_number":259,"context_line":"        self.assertEqual(self.health_monitor[\u0027max_retries\u0027],"},{"line_number":260,"context_line":"                         health_monitor[\u0027max_retries\u0027])"},{"line_number":261,"context_line":"        self.assertEqual(self.health_monitor[\u0027type\u0027], health_monitor[\u0027type\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FS78%3D","line":258,"in_reply_to":"AAAAUH%2F%2FTCs%3D","updated":"2014-01-15 11:33:11.000000000","message":"I changed this by mistake. I\u0027ll correct this. Thanks.","commit_id":"453d2f7d12a7355da352cb1ae1eb6830cfda1037"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"76a7698633a46149a5d79e7f136aab8eb97a85e2","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                                               admin_state_up\u003dFalse)"},{"line_number":205,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":206,"context_line":"        updated_member \u003d body[\u0027member\u0027]"},{"line_number":207,"context_line":"        self.assertEqual(updated_member[\u0027admin_state_up\u0027], False)"},{"line_number":208,"context_line":"        # Verification of member delete"},{"line_number":209,"context_line":"        resp, body \u003d self.client.delete_member(member[\u0027id\u0027])"},{"line_number":210,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BuYg%3D","line":207,"updated":"2014-01-22 20:52:59.000000000","message":"I think it would be clearer if you do:\n\nself.assertFalse(updated_member[\u0027admin_state_up\u0027])","commit_id":"37655a1a71dcf990fdcebba2a0f4da8e9d6c9ea6"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"ef7c28399aa162bb0bb0b16d7b209c5544693cda","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                                               admin_state_up\u003dFalse)"},{"line_number":205,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":206,"context_line":"        updated_member \u003d body[\u0027member\u0027]"},{"line_number":207,"context_line":"        self.assertEqual(updated_member[\u0027admin_state_up\u0027], False)"},{"line_number":208,"context_line":"        # Verification of member delete"},{"line_number":209,"context_line":"        resp, body \u003d self.client.delete_member(member[\u0027id\u0027])"},{"line_number":210,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BrjI%3D","line":207,"in_reply_to":"AAAAUH%2F%2BuYg%3D","updated":"2014-01-23 10:16:56.000000000","message":"Ok, will do","commit_id":"37655a1a71dcf990fdcebba2a0f4da8e9d6c9ea6"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"76a7698633a46149a5d79e7f136aab8eb97a85e2","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            self.assertIsNotNone(body[\u0027member\u0027][\u0027admin_state_up\u0027])"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":336,"context_line":"    def test_update_pool_related_to_member(self):"},{"line_number":337,"context_line":"        resp, body \u003d self.client.update_pool(self.pool[\u0027id\u0027],"},{"line_number":338,"context_line":"                                             name\u003d\u0027New_pool_name\u0027)"},{"line_number":339,"context_line":"        resp, body \u003d self.client.show_member(self.member[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BuCM%3D","line":336,"updated":"2014-01-22 20:52:59.000000000","message":"I am assuming this test method corresponds to point 10.2.2 (Update the pool that a member belongs to and confirm with a show) in the api section of https://etherpad.openstack.org/p/icehouse-summit-qa-neutron. If this is indeed the case, this test method should look like the following pseudo-code:\n\nCreate a new pool\n\nUpdate existing member pool_id with the pool_id of the newly created pool\n\nConfirm with a show that the pool_id of the member is equal to the pool_id of the newly created pool","commit_id":"37655a1a71dcf990fdcebba2a0f4da8e9d6c9ea6"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"ef7c28399aa162bb0bb0b16d7b209c5544693cda","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            self.assertIsNotNone(body[\u0027member\u0027][\u0027admin_state_up\u0027])"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":336,"context_line":"    def test_update_pool_related_to_member(self):"},{"line_number":337,"context_line":"        resp, body \u003d self.client.update_pool(self.pool[\u0027id\u0027],"},{"line_number":338,"context_line":"                                             name\u003d\u0027New_pool_name\u0027)"},{"line_number":339,"context_line":"        resp, body \u003d self.client.show_member(self.member[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2Bric%3D","line":336,"in_reply_to":"AAAAUH%2F%2BuCM%3D","updated":"2014-01-23 10:16:56.000000000","message":"Ok, will do","commit_id":"37655a1a71dcf990fdcebba2a0f4da8e9d6c9ea6"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"76a7698633a46149a5d79e7f136aab8eb97a85e2","unresolved":false,"context_lines":[{"line_number":382,"context_line":"    def test_create_member_from_admin_user_other_tenant(self):"},{"line_number":383,"context_line":"        resp, body \u003d self.admin_client.create_member("},{"line_number":384,"context_line":"            address\u003d\"10.0.9.47\", protocol_port\u003d80, pool_id\u003dself.pool[\u0027id\u0027],"},{"line_number":385,"context_line":"            tenant_id\u003d\u00277688e351a2f24be7b7d6b592a5bbe64b\u0027)"},{"line_number":386,"context_line":"        member \u003d body[\u0027member\u0027]"},{"line_number":387,"context_line":"        self.assertIsNotNone(member[\u0027id\u0027])"},{"line_number":388,"context_line":"        self.assertEqual(member[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2Bt8w%3D","line":385,"updated":"2014-01-22 20:52:59.000000000","message":"This hard coded tenant_id passed the gate so I don\u0027t have an issue with it. Later in the review cycle, though, some of the core reviewers might not like it. For an alternative approach (should you choose to take it), look at tempest.api.network.test_quotas, lines 51 and 56 - 61. Since you are sub-classing from base.BaseAdminNetworkTest, you are inheriting from its setUpClass method the attribute cls.admin_manager. So acquiring the identity client is very easy","commit_id":"37655a1a71dcf990fdcebba2a0f4da8e9d6c9ea6"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"ef7c28399aa162bb0bb0b16d7b209c5544693cda","unresolved":false,"context_lines":[{"line_number":382,"context_line":"    def test_create_member_from_admin_user_other_tenant(self):"},{"line_number":383,"context_line":"        resp, body \u003d self.admin_client.create_member("},{"line_number":384,"context_line":"            address\u003d\"10.0.9.47\", protocol_port\u003d80, pool_id\u003dself.pool[\u0027id\u0027],"},{"line_number":385,"context_line":"            tenant_id\u003d\u00277688e351a2f24be7b7d6b592a5bbe64b\u0027)"},{"line_number":386,"context_line":"        member \u003d body[\u0027member\u0027]"},{"line_number":387,"context_line":"        self.assertIsNotNone(member[\u0027id\u0027])"},{"line_number":388,"context_line":"        self.assertEqual(member[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BrLk%3D","line":385,"in_reply_to":"AAAAUH%2F%2Bt8w%3D","updated":"2014-01-23 10:16:56.000000000","message":"Ok. I\u0027ll correct this.","commit_id":"37655a1a71dcf990fdcebba2a0f4da8e9d6c9ea6"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e4062def681b2910ba2a588c742b3903dd67018d","unresolved":false,"context_lines":[{"line_number":338,"context_line":"            name\u003ddata_utils.rand_name(\"pool-\"),"},{"line_number":339,"context_line":"            lb_method\u003d\u0027ROUND_ROBIN\u0027,"},{"line_number":340,"context_line":"            protocol\u003d\u0027HTTP\u0027,"},{"line_number":341,"context_line":"            subnet_id\u003dself.subnet[\u0027id\u0027])"},{"line_number":342,"context_line":"        new_pool \u003d body[\u0027pool\u0027]"},{"line_number":343,"context_line":"        resp, body \u003d self.client.update_member(self.member[\u0027id\u0027],"},{"line_number":344,"context_line":"                                               pool_id\u003dnew_pool[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2Bn0k%3D","line":341,"updated":"2014-01-23 19:56:39.000000000","message":"You need to clean up this pool. Put the addCleanup call right asserting you got a 201 after creation and before the rest of the method","commit_id":"e3dd4f64261010014626e9bbfec3af31fef7141e"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e4062def681b2910ba2a588c742b3903dd67018d","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            tenant_id\u003dself.tenant[1][\u0027id\u0027])"},{"line_number":396,"context_line":"        member \u003d body[\u0027member\u0027]"},{"line_number":397,"context_line":"        self.assertIsNotNone(member[\u0027id\u0027])"},{"line_number":398,"context_line":"        self.assertEqual(member[\u0027tenant_id\u0027], self.tenant[1][\u0027id\u0027])"},{"line_number":399,"context_line":"        self.addCleanup(self.admin_client.delete_member, member[\u0027id\u0027])"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2Bnz4%3D","line":398,"updated":"2014-01-23 19:56:39.000000000","message":"When you create a tenant, do you get a list back from Keystone? I am looking at \n\nhttp://docs.openstack.org/api/openstack-identity-service/2.0/content/POST_addTenant_v2.0_tenants_Tenant_Operations_OS-KSADM.html\n\nand I think it returns a straight dictionary.","commit_id":"e3dd4f64261010014626e9bbfec3af31fef7141e"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"cc1ce7033c0f5c20815a2468bdde2ce0c9f2978b","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            tenant_id\u003dself.tenant[1][\u0027id\u0027])"},{"line_number":396,"context_line":"        member \u003d body[\u0027member\u0027]"},{"line_number":397,"context_line":"        self.assertIsNotNone(member[\u0027id\u0027])"},{"line_number":398,"context_line":"        self.assertEqual(member[\u0027tenant_id\u0027], self.tenant[1][\u0027id\u0027])"},{"line_number":399,"context_line":"        self.addCleanup(self.admin_client.delete_member, member[\u0027id\u0027])"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2BlEA%3D","line":398,"in_reply_to":"AAAAUH%2F%2Bnz4%3D","updated":"2014-01-24 07:14:31.000000000","message":"This is so because I create tenant as\n\n    cls.tenant \u003d cls.identity_admin_client.create_tenant\n\nnot\n\n    resp, cls.tenant \u003d cls.identity_admin_client.create_tenant\n\nIf this doesn\u0027t look good, I\u0027ll correct this.","commit_id":"e3dd4f64261010014626e9bbfec3af31fef7141e"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e4062def681b2910ba2a588c742b3903dd67018d","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        member \u003d body[\u0027member\u0027]"},{"line_number":397,"context_line":"        self.assertIsNotNone(member[\u0027id\u0027])"},{"line_number":398,"context_line":"        self.assertEqual(member[\u0027tenant_id\u0027], self.tenant[1][\u0027id\u0027])"},{"line_number":399,"context_line":"        self.addCleanup(self.admin_client.delete_member, member[\u0027id\u0027])"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"class LoadBalancerXML(LoadBalancerJSON):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2BnzQ%3D","line":399,"updated":"2014-01-23 19:56:39.000000000","message":"It would be better to move this call right after you create the member and you assert you got a 201 status back","commit_id":"e3dd4f64261010014626e9bbfec3af31fef7141e"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"24cfc35cf3e923ea6db7fd439448c489e2314e31","unresolved":false,"context_lines":[{"line_number":339,"context_line":"            subnet_id\u003dself.subnet[\u0027id\u0027])"},{"line_number":340,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":341,"context_line":"        new_pool \u003d body[\u0027pool\u0027]"},{"line_number":342,"context_line":"        #self.addCleanup(self.client.delete_pool, new_pool[\u0027id\u0027])"},{"line_number":343,"context_line":"        resp, body \u003d self.client.update_member(self.member[\u0027id\u0027],"},{"line_number":344,"context_line":"                                               pool_id\u003dnew_pool[\u0027id\u0027])"},{"line_number":345,"context_line":"        resp, body \u003d self.client.show_member(self.member[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F92aE%3D","line":342,"updated":"2014-02-03 10:33:27.000000000","message":"Any reason you commented it?","commit_id":"0c15feb00b278bd310a09ce78b5956f3a314dfd3"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"2032c6b984b5e29acb1a442015249633c05440f4","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    def test_list_members_with_filters(self):"},{"line_number":233,"context_line":"        resp, body \u003d self.client.create_member(address\u003d\"10.0.9.47\","},{"line_number":234,"context_line":"                                               protocol_port\u003d80,"},{"line_number":235,"context_line":"                                               pool_id\u003dself.pool[\u0027id\u0027])"},{"line_number":236,"context_line":"        member \u003d body[\u0027member\u0027]"},{"line_number":237,"context_line":"        self.addCleanup(self.client.delete_member, member[\u0027id\u0027])"},{"line_number":238,"context_line":"        attr_exceptions \u003d [\u0027status\u0027, \u0027status_description\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F9h0M%3D","line":235,"updated":"2014-02-06 09:39:34.000000000","message":"It seems you have mistakenly removed this line:\n\n    self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])","commit_id":"da38ba01cf4c1927814ab875d2935472bdb27339"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"ae0ee08066f6fa43649c67461d8fdfe171a60851","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                                               admin_state_up\u003dFalse)"},{"line_number":225,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":226,"context_line":"        updated_member \u003d body[\u0027member\u0027]"},{"line_number":227,"context_line":"        self.assertEqual(updated_member[\u0027admin_state_up\u0027], False)"},{"line_number":228,"context_line":"        # Verification of member delete"},{"line_number":229,"context_line":"        resp, body \u003d self.client.delete_member(member[\u0027id\u0027])"},{"line_number":230,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAVn%2F%2Bxr8%3D","line":227,"updated":"2014-03-12 08:33:59.000000000","message":"why?","commit_id":"606d03444ef4efc0c798a27f3c7ec13341f64c60"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"59da4a1a6ba2087afeaa826682e4500a8a60a79a","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                                               admin_state_up\u003dFalse)"},{"line_number":225,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":226,"context_line":"        updated_member \u003d body[\u0027member\u0027]"},{"line_number":227,"context_line":"        self.assertEqual(updated_member[\u0027admin_state_up\u0027], False)"},{"line_number":228,"context_line":"        # Verification of member delete"},{"line_number":229,"context_line":"        resp, body \u003d self.client.delete_member(member[\u0027id\u0027])"},{"line_number":230,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAVn%2F%2BxqY%3D","line":227,"in_reply_to":"AAAAVn%2F%2Bxr8%3D","updated":"2014-03-12 08:38:29.000000000","message":"Thanks, I didn\u0027t notice this change. I\u0027ll correct.","commit_id":"606d03444ef4efc0c798a27f3c7ec13341f64c60"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"ae0ee08066f6fa43649c67461d8fdfe171a60851","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":411,"context_line":"        member \u003d body[\u0027member\u0027]"},{"line_number":412,"context_line":"        self.assertEqual(member[\u0027weight\u0027], 2)"},{"line_number":413,"context_line":"        self.assertEqual(member[\u0027admin_state_up\u0027], False)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"class LoadBalancerAdminJSON(base.BaseAdminNetworkTest):"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAVn%2F%2Bxro%3D","line":413,"updated":"2014-03-12 08:33:59.000000000","message":"assertFalse","commit_id":"606d03444ef4efc0c798a27f3c7ec13341f64c60"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"811c95d47f8c6b32e73e0e7d6e05910c3f12f1c3","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":388,"context_line":"        new_pool \u003d body[\u0027pool\u0027]"},{"line_number":389,"context_line":"        self.addCleanup(self.client.delete_pool, new_pool[\u0027id\u0027])"},{"line_number":390,"context_line":"        # Update member with new pools\u0027 id"},{"line_number":391,"context_line":"        resp, body \u003d self.client.update_member(self.member[\u0027id\u0027],"},{"line_number":392,"context_line":"                                               pool_id\u003dnew_pool[\u0027id\u0027])"},{"line_number":393,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAWH%2F%2FtWY%3D","line":390,"updated":"2014-03-14 10:22:49.000000000","message":"pools\u0027-\u003epool\u0027s","commit_id":"22c91311591977c55f0e26b9068f61a72c7e4903"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"811c95d47f8c6b32e73e0e7d6e05910c3f12f1c3","unresolved":false,"context_lines":[{"line_number":403,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":404,"context_line":"    def test_update_member_weight(self):"},{"line_number":405,"context_line":"        resp, body \u003d self.client.update_member(self.member[\u0027id\u0027],"},{"line_number":406,"context_line":"                                               admin_state_up\u003dFalse,"},{"line_number":407,"context_line":"                                               weight\u003d2)"},{"line_number":408,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":409,"context_line":"        resp, body \u003d self.client.show_member(self.member[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAWH%2F%2FtWA%3D","line":406,"updated":"2014-03-14 10:22:49.000000000","message":"Could you please explain, why do you also update admin_state_up?","commit_id":"22c91311591977c55f0e26b9068f61a72c7e4903"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aa945866d5d5c48d862a92a3a788178d46b30c21","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        resp, body \u003d self.client.show_member(self.member[\u0027id\u0027])"},{"line_number":465,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":466,"context_line":"        member \u003d body[\u0027member\u0027]"},{"line_number":467,"context_line":"        self.assertEqual(member[\u0027weight\u0027], 2)"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"class LoadBalancerTestXML(LoadBalancerTestJSON):"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAWH%2F%2Bi4w%3D","line":467,"updated":"2014-03-26 01:50:06.000000000","message":"Same as https://review.openstack.org/#/c/65943/","commit_id":"30dd279c54d5c69a820f1c7362e3c9e17b314ece"},{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"f8fabb5195a505d9c4c74c90042167b0edfde4a2","unresolved":false,"context_lines":[{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":460,"context_line":"    def test_update_member_weight(self):"},{"line_number":461,"context_line":"        resp, body \u003d self.client.update_member(self.member[\u0027id\u0027],"},{"line_number":462,"context_line":"                                               weight\u003d2)"},{"line_number":463,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":464,"context_line":"        resp, body \u003d self.client.show_member(self.member[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAWH%2F%2BgDI%3D","line":461,"updated":"2014-03-26 11:27:07.000000000","message":"unused variables \"body\"\nPlease change 461 line \nfrom\n\"resp, body \u003d ... \"\nto\n\"resp, _ \u003d\"","commit_id":"344716f34c9b48a7b14506cdf8f575e09796faca"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5481d2a174e21e409fc18f9c51a5dff80911d3b3","unresolved":false,"context_lines":[{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":460,"context_line":"    def test_update_member_weight(self):"},{"line_number":461,"context_line":"        resp, body \u003d self.client.update_member(self.member[\u0027id\u0027],"},{"line_number":462,"context_line":"                                               weight\u003d2)"},{"line_number":463,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":464,"context_line":"        resp, body \u003d self.client.show_member(self.member[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAWH%2F%2Bf9M%3D","line":461,"in_reply_to":"AAAAWH%2F%2BgDI%3D","updated":"2014-03-26 11:39:35.000000000","message":"This is so big mistake that you set -1 for this. Will correct in next patch.","commit_id":"344716f34c9b48a7b14506cdf8f575e09796faca"}],"tempest/services/network/json/network_client.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"8d652b003399ac276eafd81447a7acbe365c9ea3","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        body \u003d json.loads(body)"},{"line_number":225,"context_line":"        return resp, body"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def create_member(self, address, protocol_port, pool_id):"},{"line_number":228,"context_line":"        post_body \u003d {"},{"line_number":229,"context_line":"            \"member\": {"},{"line_number":230,"context_line":"                \"protocol_port\": protocol_port,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FS%2FI%3D","side":"PARENT","line":227,"updated":"2014-01-15 11:11:41.000000000","message":"why delete create_member and update_member?","commit_id":"3800e6a2a8bbf4623448146233b2d16224bfbc38"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"0ee903486e30b94137a9333077e2b46b829481db","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        body \u003d json.loads(body)"},{"line_number":225,"context_line":"        return resp, body"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def create_member(self, address, protocol_port, pool_id):"},{"line_number":228,"context_line":"        post_body \u003d {"},{"line_number":229,"context_line":"            \"member\": {"},{"line_number":230,"context_line":"                \"protocol_port\": protocol_port,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FS60%3D","side":"PARENT","line":227,"in_reply_to":"AAAAUH%2F%2FS%2FI%3D","updated":"2014-01-15 11:28:04.000000000","message":"finally, I got the point from dependence. have no problem about this","commit_id":"3800e6a2a8bbf4623448146233b2d16224bfbc38"}]}