)]}'
{"releasenotes/notes/fixed-bug-1835186-and-add-unit-test-14a1e3f46a746c9b.yaml":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"62de69574efd4bb57c9ffa1542c0854d20d6d478","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed bug #1835186. In the API for volume v3,update/delete encryption type interface"},{"line_number":5,"context_line":"    is wrong in tempest/lib/services/volume/v3/encryption_types_client.py file, and add"},{"line_number":6,"context_line":"    unit test for update/delete volume encryption type intreface."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_7438983c","line":4,"range":{"start_line":4,"start_character":48,"end_line":4,"end_character":49},"updated":"2019-07-08 23:05:25.000000000","message":"Please put a single space after \",\" for readability.","commit_id":"e5a312c6de31e44cef7295cd325bb66c28278e76"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"62de69574efd4bb57c9ffa1542c0854d20d6d478","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed bug #1835186. In the API for volume v3,update/delete encryption type interface"},{"line_number":5,"context_line":"    is wrong in tempest/lib/services/volume/v3/encryption_types_client.py file, and add"},{"line_number":6,"context_line":"    unit test for update/delete volume encryption type intreface."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_54d1dccc","line":5,"updated":"2019-07-08 23:05:25.000000000","message":"How about\n\n .. encryption type API supports not only \"provider\" but also\n another encryption_id as https://developer.openstack.org/api-ref/block-storage/v3/#update-an-encryption-type\n The corresponding client interfaces and unit tests are\n changed for supporting the other encryption_id.\n\nto explain why we need to change clearly.","commit_id":"e5a312c6de31e44cef7295cd325bb66c28278e76"}],"tempest/lib/services/volume/v3/encryption_types_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"62de69574efd4bb57c9ffa1542c0854d20d6d478","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":69,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def delete_encryption_type(self, volume_type_id, encryption_id):"},{"line_number":72,"context_line":"        \"\"\"Delete the encryption type for the specified volume-type.\"\"\""},{"line_number":73,"context_line":"        url \u003d \"/types/%s/encryption/%s\" % (volume_type_id, encryption_id)"},{"line_number":74,"context_line":"        resp, body \u003d self.delete(url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_748658de","line":71,"updated":"2019-07-08 23:05:25.000000000","message":"We need to change test side also for passing test jobs like http://codesearch.openstack.org/?q\u003ddelete_encryption_type\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d\n\n tempest/tests/lib/services/volume/v3/test_encryption_types_client.py: 99\n\nIn addition, patrole also is using this function.\nSo it is better to put\n\n encryption_id\u003d\"provider\"\n\nfor a workaround at this time for smooth transit.","commit_id":"e5a312c6de31e44cef7295cd325bb66c28278e76"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"339ba7426e0520efc9fb19c491edd90948adae6b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":69,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def delete_encryption_type(self, volume_type_id, encryption_id):"},{"line_number":72,"context_line":"        \"\"\"Delete the encryption type for the specified volume-type.\"\"\""},{"line_number":73,"context_line":"        url \u003d \"/types/%s/encryption/%s\" % (volume_type_id, encryption_id)"},{"line_number":74,"context_line":"        resp, body \u003d self.delete(url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_8beacaa9","line":71,"in_reply_to":"7faddb67_748658de","updated":"2019-07-10 01:24:02.000000000","message":"Thank you for your review. I am very sorry, because I only read the API description of v3 version and assumed that the interface was wrong in code.","commit_id":"e5a312c6de31e44cef7295cd325bb66c28278e76"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"62de69574efd4bb57c9ffa1542c0854d20d6d478","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def delete_encryption_type(self, volume_type_id, encryption_id):"},{"line_number":72,"context_line":"        \"\"\"Delete the encryption type for the specified volume-type.\"\"\""},{"line_number":73,"context_line":"        url \u003d \"/types/%s/encryption/%s\" % (volume_type_id, encryption_id)"},{"line_number":74,"context_line":"        resp, body \u003d self.delete(url)"},{"line_number":75,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":76,"context_line":"        return rest_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_143fe425","line":73,"updated":"2019-07-08 23:05:25.000000000","message":"This seems good for me according to https://developer.openstack.org/api-ref/block-storage/v3/#delete-an-encryption-type","commit_id":"e5a312c6de31e44cef7295cd325bb66c28278e76"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"62de69574efd4bb57c9ffa1542c0854d20d6d478","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":76,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def update_encryption_type(self, volume_type_id, encryption_id, **kwargs):"},{"line_number":79,"context_line":"        \"\"\"Update an encryption type for an existing volume type."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_343a2034","line":78,"updated":"2019-07-08 23:05:25.000000000","message":"ditto: https://developer.openstack.org/api-ref/block-storage/v3/#update-an-encryption-type","commit_id":"e5a312c6de31e44cef7295cd325bb66c28278e76"}]}