)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42ca3c92ab7fe4ab5ed7c86eac127bf3de526d41","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Most of the compute Action API accept request body with"},{"line_number":10,"context_line":"action name and null value. For exmaple: {\u0027unshelve\u0027: null}."},{"line_number":11,"context_line":"But Tempest pass the empty dict instead of null- {\u0027unshelve\u0027: {}}."},{"line_number":12,"context_line":"This is the wrong usage of API. This does not give any error as"},{"line_number":13,"context_line":"Compute API does not check the value is null or anything else."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Nova does not have schema also for those request bodies."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_bdbb1e70","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":31},"updated":"2019-07-11 15:41:59.000000000","message":"I wouldn\u0027t say it\u0027s wrong, it\u0027s just undefined. Since the unshelve action API doesn\u0027t care what is in the body, you could pass it anything you want, an int, a string, a dict, a list, empty or not, it doesn\u0027t matter because it\u0027s not used.\n\nThis is only coming up now because a schema is going to be enforced for https://review.opendev.org/#/c/663851, but I\u0027m not sure why we would have schema validation failures in the compute API for microversions below that.\n\nSo it\u0027s probably more accurate to say that starting with https://review.opendev.org/#/c/663851 the unshelve API has strict request validation schema and {} is not allowed. However, why would that matter for existing unshelve tests in tempest that are not using that new microversion?\n\nSounds like the nova change has caused some regression for earlier microversions.","commit_id":"165023f55086e5139969dbcf90977294c4398ed7"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"52ce54b81551ac7d1fb50e0ffe951f82d3c40521","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Most of the compute Action API accept request body with"},{"line_number":10,"context_line":"action name and null value. For exmaple: {\u0027unshelve\u0027: null}."},{"line_number":11,"context_line":"But Tempest pass the empty dict instead of null- {\u0027unshelve\u0027: {}}."},{"line_number":12,"context_line":"This is the wrong usage of API. This does not give any error as"},{"line_number":13,"context_line":"Compute API does not check the value is null or anything else."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Nova does not have schema also for those request bodies."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_cc74bc9c","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":31},"in_reply_to":"7faddb67_002c4597","updated":"2020-03-23 16:17:22.000000000","message":"isn\u0027t null in the doc just None in python?","commit_id":"165023f55086e5139969dbcf90977294c4398ed7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d468aef69a486f5be3bbc8e52b35b535aa8644d2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Most of the compute Action API accept request body with"},{"line_number":10,"context_line":"action name and null value. For exmaple: {\u0027unshelve\u0027: null}."},{"line_number":11,"context_line":"But Tempest pass the empty dict instead of null- {\u0027unshelve\u0027: {}}."},{"line_number":12,"context_line":"This is the wrong usage of API. This does not give any error as"},{"line_number":13,"context_line":"Compute API does not check the value is null or anything else."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Nova does not have schema also for those request bodies."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_002c4597","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":31},"in_reply_to":"7faddb67_bdbb1e70","updated":"2019-07-11 15:51:31.000000000","message":"Yeah, that was nova regression due to applying the schema for older microverison.\n\nBut I would like to pass the request body as api-ref say in the example which is \u0027null\u0027. It can pass with any value as value is unused but let\u0027s use the one nova api-ref tell.\n\n- https://developer.openstack.org/api-ref/compute/?expanded\u003dunshelve-restore-shelved-server-unshelve-action-detail","commit_id":"165023f55086e5139969dbcf90977294c4398ed7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ff42956c2f427740ad72c209e79f53dfd071dd03","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Most of the compute Action API accept request body with"},{"line_number":10,"context_line":"action name and null value. For exmaple: {\u0027unshelve\u0027: null}."},{"line_number":11,"context_line":"But Tempest pass the empty dict instead of null- {\u0027unshelve\u0027: {}}."},{"line_number":12,"context_line":"This is the wrong usage of API. This does not give any error as"},{"line_number":13,"context_line":"Compute API does not check the value is null or anything else."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Nova does not have schema also for those request bodies."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_8e562b29","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":31},"in_reply_to":"df33271e_cc74bc9c","updated":"2020-06-16 15:07:47.000000000","message":"Done","commit_id":"165023f55086e5139969dbcf90977294c4398ed7"}]}