)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"39ea8d2554776842f1d4983b41d7de1d9e2e76fb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"accounts.yaml are not identical, then the test cases"},{"line_number":12,"context_line":"are failing. So, added .lower() method to change the"},{"line_number":13,"context_line":"username strings to be case insensitive."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id7d079c881bbfae972d65ef6049f78da7f25fc1d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7faddb67_32fabbbc","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":0},"updated":"2019-07-16 14:26:09.000000000","message":"add bug link here.\n\nCloses-Bug: #1836618","commit_id":"bb225da087f57ecd3f36fe4635cc3d91a71810e4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"61a80c599be0b421dd0ef12d3106067ea02a3da4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"are failing. So, added .lower() method to change the"},{"line_number":13,"context_line":"username strings to be case insensitive."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Link to the bug: https://bugs.launchpad.net/tempest/+bug/1836618"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id7d079c881bbfae972d65ef6049f78da7f25fc1d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_bec3d188","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":64},"updated":"2019-07-16 21:02:22.000000000","message":"this would not update the LP and how we mention the bugs in commit msg. you can write like below:\n\nCloses-Bug: #1836618","commit_id":"272049963a1c439d5b7fcb44338fe3d126c54f57"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"70e795a736ff18fa6347ea6e10043db4c6c103a4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In any domain, due to case sensitivity, if a username"},{"line_number":10,"context_line":"for the project and the username in tempest.conf or"},{"line_number":11,"context_line":"accounts.yaml are not identical, then the test cases"},{"line_number":12,"context_line":"are failing."},{"line_number":13,"context_line":"So, added a condition to check if the usernames on"},{"line_number":14,"context_line":"project and tempest.conf or accounts.yaml are not"},{"line_number":15,"context_line":"the same. If they are not the same and if case is all that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7faddb67_202e21a5","line":12,"updated":"2019-07-30 00:46:06.000000000","message":"An easy workaround that wouldn\u0027t require a change in tempest would just be to ensure the username in the config matches the username in the backend. That would also be much easier to read and maintain.","commit_id":"347c035b00bb57ad86e20cb6ce5f26870b320422"}],"tempest/api/identity/v3/test_tokens.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"39ea8d2554776842f1d4983b41d7de1d9e2e76fb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.assertEqual(authenticated_token, token_body)"},{"line_number":44,"context_line":"        # test to see if token has been properly authenticated"},{"line_number":45,"context_line":"        self.assertEqual(authenticated_token[\u0027user\u0027][\u0027id\u0027], user_id)"},{"line_number":46,"context_line":"        self.assertEqual(authenticated_token[\u0027user\u0027][\u0027name\u0027].lower(), username.lower())"},{"line_number":47,"context_line":"        self.non_admin_client.delete_token(subject_token)"},{"line_number":48,"context_line":"        self.assertRaises("},{"line_number":49,"context_line":"            lib_exc.NotFound, self.non_admin_client.show_token, subject_token)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_d2348795","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":87},"updated":"2019-07-16 14:26:09.000000000","message":"this is going beyond 79 char.\n\n        self.assertEqual(authenticated_token[\u0027user\u0027][\u0027name\u0027].lower(),\n                         username.lower())","commit_id":"bb225da087f57ecd3f36fe4635cc3d91a71810e4"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"924d949913f776cc05410d7acaf629040c26a348","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.assertEqual(authenticated_token, token_body)"},{"line_number":44,"context_line":"        # test to see if token has been properly authenticated"},{"line_number":45,"context_line":"        self.assertEqual(authenticated_token[\u0027user\u0027][\u0027id\u0027], user_id)"},{"line_number":46,"context_line":"        self.assertEqual("},{"line_number":47,"context_line":"            authenticated_token[\u0027user\u0027][\u0027name\u0027].lower(), username.lower())"},{"line_number":48,"context_line":"        self.non_admin_client.delete_token(subject_token)"},{"line_number":49,"context_line":"        self.assertRaises("},{"line_number":50,"context_line":"            lib_exc.NotFound, self.non_admin_client.show_token, subject_token)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_27d689f3","line":47,"range":{"start_line":46,"start_character":8,"end_line":47,"end_character":74},"updated":"2019-07-24 02:00:53.000000000","message":"what about taking this approach \n\n\ndef case_sensitive(self, sent_username, received_username)\n  if (sent_username !\u003d received_username and \n      sent_username.lower() \u003d\u003d received_username.()):\n      return \u003d False\n  else:\n      return \u003d True\n\nif case_sensitive(username , \n    authenticated_token[\u0027user\u0027][\u0027name\u0027]) :\n  self.assertEqual(authenticated_token[\u0027user\u0027][\u0027name\u0027], username)\nelse:\n  self.assertEqual(authenticated_token[\u0027user\u0027][\u0027name\u0027].lower(), \n                              username.lower())\n\nwhat do you think?","commit_id":"af7ceb50d9f646ca30ccfb89a9aa95f0058450fc"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"5e53000053df33fd2a5f9c0fae94eabcdc7bd256","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.assertEqual(authenticated_token[\u0027user\u0027][\u0027id\u0027], user_id)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        if username !\u003d authenticated_token[\u0027user\u0027][\u0027name\u0027] and \\"},{"line_number":48,"context_line":"                username \u003d\u003d authenticated_token[\u0027user\u0027][\u0027name\u0027].lower():"},{"line_number":49,"context_line":"            self.assertEqual("},{"line_number":50,"context_line":"                authenticated_token[\u0027user\u0027][\u0027name\u0027].lower(), username.lower())"},{"line_number":51,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_bfb9fd15","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":24},"updated":"2019-07-26 01:08:58.000000000","message":"should you lower() this side of the compare also","commit_id":"6b4f81fd8b39bb6a456405b5b5067cbc0e0b17d2"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"5e53000053df33fd2a5f9c0fae94eabcdc7bd256","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.assertEqual(token_details[\u0027user\u0027][\u0027id\u0027], user.user_id)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        if user.username !\u003d token_details[\u0027user\u0027][\u0027name\u0027] and \\"},{"line_number":122,"context_line":"                user.username \u003d\u003d token_details[\u0027user\u0027][\u0027name\u0027].lower():"},{"line_number":123,"context_line":"            self.assertEqual("},{"line_number":124,"context_line":"                token_details[\u0027user\u0027][\u0027name\u0027].lower(), user.username.lower())"},{"line_number":125,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_5f36c9b6","line":122,"range":{"start_line":122,"start_character":16,"end_line":122,"end_character":30},"updated":"2019-07-26 01:08:58.000000000","message":"should you user.username.lower() also","commit_id":"6b4f81fd8b39bb6a456405b5b5067cbc0e0b17d2"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"70e795a736ff18fa6347ea6e10043db4c6c103a4","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        if username !\u003d authenticated_token[\u0027user\u0027][\u0027name\u0027] \\"},{"line_number":48,"context_line":"                and username.lower() \u003d\u003d \\"},{"line_number":49,"context_line":"                authenticated_token[\u0027user\u0027][\u0027name\u0027].lower():"},{"line_number":50,"context_line":"            self.assertEqual("},{"line_number":51,"context_line":"                authenticated_token[\u0027user\u0027][\u0027name\u0027].lower(),"},{"line_number":52,"context_line":"                username.lower())"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_4029dd98","line":49,"updated":"2019-07-30 00:46:06.000000000","message":"I don\u0027t think you need this extra check, just go ahead and normalize both values when doing the assertEqual.","commit_id":"347c035b00bb57ad86e20cb6ce5f26870b320422"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"3ee403ada122e582315e515af5f1e24bc7a8371a","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        if username !\u003d authenticated_token[\u0027user\u0027][\u0027name\u0027] \\"},{"line_number":48,"context_line":"                and username.lower() \u003d\u003d \\"},{"line_number":49,"context_line":"                authenticated_token[\u0027user\u0027][\u0027name\u0027].lower():"},{"line_number":50,"context_line":"            self.assertEqual("},{"line_number":51,"context_line":"                authenticated_token[\u0027user\u0027][\u0027name\u0027].lower(),"},{"line_number":52,"context_line":"                username.lower())"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_7b67ee52","line":49,"in_reply_to":"7faddb67_4029dd98","updated":"2019-07-30 04:22:39.000000000","message":"yeah, I agree. And I think it\u0027s good to put a NOTE for the reason for `lower()` here.","commit_id":"347c035b00bb57ad86e20cb6ce5f26870b320422"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"72857e27298aa16001f779b1ba80d5f999b19a1b","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        if username !\u003d authenticated_token[\u0027user\u0027][\u0027name\u0027] \\"},{"line_number":48,"context_line":"                and username.lower() \u003d\u003d \\"},{"line_number":49,"context_line":"                authenticated_token[\u0027user\u0027][\u0027name\u0027].lower():"},{"line_number":50,"context_line":"            self.assertEqual("},{"line_number":51,"context_line":"                authenticated_token[\u0027user\u0027][\u0027name\u0027].lower(),"},{"line_number":52,"context_line":"                username.lower())"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_0a9bed65","line":49,"in_reply_to":"7faddb67_7b67ee52","updated":"2019-07-31 02:44:12.000000000","message":"yeah, let\u0027s go with the option of assertEqual both value as lower case. \n\nYou can add NOTE like below:\n\nNOTE: resource name case-sensitive in keystone depends on backend such as MySQL or LDAP are case-insensitive, case-preserving, as explained in https://docs.openstack.org/keystone/latest/admin/case-insensitive.html#backends . Resouce name is returned as it is stored in the backend, not as it is requested. Verifying the username with both lower case to avoid failure on different backends.","commit_id":"347c035b00bb57ad86e20cb6ce5f26870b320422"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"3ee403ada122e582315e515af5f1e24bc7a8371a","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        if username !\u003d subject_name and \\"},{"line_number":98,"context_line":"                username.lower() \u003d\u003d subject_name.lower():"},{"line_number":99,"context_line":"            self.assertEqual(subject_name.lower(), username.lower())"},{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            self.assertEqual(subject_name, username)"},{"line_number":102,"context_line":"        self.assertEqual(resp[\u0027methods\u0027][0], \u0027password\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_7b228e03","line":99,"updated":"2019-07-30 04:22:39.000000000","message":"I think here is the same as above (like the patch set 8).","commit_id":"347c035b00bb57ad86e20cb6ce5f26870b320422"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"409a87931dc76b80417db113135aaf659ece2612","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        # requested. Verifying the username with both lower-case to"},{"line_number":134,"context_line":"        # avoid failure on different backends"},{"line_number":135,"context_line":"        self.assertEqual("},{"line_number":136,"context_line":"                token_details[\u0027user\u0027][\u0027name\u0027].lower(), user.username.lower())"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # Perform Delete Token"}],"source_content_type":"text/x-python","patch_set":13,"id":"7faddb67_a32e5b40","line":136,"range":{"start_line":136,"start_character":74,"end_line":136,"end_character":77},"updated":"2019-08-02 06:08:31.000000000","message":"you are hitting max length error here.","commit_id":"81817cbc14043ec83451e51e71bd7d671ff008ba"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3d6a0ee71285611e578fcca4cb0a88ed6c3f4401","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        # requested. Verifying the username with both lower-case to"},{"line_number":134,"context_line":"        # avoid failure on different backends"},{"line_number":135,"context_line":"        self.assertEqual("},{"line_number":136,"context_line":"                token_details[\u0027user\u0027][\u0027name\u0027].lower(), user.username.lower())"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # Perform Delete Token"}],"source_content_type":"text/x-python","patch_set":13,"id":"7faddb67_0315efe4","line":136,"range":{"start_line":136,"start_character":74,"end_line":136,"end_character":77},"in_reply_to":"7faddb67_a32e5b40","updated":"2019-08-02 06:10:25.000000000","message":"ah indentation issue not length.","commit_id":"81817cbc14043ec83451e51e71bd7d671ff008ba"}]}