)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d0ab04ebf44f9d408e3641109cf4fffaa0403561","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Changes were made in ListProjectsStaticTestJSON in order to prevent "},{"line_number":10,"context_line":"failure when the os_primary project is not in the default domain. "},{"line_number":11,"context_line":"Instead of checking to see if the projects in question are both in the "},{"line_number":12,"context_line":"default domain, check to see if they are in their respective correct "},{"line_number":13,"context_line":"domains."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5dfe04f6638657ba0b3c1f18c4bc5b5222228234"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7faddb67_71f4ed87","line":12,"updated":"2019-07-30 07:06:34.000000000","message":"nit: above four lines have trailing spaces.","commit_id":"8f4c2c238185c51e6382cebdb203a409c989a5df"}],"tempest/api/identity/admin/v3/test_list_projects.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6d865a55e05e09b2255d8321351a26d9f7b32f10","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            p2_name, domain_id\u003dcls.p2_domain_id)[\u0027project\u0027]"},{"line_number":108,"context_line":"        cls.addClassResourceCleanup(cls.projects_client.delete_project,"},{"line_number":109,"context_line":"                                    cls.p2[\u0027id\u0027])"},{"line_number":110,"context_line":"        cls.projects.append(cls.p2)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @decorators.idempotent_id(\u00271d830662-22ad-427c-8c3e-4ec854b0af44\u0027)"},{"line_number":113,"context_line":"    def test_list_projects(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_86b52a35","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":35},"updated":"2019-08-07 04:15:01.000000000","message":"let\u0027s not store the duplicate copy of created projects. we can use self.p1 and self.p2 in tests as commented below.","commit_id":"e373f37e062718a7ed444b27f84c1a53483d73c7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6d865a55e05e09b2255d8321351a26d9f7b32f10","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        # List projects"},{"line_number":115,"context_line":"        list_projects \u003d self.projects_client.list_projects()[\u0027projects\u0027]"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        for p in self.projects:"},{"line_number":118,"context_line":"            show_project \u003d self.projects_client.show_project(p[\u0027id\u0027])["},{"line_number":119,"context_line":"                \u0027project\u0027]"},{"line_number":120,"context_line":"            self.assertIn(show_project, list_projects)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_c6ab22d5","line":117,"range":{"start_line":117,"start_character":17,"end_line":117,"end_character":30},"updated":"2019-08-07 04:15:01.000000000","message":"and here you can just make list from self.p*  \n\nfor p in [self.p1, self.p2]:","commit_id":"e373f37e062718a7ed444b27f84c1a53483d73c7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6d865a55e05e09b2255d8321351a26d9f7b32f10","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        # Verify both projects are in their respective domains"},{"line_number":133,"context_line":"        for p in self.projects:"},{"line_number":134,"context_line":"            params \u003d {key: p[key]}"},{"line_number":135,"context_line":"            self._list_projects_with_params([p], [], params, key)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_a65dc616","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":65},"updated":"2019-08-07 04:15:01.000000000","message":"checking only requested project\u0027s domain id in list filter is return in list API response or not is ok but not enough to verify the list filter. We need some project in exclude list also so that we can verify if keystone list API filter works fine or not.\n\nCan we add the project in exclude list also if domain id of those project is different? something like that.\n\nparams \u003d {key: self.p1[key]}\nexclude \u003d []\nif self.p1[key] !\u003d self.p2[key]:\n    exclude \u003d [self.p2]\nself._list_projects_with_params([self.p1], exclude, params, key)","commit_id":"e373f37e062718a7ed444b27f84c1a53483d73c7"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"96bfbd3a104b9a8f9531c465ac713fc9f9040a90","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            cls.os_primary.credentials.project_id)[\u0027project\u0027]"},{"line_number":100,"context_line":"        # Create a test project"},{"line_number":101,"context_line":"        p2_name \u003d data_utils.rand_name(\u0027project\u0027)"},{"line_number":102,"context_line":"        cls.p2_domain_id \u003d CONF.identity.default_domain_id"},{"line_number":103,"context_line":"        cls.p2 \u003d cls.projects_client.create_project("},{"line_number":104,"context_line":"            p2_name, domain_id\u003dcls.p2_domain_id)[\u0027project\u0027]"},{"line_number":105,"context_line":"        cls.addClassResourceCleanup(cls.projects_client.delete_project,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_782dcda6","line":102,"range":{"start_line":102,"start_character":8,"end_line":102,"end_character":24},"updated":"2019-08-13 09:18:01.000000000","message":"this need not be an instance variable","commit_id":"f770220e3d0c4c1a5d366011912884b9e1d1268f"}]}
