)]}'
{"releasenotes/notes/add-show-api-v3-details-api-to-v3-versions-client-4b408427379cabfe.yaml":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5f8e5f529d063d78cdae4fe8bc7e01dd5cdfd323","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add show api v3 details api to v3 versions_client library."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * show_v3_version_detail"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_215e0776","line":4,"range":{"start_line":4,"start_character":35,"end_line":4,"end_character":37},"updated":"2019-07-31 14:26:50.000000000","message":"v3 volume\n\nThat will help to make it clear that this is for Cinder, since versions_client exists for other projects too.","commit_id":"fa89088dc5de74946760b106f5673ae2dad73591"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"223d14ac3a3f888b19ca5f1e8761dbb0b693011d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add show api v3 details api to v3 versions_client library."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * show_v3_version_detail"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_3667ef4f","line":4,"range":{"start_line":4,"start_character":35,"end_line":4,"end_character":37},"in_reply_to":"7faddb67_215e0776","updated":"2019-08-05 12:09:41.000000000","message":"Done","commit_id":"fa89088dc5de74946760b106f5673ae2dad73591"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5f8e5f529d063d78cdae4fe8bc7e01dd5cdfd323","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add show api v3 details api to v3 versions_client library."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * show_v3_version_detail"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_81733b16","line":6,"range":{"start_line":6,"start_character":6,"end_line":6,"end_character":28},"updated":"2019-07-31 14:26:50.000000000","message":"show_version","commit_id":"fa89088dc5de74946760b106f5673ae2dad73591"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"223d14ac3a3f888b19ca5f1e8761dbb0b693011d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add show api v3 details api to v3 versions_client library."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * show_v3_version_detail"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_9657c358","line":6,"range":{"start_line":6,"start_character":6,"end_line":6,"end_character":28},"in_reply_to":"7faddb67_81733b16","updated":"2019-08-05 12:09:41.000000000","message":"Done","commit_id":"fa89088dc5de74946760b106f5673ae2dad73591"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c66ab4b4e16bd370c1d71002283238d29ae5bc24","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add show api v3 details api to v3 versions_client library for cinder."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * show_version"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_9cb58034","line":4,"range":{"start_line":4,"start_character":13,"end_line":4,"end_character":27},"updated":"2019-08-07 02:31:40.000000000","message":"s/api v3 details api/API version details function/","commit_id":"97bcd70343044f6c8483aeb72bcfb643a9835b38"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"3809f9fa5d291a652e558f81936fcec286374f1e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add show api v3 details api to v3 versions_client library for cinder."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * show_version"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_5c070883","line":4,"range":{"start_line":4,"start_character":13,"end_line":4,"end_character":27},"in_reply_to":"7faddb67_9cb58034","updated":"2019-08-07 04:16:44.000000000","message":"Done","commit_id":"97bcd70343044f6c8483aeb72bcfb643a9835b38"}],"tempest/lib/api_schema/response/volume/versions.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"fd120b046a53a965a5ab6d2b30a2f7357cc5d2dd","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"volumn_api_v3_details \u003d {"},{"line_number":63,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":64,"context_line":"    \u0027response_body\u0027: {"},{"line_number":65,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_d001fb39","line":62,"range":{"start_line":62,"start_character":10,"end_line":62,"end_character":13},"updated":"2019-07-31 17:46:14.000000000","message":"This schema is not only for v3, so let\u0027s remove \"_v3\"","commit_id":"fa89088dc5de74946760b106f5673ae2dad73591"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5f8e5f529d063d78cdae4fe8bc7e01dd5cdfd323","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"volumn_api_v3_details \u003d {"},{"line_number":63,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":64,"context_line":"    \u0027response_body\u0027: {"},{"line_number":65,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_e1254f0a","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":6},"updated":"2019-07-31 14:26:50.000000000","message":"volume","commit_id":"fa89088dc5de74946760b106f5673ae2dad73591"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"67cd0cfb101184ea5a41f0988524a9467dda414a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"volumn_api_v3_details \u003d {"},{"line_number":63,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":64,"context_line":"    \u0027response_body\u0027: {"},{"line_number":65,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_9495b0e6","line":62,"range":{"start_line":62,"start_character":10,"end_line":62,"end_character":13},"in_reply_to":"7faddb67_d001fb39","updated":"2019-08-01 03:31:46.000000000","message":"@Felipe, from link to cinder API, it shows for cinder v3, so should be keep the v3 flag?\nThis is it\u0027s description \"Shows details for Block Storage API v3.\"\n\nlinks: https://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dshow-api-v3-details-detail#show-api-v3-details","commit_id":"fa89088dc5de74946760b106f5673ae2dad73591"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"223d14ac3a3f888b19ca5f1e8761dbb0b693011d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"volumn_api_v3_details \u003d {"},{"line_number":63,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":64,"context_line":"    \u0027response_body\u0027: {"},{"line_number":65,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_d6ce9b2b","line":62,"range":{"start_line":62,"start_character":10,"end_line":62,"end_character":13},"in_reply_to":"7faddb67_d001fb39","updated":"2019-08-05 12:09:41.000000000","message":"Done","commit_id":"fa89088dc5de74946760b106f5673ae2dad73591"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"223d14ac3a3f888b19ca5f1e8761dbb0b693011d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"volumn_api_v3_details \u003d {"},{"line_number":63,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":64,"context_line":"    \u0027response_body\u0027: {"},{"line_number":65,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_f6d157cd","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":6},"in_reply_to":"7faddb67_e1254f0a","updated":"2019-08-05 12:09:41.000000000","message":"Done","commit_id":"fa89088dc5de74946760b106f5673ae2dad73591"}],"tempest/lib/services/volume/v3/versions_client.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"cd92f0d702d9ff3d314c880c266f4e8fc2d611c4","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.validate_response(schema.list_versions, resp, body)"},{"line_number":47,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def show_api_v3_detail(self):"},{"line_number":50,"context_line":"        \"\"\"Show API v3 details"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_76d5c3b6","line":49,"updated":"2019-07-30 05:14:06.000000000","message":"Did you wanted to make this `show_api_v3_details(self)` (adding \u0027s\u0027)? I only found similar name one is this, though.\n\n  $ ag _detail tempest/lib/services | ag \"def \"\n  tempest/lib/services/network/quotas_client.py:50:    def show_quota_details(self, tenant_id):","commit_id":"1df1a964dd99d5d54d9c13f3ec1dc35d9ba613b4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d012f95a0d3993463e53e1d38e677a6f555759be","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.validate_response(schema.list_versions, resp, body)"},{"line_number":47,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def show_api_v3_detail(self):"},{"line_number":50,"context_line":"        \"\"\"Show API v3 details"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_c2585f8b","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":33},"updated":"2019-07-30 22:25:10.000000000","message":"I think this method doesn\u0027t need to be only for v3 API.\nHow about\n\n def show_version(self, version):\n\nlike Neutron version client?\nWe can specify version and the client function return the version info of the specified one.","commit_id":"1df1a964dd99d5d54d9c13f3ec1dc35d9ba613b4"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"0b76a1ec3ba3b62c0311c92d1f3c23c6be744549","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.validate_response(schema.list_versions, resp, body)"},{"line_number":47,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def show_api_v3_detail(self):"},{"line_number":50,"context_line":"        \"\"\"Show API v3 details"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_c77b8e25","line":49,"in_reply_to":"7faddb67_76d5c3b6","updated":"2019-07-31 01:03:45.000000000","message":"Done","commit_id":"1df1a964dd99d5d54d9c13f3ec1dc35d9ba613b4"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"0b76a1ec3ba3b62c0311c92d1f3c23c6be744549","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.validate_response(schema.list_versions, resp, body)"},{"line_number":47,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def show_api_v3_detail(self):"},{"line_number":50,"context_line":"        \"\"\"Show API v3 details"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_a77e9216","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":33},"in_reply_to":"7faddb67_c2585f8b","updated":"2019-07-31 01:03:45.000000000","message":"Done","commit_id":"1df1a964dd99d5d54d9c13f3ec1dc35d9ba613b4"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"cd92f0d702d9ff3d314c880c266f4e8fc2d611c4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#show-api-v3-details"},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        version_url \u003d self._get_base_version_url() + \u0027v3/\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        start \u003d time.time()"},{"line_number":59,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027)"},{"line_number":60,"context_line":"        end \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_16e48fab","line":57,"updated":"2019-07-30 05:14:06.000000000","message":"Below code is almost the same as list_version()\u0027s. So, I think we can share the common code.","commit_id":"1df1a964dd99d5d54d9c13f3ec1dc35d9ba613b4"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"a75db741dd823b24c742f8e8735a0ad63b1ddee9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#list-all-api-versions"},{"line_number":32,"context_line":"        \"\"\""},{"line_number":33,"context_line":"        version_url \u003d self._get_base_version_url()"},{"line_number":34,"context_line":"        "},{"line_number":35,"context_line":"        start \u003d time.time()"},{"line_number":36,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027)"},{"line_number":37,"context_line":"        end \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_678f3acd","line":34,"updated":"2019-07-31 01:42:27.000000000","message":"This change isn\u0027t necessary.","commit_id":"2c3b5eb0d864cea13ee5aed7700b2feafff35601"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"e1d1684d73cc951b785cad83034d6753eae0e063","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#list-all-api-versions"},{"line_number":32,"context_line":"        \"\"\""},{"line_number":33,"context_line":"        version_url \u003d self._get_base_version_url()"},{"line_number":34,"context_line":"        "},{"line_number":35,"context_line":"        start \u003d time.time()"},{"line_number":36,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027)"},{"line_number":37,"context_line":"        end \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_ea1e915d","line":34,"in_reply_to":"7faddb67_678f3acd","updated":"2019-07-31 02:03:06.000000000","message":"Done","commit_id":"2c3b5eb0d864cea13ee5aed7700b2feafff35601"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5f8e5f529d063d78cdae4fe8bc7e01dd5cdfd323","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":53,"context_line":"        API reference:"},{"line_number":54,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#show-api-v3-details"},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        version_url \u003d self._get_base_version_url() + version + \u0027/\u0027"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_41322312","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":85},"updated":"2019-07-31 14:26:50.000000000","message":"For clarification this API doesn\u0027t need auth either?","commit_id":"fa89088dc5de74946760b106f5673ae2dad73591"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"3aaa1e48122eca9a8215dce5679be59ef6c621c2","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":53,"context_line":"        API reference:"},{"line_number":54,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#show-api-v3-details"},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        version_url \u003d self._get_base_version_url() + version + \u0027/\u0027"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_1456a05d","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":25},"updated":"2019-08-01 01:30:28.000000000","message":"NIT: should this be docs to support need name an skip redirect?\nhttps://docs.openstack.org/api-ref/block-storage/v3/#show-api-v3-details","commit_id":"fa89088dc5de74946760b106f5673ae2dad73591"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"67cd0cfb101184ea5a41f0988524a9467dda414a","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":53,"context_line":"        API reference:"},{"line_number":54,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#show-api-v3-details"},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        version_url \u003d self._get_base_version_url() + version + \u0027/\u0027"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_cf4b91ae","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":85},"in_reply_to":"7faddb67_41322312","updated":"2019-08-01 03:31:46.000000000","message":"@Felipe, check cinder\u0027s api interface [1] and API documentation [2], did not verify the permissions, I think this is ok, but not sure, I hope to get a reply from @whoami-rajat (cinder team core).\n\n[1]https://github.com/openstack/cinder/blob/32217cbbc7d26e8edc4f3f4f04addbe3a37b314b/cinder/api/versions.py#L105\n[2]https://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dshow-api-v3-details-detail#show-api-v3-details","commit_id":"fa89088dc5de74946760b106f5673ae2dad73591"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"223d14ac3a3f888b19ca5f1e8761dbb0b693011d","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":53,"context_line":"        API reference:"},{"line_number":54,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#show-api-v3-details"},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        version_url \u003d self._get_base_version_url() + version + \u0027/\u0027"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_76dd67db","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":85},"in_reply_to":"7faddb67_41322312","updated":"2019-08-05 12:09:41.000000000","message":"Done","commit_id":"fa89088dc5de74946760b106f5673ae2dad73591"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"fd120b046a53a965a5ab6d2b30a2f7357cc5d2dd","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self._error_checker(resp, body)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        body \u003d json.loads(body)"},{"line_number":66,"context_line":"        self.validate_response(schema.volumn_api_v3_details, resp, body)"},{"line_number":67,"context_line":"        return rest_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_90f7035a","line":66,"range":{"start_line":66,"start_character":48,"end_line":66,"end_character":51},"updated":"2019-07-31 17:46:14.000000000","message":"ditto","commit_id":"fa89088dc5de74946760b106f5673ae2dad73591"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"223d14ac3a3f888b19ca5f1e8761dbb0b693011d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self._error_checker(resp, body)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        body \u003d json.loads(body)"},{"line_number":66,"context_line":"        self.validate_response(schema.volumn_api_v3_details, resp, body)"},{"line_number":67,"context_line":"        return rest_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_96058348","line":66,"range":{"start_line":66,"start_character":48,"end_line":66,"end_character":51},"in_reply_to":"7faddb67_90f7035a","updated":"2019-08-05 12:09:41.000000000","message":"Done","commit_id":"fa89088dc5de74946760b106f5673ae2dad73591"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5f32dbc6fddf25b088074f8aae818d726e62cbc0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#show-api-v3-details"},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        version_url \u003d self._get_base_version_url() + version + \u0027/\u0027"},{"line_number":58,"context_line":"        # we need a token for this request"},{"line_number":59,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027,"},{"line_number":60,"context_line":"                                      {\u0027X-Auth-Token\u0027: self.token})"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_d7776a9f","line":57,"range":{"start_line":57,"start_character":22,"end_line":57,"end_character":66},"updated":"2019-08-06 04:13:21.000000000","message":"nit: it is slightly better to use:\n\n    os.path.join(self._get_base_version_url(), version)\n\nto avoid a double-slash getting injected.","commit_id":"40bdd4429b2a081266a43f2fdbed4e7323a1ccff"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"2bdc259ebafcbfe5f8f1a078367dc1c14c750f8b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#show-api-v3-details"},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        version_url \u003d self._get_base_version_url() + version + \u0027/\u0027"},{"line_number":58,"context_line":"        # we need a token for this request"},{"line_number":59,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027,"},{"line_number":60,"context_line":"                                      {\u0027X-Auth-Token\u0027: self.token})"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_d7152a9d","line":57,"range":{"start_line":57,"start_character":22,"end_line":57,"end_character":66},"in_reply_to":"7faddb67_d7776a9f","updated":"2019-08-06 05:41:04.000000000","message":"thanks for your review","commit_id":"40bdd4429b2a081266a43f2fdbed4e7323a1ccff"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5f32dbc6fddf25b088074f8aae818d726e62cbc0","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        version_url \u003d self._get_base_version_url() + version + \u0027/\u0027"},{"line_number":58,"context_line":"        # we need a token for this request"},{"line_number":59,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027,"},{"line_number":60,"context_line":"                                      {\u0027X-Auth-Token\u0027: self.token})"},{"line_number":61,"context_line":"        self._error_checker(resp, body)"},{"line_number":62,"context_line":"        body \u003d json.loads(body)"},{"line_number":63,"context_line":"        self.validate_response(schema.volume_api_version_details, resp, body)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_975492ff","line":60,"range":{"start_line":58,"start_character":8,"end_line":60,"end_character":67},"updated":"2019-08-06 04:13:21.000000000","message":"Thanks for confirming this. I\u0027m assuming, then, that authentication is then needed for this API endpoint? If so, there is an easier way to do this, e.g.:\n\nhttps://github.com/openstack/tempest/blob/0a0f5c6e0bd7ee159247b1e432d3d2ca5b5236b4/tempest/lib/services/volume/v3/volumes_client.py#L84\n\nWhich then becomes: \n\n        resp, body \u003d self.get(version_url)\n        body \u003d json.loads(body)\n        self.validate_response(schema.volume_api_version_details, resp, body)\n        return rest_client.ResponseBody(resp, body)","commit_id":"40bdd4429b2a081266a43f2fdbed4e7323a1ccff"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3e88bd1206e4a21114e358ae6b47f15e63fa5900","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        version_url \u003d self._get_base_version_url() + version + \u0027/\u0027"},{"line_number":58,"context_line":"        # we need a token for this request"},{"line_number":59,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027,"},{"line_number":60,"context_line":"                                      {\u0027X-Auth-Token\u0027: self.token})"},{"line_number":61,"context_line":"        self._error_checker(resp, body)"},{"line_number":62,"context_line":"        body \u003d json.loads(body)"},{"line_number":63,"context_line":"        self.validate_response(schema.volume_api_version_details, resp, body)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_5dab98d4","line":60,"range":{"start_line":58,"start_character":8,"end_line":60,"end_character":67},"in_reply_to":"7faddb67_975492ff","updated":"2019-08-06 10:18:12.000000000","message":"+1","commit_id":"40bdd4429b2a081266a43f2fdbed4e7323a1ccff"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"2bdc259ebafcbfe5f8f1a078367dc1c14c750f8b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        version_url \u003d self._get_base_version_url() + version + \u0027/\u0027"},{"line_number":58,"context_line":"        # we need a token for this request"},{"line_number":59,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027,"},{"line_number":60,"context_line":"                                      {\u0027X-Auth-Token\u0027: self.token})"},{"line_number":61,"context_line":"        self._error_checker(resp, body)"},{"line_number":62,"context_line":"        body \u003d json.loads(body)"},{"line_number":63,"context_line":"        self.validate_response(schema.volume_api_version_details, resp, body)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_f71866d3","line":60,"range":{"start_line":58,"start_character":8,"end_line":60,"end_character":67},"in_reply_to":"7faddb67_975492ff","updated":"2019-08-06 05:41:04.000000000","message":"Done","commit_id":"40bdd4429b2a081266a43f2fdbed4e7323a1ccff"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3875338da3d74a72487b73e435f3d2ccc2773496","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":54,"context_line":"        API reference:"},{"line_number":55,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#show-api-v3-details"},{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        version_url \u003d os.path.join(self._get_base_version_url(), version)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_acb940cc","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":85},"updated":"2019-08-06 08:09:08.000000000","message":"let\u0027s use new url - https://docs.openstack.org/api-ref/block-storage/v3/#show-api-v3-details","commit_id":"97bcd70343044f6c8483aeb72bcfb643a9835b38"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"421de8ea28db6eb3459a99e2dde530f54d6fa5d1","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":54,"context_line":"        API reference:"},{"line_number":55,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#show-api-v3-details"},{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        version_url \u003d os.path.join(self._get_base_version_url(), version)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_5cde2811","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":85},"in_reply_to":"7faddb67_5d6638ef","updated":"2019-08-07 03:12:43.000000000","message":"Done","commit_id":"97bcd70343044f6c8483aeb72bcfb643a9835b38"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"421de8ea28db6eb3459a99e2dde530f54d6fa5d1","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":54,"context_line":"        API reference:"},{"line_number":55,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#show-api-v3-details"},{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        version_url \u003d os.path.join(self._get_base_version_url(), version)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_7ce1a4cf","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":85},"in_reply_to":"7faddb67_9c6020d1","updated":"2019-08-07 03:12:43.000000000","message":"Done","commit_id":"97bcd70343044f6c8483aeb72bcfb643a9835b38"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3e88bd1206e4a21114e358ae6b47f15e63fa5900","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":54,"context_line":"        API reference:"},{"line_number":55,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#show-api-v3-details"},{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        version_url \u003d os.path.join(self._get_base_version_url(), version)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_5d6638ef","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":85},"in_reply_to":"7faddb67_acb940cc","updated":"2019-08-06 10:18:12.000000000","message":"+1, although it can be redirected, it is most appropriate to use the latest ones.","commit_id":"97bcd70343044f6c8483aeb72bcfb643a9835b38"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c66ab4b4e16bd370c1d71002283238d29ae5bc24","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":54,"context_line":"        API reference:"},{"line_number":55,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#show-api-v3-details"},{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        version_url \u003d os.path.join(self._get_base_version_url(), version)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_9c6020d1","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":85},"in_reply_to":"7faddb67_acb940cc","updated":"2019-08-07 02:31:40.000000000","message":"+1, and I cannot +2 due to your comment.\nbetter to put -1 clearly.","commit_id":"97bcd70343044f6c8483aeb72bcfb643a9835b38"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"421de8ea28db6eb3459a99e2dde530f54d6fa5d1","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":54,"context_line":"        API reference:"},{"line_number":55,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#show-api-v3-details"},{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        version_url \u003d os.path.join(self._get_base_version_url(), version)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_9cc26033","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":85},"in_reply_to":"7faddb67_acb940cc","updated":"2019-08-07 03:12:43.000000000","message":"Done","commit_id":"97bcd70343044f6c8483aeb72bcfb643a9835b38"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f06b9f5484931c171b18f07aed0e8d013a373f51","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":54,"context_line":"        API reference:"},{"line_number":55,"context_line":"        https://docs.openstack.org/api-ref/block-storage/v3/#sh"},{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        version_url \u003d os.path.join(self._get_base_version_url(), version)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_1cb5107e","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":63},"updated":"2019-08-07 03:41:59.000000000","message":"seems like you pasted it wrong - https://docs.openstack.org/api-ref/block-storage/v3/#show-api-v3-details","commit_id":"c09ef72dedfd007d3924467b4665693a1f06a422"},{"author":{"_account_id":30409,"name":"wangzhiguang","email":"wangzhiguang@inspur.com","username":"wangzhiguang"},"change_message_id":"3809f9fa5d291a652e558f81936fcec286374f1e","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":54,"context_line":"        API reference:"},{"line_number":55,"context_line":"        https://docs.openstack.org/api-ref/block-storage/v3/#sh"},{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        version_url \u003d os.path.join(self._get_base_version_url(), version)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_c694828f","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":63},"in_reply_to":"7faddb67_1cb5107e","updated":"2019-08-07 04:16:44.000000000","message":"Done","commit_id":"c09ef72dedfd007d3924467b4665693a1f06a422"}]}
