)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8a568af01729365fa8f7bb9a1a0feeb48e3515b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"7faddb67_39510963","line":29,"updated":"2019-08-21 18:29:10.000000000","message":"This should also close bug 1840788; can that be added here please?","commit_id":"1db2cedc81a4de3906aa998919f0cc8ea7bc2779"}],"releasenotes/notes/deprecate-vnc-server-header-529f07d592aefb62.yaml":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"2f84dbe10aa6abdf4acd5e0ebde6983689f66d9a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"fixes:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Adequately validates WebSocket upgrade in test_novnc and removes unneeded"},{"line_number":11,"context_line":"    configuration complexity. Closes bug #1838777. "},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7faddb67_83b986ed","line":11,"updated":"2019-08-08 04:35:11.000000000","message":"Please remove the trailing space.","commit_id":"0a3346773ede329c5ddba91ca5631ca560523ddf"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8a568af01729365fa8f7bb9a1a0feeb48e3515b3","unresolved":false,"context_lines":[{"line_number":8,"context_line":"fixes:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Adequately validates WebSocket upgrade in test_novnc and removes unneeded"},{"line_number":11,"context_line":"    configuration complexity. Closes bug #1838777."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_99c7dd12","line":11,"range":{"start_line":11,"start_character":42,"end_line":11,"end_character":49},"updated":"2019-08-21 18:29:10.000000000","message":"and 1840788","commit_id":"1db2cedc81a4de3906aa998919f0cc8ea7bc2779"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c0d017fd59351f5ec758dc2a36e10b662a6bdb72","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The config option ``CONF.vnc_server_header`` has become obsolete with the"},{"line_number":5,"context_line":"    usage of different response header fields to accomplish the same goal in"},{"line_number":6,"context_line":"    accordance with RFC7231 Section 6.2.2."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"7faddb67_835f464c","line":4,"range":{"start_line":4,"start_character":24,"end_line":4,"end_character":46},"updated":"2019-08-23 05:53:22.000000000","message":"CONF.compute.vnc_server_header","commit_id":"1df9c52e200674374a7a1776a745d4656a243e87"}],"tempest/api/compute/servers/test_novnc.py":[{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"318b8b80d030ac81fc3b6ad40626afc20422a919","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def _validate_websocket_upgrade(self):"},{"line_number":159,"context_line":"        \"\"\"Verify that the websocket upgrade was successful by parsing response"},{"line_number":160,"context_line":"        and ensuring that required response fields are present and accurate."},{"line_number":161,"context_line":"        (https://tools.ietf.org/html/rfc7231#section-6.2.2)"},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        _response \u003d self._websocket.response"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_555ce817","line":161,"range":{"start_line":160,"start_character":8,"end_line":161,"end_character":59},"updated":"2019-08-05 02:16:34.000000000","message":"add empty line above\n\nH405  multi line docstring summary not separated with an empty line\n2019-08-02 21:15:17.177857 | ubuntu-bionic |         \"\"\"","commit_id":"1c90600fb57dad7c9a2b8e1f8504f52fc72f71a8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c0cf8e0a96878080b0b4cb5e7a232c5df9019b95","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                                 b\u0027Protocols\u0027),"},{"line_number":170,"context_line":"            \u0027Incorrect HTTP return status code: {}\u0027.format(_response)"},{"line_number":171,"context_line":"        )"},{"line_number":172,"context_line":"        _required_header \u003d b\u0027Upgrade: websocket\u0027"},{"line_number":173,"context_line":"        self.assertIn("},{"line_number":174,"context_line":"            _required_header,"},{"line_number":175,"context_line":"            _response,"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_9c54b9ff","line":172,"range":{"start_line":172,"start_character":26,"end_line":172,"end_character":48},"updated":"2019-08-06 01:51:35.000000000","message":"I\u0027m not familar with novnc protocol, so I\u0027m not sure whether using this check to replace the original check of \"server: {vnc_server_header}\" is accurate. Just wait for opinions from someone who is familar with novnc.","commit_id":"41c63df6a44523fc666d00e6df981320c5bd24eb"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"06f83da955a32e438569d20afaf94350c55010af","unresolved":false,"context_lines":[{"line_number":31,"context_line":"else:"},{"line_number":32,"context_line":"    ord_func \u003d int"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class NoVNCConsoleTestJSON(base.BaseV2ComputeTest):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":14,"id":"7faddb67_5c4e286f","side":"PARENT","line":34,"updated":"2019-08-07 02:28:24.000000000","message":"Don\u0027t delete this line. I think it causes a pep8 error.\n\nhttps://logs.opendev.org/64/674364/14/check/openstack-tox-pep8/4e48ca7/job-output.txt.gz#_2019-08-06_19_32_21_691165","commit_id":"464509830a9b8d8774562708b38e739ac70769ad"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"06f83da955a32e438569d20afaf94350c55010af","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d config.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"if six.PY2:"},{"line_number":34,"context_line":"    ord_func \u003d ord"}],"source_content_type":"text/x-python","patch_set":14,"id":"7faddb67_bc2ddc8f","line":31,"updated":"2019-08-07 02:28:24.000000000","message":"This LOG isn\u0027t used.","commit_id":"a5d0db81534d1739b93aa45046fa1bd173a0956a"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"06f83da955a32e438569d20afaf94350c55010af","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        self.assertTrue("},{"line_number":171,"context_line":"            _response.startswith(b\u0027HTTP/1.1 101 Switching \u0027"},{"line_number":172,"context_line":"                                 b\u0027Protocols\u0027),"},{"line_number":173,"context_line":"            \u0027Incorrect HTTP return status code: {}\u0027.format(_response)"},{"line_number":174,"context_line":"        )"},{"line_number":175,"context_line":"        _required_header \u003d b\u0027Upgrade: websocket\u0027"},{"line_number":176,"context_line":"        self.assertIn("}],"source_content_type":"text/x-python","patch_set":14,"id":"7faddb67_7c51a40d","line":173,"updated":"2019-08-07 02:28:24.000000000","message":"We don\u0027t need to use six.text_type() here?","commit_id":"a5d0db81534d1739b93aa45046fa1bd173a0956a"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"06f83da955a32e438569d20afaf94350c55010af","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        _required_header \u003d b\u0027Upgrade: websocket\u0027"},{"line_number":176,"context_line":"        self.assertIn("},{"line_number":177,"context_line":"            _required_header,"},{"line_number":178,"context_line":"            _response,"},{"line_number":179,"context_line":"            \u0027Did not get the expected WebSocket HTTP Response.\u0027"},{"line_number":180,"context_line":"        )"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7faddb67_1c5430fd","line":178,"updated":"2019-08-07 02:28:24.000000000","message":"We don\u0027t need to lower() here with making _required_header lower()? It might be safer.","commit_id":"a5d0db81534d1739b93aa45046fa1bd173a0956a"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"2f84dbe10aa6abdf4acd5e0ebde6983689f66d9a","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        self.assertTrue("},{"line_number":167,"context_line":"            self._websocket.response.startswith(b\u0027HTTP/1.1 101 Switching \u0027"},{"line_number":168,"context_line":"                                 \t\tb\u0027Protocols\u0027),"},{"line_number":169,"context_line":"            \u0027Incorrect HTTP return status code: {}\u0027.format("},{"line_number":170,"context_line":"                six.text_type(self._websocket.response)"},{"line_number":171,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":20,"id":"7faddb67_a3be02d2","line":168,"updated":"2019-08-08 04:35:11.000000000","message":"Please don\u0027t use tab spaces.. And I recommend you to run tox -e pep8 in your local environment before submitting a patch at least. I think that can reduce your wasted time :)","commit_id":"0a3346773ede329c5ddba91ca5631ca560523ddf"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"70f756c7e277e31ef9d8aa7942737a6b208df790","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                six.text_type(self._websocket.response)"},{"line_number":171,"context_line":"            )"},{"line_number":172,"context_line":"        )"},{"line_number":173,"context_line":"        _required_header \u003d \u0027Upgrade: websocket\u0027.lower()"},{"line_number":174,"context_line":"        _response \u003d six.text_type(self._websocket.response).lower()"},{"line_number":175,"context_line":"        self.assertIn("},{"line_number":176,"context_line":"            _required_header,"}],"source_content_type":"text/x-python","patch_set":23,"id":"7faddb67_7fff6c65","line":173,"range":{"start_line":173,"start_character":27,"end_line":173,"end_character":55},"updated":"2019-08-21 11:49:28.000000000","message":"just make this \n_required_header \u003d \u0027upgrade: websocket\u0027","commit_id":"db64833495844f85bf6d8b3bb411a4aa97ea7f62"}],"tempest/config.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c0cf8e0a96878080b0b4cb5e7a232c5df9019b95","unresolved":false,"context_lines":[{"line_number":480,"context_line":"                default\u003dFalse,"},{"line_number":481,"context_line":"                help\u003d\u0027Enable VNC console. This configuration value should \u0027"},{"line_number":482,"context_line":"                     \u0027be same as nova.conf: vnc.enabled\u0027),"},{"line_number":483,"context_line":"    cfg.StrOpt(\u0027vnc_server_header\u0027,"},{"line_number":484,"context_line":"               default\u003d\u0027WebSockify\u0027,"},{"line_number":485,"context_line":"               help\u003d\u0027Expected VNC server name (WebSockify, nginx, etc) \u0027"},{"line_number":486,"context_line":"                    \u0027in response header.\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_dc29d189","side":"PARENT","line":483,"range":{"start_line":483,"start_character":0,"end_line":483,"end_character":35},"updated":"2019-08-06 01:51:35.000000000","message":"This needs to be deprecated first, and also needs a reno file, like\ntempest/releasenotes/notes/deprecate-config-forbid_global_implied_dsr-e64cfa66e6e3ded5.yaml","commit_id":"464509830a9b8d8774562708b38e739ac70769ad"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"c51a74c0553af79f6736cc057d1b5c0d70224fb3","unresolved":false,"context_lines":[{"line_number":485,"context_line":"               help\u003d\u0027Expected VNC server name (WebSockify, nginx, etc) \u0027"},{"line_number":486,"context_line":"                    \u0027in response header.\u0027,"},{"line_number":487,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":488,"context_line":"               deprecated_reason\u003d\u0027This config option has become obsolete with \u0027"},{"line_number":489,"context_line":"                                 \u0027the usage of different response header \u0027"},{"line_number":490,"context_line":"                                 \u0027fields to accomplish the same goal in \u0027"},{"line_number":491,"context_line":"                                 \u0027accordance with RFC7231 Section 6.2.2.\u0027),"}],"source_content_type":"text/x-python","patch_set":14,"id":"7faddb67_465ad5f1","line":488,"range":{"start_line":488,"start_character":14,"end_line":488,"end_character":79},"updated":"2019-08-07 00:58:20.000000000","message":"line too long reformat","commit_id":"a5d0db81534d1739b93aa45046fa1bd173a0956a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8a568af01729365fa8f7bb9a1a0feeb48e3515b3","unresolved":false,"context_lines":[{"line_number":480,"context_line":"                default\u003dFalse,"},{"line_number":481,"context_line":"                help\u003d\u0027Enable VNC console. This configuration value should \u0027"},{"line_number":482,"context_line":"                     \u0027be same as nova.conf: vnc.enabled\u0027),"},{"line_number":483,"context_line":"    cfg.StrOpt(\u0027vnc_server_header\u0027,"},{"line_number":484,"context_line":"               default\u003d\u0027WebSockify\u0027,"},{"line_number":485,"context_line":"               help\u003d\u0027Expected VNC server name (WebSockify, nginx, etc) \u0027"},{"line_number":486,"context_line":"                    \u0027in response header.\u0027,"},{"line_number":487,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":488,"context_line":"               deprecated_reason\u003d\u0027This option has become obsolete with the \u0027"},{"line_number":489,"context_line":"                                 \u0027usage of different response header fields \u0027"},{"line_number":490,"context_line":"                                 \u0027to accomplish the same goal in accordance \u0027"},{"line_number":491,"context_line":"                                 \u0027with RFC7231 Section 6.2.2.\u0027),"},{"line_number":492,"context_line":"    cfg.BoolOpt(\u0027spice_console\u0027,"},{"line_number":493,"context_line":"                default\u003dFalse,"},{"line_number":494,"context_line":"                help\u003d\u0027Enable Spice console. This configuration value should \u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"7faddb67_b965f946","line":491,"range":{"start_line":483,"start_character":0,"end_line":491,"end_character":64},"updated":"2019-08-21 18:29:10.000000000","message":"Why bother deprecating this? So that it will issue a warning and let people know they should scrub it out of their confs? (I guess that\u0027s a good enough reason.)\n\nPerhaps include \"...and will be ignored\" in the deprecated_reason.","commit_id":"1db2cedc81a4de3906aa998919f0cc8ea7bc2779"}]}