)]}'
{"tempest/api/network/test_extra_dhcp_options.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"27393a5805cb79e39738603e9104751cf1f5c0aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F93Q0%3D","line":1,"updated":"2014-02-03 06:13:46.000000000","message":"better to remove this vim header. we have removed a lot of this line already.","commit_id":"0231b0a8ae2a869b2505df85f8fd3eedc3fdbd6d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"27393a5805cb79e39738603e9104751cf1f5c0aa","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        resp, body \u003d self.client.create_port(self.network[\u0027id\u0027],"},{"line_number":59,"context_line":"                                             extra_dhcp_opts)"},{"line_number":60,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":61,"context_line":"        self.ports.append(body[\u0027port\u0027])"},{"line_number":62,"context_line":"        port_id \u003d body[\u0027port\u0027][\u0027id\u0027]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # Confirm port created has Extra DHCP Options"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F93RE%3D","line":61,"updated":"2014-02-03 06:13:46.000000000","message":"this self.ports is not used at the other place.\nSo better to remove this append().","commit_id":"0231b0a8ae2a869b2505df85f8fd3eedc3fdbd6d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"27393a5805cb79e39738603e9104751cf1f5c0aa","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                    break"},{"line_number":98,"context_line":"            else:"},{"line_number":99,"context_line":"                self.fail(\u0027Extra DHCP option not found in port %s\u0027 %"},{"line_number":100,"context_line":"                          str(retrieved_option))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F93QI%3D","line":100,"updated":"2014-02-03 06:13:46.000000000","message":"Why don\u0027t you add xml tests?\n\nThis patch adds some xml client methods, but this patch seems to not use them.","commit_id":"0231b0a8ae2a869b2505df85f8fd3eedc3fdbd6d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"61887733b6ab845c2842d9cb2024e6a310436168","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                    break"},{"line_number":98,"context_line":"            else:"},{"line_number":99,"context_line":"                self.fail(\u0027Extra DHCP option not found in port %s\u0027 %"},{"line_number":100,"context_line":"                          str(retrieved_option))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F9zws%3D","line":100,"in_reply_to":"AAAAUH%2F909w%3D","updated":"2014-02-03 18:41:13.000000000","message":"Salvatore,\n\nThanks for your review and comments. Yeah, you are correct. The API extension doesn\u0027t work with XML right now. I have a patchset to fix this: https://review.openstack.org/#/c/68544/. The patch for the extra dhcp options extension works fine but I am having some issues with the unit tests in the python 2.6 and python 2.7 gate. My patch for the unit test works but another unit test (neutron.tests.unit.test_provider_configuration) fails when mine is present. It\u0027s a weird error with gettextutils. I am working on it","commit_id":"0231b0a8ae2a869b2505df85f8fd3eedc3fdbd6d"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"a6d106905582fcde6dfc2844fc07801a8d6b8d45","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                    break"},{"line_number":98,"context_line":"            else:"},{"line_number":99,"context_line":"                self.fail(\u0027Extra DHCP option not found in port %s\u0027 %"},{"line_number":100,"context_line":"                          str(retrieved_option))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F909w%3D","line":100,"in_reply_to":"AAAAUH%2F93QI%3D","updated":"2014-02-03 15:37:08.000000000","message":"It seems the extra dhcp opt extension is at the moment not working properly with XML serialization/deserialization in neutron","commit_id":"0231b0a8ae2a869b2505df85f8fd3eedc3fdbd6d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"61887733b6ab845c2842d9cb2024e6a310436168","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                    break"},{"line_number":98,"context_line":"            else:"},{"line_number":99,"context_line":"                self.fail(\u0027Extra DHCP option not found in port %s\u0027 %"},{"line_number":100,"context_line":"                          str(retrieved_option))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F9zxs%3D","line":100,"in_reply_to":"AAAAUH%2F93QI%3D","updated":"2014-02-03 18:41:13.000000000","message":"Ken\u0027ichi Ohmichi\n\nThanks for your review and comments. The extra dhcp options extension api doesn\u0027t work with xml right now. I have a patchset to fix this: https://review.openstack.org/#/c/68544/. The patch for the extra dhcp options extension works fine but I am having some issues with the unit tests","commit_id":"0231b0a8ae2a869b2505df85f8fd3eedc3fdbd6d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e9743dfdd61625c63caf47270141140435d7d919","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                    break"},{"line_number":98,"context_line":"            else:"},{"line_number":99,"context_line":"                self.fail(\u0027Extra DHCP option not found in port %s\u0027 %"},{"line_number":100,"context_line":"                          str(retrieved_option))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F9yDU%3D","line":100,"in_reply_to":"AAAAUH%2F9zxs%3D","updated":"2014-02-04 00:54:24.000000000","message":"@minsel\n\nThanks for your explanation, I got it.\nNow it is good for me if the other parts are fixed.","commit_id":"0231b0a8ae2a869b2505df85f8fd3eedc3fdbd6d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"41f0f0da22aba2f14c1a08d595e90b8c1020e7b1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def setUpClass(cls):"},{"line_number":40,"context_line":"        super(ExtraDHCPOptionsTestJSON, cls).setUpClass()"},{"line_number":41,"context_line":"        if not test.is_extension_enabled(\u0027lbaas\u0027, \u0027network\u0027):"},{"line_number":42,"context_line":"            msg \u003d \"Extra DHCP Options extension not enabled.\""},{"line_number":43,"context_line":"            raise cls.skipException(msg)"},{"line_number":44,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":45,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FR2w%3D","line":42,"updated":"2014-02-14 09:17:49.000000000","message":"Sorry for my late review.\n\nI saw neutron code, but I could not confirm extra dhcp should depend on lbaas extension.\nCould you explain that?","commit_id":"691567830fdfe829abd70a987a3b8a313e4115b6"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"daeb8932ccb158fc3eba7813f8c61184d4528629","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def setUpClass(cls):"},{"line_number":40,"context_line":"        super(ExtraDHCPOptionsTestJSON, cls).setUpClass()"},{"line_number":41,"context_line":"        if not test.is_extension_enabled(\u0027lbaas\u0027, \u0027network\u0027):"},{"line_number":42,"context_line":"            msg \u003d \"Extra DHCP Options extension not enabled.\""},{"line_number":43,"context_line":"            raise cls.skipException(msg)"},{"line_number":44,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":45,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FHfw%3D","line":42,"in_reply_to":"AAAAUX%2F%2FR2w%3D","updated":"2014-02-17 01:30:13.000000000","message":"@Ken\u0027ichi Ohmichi\n\nGood catch!!!!! Thanks you for your review. This was an error. Fixed in next patchset","commit_id":"691567830fdfe829abd70a987a3b8a313e4115b6"}]}