)]}'
{"tempest/api/identity/admin/v3/test_projects.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c065285d24d686a83fb6de4f323a8bebfac0a026","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        _projects \u003d self.projects_client.list_projects()[\u0027projects\u0027]"},{"line_number":232,"context_line":"        project_list \u003d next(x for x in _projects if x[\u0027id\u0027] \u003d\u003d project[\u0027id\u0027])"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        # Assert the list of fields is correct (one is enough to check here)"},{"line_number":235,"context_line":"        self.assertSetEqual(set(fields), set(project_get.keys()))"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # Ensure the set of tags is identical and match the expected one"},{"line_number":238,"context_line":"        get_tags \u003d set(project_get.pop(\"tags\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_16d80f1c","line":235,"range":{"start_line":234,"start_character":0,"end_line":235,"end_character":65},"updated":"2019-08-29 17:20:35.000000000","message":"Why don\u0027t you change here for additional properties instead of skipping the test?\nMy concern here is the skip makes the test coverage less and it stops blocking patches which can remove the existing properties.","commit_id":"b22bc7caabb72ef25d313fa374b971f488f7fdda"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"bb38d07a8ece6eb3c6d8c4ef93b08e5609b5be69","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        _projects \u003d self.projects_client.list_projects()[\u0027projects\u0027]"},{"line_number":232,"context_line":"        project_list \u003d next(x for x in _projects if x[\u0027id\u0027] \u003d\u003d project[\u0027id\u0027])"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        # Assert the list of fields is correct (one is enough to check here)"},{"line_number":235,"context_line":"        self.assertSetEqual(set(fields), set(project_get.keys()))"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # Ensure the set of tags is identical and match the expected one"},{"line_number":238,"context_line":"        get_tags \u003d set(project_get.pop(\"tags\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_dee117d1","line":235,"range":{"start_line":234,"start_character":0,"end_line":235,"end_character":65},"in_reply_to":"7faddb67_16d80f1c","updated":"2019-08-30 21:10:32.000000000","message":"This is somewhat of a chicken and egg issue. \n\nI\u0027ll go ahead and modify this test to require at minimum the current fields and not fail in the case of additional fields. for correctness i\u0027ll still updated the expected fields when the new code lands but maintain that we require the values in keys within the \"fields\" but allow more fields in the future with the subsequent patch.\n\nthanks!","commit_id":"b22bc7caabb72ef25d313fa374b971f488f7fdda"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"cd7a543c6aa708dd9066c3d28ff037053643f112","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        self.assertEqual(u_email, new_user_get[\u0027email\u0027])"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    @decorators.idempotent_id(\u0027d1db68b6-aebe-4fa0-b79d-d724d2e21162\u0027)"},{"line_number":217,"context_line":"    @decorators.skip_because(bug\u003d\u00271807751\u0027)"},{"line_number":218,"context_line":"    def test_project_get_equals_list(self):"},{"line_number":219,"context_line":"        fields \u003d [\u0027parent_id\u0027, \u0027is_domain\u0027, \u0027description\u0027, \u0027links\u0027,"},{"line_number":220,"context_line":"                  \u0027name\u0027, \u0027enabled\u0027, \u0027domain_id\u0027, \u0027id\u0027, \u0027tags\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_1eefaf87","line":217,"range":{"start_line":217,"start_character":0,"end_line":217,"end_character":43},"updated":"2019-08-30 21:27:04.000000000","message":"Needs fix.","commit_id":"9eeb63b947b889da375861c22c82ea4c871f1d1d"}]}