)]}'
{"tempest/api/compute/images/test_images_oneserver.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"65380a92897ea3640fb60c7d94e57c41a8c76457","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        # will return 400(Bad Request) if we attempt to send a name which has"},{"line_number":101,"context_line":"        # 4 byte utf-8 character."},{"line_number":102,"context_line":"        utf8_name \u003d data_utils.rand_name(b\u0027\\xe2\\x82\\xa1\u0027.decode(\u0027utf-8\u0027))"},{"line_number":103,"context_line":"        self.create_image_from_server(self.server_id, name\u003dutf8_name,"},{"line_number":104,"context_line":"                                      wait_until\u003d\u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_ba34aead","line":104,"range":{"start_line":103,"start_character":8,"end_line":104,"end_character":58},"updated":"2019-08-27 14:53:42.000000000","message":"Yes, looks good. The name is popped out of kwargs but is still passed in via `name\u003dname` to the service client method: https://github.com/openstack/tempest/blob/e467c3c9f255408fd7ec50972a733acac6420420/tempest/api/compute/base.py#L323\n\nHowever, is wait_until\u003d\u0027ACTIVE\u0027 necessary given that the test does not currently have wait logic?","commit_id":"6be496b5afd686a37730391f6312c85460c5f7e4"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0f35586de7836fe0eb4afe92798d067868592901","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        # will return 400(Bad Request) if we attempt to send a name which has"},{"line_number":101,"context_line":"        # 4 byte utf-8 character."},{"line_number":102,"context_line":"        utf8_name \u003d data_utils.rand_name(b\u0027\\xe2\\x82\\xa1\u0027.decode(\u0027utf-8\u0027))"},{"line_number":103,"context_line":"        self.create_image_from_server(self.server_id, name\u003dutf8_name,"},{"line_number":104,"context_line":"                                      wait_until\u003d\u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_e62605cc","line":104,"range":{"start_line":103,"start_character":8,"end_line":104,"end_character":58},"in_reply_to":"7faddb67_ba34aead","updated":"2019-08-28 00:35:32.000000000","message":"Thanks.\nFirst, I think waiting for server active can be a more thorough check.\nSecond, waiting for server active can avoid the potential risk of \"Cannot \u0027delete\u0027 instance while it is in task_state image_snapshot\"","commit_id":"6be496b5afd686a37730391f6312c85460c5f7e4"}]}