)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"fa253d7c1083eb6e1c7358e14942a51be04bc58b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Bug https://bugs.launchpad.net/tempest/+bug/1839794"},{"line_number":10,"context_line":"found out that the volume version_show client that"},{"line_number":11,"context_line":"was not used had a defect when builing the URL."},{"line_number":12,"context_line":"Used the same direction that the compute client did"},{"line_number":13,"context_line":"to strip off the version and project info and add back"},{"line_number":14,"context_line":"the version. Also added a Volume v3 test using the"},{"line_number":15,"context_line":"client"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I9be99f5fc0eab3de125ce69415a0be65b1c4ad0d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5faad753_126391de","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":11},"updated":"2019-09-09 02:51:12.000000000","message":"Is this currently the case? I just see code for using a raw_request, nothing related to this.","commit_id":"bc916477607671a6ab557c02c0bbc01ee71a5d8c"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"1e99c59090f096250c75783c32c465a207a095c9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Bug https://bugs.launchpad.net/tempest/+bug/1839794"},{"line_number":10,"context_line":"found out that the volume version_show client that"},{"line_number":11,"context_line":"was not used had a defect when builing the URL."},{"line_number":12,"context_line":"Used the same direction that the compute client did"},{"line_number":13,"context_line":"to strip off the version and project info and add back"},{"line_number":14,"context_line":"the version. Also added a Volume v3 test using the"},{"line_number":15,"context_line":"client"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I9be99f5fc0eab3de125ce69415a0be65b1c4ad0d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5faad753_45484bcb","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":11},"in_reply_to":"5faad753_126391de","updated":"2019-09-10 01:53:34.000000000","message":"Added link to example","commit_id":"bc916477607671a6ab557c02c0bbc01ee71a5d8c"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"c8d2e2771a8bc1c1f4654db6a0ab275b7251e0b9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Bug https://bugs.launchpad.net/tempest/+bug/1839794"},{"line_number":10,"context_line":"found out that the volume version_show client that"},{"line_number":11,"context_line":"was not used had a defect when builing the URL."},{"line_number":12,"context_line":"Used the same direction that the compute client did"},{"line_number":13,"context_line":"to strip off the version and project info and add back"},{"line_number":14,"context_line":"the version. Also added a Volume v3 test using the"},{"line_number":15,"context_line":"client"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I9be99f5fc0eab3de125ce69415a0be65b1c4ad0d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5faad753_f293554e","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":11},"in_reply_to":"5faad753_126391de","updated":"2019-09-09 03:53:03.000000000","message":"Yes the compute version client used the same direction here is the link https://github.com/openstack/tempest/blob/master/tempest/lib/services/compute/versions_client.py#L40","commit_id":"bc916477607671a6ab557c02c0bbc01ee71a5d8c"}],"tempest/api/volume/test_versions.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"fa253d7c1083eb6e1c7358e14942a51be04bc58b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        self.versions_client.list_versions()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @decorators.idempotent_id(\u00277f755ae2-caa9-4049-988c-331d8f7a579f\u0027)"},{"line_number":32,"context_line":"    def test_show_version(self):"},{"line_number":33,"context_line":"        # NOTE: The version data is checked on service client side"},{"line_number":34,"context_line":"        # with JSON-Schema validation. It is enough to just call"},{"line_number":35,"context_line":"        # the API here."}],"source_content_type":"text/x-python","patch_set":7,"id":"5faad753_526909bc","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":32},"updated":"2019-09-09 02:51:12.000000000","message":"A feature flag should be used here via testtools.skipUnless(CONF.volume.catalog_type \u003d\u003d \u0027volumev3\u0027):\n\nhttps://opendev.org/openstack/tempest/src/branch/master/tempest/config.py#L848\n\nTo avoid this throwing an error in the case where v3 isn\u0027t present in the cloud.","commit_id":"bc916477607671a6ab557c02c0bbc01ee71a5d8c"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"c8d2e2771a8bc1c1f4654db6a0ab275b7251e0b9","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        self.versions_client.list_versions()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @decorators.idempotent_id(\u00277f755ae2-caa9-4049-988c-331d8f7a579f\u0027)"},{"line_number":32,"context_line":"    def test_show_version(self):"},{"line_number":33,"context_line":"        # NOTE: The version data is checked on service client side"},{"line_number":34,"context_line":"        # with JSON-Schema validation. It is enough to just call"},{"line_number":35,"context_line":"        # the API here."}],"source_content_type":"text/x-python","patch_set":7,"id":"5faad753_d2dc191a","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":32},"in_reply_to":"5faad753_526909bc","updated":"2019-09-09 03:53:03.000000000","message":"Good idea I will create skip check and a version 2 test also per existing confs\nhttps://github.com/openstack/tempest/blob/master/tempest/config.py#L937","commit_id":"bc916477607671a6ab557c02c0bbc01ee71a5d8c"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"1e99c59090f096250c75783c32c465a207a095c9","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        self.versions_client.list_versions()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @decorators.idempotent_id(\u00277f755ae2-caa9-4049-988c-331d8f7a579f\u0027)"},{"line_number":32,"context_line":"    def test_show_version(self):"},{"line_number":33,"context_line":"        # NOTE: The version data is checked on service client side"},{"line_number":34,"context_line":"        # with JSON-Schema validation. It is enough to just call"},{"line_number":35,"context_line":"        # the API here."}],"source_content_type":"text/x-python","patch_set":7,"id":"5faad753_853e4327","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":32},"in_reply_to":"5faad753_526909bc","updated":"2019-09-10 01:53:34.000000000","message":"I decided to loop through versions and test each so it should work in the future versions.  Hope you agree.","commit_id":"bc916477607671a6ab557c02c0bbc01ee71a5d8c"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"a699039ce699daf69c7b4457b0d71d4d8254a378","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # NOTE: The version data is checked on service client side"},{"line_number":34,"context_line":"        # with JSON-Schema validation. It is enough to just call"},{"line_number":35,"context_line":"        # the API here."},{"line_number":36,"context_line":"        self.versions_client.show_version(\u0027v3\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5faad753_52c5898d","line":36,"updated":"2019-09-09 02:59:37.000000000","message":"Can we check the response version string here just in case? It should start with \u00273.\u0027?","commit_id":"bc916477607671a6ab557c02c0bbc01ee71a5d8c"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"1e99c59090f096250c75783c32c465a207a095c9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # NOTE: The version data is checked on service client side"},{"line_number":34,"context_line":"        # with JSON-Schema validation. It is enough to just call"},{"line_number":35,"context_line":"        # the API here."},{"line_number":36,"context_line":"        self.versions_client.show_version(\u0027v3\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5faad753_a53b3f36","line":36,"in_reply_to":"5faad753_52c5898d","updated":"2019-09-10 01:53:34.000000000","message":"Done","commit_id":"bc916477607671a6ab557c02c0bbc01ee71a5d8c"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"c8d2e2771a8bc1c1f4654db6a0ab275b7251e0b9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # NOTE: The version data is checked on service client side"},{"line_number":34,"context_line":"        # with JSON-Schema validation. It is enough to just call"},{"line_number":35,"context_line":"        # the API here."},{"line_number":36,"context_line":"        self.versions_client.show_version(\u0027v3\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5faad753_f2e115d2","line":36,"in_reply_to":"5faad753_52c5898d","updated":"2019-09-09 03:53:03.000000000","message":"Will do for this for v3 and the new v2 test I will add","commit_id":"bc916477607671a6ab557c02c0bbc01ee71a5d8c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"944283208d1e56cb81d89f31354ee5998a601419","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        versions \u003d self.versions_client.list_versions()[\u0027versions\u0027]"},{"line_number":37,"context_line":"        for version_dict in versions:"},{"line_number":38,"context_line":"            version \u003d version_dict[\u0027id\u0027]"},{"line_number":39,"context_line":"            major_version \u003d version.split(\u0027.\u0027)[0]"},{"line_number":40,"context_line":"            response \u003d self.versions_client.show_version(major_version)"},{"line_number":41,"context_line":"            self.assertEqual(version, response[\u0027versions\u0027][0][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"5faad753_8f772b3b","line":39,"updated":"2019-09-10 17:45:59.000000000","message":"I checked the tempest log of this change as https://c5b2fc683a7e0ca6504c-ee3f0a1068b44b14292a9ecbc1a53c42.ssl.cf1.rackcdn.com/680790/9/check/tempest-full/556ec2c/controller/logs/tempest_log.txt.gz\n\nThe above list_versions() log is output, but the show_version\u0027s ones are just\n\n 2019-09-10 02:58:37.006 12918 INFO urllib3.poolmanager [-] Redirecting https://10.4.70.86/volume/v2 -\u003e https://10.4.70.86/volume/v2/\n 2019-09-10 02:58:37.042 12918 INFO urllib3.poolmanager [-] Redirecting https://10.4.70.86/volume/v3 -\u003e https://10.4.70.86/volume/v3/\n\nwithout the API details.\nIn addition, the official API doc says the URL contains \"/\" at the end as https://docs.openstack.org/api-ref/block-storage/v3/index.html#api-version-details\n\nSo could you add \"/\" as \"https://.../volume/v3/\" here?","commit_id":"5a3c059a112be2d59e8172751fc295e6ad3a5c5a"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"ebfbaccfcc52dafbe57a839ddc77a5c6303e1cf4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        versions \u003d self.versions_client.list_versions()[\u0027versions\u0027]"},{"line_number":37,"context_line":"        for version_dict in versions:"},{"line_number":38,"context_line":"            version \u003d version_dict[\u0027id\u0027]"},{"line_number":39,"context_line":"            major_version \u003d version.split(\u0027.\u0027)[0]"},{"line_number":40,"context_line":"            response \u003d self.versions_client.show_version(major_version)"},{"line_number":41,"context_line":"            self.assertEqual(version, response[\u0027versions\u0027][0][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"5faad753_e2257aac","line":39,"in_reply_to":"5faad753_8f772b3b","updated":"2019-09-11 17:55:30.000000000","message":"Done","commit_id":"5a3c059a112be2d59e8172751fc295e6ad3a5c5a"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"247be78894d686386b7cc51ca60f9265af74ff32","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        for version_dict in versions:"},{"line_number":38,"context_line":"            version \u003d version_dict[\u0027id\u0027]"},{"line_number":39,"context_line":"            major_version \u003d version.split(\u0027.\u0027)[0]"},{"line_number":40,"context_line":"            response \u003d self.versions_client.show_version(major_version + \u0027/\u0027)"},{"line_number":41,"context_line":"            self.assertEqual(version, response[\u0027versions\u0027][0][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_142dae42","line":40,"updated":"2019-09-19 01:19:42.000000000","message":"well, I feel it might be good to move \"+ \u0027/\u0027\" to show_version()? I think show_version() should take care of that.","commit_id":"36e0a5ff7ffd4abbfcfba2131940ec1e3fe2bde4"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"bccab86c6976326c8eb6841eea5f091ec7b4c01a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        for version_dict in versions:"},{"line_number":38,"context_line":"            version \u003d version_dict[\u0027id\u0027]"},{"line_number":39,"context_line":"            major_version \u003d version.split(\u0027.\u0027)[0]"},{"line_number":40,"context_line":"            response \u003d self.versions_client.show_version(major_version + \u0027/\u0027)"},{"line_number":41,"context_line":"            self.assertEqual(version, response[\u0027versions\u0027][0][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_5f931350","line":40,"in_reply_to":"3fa7e38b_142dae42","updated":"2019-09-21 01:32:10.000000000","message":"Done","commit_id":"36e0a5ff7ffd4abbfcfba2131940ec1e3fe2bde4"}],"tempest/lib/services/volume/v3/versions_client.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"247be78894d686386b7cc51ca60f9265af74ff32","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        https://docs.openstack.org/api-ref/block-storage/v3/#show-api-v3-details"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        version_url \u003d os.path.join(self._get_base_version_url(), version)"},{"line_number":62,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027,"},{"line_number":63,"context_line":"                                      {\u0027X-Auth-Token\u0027: self.token})"},{"line_number":64,"context_line":"        self._error_checker(resp, body)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_b4213a50","line":61,"updated":"2019-09-19 01:19:42.000000000","message":"I think this is not good technically if we use tempest on a Windows box. But I think we don\u0027t support Windows for tempest running so far. So, I think it\u0027s OK now. We should use urlparse/urllib/six urljoin() instead of os.path.join().\nI think the fix should be in a different patch, though.","commit_id":"36e0a5ff7ffd4abbfcfba2131940ec1e3fe2bde4"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"bccab86c6976326c8eb6841eea5f091ec7b4c01a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        https://docs.openstack.org/api-ref/block-storage/v3/#show-api-v3-details"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        version_url \u003d os.path.join(self._get_base_version_url(), version)"},{"line_number":62,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027,"},{"line_number":63,"context_line":"                                      {\u0027X-Auth-Token\u0027: self.token})"},{"line_number":64,"context_line":"        self._error_checker(resp, body)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_ff999f6d","line":61,"in_reply_to":"3fa7e38b_b4213a50","updated":"2019-09-21 01:32:10.000000000","message":"Done","commit_id":"36e0a5ff7ffd4abbfcfba2131940ec1e3fe2bde4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8e04fc1b2d2b50a488e80042b577d50712afd475","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        https://docs.openstack.org/api-ref/block-storage/v3/#show-api-v3-details"},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        version_url \u003d urljoin(self._get_base_version_url(), version + \u0027/\u0027)"},{"line_number":63,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027,"},{"line_number":64,"context_line":"                                      {\u0027X-Auth-Token\u0027: self.token})"},{"line_number":65,"context_line":"        self._error_checker(resp, body)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_e646f37c","line":62,"range":{"start_line":62,"start_character":70,"end_line":62,"end_character":73},"updated":"2019-09-22 18:08:17.000000000","message":"nit: I doubt this is really needed, but you can also likely add it as urljoin(self._get_base_version_url(), version, \u0027/\u0027)","commit_id":"152f1054b5ed98dafe1333deba6b14a08d7ec03f"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b126d534e55449fb9ca28b7fb8186a0b12305cc2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        https://docs.openstack.org/api-ref/block-storage/v3/#show-api-v3-details"},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        version_url \u003d urljoin(self._get_base_version_url(), version + \u0027/\u0027)"},{"line_number":63,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027,"},{"line_number":64,"context_line":"                                      {\u0027X-Auth-Token\u0027: self.token})"},{"line_number":65,"context_line":"        self._error_checker(resp, body)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_0335288f","line":62,"updated":"2019-09-24 06:04:37.000000000","message":"yeah, I agree. But this shouldn\u0027t be so harmful and, I think we can update it with a following patch if we\u0027d like to.","commit_id":"152f1054b5ed98dafe1333deba6b14a08d7ec03f"}],"tempest/tests/lib/services/volume/v3/test_versions_client.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"fa253d7c1083eb6e1c7358e14942a51be04bc58b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                                \u0027volume\u0027,"},{"line_number":104,"context_line":"                                                \u0027regionOne\u0027)"},{"line_number":105,"context_line":"        self.assertEqual(expected_base_url,"},{"line_number":106,"context_line":"                         client._get_base_version_url())"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def _test_list_versions(self, bytes_body\u003dFalse):"},{"line_number":109,"context_line":"        self.check_service_client_function("}],"source_content_type":"text/x-python","patch_set":7,"id":"5faad753_3247ad4e","line":106,"range":{"start_line":106,"start_character":32,"end_line":106,"end_character":53},"updated":"2019-09-09 02:51:12.000000000","message":"This is implemented in the rest_client itself (https://opendev.org/openstack/tempest/src/branch/master/tempest/lib/common/rest_client.py#L941), so if there\u0027s no existing coverage for this method within the rest client test module itself then this should be moved there instead.","commit_id":"bc916477607671a6ab557c02c0bbc01ee71a5d8c"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"c8d2e2771a8bc1c1f4654db6a0ab275b7251e0b9","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                                \u0027volume\u0027,"},{"line_number":104,"context_line":"                                                \u0027regionOne\u0027)"},{"line_number":105,"context_line":"        self.assertEqual(expected_base_url,"},{"line_number":106,"context_line":"                         client._get_base_version_url())"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def _test_list_versions(self, bytes_body\u003dFalse):"},{"line_number":109,"context_line":"        self.check_service_client_function("}],"source_content_type":"text/x-python","patch_set":7,"id":"5faad753_d2b739d8","line":106,"range":{"start_line":106,"start_character":32,"end_line":106,"end_character":53},"in_reply_to":"5faad753_3247ad4e","updated":"2019-09-09 03:53:03.000000000","message":"This method is in support of the test case method and uses the pattern in the existing compute test \nhttps://github.com/openstack/tempest/blob/master/tempest/tests/lib/services/compute/test_versions_client.py#L99\nI am not sure what you are asking here.  Do you want another test on the rest_client also???","commit_id":"bc916477607671a6ab557c02c0bbc01ee71a5d8c"}]}