)]}'
{"tempest/config.py":[{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"5a465c9e76a8e59d16b2ac6c61a1812895779979","unresolved":false,"context_lines":[{"line_number":809,"context_line":"               help\u003d\"User name used to authenticate to an instance.\"),"},{"line_number":810,"context_line":"    cfg.StrOpt(\u0027image_alt_ssh_user\u0027,"},{"line_number":811,"context_line":"               default\u003d\"root\","},{"line_number":812,"context_line":"               help\u003d\"User name used to authenticate to an alt instance.\"),"},{"line_number":813,"context_line":"    cfg.StrOpt(\u0027image_ssh_password\u0027,"},{"line_number":814,"context_line":"               default\u003d\"password\","},{"line_number":815,"context_line":"               help\u003d\"Password used to authenticate to an instance.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_4079c4f8","line":812,"updated":"2020-02-10 10:06:07.000000000","message":"Do add a new config option requires a release note?","commit_id":"99f5ebab46cd2f7bb07243579385e9e059eb41f6"},{"author":{"_account_id":30996,"name":"Weronika Sikora","email":"weronika.sikora@ovhcloud.com","username":"weronika.sikora"},"change_message_id":"a101b065b7cd58f89432da2b455adb5e905aaff8","unresolved":false,"context_lines":[{"line_number":809,"context_line":"               help\u003d\"User name used to authenticate to an instance.\"),"},{"line_number":810,"context_line":"    cfg.StrOpt(\u0027image_alt_ssh_user\u0027,"},{"line_number":811,"context_line":"               default\u003d\"root\","},{"line_number":812,"context_line":"               help\u003d\"User name used to authenticate to an alt instance.\"),"},{"line_number":813,"context_line":"    cfg.StrOpt(\u0027image_ssh_password\u0027,"},{"line_number":814,"context_line":"               default\u003d\"password\","},{"line_number":815,"context_line":"               help\u003d\"Password used to authenticate to an instance.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_06af612d","line":812,"in_reply_to":"3fa7e38b_4079c4f8","updated":"2020-02-10 14:12:44.000000000","message":"You\u0027re right, I forgot about that. Please let me know if I created the release notes correctly and if I should change anything.","commit_id":"99f5ebab46cd2f7bb07243579385e9e059eb41f6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d5e4a9a2c050bc49a699bcdf3a08c451418532f1","unresolved":false,"context_lines":[{"line_number":810,"context_line":"    cfg.StrOpt(\u0027image_alt_ssh_user\u0027,"},{"line_number":811,"context_line":"               default\u003d\"root\","},{"line_number":812,"context_line":"               help\u003d\"User name used to authenticate to an alt instance.\"),"},{"line_number":813,"context_line":"    cfg.StrOpt(\u0027image_ssh_password\u0027,"},{"line_number":814,"context_line":"               default\u003d\"password\","},{"line_number":815,"context_line":"               help\u003d\"Password used to authenticate to an instance.\"),"},{"line_number":816,"context_line":"    cfg.StrOpt(\u0027ssh_shell_prologue\u0027,"},{"line_number":817,"context_line":"               default\u003d\"set -eu -o pipefail; PATH\u003d$$PATH:/sbin:/usr/sbin;\","},{"line_number":818,"context_line":"               help\u003d\"Shell fragments to use before executing a command \""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_22509e0a","line":815,"range":{"start_line":813,"start_character":0,"end_line":815,"end_character":69},"updated":"2020-11-03 17:37:16.000000000","message":"we need to add password config also for alt img","commit_id":"00fedadd8fdf58c5b9b4c85a063bb3492918f14c"},{"author":{"_account_id":30996,"name":"Weronika Sikora","email":"weronika.sikora@ovhcloud.com","username":"weronika.sikora"},"change_message_id":"976028f00eb50b7b6a1ce6386f821c51253a7143","unresolved":false,"context_lines":[{"line_number":810,"context_line":"    cfg.StrOpt(\u0027image_alt_ssh_user\u0027,"},{"line_number":811,"context_line":"               default\u003d\"root\","},{"line_number":812,"context_line":"               help\u003d\"User name used to authenticate to an alt instance.\"),"},{"line_number":813,"context_line":"    cfg.StrOpt(\u0027image_ssh_password\u0027,"},{"line_number":814,"context_line":"               default\u003d\"password\","},{"line_number":815,"context_line":"               help\u003d\"Password used to authenticate to an instance.\"),"},{"line_number":816,"context_line":"    cfg.StrOpt(\u0027ssh_shell_prologue\u0027,"},{"line_number":817,"context_line":"               default\u003d\"set -eu -o pipefail; PATH\u003d$$PATH:/sbin:/usr/sbin;\","},{"line_number":818,"context_line":"               help\u003d\"Shell fragments to use before executing a command \""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_ee6e8393","line":815,"range":{"start_line":813,"start_character":0,"end_line":815,"end_character":69},"in_reply_to":"1f621f24_22509e0a","updated":"2020-11-04 15:06:44.000000000","message":"Sure thing. Done.\nI didn\u0027t catch any test that would use this variable, though, so I didn\u0027t add it anywhere besides the base class for compute tests. Please tell me if I missed something.","commit_id":"00fedadd8fdf58c5b9b4c85a063bb3492918f14c"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"7da8ed3cedeb270da734a178eb4e4171ff2e8aab","unresolved":false,"context_lines":[{"line_number":866,"context_line":"               default\u003d\"root\","},{"line_number":867,"context_line":"               help\u003d\"User name used to authenticate to an instance.\"),"},{"line_number":868,"context_line":"    cfg.StrOpt(\u0027image_alt_ssh_user\u0027,"},{"line_number":869,"context_line":"               default\u003d\"root\","},{"line_number":870,"context_line":"               help\u003d\"User name used to authenticate to an alt instance.\"),"},{"line_number":871,"context_line":"    cfg.StrOpt(\u0027image_ssh_password\u0027,"},{"line_number":872,"context_line":"               default\u003d\"password\","}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_b7f4d287","line":869,"updated":"2020-11-05 12:38:02.000000000","message":"I wonder will it cause issue for users why used to configure only the ssh_user, we might want to default to the same as image_ssh_user.\n\nAt least devstack should set this now arg in lib/tempest .","commit_id":"c54a911004011e20494cd132c2577496c9401a15"},{"author":{"_account_id":30996,"name":"Weronika Sikora","email":"weronika.sikora@ovhcloud.com","username":"weronika.sikora"},"change_message_id":"843b426a7974d4442dbe6c1f7e64dbe480c6dc94","unresolved":false,"context_lines":[{"line_number":866,"context_line":"               default\u003d\"root\","},{"line_number":867,"context_line":"               help\u003d\"User name used to authenticate to an instance.\"),"},{"line_number":868,"context_line":"    cfg.StrOpt(\u0027image_alt_ssh_user\u0027,"},{"line_number":869,"context_line":"               default\u003d\"root\","},{"line_number":870,"context_line":"               help\u003d\"User name used to authenticate to an alt instance.\"),"},{"line_number":871,"context_line":"    cfg.StrOpt(\u0027image_ssh_password\u0027,"},{"line_number":872,"context_line":"               default\u003d\"password\","}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_3a7f0768","line":869,"in_reply_to":"1f621f24_b7f4d287","updated":"2020-11-05 13:13:55.000000000","message":"I thought so too, so I\u0027m setting it in lib/tempest to \"cirros\", like for the image_ssh_user:\nhttps://review.opendev.org/#/c/682902/4/lib/tempest\n\nIt might prove to be an issue if the user is using a non-cirros image for testing and configured only image_ssh_user - atm the image_alt_ssh_user will be set to \"cirros\" by Devstack, regardless of the image used, in the same way as image_ssh_user is being set. That would mean the user has to configure the second variable as well.\n\nI can keep the image_ssh_user hardcoded to cirros (so leave it unchanged), but set the image_alt_ssh_user to the image_ssh_user value to prevent this from happening.\n\nSo instead of:\niniset $TEMPEST_CONFIG validation image_ssh_user ${DEFAULT_INSTANCE_USER:-cirros}\niniset $TEMPEST_CONFIG validation image_alt_ssh_user ${DEFAULT_INSTANCE_ALT_USER:-cirros}\n\ndo it like this:\niniset $TEMPEST_CONFIG validation image_ssh_user ${DEFAULT_INSTANCE_USER:-cirros}\niniset $TEMPEST_CONFIG validation image_alt_ssh_user ${DEFAULT_INSTANCE_ALT_USER:-$DEFAULT_INSTANCE_USER}\n\nIs that what you had in mind?","commit_id":"c54a911004011e20494cd132c2577496c9401a15"}]}