)]}'
{"tempest/api/network/admin/test_dhcp_agent_scheduler.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"66956e7c70d0a0db766c75682d69c9bcec228d73","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        if self._check_network_in_dhcp_agent(network_id, agent):"},{"line_number":72,"context_line":"            self._remove_network_from_dhcp_agent(network_id, agent)"},{"line_number":73,"context_line":"            self._add_dhcp_agent_to_network(network_id, agent)"},{"line_number":74,"context_line":"        else:"},{"line_number":75,"context_line":"            self._add_dhcp_agent_to_network(network_id, agent)"},{"line_number":76,"context_line":"            self._remove_network_from_dhcp_agent(network_id, agent)"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FDZg%3D","line":74,"updated":"2014-02-17 12:35:31.000000000","message":"I hope neutron will not have the idea to add an agent to the network at the same time.","commit_id":"484f457cb8b4c0e150ae1e394938abed4926680e"},{"author":{"_account_id":6455,"name":"Harika Vakadi","email":"harika_vakadi@persistent.co.in","username":"harika-vakadi"},"change_message_id":"0ca1420e0fcc6c71f0553e7e7daa0125d026a1c7","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        if self._check_network_in_dhcp_agent(network_id, agent):"},{"line_number":72,"context_line":"            self._remove_network_from_dhcp_agent(network_id, agent)"},{"line_number":73,"context_line":"            self._add_dhcp_agent_to_network(network_id, agent)"},{"line_number":74,"context_line":"        else:"},{"line_number":75,"context_line":"            self._add_dhcp_agent_to_network(network_id, agent)"},{"line_number":76,"context_line":"            self._remove_network_from_dhcp_agent(network_id, agent)"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B6Ss%3D","line":74,"in_reply_to":"AAAAUX%2F%2FDZg%3D","updated":"2014-02-18 08:59:36.000000000","message":"Hi Afazekas,\n\nDo you mean to say that agent would be added to network while creating network using neutron?\n\nCan you please elaborate the question?\n\nRegards,\nHarika","commit_id":"484f457cb8b4c0e150ae1e394938abed4926680e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"ba74eb10de557c9472c74267edf32928b7fa2f7e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                break"},{"line_number":69,"context_line":"        else:"},{"line_number":70,"context_line":"            msg \u003d \"DHCP Agent not found\""},{"line_number":71,"context_line":"            raise self.skipException(msg)"},{"line_number":72,"context_line":"        network \u003d self.create_network()"},{"line_number":73,"context_line":"        network_id \u003d network[\u0027id\u0027]"},{"line_number":74,"context_line":"        if self._check_network_in_dhcp_agent(network_id, agent):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2FrbQ%3D","line":71,"updated":"2014-03-04 18:05:53.000000000","message":"I don\u0027t think we should skip here without a config option for this. If a valid neutron configuration is running without a dhcp agent then we should have config flag (probably in network-feature-enabled) for the dhcp agent.  It\u0027s better to be explicit and specify whether we expect a dhcp agent or not upfront and skip based on that instead. If a dhcp agent is expected and one isn\u0027t found then we should fail.","commit_id":"981c4c237d294086d91034fd2701c8258e97589b"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"8530b7a024ea586a28f160189b655dd4b6a7505b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            agent_id\u003dagent[\u0027id\u0027],"},{"line_number":86,"context_line":"            network_id\u003dnetwork_id)"},{"line_number":87,"context_line":"        self.assertEqual(resp[\u0027status\u0027], \u0027204\u0027)"},{"line_number":88,"context_line":"        self.assertFalse(self._check_network_in_dhcp_agent("},{"line_number":89,"context_line":"            network_id, agent))"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _add_dhcp_agent_to_network(self, network_id, agent):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F%2FeTY%3D","line":88,"updated":"2014-03-17 17:37:39.000000000","message":"It is similar assertion what cases issue with the l3 agent.","commit_id":"7adf9f88e05d91fac998f0826cd65c1165ade854"}]}