)]}'
{"tempest/api/network/admin/test_l3_agent_scheduler.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d996950d07f377070dde7f2e766935669654432a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":46,"context_line":"        for a in agents:"},{"line_number":47,"context_line":"            if a[\u0027agent_type\u0027] \u003d\u003d \u0027L3 agent\u0027:"},{"line_number":48,"context_line":"                cls.agent \u003d a"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":51,"context_line":"    def test_list_routers_on_l3_agent(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BbPI%3D","line":48,"updated":"2014-01-27 00:56:39.000000000","message":"I think we need to handle the possibility of not finding the L3 agent. To do this:\n\n1) I would add a break statement to the if, after cls.agent \u003d a\n2) I would add a an else statement to the for loop of line 46. In this else statement block I would include the following statements:\n\nmsg \u003d \"L3 Agent not found\"\nraise cls.skipException(msg)","commit_id":"a4aef1f4f94962cb446516177c8c4f0af7001092"},{"author":{"_account_id":6455,"name":"Harika Vakadi","email":"harika_vakadi@persistent.co.in","username":"harika-vakadi"},"change_message_id":"13d5871cf8cfeb606aad6b755df7cb75c32bf478","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":46,"context_line":"        for a in agents:"},{"line_number":47,"context_line":"            if a[\u0027agent_type\u0027] \u003d\u003d \u0027L3 agent\u0027:"},{"line_number":48,"context_line":"                cls.agent \u003d a"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":51,"context_line":"    def test_list_routers_on_l3_agent(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Bag8%3D","line":48,"in_reply_to":"AAAAUH%2F%2BbPI%3D","updated":"2014-01-27 07:02:49.000000000","message":"Done","commit_id":"a4aef1f4f94962cb446516177c8c4f0af7001092"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"3d640294d4cf9743b1b6e9b6cffa9aee013a688a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 IBM Corp."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F94Ts%3D","line":1,"updated":"2014-02-02 17:03:12.000000000","message":"vim lines are removed from everywhere.","commit_id":"4a202f67b4fca171c314b1cc099a4bc755380d33"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"bcb8e91fdf22b145495344ffaece2816896b39bc","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        resp, body \u003d self.admin_client.list_l3_agents_hosting_router("},{"line_number":67,"context_line":"            router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(len(body[\u0027agents\u0027]), 1)"},{"line_number":70,"context_line":"        self.assertIn(\u0027agent_type\u0027, body[\u0027agents\u0027][0])"},{"line_number":71,"context_line":"        self.assertEqual(body[\u0027agents\u0027][0][\u0027agent_type\u0027], \u0027L3 agent\u0027)"},{"line_number":72,"context_line":"        self.assertEqual(body[\u0027agents\u0027][0][\u0027id\u0027], self.agent[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FunU%3D","line":69,"updated":"2014-02-11 07:18:59.000000000","message":"I\u0027m not sure so this is just a question. Is it ok to assert length here?  This could lead to future failures arousing from parallel testing.","commit_id":"3d8d197f06a29c263daed772b2b5a3cd59300465"},{"author":{"_account_id":6455,"name":"Harika Vakadi","email":"harika_vakadi@persistent.co.in","username":"harika-vakadi"},"change_message_id":"ce59c6540cefc745a872f50350618c47d1925b34","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        resp, body \u003d self.admin_client.list_l3_agents_hosting_router("},{"line_number":67,"context_line":"            router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(len(body[\u0027agents\u0027]), 1)"},{"line_number":70,"context_line":"        self.assertIn(\u0027agent_type\u0027, body[\u0027agents\u0027][0])"},{"line_number":71,"context_line":"        self.assertEqual(body[\u0027agents\u0027][0][\u0027agent_type\u0027], \u0027L3 agent\u0027)"},{"line_number":72,"context_line":"        self.assertEqual(body[\u0027agents\u0027][0][\u0027id\u0027], self.agent[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FQck%3D","line":69,"in_reply_to":"AAAAUX%2F%2FunU%3D","updated":"2014-02-14 13:50:47.000000000","message":"Done","commit_id":"3d8d197f06a29c263daed772b2b5a3cd59300465"},{"author":{"_account_id":1795,"name":"Ravikumar Venkatesan","email":"ravikumar.venkatesan@hpe.com","username":"ravikumar-venkatesan"},"change_message_id":"8a7f996de2617ed0289609f02477fa7c897baec3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        resp, body \u003d self.admin_client.list_l3_agents_hosting_router("},{"line_number":67,"context_line":"            router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(len(body[\u0027agents\u0027]), 1)"},{"line_number":70,"context_line":"        self.assertIn(\u0027agent_type\u0027, body[\u0027agents\u0027][0])"},{"line_number":71,"context_line":"        self.assertEqual(body[\u0027agents\u0027][0][\u0027agent_type\u0027], \u0027L3 agent\u0027)"},{"line_number":72,"context_line":"        self.assertEqual(body[\u0027agents\u0027][0][\u0027id\u0027], self.agent[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2Fnxc%3D","line":69,"in_reply_to":"AAAAUX%2F%2FunU%3D","updated":"2014-02-11 22:56:58.000000000","message":"Hi Ann,\n\n Yes. i agree. it does not add much value, but only error prone. we will remove that verification\nRegards,\n\nRavi","commit_id":"3d8d197f06a29c263daed772b2b5a3cd59300465"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"091a8409e8f915716657e4a3ec141368cdb30ffd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        if not test.is_extension_enabled(\u0027l3_agent_scheduler\u0027, \u0027network\u0027):"},{"line_number":39,"context_line":"            msg \u003d \"L3 Agent Scheduler Extension not enabled.\""},{"line_number":40,"context_line":"            raise cls.skipException(msg)"},{"line_number":41,"context_line":"        #Trying to get agent details for L3 Agent"},{"line_number":42,"context_line":"        resp, body \u003d cls.admin_client.list_agents()"},{"line_number":43,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":44,"context_line":"        for a in agents:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2Banw%3D","line":41,"updated":"2014-02-21 09:34:35.000000000","message":"space after #.","commit_id":"6a8cdb5b97f28c13e25a230fcfdd2c6c23b50354"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"3f8857b7005494c0db20160a90e1323de5a007f7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        # Trying to get agent details for L3 Agent"},{"line_number":42,"context_line":"        resp, body \u003d cls.admin_client.list_agents()"},{"line_number":43,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":44,"context_line":"        for a in agents:"},{"line_number":45,"context_line":"            if a[\u0027agent_type\u0027] \u003d\u003d \u0027L3 agent\u0027:"},{"line_number":46,"context_line":"                cls.agent \u003d a"},{"line_number":47,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2Fg5Q%3D","line":44,"updated":"2014-02-26 07:17:57.000000000","message":"except a use some generic keyword such as \"for agent in body[\u0027agents\u0027]\"","commit_id":"dfac5de9cac78d1664a52334052150e795723daa"},{"author":{"_account_id":6455,"name":"Harika Vakadi","email":"harika_vakadi@persistent.co.in","username":"harika-vakadi"},"change_message_id":"ff274a87f79a77120b44b2fce1473a29d830684b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        # Trying to get agent details for L3 Agent"},{"line_number":42,"context_line":"        resp, body \u003d cls.admin_client.list_agents()"},{"line_number":43,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":44,"context_line":"        for a in agents:"},{"line_number":45,"context_line":"            if a[\u0027agent_type\u0027] \u003d\u003d \u0027L3 agent\u0027:"},{"line_number":46,"context_line":"                cls.agent \u003d a"},{"line_number":47,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2Ff8g%3D","line":44,"in_reply_to":"AAAAU3%2F%2Fg5Q%3D","updated":"2014-02-26 09:23:08.000000000","message":"Done","commit_id":"dfac5de9cac78d1664a52334052150e795723daa"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"3f8857b7005494c0db20160a90e1323de5a007f7","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        resp, body \u003d self.admin_client.list_l3_agents_hosting_router("},{"line_number":68,"context_line":"            router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":70,"context_line":"        for a in body[\u0027agents\u0027]:"},{"line_number":71,"context_line":"            l3_agent_ids.append(a[\u0027id\u0027])"},{"line_number":72,"context_line":"            self.assertIn(\u0027agent_type\u0027, a)"},{"line_number":73,"context_line":"            self.assertEqual(\u0027L3 agent\u0027, a[\u0027agent_type\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2FhDE%3D","line":70,"updated":"2014-02-26 07:17:57.000000000","message":"except a use some generic keyword such as \"for agent in body[\u0027agents\u0027]\"","commit_id":"dfac5de9cac78d1664a52334052150e795723daa"},{"author":{"_account_id":6455,"name":"Harika Vakadi","email":"harika_vakadi@persistent.co.in","username":"harika-vakadi"},"change_message_id":"ff274a87f79a77120b44b2fce1473a29d830684b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        resp, body \u003d self.admin_client.list_l3_agents_hosting_router("},{"line_number":68,"context_line":"            router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":70,"context_line":"        for a in body[\u0027agents\u0027]:"},{"line_number":71,"context_line":"            l3_agent_ids.append(a[\u0027id\u0027])"},{"line_number":72,"context_line":"            self.assertIn(\u0027agent_type\u0027, a)"},{"line_number":73,"context_line":"            self.assertEqual(\u0027L3 agent\u0027, a[\u0027agent_type\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2Ff8c%3D","line":70,"in_reply_to":"AAAAU3%2F%2FhDE%3D","updated":"2014-02-26 09:23:08.000000000","message":"Done","commit_id":"dfac5de9cac78d1664a52334052150e795723daa"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"3f8857b7005494c0db20160a90e1323de5a007f7","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self.assertIn(\u0027agent_type\u0027, a)"},{"line_number":73,"context_line":"            self.assertEqual(\u0027L3 agent\u0027, a[\u0027agent_type\u0027])"},{"line_number":74,"context_line":"        self.assertIn(self.agent[\u0027id\u0027], l3_agent_ids)"},{"line_number":75,"context_line":"        for a in body[\u0027agents\u0027]:"},{"line_number":76,"context_line":"            l3_agent_ids.remove(a[\u0027id\u0027])"},{"line_number":77,"context_line":"        resp, body \u003d self.admin_client.remove_router_from_l3_agent("},{"line_number":78,"context_line":"            self.agent[\u0027id\u0027], router[\u0027router\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2FhEE%3D","line":75,"updated":"2014-02-26 07:17:57.000000000","message":"Here you just wanted to flush your list \"l3_agent_ids\".\nbetter will be if you use following keyword rather a for loop - \n\"del l3_agent_ids[:]\" this will flush the l3_agent_ids list.\nor you may reinitialize the list as per my thinking.","commit_id":"dfac5de9cac78d1664a52334052150e795723daa"},{"author":{"_account_id":6455,"name":"Harika Vakadi","email":"harika_vakadi@persistent.co.in","username":"harika-vakadi"},"change_message_id":"ff274a87f79a77120b44b2fce1473a29d830684b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self.assertIn(\u0027agent_type\u0027, a)"},{"line_number":73,"context_line":"            self.assertEqual(\u0027L3 agent\u0027, a[\u0027agent_type\u0027])"},{"line_number":74,"context_line":"        self.assertIn(self.agent[\u0027id\u0027], l3_agent_ids)"},{"line_number":75,"context_line":"        for a in body[\u0027agents\u0027]:"},{"line_number":76,"context_line":"            l3_agent_ids.remove(a[\u0027id\u0027])"},{"line_number":77,"context_line":"        resp, body \u003d self.admin_client.remove_router_from_l3_agent("},{"line_number":78,"context_line":"            self.agent[\u0027id\u0027], router[\u0027router\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2Ff8Y%3D","line":75,"in_reply_to":"AAAAU3%2F%2FhEE%3D","updated":"2014-02-26 09:23:08.000000000","message":"Done","commit_id":"dfac5de9cac78d1664a52334052150e795723daa"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"3f8857b7005494c0db20160a90e1323de5a007f7","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":80,"context_line":"        resp, body \u003d self.admin_client.list_l3_agents_hosting_router("},{"line_number":81,"context_line":"            router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":82,"context_line":"        for a in body[\u0027agents\u0027]:"},{"line_number":83,"context_line":"            l3_agent_ids.append(a[\u0027id\u0027])"},{"line_number":84,"context_line":"        self.assertNotIn(self.agent[\u0027id\u0027], l3_agent_ids)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2FhC4%3D","line":82,"updated":"2014-02-26 07:17:57.000000000","message":"As of above","commit_id":"dfac5de9cac78d1664a52334052150e795723daa"},{"author":{"_account_id":6455,"name":"Harika Vakadi","email":"harika_vakadi@persistent.co.in","username":"harika-vakadi"},"change_message_id":"ff274a87f79a77120b44b2fce1473a29d830684b","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":80,"context_line":"        resp, body \u003d self.admin_client.list_l3_agents_hosting_router("},{"line_number":81,"context_line":"            router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":82,"context_line":"        for a in body[\u0027agents\u0027]:"},{"line_number":83,"context_line":"            l3_agent_ids.append(a[\u0027id\u0027])"},{"line_number":84,"context_line":"        self.assertNotIn(self.agent[\u0027id\u0027], l3_agent_ids)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2Ff8I%3D","line":82,"in_reply_to":"AAAAU3%2F%2FhC4%3D","updated":"2014-02-26 09:23:08.000000000","message":"Done","commit_id":"dfac5de9cac78d1664a52334052150e795723daa"}],"tempest/services/network/json/network_client.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"3d640294d4cf9743b1b6e9b6cffa9aee013a688a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F94To%3D","line":1,"updated":"2014-02-02 17:03:12.000000000","message":"vim lines are removed from everywhere.","commit_id":"4a202f67b4fca171c314b1cc099a4bc755380d33"}],"tempest/services/network/xml/network_client.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"3d640294d4cf9743b1b6e9b6cffa9aee013a688a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F94Tg%3D","line":1,"updated":"2014-02-02 17:03:12.000000000","message":"vim lines are removed from everywhere.","commit_id":"4a202f67b4fca171c314b1cc099a4bc755380d33"}]}