)]}'
{"releasenotes/notes/fix-1847749-2670b1d4f6097a1a.yaml":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"95cb99bceb5542b22a9386249f075e6e0b0fd875","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Bug#1847749. This privides the workaround of Skip Exception raised instead of skiping"},{"line_number":5,"context_line":"    the CLI tests. If you are running Tempest with stestr \u003e 2.5.0 then use this fix."},{"line_number":6,"context_line":"    Ref- https://github.com/testing-cabal/testtools/issues/272 "}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_de0a57d0","line":4,"range":{"start_line":4,"start_character":82,"end_line":4,"end_character":89},"updated":"2019-10-11 20:23:19.000000000","message":"skipping","commit_id":"1d93b441437e16b9ac69b0c28aaa887eb5902df9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c1fa1df8b81bfe391e62269ebc98de7503bba9ab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Bug#1847749. This privides the workaround of Skip Exception raised instead of skiping"},{"line_number":5,"context_line":"    the CLI tests. If you are running Tempest with stestr \u003e 2.5.0 then use this fix."},{"line_number":6,"context_line":"    Ref- https://github.com/testing-cabal/testtools/issues/272 "}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_b9d2155b","line":4,"range":{"start_line":4,"start_character":82,"end_line":4,"end_character":89},"in_reply_to":"3fa7e38b_de0a57d0","updated":"2019-10-11 21:52:23.000000000","message":"Done","commit_id":"1d93b441437e16b9ac69b0c28aaa887eb5902df9"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"95cb99bceb5542b22a9386249f075e6e0b0fd875","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Bug#1847749. This privides the workaround of Skip Exception raised instead of skiping"},{"line_number":5,"context_line":"    the CLI tests. If you are running Tempest with stestr \u003e 2.5.0 then use this fix."},{"line_number":6,"context_line":"    Ref- https://github.com/testing-cabal/testtools/issues/272 "}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_be051bc4","line":6,"range":{"start_line":6,"start_character":62,"end_line":6,"end_character":63},"updated":"2019-10-11 20:23:19.000000000","message":"WS","commit_id":"1d93b441437e16b9ac69b0c28aaa887eb5902df9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c1fa1df8b81bfe391e62269ebc98de7503bba9ab","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Bug#1847749. This privides the workaround of Skip Exception raised instead of skiping"},{"line_number":5,"context_line":"    the CLI tests. If you are running Tempest with stestr \u003e 2.5.0 then use this fix."},{"line_number":6,"context_line":"    Ref- https://github.com/testing-cabal/testtools/issues/272 "}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_19e00926","line":6,"range":{"start_line":6,"start_character":62,"end_line":6,"end_character":63},"in_reply_to":"3fa7e38b_be051bc4","updated":"2019-10-11 21:52:23.000000000","message":"Done","commit_id":"1d93b441437e16b9ac69b0c28aaa887eb5902df9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"031bf08fcd51b7ea528973e50e4820d4eed6377c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Bug#1847749. This privides the workaround of Skip Exception raised instead of skipping"},{"line_number":5,"context_line":"    the CLI tests. If you are running Tempest with stestr \u003e 2.5.0 then use this fix."},{"line_number":6,"context_line":"    Ref- https://github.com/testing-cabal/testtools/issues/272"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_5262c1af","line":4,"range":{"start_line":4,"start_character":22,"end_line":4,"end_character":30},"updated":"2019-10-14 18:39:41.000000000","message":"provides","commit_id":"e64c78dcf720202a0542bb1e1184f5229a11524f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6eee93d8e4e112bddbddae7d9c13c4e3bcb6949a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Bug#1847749. This privides the workaround of Skip Exception raised instead of skipping"},{"line_number":5,"context_line":"    the CLI tests. If you are running Tempest with stestr \u003e 2.5.0 then use this fix."},{"line_number":6,"context_line":"    Ref- https://github.com/testing-cabal/testtools/issues/272"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_68d7d04c","line":4,"range":{"start_line":4,"start_character":22,"end_line":4,"end_character":30},"in_reply_to":"3fa7e38b_5262c1af","updated":"2019-10-14 20:29:10.000000000","message":"thanks. I will fix it in followup.","commit_id":"e64c78dcf720202a0542bb1e1184f5229a11524f"}],"tempest/lib/base.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"95cb99bceb5542b22a9386249f075e6e0b0fd875","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def _handle_skip_exception(cls):"},{"line_number":35,"context_line":"        try:"},{"line_number":36,"context_line":"            stestr_version \u003d pkg_resources.parse_version("},{"line_number":37,"context_line":"                pkg_resources.get_distribution(\"stestr\").version)"},{"line_number":38,"context_line":"            stestr_min \u003d pkg_resources.parse_version(\u00272.5.0\u0027)"},{"line_number":39,"context_line":"            new_stestr \u003d (stestr_version \u003e\u003d stestr_min)"},{"line_number":40,"context_line":"            import unittest"},{"line_number":41,"context_line":"            import unittest2"},{"line_number":42,"context_line":"            if sys.version_info \u003e\u003d (3, 5) and new_stestr:"},{"line_number":43,"context_line":"                testtools.TestCase.skipException \u003d unittest.case.SkipTest"},{"line_number":44,"context_line":"            else:"},{"line_number":45,"context_line":"                testtools.TestCase.skipException \u003d unittest2.case.SkipTest"},{"line_number":46,"context_line":"        except Exception:"},{"line_number":47,"context_line":"            pass"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @classmethod"},{"line_number":50,"context_line":"    def setUpClass(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_5ef667d9","line":47,"range":{"start_line":35,"start_character":0,"end_line":47,"end_character":16},"updated":"2019-10-11 20:23:19.000000000","message":"Why not put this in tempest.common as a helper then import it in and use it here instead of copy/paste in 2 places?","commit_id":"1d93b441437e16b9ac69b0c28aaa887eb5902df9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c1fa1df8b81bfe391e62269ebc98de7503bba9ab","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def _handle_skip_exception(cls):"},{"line_number":35,"context_line":"        try:"},{"line_number":36,"context_line":"            stestr_version \u003d pkg_resources.parse_version("},{"line_number":37,"context_line":"                pkg_resources.get_distribution(\"stestr\").version)"},{"line_number":38,"context_line":"            stestr_min \u003d pkg_resources.parse_version(\u00272.5.0\u0027)"},{"line_number":39,"context_line":"            new_stestr \u003d (stestr_version \u003e\u003d stestr_min)"},{"line_number":40,"context_line":"            import unittest"},{"line_number":41,"context_line":"            import unittest2"},{"line_number":42,"context_line":"            if sys.version_info \u003e\u003d (3, 5) and new_stestr:"},{"line_number":43,"context_line":"                testtools.TestCase.skipException \u003d unittest.case.SkipTest"},{"line_number":44,"context_line":"            else:"},{"line_number":45,"context_line":"                testtools.TestCase.skipException \u003d unittest2.case.SkipTest"},{"line_number":46,"context_line":"        except Exception:"},{"line_number":47,"context_line":"            pass"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @classmethod"},{"line_number":50,"context_line":"    def setUpClass(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_b9e9b51a","line":47,"range":{"start_line":35,"start_character":0,"end_line":47,"end_character":16},"in_reply_to":"3fa7e38b_5ef667d9","updated":"2019-10-11 21:52:23.000000000","message":"ok. I will make this as common and use it in test.py","commit_id":"1d93b441437e16b9ac69b0c28aaa887eb5902df9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c86fc2400c2f3cd054ce8b4907eb52e3c564d81c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        stestr_min \u003d pkg_resources.parse_version(\u00272.5.0\u0027)"},{"line_number":29,"context_line":"        new_stestr \u003d (stestr_version \u003e\u003d stestr_min)"},{"line_number":30,"context_line":"        import unittest"},{"line_number":31,"context_line":"        import unittest2"},{"line_number":32,"context_line":"        if sys.version_info \u003e\u003d (3, 5) and new_stestr:"},{"line_number":33,"context_line":"            testtools.TestCase.skipException \u003d unittest.case.SkipTest"},{"line_number":34,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_31f2aa71","line":31,"updated":"2019-10-14 15:17:19.000000000","message":"Small optimization, but it doesn\u0027t look like both need to be imported. Might be very slightly more efficient to move the imports into the if/else to just import the one that is actually needed.","commit_id":"e64c78dcf720202a0542bb1e1184f5229a11524f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f8855874bab148a994d9f149f9a79293141b58b6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        stestr_min \u003d pkg_resources.parse_version(\u00272.5.0\u0027)"},{"line_number":29,"context_line":"        new_stestr \u003d (stestr_version \u003e\u003d stestr_min)"},{"line_number":30,"context_line":"        import unittest"},{"line_number":31,"context_line":"        import unittest2"},{"line_number":32,"context_line":"        if sys.version_info \u003e\u003d (3, 5) and new_stestr:"},{"line_number":33,"context_line":"            testtools.TestCase.skipException \u003d unittest.case.SkipTest"},{"line_number":34,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_e3d9a982","line":31,"in_reply_to":"3fa7e38b_31f2aa71","updated":"2019-10-14 15:38:13.000000000","message":"yeah with new code yes we can do that. I will change that in followup or if changing this file further.","commit_id":"e64c78dcf720202a0542bb1e1184f5229a11524f"}],"tempest/test.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"95cb99bceb5542b22a9386249f075e6e0b0fd875","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        cls._teardowns \u003d []"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @classmethod"},{"line_number":144,"context_line":"    def _handle_skip_exception(cls):"},{"line_number":145,"context_line":"        try:"},{"line_number":146,"context_line":"            stestr_version \u003d pkg_resources.parse_version("},{"line_number":147,"context_line":"                pkg_resources.get_distribution(\"stestr\").version)"},{"line_number":148,"context_line":"            stestr_min \u003d pkg_resources.parse_version(\u00272.5.0\u0027)"},{"line_number":149,"context_line":"            new_stestr \u003d (stestr_version \u003e\u003d stestr_min)"},{"line_number":150,"context_line":"            import unittest"},{"line_number":151,"context_line":"            import unittest2"},{"line_number":152,"context_line":"            if sys.version_info \u003e\u003d (3, 5) and new_stestr:"},{"line_number":153,"context_line":"                testtools.TestCase.skipException \u003d unittest.case.SkipTest"},{"line_number":154,"context_line":"            else:"},{"line_number":155,"context_line":"                testtools.TestCase.skipException \u003d unittest2.case.SkipTest"},{"line_number":156,"context_line":"        except Exception:"},{"line_number":157,"context_line":"            pass"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    @classmethod"},{"line_number":160,"context_line":"    def setUpClass(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_3ef92bc7","line":157,"range":{"start_line":144,"start_character":0,"end_line":157,"end_character":16},"updated":"2019-10-11 20:23:19.000000000","message":"Why not put this in tempest.common as a helper then import it in and use it here instead of copy/paste in 2 places?","commit_id":"1d93b441437e16b9ac69b0c28aaa887eb5902df9"}]}
