)]}'
{"tempest/api/network/admin/test_agent_management.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"4abf3397d005a40754ebd9afa8b60b654bed8cda","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":34,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":35,"context_line":"        # Hearthbeats must be excluded from comparison"},{"line_number":36,"context_line":"        self.agent.pop(\u0027heartbeat_timestamp\u0027, None)"},{"line_number":37,"context_line":"        for agent in agents:"},{"line_number":38,"context_line":"            agent.pop(\u0027heartbeat_timestamp\u0027, None)"},{"line_number":39,"context_line":"        self.assertIn(self.agent, agents)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BgVM%3D","line":36,"updated":"2014-01-24 23:11:27.000000000","message":"I don\u0027t think you need to set a default here, but whatever.","commit_id":"5bd6c168c06d436d92616b711a15e732b5d77c4b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"740ef9b8db0361ffe50153b4a01b778bba4a790f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":34,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":35,"context_line":"        # Hearthbeats must be excluded from comparison"},{"line_number":36,"context_line":"        self.agent.pop(\u0027heartbeat_timestamp\u0027, None)"},{"line_number":37,"context_line":"        for agent in agents:"},{"line_number":38,"context_line":"            agent.pop(\u0027heartbeat_timestamp\u0027, None)"},{"line_number":39,"context_line":"        self.assertIn(self.agent, agents)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BeUs%3D","line":36,"in_reply_to":"AAAAUH%2F%2BgHA%3D","updated":"2014-01-25 13:57:36.000000000","message":"I think it is okay. Precisely speaking, each agent data contains fields which changes time to time. heartbeat_timestamp and configuration are these fields and it is better to exclude these fields.","commit_id":"5bd6c168c06d436d92616b711a15e732b5d77c4b"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"790215a44e97e6e3d371a6034445536e830b4a04","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":34,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":35,"context_line":"        # Hearthbeats must be excluded from comparison"},{"line_number":36,"context_line":"        self.agent.pop(\u0027heartbeat_timestamp\u0027, None)"},{"line_number":37,"context_line":"        for agent in agents:"},{"line_number":38,"context_line":"            agent.pop(\u0027heartbeat_timestamp\u0027, None)"},{"line_number":39,"context_line":"        self.assertIn(self.agent, agents)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BgHA%3D","line":36,"in_reply_to":"AAAAUH%2F%2BgVM%3D","updated":"2014-01-24 23:18:25.000000000","message":"meh it\u0027s just because I don\u0027t know if *all* the neutron agents have a heartbeat, and I wanted to avoid silly KeyErrors","commit_id":"5bd6c168c06d436d92616b711a15e732b5d77c4b"}]}
