)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"36c33496ecb380d9be02d4604937f1570f64a1fc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-10-30 16:16:36 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes race condition in test_add_remove_fixed_ip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently race condition can occure in tempest.api.compute.servers.test_attach_interfaces.AttachInterfacesUnderV243Test.test_add_remove_fixed_ip"},{"line_number":10,"context_line":"when floating IP added during resource preparation doesn\u0027t appear in the list of original IPs that is created at the beggining of the test, which then confuses the test"},{"line_number":11,"context_line":"and floating ip is later recognized as fixed IP added in the test."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_6f31ec0a","line":8,"updated":"2019-11-05 06:16:18.000000000","message":"Could you, please, indent the lines so that they are no longer than at least 80 chars (73 according to gerrit).","commit_id":"72ebb574a5890283d0dfcbf7b5dc87ed6dd1dbca"},{"author":{"_account_id":30942,"name":"David Sedlák","email":"dsedlak@redhat.com","username":"dsedlak"},"change_message_id":"986afeb1f74e0bd9fdca7be29f7c71f944e40423","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-10-30 16:16:36 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes race condition in test_add_remove_fixed_ip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently race condition can occure in tempest.api.compute.servers.test_attach_interfaces.AttachInterfacesUnderV243Test.test_add_remove_fixed_ip"},{"line_number":10,"context_line":"when floating IP added during resource preparation doesn\u0027t appear in the list of original IPs that is created at the beggining of the test, which then confuses the test"},{"line_number":11,"context_line":"and floating ip is later recognized as fixed IP added in the test."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_acd3b9d4","line":8,"in_reply_to":"3fa7e38b_6f31ec0a","updated":"2020-03-16 18:10:46.000000000","message":"Done","commit_id":"72ebb574a5890283d0dfcbf7b5dc87ed6dd1dbca"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"711e8f693a48ae9560eb288cf06634a3908eef54","unresolved":false,"context_lines":[{"line_number":14,"context_line":"which then confuses the test"},{"line_number":15,"context_line":"and floating ip is later recognized as fixed IP added in the test."},{"line_number":16,"context_line":"more details including log:"},{"line_number":17,"context_line":"https://bugzilla.redhat.com/show_bug.cgi?id\u003d1752416"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This change ensures possible floating IP added during server"},{"line_number":20,"context_line":"creation is always present in the set of original IPs and also"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_b2f7ec59","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":51},"updated":"2020-03-17 10:52:17.000000000","message":"this should be removed as the number of the launchpad bug you created should be put as reference here (Closes-Bug: #1866179)","commit_id":"174e97dd5fa8b4b46342476984d5ceedfafefb59"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fe604764b4e3d23928cf5fed9a25bb605ab922f4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"This change ensures possible floating IP added during server"},{"line_number":20,"context_line":"creation is always present in the set of original IPs and also"},{"line_number":21,"context_line":"during every comparasion of IPs."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ic3a3e0708714b6d6c9c226e641e1c520e5ebde9d"},{"line_number":24,"context_line":"Signed-off-by: David Sedlák \u003cdsedlak@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_30b56532","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":0},"updated":"2020-02-25 18:34:00.000000000","message":"can you log bug on https://bugs.launchpad.net/tempest\nwith log if you have, logs should show if floating ip is included there or not","commit_id":"174e97dd5fa8b4b46342476984d5ceedfafefb59"},{"author":{"_account_id":30942,"name":"David Sedlák","email":"dsedlak@redhat.com","username":"dsedlak"},"change_message_id":"986afeb1f74e0bd9fdca7be29f7c71f944e40423","unresolved":false,"context_lines":[{"line_number":19,"context_line":"This change ensures possible floating IP added during server"},{"line_number":20,"context_line":"creation is always present in the set of original IPs and also"},{"line_number":21,"context_line":"during every comparasion of IPs."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ic3a3e0708714b6d6c9c226e641e1c520e5ebde9d"},{"line_number":24,"context_line":"Signed-off-by: David Sedlák \u003cdsedlak@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_eccd3131","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":0},"in_reply_to":"1fa4df85_30b56532","updated":"2020-03-16 18:10:46.000000000","message":"Done","commit_id":"174e97dd5fa8b4b46342476984d5ceedfafefb59"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"85173a6f5dfb56cbeb0c170cf34ae98879528f1b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"This change ensures possible floating IP added during server"},{"line_number":20,"context_line":"creation is always present in the set of original IPs and also"},{"line_number":21,"context_line":"during every comparasion of IPs."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ic3a3e0708714b6d6c9c226e641e1c520e5ebde9d"},{"line_number":24,"context_line":"Signed-off-by: David Sedlák \u003cdsedlak@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_06a2459b","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":0},"in_reply_to":"1fa4df85_e6984976","updated":"2020-03-17 10:55:26.000000000","message":"aaaah, i meant this https://bugs.launchpad.net/tempest/+bug/1866179","commit_id":"174e97dd5fa8b4b46342476984d5ceedfafefb59"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"711e8f693a48ae9560eb288cf06634a3908eef54","unresolved":false,"context_lines":[{"line_number":19,"context_line":"This change ensures possible floating IP added during server"},{"line_number":20,"context_line":"creation is always present in the set of original IPs and also"},{"line_number":21,"context_line":"during every comparasion of IPs."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ic3a3e0708714b6d6c9c226e641e1c520e5ebde9d"},{"line_number":24,"context_line":"Signed-off-by: David Sedlák \u003cdsedlak@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_e6984976","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":0},"in_reply_to":"1fa4df85_eccd3131","updated":"2020-03-17 10:52:17.000000000","message":"https://bugs.launchpad.net/tempest/+bug/1676207","commit_id":"174e97dd5fa8b4b46342476984d5ceedfafefb59"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"711e8f693a48ae9560eb288cf06634a3908eef54","unresolved":false,"context_lines":[{"line_number":19,"context_line":"This change ensures possible floating IP added during server"},{"line_number":20,"context_line":"creation is always present in the set of original IPs and also"},{"line_number":21,"context_line":"during every comparasion of IPs."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ic3a3e0708714b6d6c9c226e641e1c520e5ebde9d"},{"line_number":24,"context_line":"Signed-off-by: David Sedlák \u003cdsedlak@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1fa4df85_f2c9e478","line":22,"updated":"2020-03-17 10:52:17.000000000","message":"if we do one more update of the patch, please, add this to the commit message:\nCloses-Bug: #1866179","commit_id":"634969f8a827ea1f5ff3c17d054db06c3bb394d7"}],"tempest/api/compute/servers/test_attach_interfaces.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"9449b149a56fb01c2a229965a6c167aafdab6377","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        # Keep track of the original addresses so we can know which IP is new."},{"line_number":370,"context_line":"        original_ips \u003d [addr[\u0027addr\u0027] for addr in list(addresses.values())[0]]"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        def _get_server_floating_ips():"},{"line_number":373,"context_line":"            _floating_ips \u003d []"},{"line_number":374,"context_line":"            _server \u003d self.os_primary.servers_client.show_server("},{"line_number":375,"context_line":"                server[\u0027id\u0027])[\u0027server\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_15036578","line":372,"updated":"2019-11-11 14:58:11.000000000","message":"Server client may also have delyed floating ip response. Would be better to explicitly exclude (union) the ip we allocated as floating","commit_id":"c00506c419cce10f26e75749da57268dbbb5c65e"},{"author":{"_account_id":30942,"name":"David Sedlák","email":"dsedlak@redhat.com","username":"dsedlak"},"change_message_id":"986afeb1f74e0bd9fdca7be29f7c71f944e40423","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        # Keep track of the original addresses so we can know which IP is new."},{"line_number":370,"context_line":"        original_ips \u003d [addr[\u0027addr\u0027] for addr in list(addresses.values())[0]]"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        def _get_server_floating_ips():"},{"line_number":373,"context_line":"            _floating_ips \u003d []"},{"line_number":374,"context_line":"            _server \u003d self.os_primary.servers_client.show_server("},{"line_number":375,"context_line":"                server[\u0027id\u0027])[\u0027server\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_cb9b7215","line":372,"in_reply_to":"3fa7e38b_15036578","updated":"2020-03-16 18:10:46.000000000","message":"Done","commit_id":"c00506c419cce10f26e75749da57268dbbb5c65e"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"b7b7cba9f91ab8e8881d3734be06d7bc5f451c07","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        # NOTE(zhufl) By default only project that is admin or network owner"},{"line_number":354,"context_line":"        # or project with role advsvc is authorised to add interfaces with"},{"line_number":355,"context_line":"        # fixed-ip, so if we don\u0027t create network for each project, do not"},{"line_number":356,"context_line":"        # test."},{"line_number":357,"context_line":"        if not (CONF.auth.use_dynamic_credentials and"},{"line_number":358,"context_line":"                CONF.auth.create_isolated_networks and"},{"line_number":359,"context_line":"                not CONF.network.shared_physical_network):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_9151d711","line":356,"updated":"2020-02-24 15:30:14.000000000","message":"Unrelated comment change.","commit_id":"fb25fea34b59c6059468aa3f9fef40a05e604b5d"},{"author":{"_account_id":30942,"name":"David Sedlák","email":"dsedlak@redhat.com","username":"dsedlak"},"change_message_id":"986afeb1f74e0bd9fdca7be29f7c71f944e40423","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        # NOTE(zhufl) By default only project that is admin or network owner"},{"line_number":354,"context_line":"        # or project with role advsvc is authorised to add interfaces with"},{"line_number":355,"context_line":"        # fixed-ip, so if we don\u0027t create network for each project, do not"},{"line_number":356,"context_line":"        # test."},{"line_number":357,"context_line":"        if not (CONF.auth.use_dynamic_credentials and"},{"line_number":358,"context_line":"                CONF.auth.create_isolated_networks and"},{"line_number":359,"context_line":"                not CONF.network.shared_physical_network):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_abbf165f","line":356,"in_reply_to":"1fa4df85_9151d711","updated":"2020-03-16 18:10:46.000000000","message":"Done","commit_id":"fb25fea34b59c6059468aa3f9fef40a05e604b5d"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"b7b7cba9f91ab8e8881d3734be06d7bc5f451c07","unresolved":false,"context_lines":[{"line_number":416,"context_line":"            if fixed_ip is not None:"},{"line_number":417,"context_line":"                break"},{"line_number":418,"context_line":"        self.servers_client.remove_fixed_ip(server[\u0027id\u0027], address\u003dfixed_ip)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"        # Wait for the interface count to decrease by one."},{"line_number":421,"context_line":"        if not test_utils.call_until_true("},{"line_number":422,"context_line":"                _wait_for_ip_change, CONF.compute.build_timeout,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_113887d1","line":419,"updated":"2020-02-24 15:30:14.000000000","message":"Extra white line","commit_id":"fb25fea34b59c6059468aa3f9fef40a05e604b5d"},{"author":{"_account_id":30942,"name":"David Sedlák","email":"dsedlak@redhat.com","username":"dsedlak"},"change_message_id":"986afeb1f74e0bd9fdca7be29f7c71f944e40423","unresolved":false,"context_lines":[{"line_number":416,"context_line":"            if fixed_ip is not None:"},{"line_number":417,"context_line":"                break"},{"line_number":418,"context_line":"        self.servers_client.remove_fixed_ip(server[\u0027id\u0027], address\u003dfixed_ip)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"        # Wait for the interface count to decrease by one."},{"line_number":421,"context_line":"        if not test_utils.call_until_true("},{"line_number":422,"context_line":"                _wait_for_ip_change, CONF.compute.build_timeout,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_cbc4d2f7","line":419,"in_reply_to":"1fa4df85_113887d1","updated":"2020-03-16 18:10:46.000000000","message":"Done","commit_id":"fb25fea34b59c6059468aa3f9fef40a05e604b5d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fe604764b4e3d23928cf5fed9a25bb605ab922f4","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    def _create_server_get_interfaces(self):"},{"line_number":76,"context_line":"        validation_resources \u003d self.get_test_validation_resources("},{"line_number":77,"context_line":"            self.os_primary)"},{"line_number":78,"context_line":"        server \u003d self.create_test_server("},{"line_number":79,"context_line":"            validatable\u003dTrue,"},{"line_number":80,"context_line":"            validation_resources\u003dvalidation_resources,"},{"line_number":81,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":82,"context_line":"        # NOTE(mgoddard): Get detailed server to ensure addresses are present"},{"line_number":83,"context_line":"        # in fixed IP case."},{"line_number":84,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_9040d909","line":81,"range":{"start_line":78,"start_character":0,"end_line":81,"end_character":32},"updated":"2020-02-25 18:34:00.000000000","message":"or another option which can solve other tests issue also for FIP update is that we should wait for floating ip to be associated with the server here- https://github.com/openstack/tempest/blob/6efb97bc9dae573cd727ba91c8ddcbd8f8767192/tempest/common/compute.py#L216","commit_id":"174e97dd5fa8b4b46342476984d5ceedfafefb59"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"711e8f693a48ae9560eb288cf06634a3908eef54","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    def _create_server_get_interfaces(self):"},{"line_number":76,"context_line":"        validation_resources \u003d self.get_test_validation_resources("},{"line_number":77,"context_line":"            self.os_primary)"},{"line_number":78,"context_line":"        server \u003d self.create_test_server("},{"line_number":79,"context_line":"            validatable\u003dTrue,"},{"line_number":80,"context_line":"            validation_resources\u003dvalidation_resources,"},{"line_number":81,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":82,"context_line":"        # NOTE(mgoddard): Get detailed server to ensure addresses are present"},{"line_number":83,"context_line":"        # in fixed IP case."},{"line_number":84,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_5289d823","line":81,"range":{"start_line":78,"start_character":0,"end_line":81,"end_character":32},"in_reply_to":"1fa4df85_0cc3ed39","updated":"2020-03-17 10:52:17.000000000","message":"I agree with David, we don\u0027t need to wait for the full IP association with the server and make the test slower unless it\u0027s necessary for the purpose of the test.","commit_id":"174e97dd5fa8b4b46342476984d5ceedfafefb59"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0c94b6d53fee1341d1451e20710211f7c32f2ddf","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    def _create_server_get_interfaces(self):"},{"line_number":76,"context_line":"        validation_resources \u003d self.get_test_validation_resources("},{"line_number":77,"context_line":"            self.os_primary)"},{"line_number":78,"context_line":"        server \u003d self.create_test_server("},{"line_number":79,"context_line":"            validatable\u003dTrue,"},{"line_number":80,"context_line":"            validation_resources\u003dvalidation_resources,"},{"line_number":81,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":82,"context_line":"        # NOTE(mgoddard): Get detailed server to ensure addresses are present"},{"line_number":83,"context_line":"        # in fixed IP case."},{"line_number":84,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_c42a8c8e","line":81,"range":{"start_line":78,"start_character":0,"end_line":81,"end_character":32},"in_reply_to":"1fa4df85_5289d823","updated":"2020-03-27 02:42:24.000000000","message":"yeah that is valid point. we can enable that with flag like we wait for server to  be active. let me work on poc sometime.","commit_id":"174e97dd5fa8b4b46342476984d5ceedfafefb59"},{"author":{"_account_id":30942,"name":"David Sedlák","email":"dsedlak@redhat.com","username":"dsedlak"},"change_message_id":"986afeb1f74e0bd9fdca7be29f7c71f944e40423","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    def _create_server_get_interfaces(self):"},{"line_number":76,"context_line":"        validation_resources \u003d self.get_test_validation_resources("},{"line_number":77,"context_line":"            self.os_primary)"},{"line_number":78,"context_line":"        server \u003d self.create_test_server("},{"line_number":79,"context_line":"            validatable\u003dTrue,"},{"line_number":80,"context_line":"            validation_resources\u003dvalidation_resources,"},{"line_number":81,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":82,"context_line":"        # NOTE(mgoddard): Get detailed server to ensure addresses are present"},{"line_number":83,"context_line":"        # in fixed IP case."},{"line_number":84,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_0cc3ed39","line":81,"range":{"start_line":78,"start_character":0,"end_line":81,"end_character":32},"in_reply_to":"1fa4df85_9040d909","updated":"2020-03-16 18:10:46.000000000","message":"I\u0027m not really sure about this. It could probably resolve similar issues in other related tests, but it would also mean every related test would have to wait for associated FIP to propagate (which is not necessary for some tests). Propagation of FIP after VM creation can in some cases take even 15 to 30 seconds. That means this change would unnecessary increase run time of some tests. I suggest to make waiting for FIP propagation optional by adding new parameter creating separate function or creating some kind of wrapper and using it only when necessary. But this patch is supposed to be a simple bugfix and I would like it to be merged asap. We can create new path for adding this feature if we will be able to agree on the way to do it.","commit_id":"174e97dd5fa8b4b46342476984d5ceedfafefb59"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fe604764b4e3d23928cf5fed9a25bb605ab922f4","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        self._wait_for_validation(server, validation_resources)"},{"line_number":89,"context_line":"        try:"},{"line_number":90,"context_line":"            fip \u003d set([validation_resources[\u0027floating_ip\u0027]"},{"line_number":91,"context_line":"                                           [\u0027floating_ip_address\u0027]])"},{"line_number":92,"context_line":"        except KeyError:"},{"line_number":93,"context_line":"            fip \u003d ()"},{"line_number":94,"context_line":"        ifs \u003d (self.interfaces_client.list_interfaces(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_70f51dcb","line":91,"range":{"start_line":91,"start_character":45,"end_line":91,"end_character":64},"updated":"2020-02-25 18:34:00.000000000","message":"address is stored as \u0027ip\u0027\n\n- https://github.com/openstack/tempest/blob/90b90ad3c86856f2b9cdae4e81bf6c3408c63b27/tempest/lib/common/validation_resources.py#L210","commit_id":"174e97dd5fa8b4b46342476984d5ceedfafefb59"},{"author":{"_account_id":30942,"name":"David Sedlák","email":"dsedlak@redhat.com","username":"dsedlak"},"change_message_id":"986afeb1f74e0bd9fdca7be29f7c71f944e40423","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        self._wait_for_validation(server, validation_resources)"},{"line_number":89,"context_line":"        try:"},{"line_number":90,"context_line":"            fip \u003d set([validation_resources[\u0027floating_ip\u0027]"},{"line_number":91,"context_line":"                                           [\u0027floating_ip_address\u0027]])"},{"line_number":92,"context_line":"        except KeyError:"},{"line_number":93,"context_line":"            fip \u003d ()"},{"line_number":94,"context_line":"        ifs \u003d (self.interfaces_client.list_interfaces(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_4bb0e28a","line":91,"range":{"start_line":91,"start_character":45,"end_line":91,"end_character":64},"in_reply_to":"1fa4df85_70f51dcb","updated":"2020-03-16 18:10:46.000000000","message":"Done","commit_id":"174e97dd5fa8b4b46342476984d5ceedfafefb59"}]}