)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4e4c365d2aa56944c415d6d6d119239b3bf698bd","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        token \u003d self.identity_client.auth_token"},{"line_number":110,"context_line":"        region \u003d self.config.identity.region"},{"line_number":111,"context_line":"        endpoint \u003d self.identity_client.service_catalog.url_for("},{"line_number":112,"context_line":"            attr\u003d\u0027region\u0027, filter_value\u003dregion,"},{"line_number":113,"context_line":"            service_type\u003d\u0027image\u0027, endpoint_type\u003d\u0027publicURL\u0027)"},{"line_number":114,"context_line":"        dscv \u003d self.config.identity.disable_ssl_certificate_validation"},{"line_number":115,"context_line":"        return glanceclient.Client(\u00271\u0027, endpoint\u003dendpoint, token\u003dtoken,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9%2F%2Bc%3D","line":112,"updated":"2014-01-31 06:03:06.000000000","message":"A similar change seems necessary.","commit_id":"23f371b3715ea25c07f850a8850383c9d77e21df"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"993ccac361715a5554a180d6eb73a40e180ffe3c","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        keystone \u003d self._get_identity_client(username, password, tenant_name)"},{"line_number":165,"context_line":"        region \u003d self.config.identity.region"},{"line_number":166,"context_line":"        token \u003d keystone.auth_token"},{"line_number":167,"context_line":"        service_type \u003d self.config.orchestration.catalog_type"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            endpoint \u003d keystone.service_catalog.url_for("},{"line_number":170,"context_line":"                attr\u003d\u0027region\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F98wk%3D","line":167,"updated":"2014-01-31 18:54:03.000000000","message":"This no longer works you need to use the global CONF object instead.","commit_id":"23f371b3715ea25c07f850a8850383c9d77e21df"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"92d56af70800d12238bee1b843e7449215c6697f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        keystone \u003d self._get_identity_client(username, password, tenant_name)"},{"line_number":165,"context_line":"        region \u003d self.config.identity.region"},{"line_number":166,"context_line":"        token \u003d keystone.auth_token"},{"line_number":167,"context_line":"        service_type \u003d self.config.orchestration.catalog_type"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            endpoint \u003d keystone.service_catalog.url_for("},{"line_number":170,"context_line":"                attr\u003d\u0027region\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F96Ls%3D","line":167,"in_reply_to":"AAAAUH%2F98wk%3D","updated":"2014-02-01 16:36:42.000000000","message":"Oops, OK, I\u0027ll rebase it manually later today.","commit_id":"23f371b3715ea25c07f850a8850383c9d77e21df"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ace3dfada1dc5168aa5454857897b09fe7eab9d8","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        token \u003d self.identity_client.auth_token"},{"line_number":112,"context_line":"        region \u003d CONF.identity.region"},{"line_number":113,"context_line":"        endpoint \u003d self.identity_client.service_catalog.url_for("},{"line_number":114,"context_line":"            attr\u003d\u0027region\u0027, filter_value\u003dregion,"},{"line_number":115,"context_line":"            service_type\u003d\u0027image\u0027, endpoint_type\u003d\u0027publicURL\u0027)"},{"line_number":116,"context_line":"        dscv \u003d CONF.identity.disable_ssl_certificate_validation"},{"line_number":117,"context_line":"        return glanceclient.Client(\u00271\u0027, endpoint\u003dendpoint, token\u003dtoken,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F96B8%3D","line":114,"updated":"2014-02-01 19:43:37.000000000","message":"Yeah looks like could do this here also.  I could make the patch more generic to handle this case also.","commit_id":"7e70cca24ab325e9570b850ef4ed4c081860d834"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"66477a5f3cad2b492a748411333422643563e8d3","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        region \u003d CONF.identity.region"},{"line_number":113,"context_line":"        endpoint \u003d self.identity_client.service_catalog.url_for("},{"line_number":114,"context_line":"            attr\u003d\u0027region\u0027, filter_value\u003dregion,"},{"line_number":115,"context_line":"            service_type\u003dCONF.image.catalog_type, endpoint_type\u003d\u0027publicURL\u0027)"},{"line_number":116,"context_line":"        dscv \u003d CONF.identity.disable_ssl_certificate_validation"},{"line_number":117,"context_line":"        return glanceclient.Client(\u00271\u0027, endpoint\u003dendpoint, token\u003dtoken,"},{"line_number":118,"context_line":"                                   insecure\u003ddscv)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2F5Xo%3D","line":115,"updated":"2014-02-10 04:41:23.000000000","message":"This must be my problem.  Good thing I had 3 hours on a flight tonight to read through old ML threads and came across this gem from lifeless:\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2013-December/022915.html","commit_id":"03d78a987ba40f8dcff8aa931fd66435405555ce"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"b864784f0a90c86f482883ca8ea3e75666217ac3","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def _get_image_client(self):"},{"line_number":111,"context_line":"        token \u003d self.identity_client.auth_token"},{"line_number":112,"context_line":"        region \u003d CONF.identity.region"},{"line_number":113,"context_line":"        service_type \u003d CONF.image.catalog_type"},{"line_number":114,"context_line":"        endpoint \u003d self.identity_client.service_catalog.url_for("},{"line_number":115,"context_line":"            attr\u003d\u0027region\u0027, filter_value\u003dregion,"},{"line_number":116,"context_line":"            service_type\u003dservice_type, endpoint_type\u003d\u0027publicURL\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2F5U8%3D","line":113,"updated":"2014-02-10 04:55:24.000000000","message":"The bug causing the import error is still here actually. The group name is images not image:\n\nhttp://git.openstack.org/cgit/openstack/tempest/tree/tempest/config.py#n789\n\nIt was actually fine the way it was before inline as a parameter. What lifeless was taking about there was parameters in a function definition, (which actually the lazy loading we use in tempest because of the test runner would prevent the potential issue) not as parameters in a function call.","commit_id":"2b56232970c36b3311ab003f530a16bb29a95453"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9048c5988730007dc7ef54f69d912fe185414113","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def _get_image_client(self):"},{"line_number":111,"context_line":"        token \u003d self.identity_client.auth_token"},{"line_number":112,"context_line":"        region \u003d CONF.identity.region"},{"line_number":113,"context_line":"        service_type \u003d CONF.image.catalog_type"},{"line_number":114,"context_line":"        endpoint \u003d self.identity_client.service_catalog.url_for("},{"line_number":115,"context_line":"            attr\u003d\u0027region\u0027, filter_value\u003dregion,"},{"line_number":116,"context_line":"            service_type\u003dservice_type, endpoint_type\u003d\u0027publicURL\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2F5D8%3D","line":113,"in_reply_to":"AAAAUX%2F%2F5Hk%3D","updated":"2014-02-10 05:45:22.000000000","message":"OK, yeah, I came to the same conclusion.  If you don\u0027t get to it I will.  If you beat me, add me to the review.","commit_id":"2b56232970c36b3311ab003f530a16bb29a95453"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"0ab0af1aaee36ab51b07aa33cdcc4178000d4339","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def _get_image_client(self):"},{"line_number":111,"context_line":"        token \u003d self.identity_client.auth_token"},{"line_number":112,"context_line":"        region \u003d CONF.identity.region"},{"line_number":113,"context_line":"        service_type \u003d CONF.image.catalog_type"},{"line_number":114,"context_line":"        endpoint \u003d self.identity_client.service_catalog.url_for("},{"line_number":115,"context_line":"            attr\u003d\u0027region\u0027, filter_value\u003dregion,"},{"line_number":116,"context_line":"            service_type\u003dservice_type, endpoint_type\u003d\u0027publicURL\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2F5Hk%3D","line":113,"in_reply_to":"AAAAUX%2F%2F5KI%3D","updated":"2014-02-10 05:35:47.000000000","message":"No I did the same thing the other day myself when writing one of my patches that\u0027s why I knew about it. \n\nIt looks like a bug in the line I referenced above. The group name in the oslo opt group definition uses \u0027image\u0027, (which explains the sample) but when we assign that group to an attr in the tempest config wrapper object we use \u0027images\u0027. I\u0027ll push out a fix for it in the morning.","commit_id":"2b56232970c36b3311ab003f530a16bb29a95453"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"01f6558dc2525aaa2c24e24005e56aa6bb280e66","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def _get_image_client(self):"},{"line_number":111,"context_line":"        token \u003d self.identity_client.auth_token"},{"line_number":112,"context_line":"        region \u003d CONF.identity.region"},{"line_number":113,"context_line":"        service_type \u003d CONF.image.catalog_type"},{"line_number":114,"context_line":"        endpoint \u003d self.identity_client.service_catalog.url_for("},{"line_number":115,"context_line":"            attr\u003d\u0027region\u0027, filter_value\u003dregion,"},{"line_number":116,"context_line":"            service_type\u003dservice_type, endpoint_type\u003d\u0027publicURL\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2F5KI%3D","line":113,"in_reply_to":"AAAAUX%2F%2F5U8%3D","updated":"2014-02-10 05:26:45.000000000","message":"Huh, well that\u0027s completely confusing given the tempest.conf.sample:\n\nhttps://github.com/openstack/tempest/blob/master/etc/tempest.conf.sample#L458\n\nAm I the first to hit this kind of issue?  I can\u0027t imagine I\u0027ll be the last.","commit_id":"2b56232970c36b3311ab003f530a16bb29a95453"}]}