)]}'
{"tempest/cmd/cleanup_service.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb941b19e316e201cf14aa933289ed50c6c9a300","unresolved":false,"context_lines":[{"line_number":1013,"context_line":"    the project they are associated with, deletion. The resources cannot be"},{"line_number":1014,"context_line":"    most likely deleted after the project is deleted first."},{"line_number":1015,"context_line":"    \"\"\""},{"line_number":1016,"context_line":"    project_services \u003d []"},{"line_number":1017,"context_line":"    # TODO(gmann): Tempest should provide some plugin hook for cleanup"},{"line_number":1018,"context_line":"    # script extension to plugin tests also."},{"line_number":1019,"context_line":"    if IS_NOVA:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_885ba2f7","line":1016,"range":{"start_line":1016,"start_character":4,"end_line":1016,"end_character":20},"updated":"2019-12-20 01:21:04.000000000","message":"project_associated_services \u003d []","commit_id":"8a282e03e369f023cdbb198dfea7be6b089ce9ab"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb941b19e316e201cf14aa933289ed50c6c9a300","unresolved":false,"context_lines":[{"line_number":1005,"context_line":"        for domain in domains:"},{"line_number":1006,"context_line":"            self.data[\u0027domains\u0027][domain[\u0027id\u0027]] \u003d domain[\u0027name\u0027]"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"def get_project_cleanup_services():"},{"line_number":1010,"context_line":"    \"\"\"Returns list of project service classes."},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"    The list contains services whose resources need to be deleted prior,"},{"line_number":1013,"context_line":"    the project they are associated with, deletion. The resources cannot be"},{"line_number":1014,"context_line":"    most likely deleted after the project is deleted first."},{"line_number":1015,"context_line":"    \"\"\""},{"line_number":1016,"context_line":"    project_services \u003d []"},{"line_number":1017,"context_line":"    # TODO(gmann): Tempest should provide some plugin hook for cleanup"},{"line_number":1018,"context_line":"    # script extension to plugin tests also."},{"line_number":1019,"context_line":"    if IS_NOVA:"},{"line_number":1020,"context_line":"        project_services.append(NovaQuotaService)"},{"line_number":1021,"context_line":"    if IS_CINDER:"},{"line_number":1022,"context_line":"        project_services.append(VolumeQuotaService)"},{"line_number":1023,"context_line":"    return project_services"},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":"def get_project_related_cleanup_services():"},{"line_number":1027,"context_line":"    \"\"\"Returns list of project related classes."},{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":"    The list contains services whose resources are associated with a project,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_6858a6f8","line":1026,"range":{"start_line":1008,"start_character":0,"end_line":1026,"end_character":43},"updated":"2019-12-20 01:21:04.000000000","message":"it is difficult to understand the difference between them till you check the deletion process of these services. How about renaming them like bellow:\n\ndef get_project_associated_cleanup_services()\n\n\ndef get_resource_cleanup_services())","commit_id":"8a282e03e369f023cdbb198dfea7be6b089ce9ab"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0b283ab4ec7f2d7e015bd79419c07ed2db8c53d0","unresolved":false,"context_lines":[{"line_number":1005,"context_line":"        for domain in domains:"},{"line_number":1006,"context_line":"            self.data[\u0027domains\u0027][domain[\u0027id\u0027]] \u003d domain[\u0027name\u0027]"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"def get_project_cleanup_services():"},{"line_number":1010,"context_line":"    \"\"\"Returns list of project service classes."},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"    The list contains services whose resources need to be deleted prior,"},{"line_number":1013,"context_line":"    the project they are associated with, deletion. The resources cannot be"},{"line_number":1014,"context_line":"    most likely deleted after the project is deleted first."},{"line_number":1015,"context_line":"    \"\"\""},{"line_number":1016,"context_line":"    project_services \u003d []"},{"line_number":1017,"context_line":"    # TODO(gmann): Tempest should provide some plugin hook for cleanup"},{"line_number":1018,"context_line":"    # script extension to plugin tests also."},{"line_number":1019,"context_line":"    if IS_NOVA:"},{"line_number":1020,"context_line":"        project_services.append(NovaQuotaService)"},{"line_number":1021,"context_line":"    if IS_CINDER:"},{"line_number":1022,"context_line":"        project_services.append(VolumeQuotaService)"},{"line_number":1023,"context_line":"    return project_services"},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":"def get_project_related_cleanup_services():"},{"line_number":1027,"context_line":"    \"\"\"Returns list of project related classes."},{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":"    The list contains services whose resources are associated with a project,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_b917ce46","line":1026,"range":{"start_line":1008,"start_character":0,"end_line":1026,"end_character":43},"in_reply_to":"3fa7e38b_6858a6f8","updated":"2019-12-20 09:01:37.000000000","message":"Agree, this sounds much better.","commit_id":"8a282e03e369f023cdbb198dfea7be6b089ce9ab"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb941b19e316e201cf14aa933289ed50c6c9a300","unresolved":false,"context_lines":[{"line_number":1030,"context_line":"    however, their deletion is possible also after the project is deleted"},{"line_number":1031,"context_line":"    first."},{"line_number":1032,"context_line":"    \"\"\""},{"line_number":1033,"context_line":"    project_services \u003d []"},{"line_number":1034,"context_line":"    # TODO(gmann): Tempest should provide some plugin hook for cleanup"},{"line_number":1035,"context_line":"    # script extension to plugin tests also."},{"line_number":1036,"context_line":"    if IS_NOVA:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_086fb293","line":1033,"range":{"start_line":1033,"start_character":4,"end_line":1033,"end_character":25},"updated":"2019-12-20 01:21:04.000000000","message":"resource_cleanup_services \u003d []","commit_id":"8a282e03e369f023cdbb198dfea7be6b089ce9ab"}]}