)]}'
{"tempest/api/compute/base.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"f2760de4fc4765ab6f5bf3d958a8c4fc135eb798","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                return"},{"line_number":160,"context_line":"            time.sleep(self.build_interval)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def _delete_volume(self, volumes_client, volume_id):"},{"line_number":163,"context_line":"        \"\"\"Deletes the given volume and waits for it to be gone.\"\"\""},{"line_number":164,"context_line":"        resp, _ \u003d volumes_client.delete_volume(volume_id)"},{"line_number":165,"context_line":"        # TODO(mriedem): We should move the wait_for_resource_deletion"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BWOY%3D","line":162,"updated":"2014-01-27 20:11:47.000000000","message":"same concern, can we put this in a try block with a log, to make sure that we don\u0027t blow up on fail here? Because we\u0027ve seen that before.","commit_id":"b4753f7606ed327fa6a2642792e1306d5f3d06bb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cf61fede39c4032c228ac6221fab6c50dad479a8","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                return"},{"line_number":160,"context_line":"            time.sleep(self.build_interval)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def _delete_volume(self, volumes_client, volume_id):"},{"line_number":163,"context_line":"        \"\"\"Deletes the given volume and waits for it to be gone.\"\"\""},{"line_number":164,"context_line":"        resp, _ \u003d volumes_client.delete_volume(volume_id)"},{"line_number":165,"context_line":"        # TODO(mriedem): We should move the wait_for_resource_deletion"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BWLI%3D","line":162,"in_reply_to":"AAAAUH%2F%2BWOY%3D","updated":"2014-01-27 20:17:46.000000000","message":"Sure, do you know if any of the existing volumes cleanup tests are doing that today?","commit_id":"b4753f7606ed327fa6a2642792e1306d5f3d06bb"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"cabaf7601309b0d3f22d23890c85853511de995c","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            time.sleep(self.build_interval)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    @staticmethod"},{"line_number":163,"context_line":"    def _delete_volume(volumes_client, volume_id):"},{"line_number":164,"context_line":"        \"\"\"Deletes the given volume and waits for it to be gone.\"\"\""},{"line_number":165,"context_line":"        try:"},{"line_number":166,"context_line":"            resp, _ \u003d volumes_client.delete_volume(volume_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F982Q%3D","line":163,"updated":"2014-01-31 18:41:36.000000000","message":"I\u0027m confused by this didn\u0027t you add this same basic method in the previous patch in the series? Why are you moving it around in this patch. I think you should only be creating this once in it\u0027s final form. (in whichever patch is appropriate)\n\nIt\u0027s a bit weird to make a method in one patch only to go and modify it in the next one.","commit_id":"fff4e694cad37c379ff597fad78d1aacd63d80cc"}],"tempest/api/compute/servers/test_server_rescue.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5ca185e00842cf8a5fe636efea5c194c564c12d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        # Create a volume and wait for it to become ready for attach"},{"line_number":131,"context_line":"        resp, volume_to_attach \u003d \\"},{"line_number":132,"context_line":"            self.volumes_extensions_client.create_volume("},{"line_number":133,"context_line":"                1, display_name\u003d\u0027test_rescued_vm_attach_volume\u0027)"},{"line_number":134,"context_line":"        self.volumes_extensions_client.wait_for_volume_status("},{"line_number":135,"context_line":"            volume_to_attach[\u0027id\u0027], \u0027available\u0027)"},{"line_number":136,"context_line":"        self.addCleanup(self._delete_volume, self, volume_to_attach[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2BUQU%3D","line":133,"updated":"2014-01-28 02:24:02.000000000","message":"Maybe should prefix the name with v2?  Or just make it random?","commit_id":"cb45abbfe993ffd09205f1030a3be1958aebc44e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5ca185e00842cf8a5fe636efea5c194c564c12d","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        # Create a volume and wait for it to become ready for attach"},{"line_number":154,"context_line":"        resp, volume_to_detach \u003d \\"},{"line_number":155,"context_line":"            self.volumes_extensions_client.create_volume("},{"line_number":156,"context_line":"                1, display_name\u003d\u0027test_rescued_vm_detach_volume\u0027)"},{"line_number":157,"context_line":"        self.volumes_extensions_client.wait_for_volume_status("},{"line_number":158,"context_line":"            volume_to_detach[\u0027id\u0027], \u0027available\u0027)"},{"line_number":159,"context_line":"        self.addCleanup(self._delete_volume, self, volume_to_detach[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2BUQY%3D","line":156,"updated":"2014-01-28 02:24:02.000000000","message":"Prefix with v2 or make it random?","commit_id":"cb45abbfe993ffd09205f1030a3be1958aebc44e"}],"tempest/api/compute/v3/servers/test_server_rescue.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5ca185e00842cf8a5fe636efea5c194c564c12d","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        # Create a volume and wait for it to become ready for attach"},{"line_number":113,"context_line":"        resp, volume_to_attach \u003d \\"},{"line_number":114,"context_line":"            self.volumes_client.create_volume("},{"line_number":115,"context_line":"                1, display_name\u003d\u0027test_rescued_vm_attach_volume\u0027)"},{"line_number":116,"context_line":"        self.volumes_client.wait_for_volume_status("},{"line_number":117,"context_line":"            volume_to_attach[\u0027id\u0027], \u0027available\u0027)"},{"line_number":118,"context_line":"        self.addCleanup(self._delete_volume, self, volume_to_attach[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2BUQI%3D","line":115,"updated":"2014-01-28 02:24:02.000000000","message":"Prefix with v3 or make the name random?","commit_id":"cb45abbfe993ffd09205f1030a3be1958aebc44e"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"255af9d143c3ec75b660585db680b2f8546ef4bb","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        # Create a volume and wait for it to become ready for attach"},{"line_number":113,"context_line":"        resp, volume_to_attach \u003d \\"},{"line_number":114,"context_line":"            self.volumes_client.create_volume("},{"line_number":115,"context_line":"                1, display_name\u003d\u0027test_rescued_vm_attach_volume\u0027)"},{"line_number":116,"context_line":"        self.volumes_client.wait_for_volume_status("},{"line_number":117,"context_line":"            volume_to_attach[\u0027id\u0027], \u0027available\u0027)"},{"line_number":118,"context_line":"        self.addCleanup(self._delete_volume, self, volume_to_attach[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2BUNo%3D","line":115,"in_reply_to":"AAAAUH%2F%2BUQI%3D","updated":"2014-01-28 02:39:58.000000000","message":"Hrm. So I think the display name doesn\u0027t need to be unique, but it would be good if it was. I suggest a common prefix with a random end to make it easy to locate which test it belongs to.","commit_id":"cb45abbfe993ffd09205f1030a3be1958aebc44e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5ca185e00842cf8a5fe636efea5c194c564c12d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        # Create a volume and wait for it to become ready for attach"},{"line_number":136,"context_line":"        resp, volume_to_detach \u003d \\"},{"line_number":137,"context_line":"            self.volumes_client.create_volume("},{"line_number":138,"context_line":"                1, display_name\u003d\u0027test_rescued_vm_detach_volume\u0027)"},{"line_number":139,"context_line":"        self.volumes_client.wait_for_volume_status("},{"line_number":140,"context_line":"            volume_to_detach[\u0027id\u0027], \u0027available\u0027)"},{"line_number":141,"context_line":"        self.addCleanup(self._delete_volume, self, volume_to_detach[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2BUQE%3D","line":138,"updated":"2014-01-28 02:24:02.000000000","message":"Prefix with v3 or make the name random?","commit_id":"cb45abbfe993ffd09205f1030a3be1958aebc44e"}]}