)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"35a58ee1089a4504deb6fd802b93fe32c370245a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Paras Babbar \u003cPBabbar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-23 14:26:45 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix test_attach_detach_volume test case to not rely on user/libvirt supplied disk name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch removes user provided and libvirt assigned"},{"line_number":10,"context_line":"value as that was based on assumption rather count the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3fa7e38b_f3bb01e1","line":7,"updated":"2019-12-05 06:49:19.000000000","message":"It\u0027s a little long for the first line of the commit message. But it\u0027s not critical.","commit_id":"f11856505fcfb85f1ad4fde4bf68078c63be787a"}],"tempest/api/compute/volumes/test_attach_volume.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"46e5ee7cf91d544a5ea9ec353ac9b44c2f4783ca","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        volume \u003d self.create_volume()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # NOTE: As of the 12.0.0 Liberty release, the Nova libvirt driver"},{"line_number":91,"context_line":"        # no longer honors a user-supplied device name, in that case"},{"line_number":92,"context_line":"        # CONF.compute.volume_device_name must be set the equal value as"},{"line_number":93,"context_line":"        # the libvirt auto-assigned one"},{"line_number":94,"context_line":"        attachment \u003d self.attach_volume(server, volume,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_29fefb04","side":"PARENT","line":91,"range":{"start_line":90,"start_character":8,"end_line":91,"end_character":55},"updated":"2019-11-18 10:55:30.000000000","message":"Technically it has never been able to honour the user supplied device name, we only documented that fact in Kilo.","commit_id":"9ef43160912f5ed7a71640b370d0dde2d84f6249"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"6f31e37514a20abc95276b34e6dcc18226571d7d","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        volume \u003d self.create_volume()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # NOTE: As of the 12.0.0 Liberty release, the Nova libvirt driver"},{"line_number":91,"context_line":"        # no longer honors a user-supplied device name, in that case"},{"line_number":92,"context_line":"        # CONF.compute.volume_device_name must be set the equal value as"},{"line_number":93,"context_line":"        # the libvirt auto-assigned one"},{"line_number":94,"context_line":"        attachment \u003d self.attach_volume(server, volume,"},{"line_number":95,"context_line":"                                        device\u003d(\u0027/dev/%s\u0027 % self.device))"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_2a7d90e6","side":"PARENT","line":93,"range":{"start_line":91,"start_character":56,"end_line":93,"end_character":39},"updated":"2019-11-18 05:59:09.000000000","message":"If we use device name returned from attachment info , maybe this comment can also be modified?","commit_id":"9ef43160912f5ed7a71640b370d0dde2d84f6249"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"46e5ee7cf91d544a5ea9ec353ac9b44c2f4783ca","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        volume \u003d self.create_volume()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # NOTE: As of the 12.0.0 Liberty release, the Nova libvirt driver"},{"line_number":91,"context_line":"        # no longer honors a user-supplied device name, in that case"},{"line_number":92,"context_line":"        # CONF.compute.volume_device_name must be set the equal value as"},{"line_number":93,"context_line":"        # the libvirt auto-assigned one"},{"line_number":94,"context_line":"        attachment \u003d self.attach_volume(server, volume,"},{"line_number":95,"context_line":"                                        device\u003d(\u0027/dev/%s\u0027 % self.device))"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_69171348","side":"PARENT","line":93,"range":{"start_line":91,"start_character":56,"end_line":93,"end_character":39},"in_reply_to":"3fa7e38b_2a7d90e6","updated":"2019-11-18 10:55:30.000000000","message":"I don\u0027t believe anything has changed tbh, the device name calculated by n-cpu and provided to Libvirt can still be wrong.","commit_id":"9ef43160912f5ed7a71640b370d0dde2d84f6249"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"46e5ee7cf91d544a5ea9ec353ac9b44c2f4783ca","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        if CONF.validation.run_validation:"},{"line_number":106,"context_line":"            disks \u003d linux_client.get_disks()"},{"line_number":107,"context_line":"            device_name_to_match \u003d attachment[\u0027device\u0027].replace(\u0027/dev/\u0027, \u0027\u0027)"},{"line_number":108,"context_line":"            self.assertIn(device_name_to_match, disks)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.servers_client.detach_volume(server[\u0027id\u0027], attachment[\u0027volumeId\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_8914cf42","line":107,"range":{"start_line":107,"start_character":55,"end_line":107,"end_character":76},"updated":"2019-11-18 10:55:30.000000000","message":"You shouldn\u0027t need to replace the /dev/ part of the name.","commit_id":"d3ce8ffa1172e30def2762c09fa42cff7fae0023"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"212ab130bac1dbdfa9db879fef45efd2b56b5ca9","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        if CONF.validation.run_validation:"},{"line_number":106,"context_line":"            disks \u003d linux_client.get_disks()"},{"line_number":107,"context_line":"            device_name_to_match \u003d attachment[\u0027device\u0027].replace(\u0027/dev/\u0027, \u0027\u0027)"},{"line_number":108,"context_line":"            self.assertIn(device_name_to_match, disks)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.servers_client.detach_volume(server[\u0027id\u0027], attachment[\u0027volumeId\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ba6547e3","line":107,"range":{"start_line":107,"start_character":55,"end_line":107,"end_character":76},"in_reply_to":"3fa7e38b_8914cf42","updated":"2019-11-18 14:47:07.000000000","message":"Apologies, as discussed this isn\u0027t the case, lsblk only lists the name and not the full path.","commit_id":"d3ce8ffa1172e30def2762c09fa42cff7fae0023"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a25796070fd554ca8137ae4318d58b02fda499dc","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            disk_list_after_attach \u003d ["},{"line_number":107,"context_line":"                line[0] for line"},{"line_number":108,"context_line":"                in [device_name.split() for device_name in disks.splitlines()]]"},{"line_number":109,"context_line":"            self.assertGreater(disk_list_after_attach, disk_list_before_attach)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        self.servers_client.detach_volume(server[\u0027id\u0027], attachment[\u0027volumeId\u0027])"},{"line_number":112,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_b35b1484","line":109,"range":{"start_line":109,"start_character":11,"end_line":109,"end_character":79},"updated":"2019-11-20 12:16:44.000000000","message":"i would feel more comfortabel asserting the lenght is larger then the list directly. im not sure if it will do a comparison of all the items or just the lenghts.","commit_id":"912457abb8c6be8c2b811b045dd71fbc1a528f28"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"79df317bd667abb82edc4a3970451282ca6ad33b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            disk_list_after_attach \u003d ["},{"line_number":107,"context_line":"                line[0] for line"},{"line_number":108,"context_line":"                in [device_name.split() for device_name in disks.splitlines()]]"},{"line_number":109,"context_line":"            self.assertGreater(disk_list_after_attach, disk_list_before_attach)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        self.servers_client.detach_volume(server[\u0027id\u0027], attachment[\u0027volumeId\u0027])"},{"line_number":112,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_bed19b31","line":109,"range":{"start_line":109,"start_character":11,"end_line":109,"end_character":79},"in_reply_to":"3fa7e38b_b35b1484","updated":"2019-11-20 12:55:28.000000000","message":"Done","commit_id":"912457abb8c6be8c2b811b045dd71fbc1a528f28"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"e2ba86c6cc7b467213ad188f395b0d70ea0cb0d1","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            # NOTE(andreaf) We need to ensure the ssh key has been"},{"line_number":80,"context_line":"            # injected in the guest before we power cycle"},{"line_number":81,"context_line":"            linux_client.validate_authentication()"},{"line_number":82,"context_line":"            disks \u003d linux_client.get_disks()"},{"line_number":83,"context_line":"            disk_list_before_attach \u003d ["},{"line_number":84,"context_line":"                line[0] for line"},{"line_number":85,"context_line":"                in [device_name.split() for device_name in disks.splitlines()]]"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        volume \u003d self.create_volume()"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_8456d05d","line":85,"range":{"start_line":82,"start_character":0,"end_line":85,"end_character":79},"updated":"2019-11-20 15:32:32.000000000","message":"Can you replace this with a single method in the client that we call instead of get_disks? That way we can also have unit tests asserting the behaviour of this logic.","commit_id":"830900a9414002a831b8c033508632c4a6c5ecc5"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"2a4108fcda2c9be592b6f21807c7058977157349","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            # NOTE(andreaf) We need to ensure the ssh key has been"},{"line_number":80,"context_line":"            # injected in the guest before we power cycle"},{"line_number":81,"context_line":"            linux_client.validate_authentication()"},{"line_number":82,"context_line":"            disks \u003d linux_client.get_disks()"},{"line_number":83,"context_line":"            disk_list_before_attach \u003d ["},{"line_number":84,"context_line":"                line[0] for line"},{"line_number":85,"context_line":"                in [device_name.split() for device_name in disks.splitlines()]]"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        volume \u003d self.create_volume()"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_6409542f","line":85,"range":{"start_line":82,"start_character":0,"end_line":85,"end_character":79},"in_reply_to":"3fa7e38b_8456d05d","updated":"2019-11-20 15:43:34.000000000","message":"We can create one test case that return the disk list using the same lsblk command get_disk() is using , if that\u0027s what you mean? As we already have get_disk() that is exactly using the same lsblk command in client so I thought of not creating the new one and just modifying the output according to our need here!","commit_id":"830900a9414002a831b8c033508632c4a6c5ecc5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6addc3ffe9fd51139417fb8444861e47ec08e069","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            # NOTE(andreaf) We need to ensure the ssh key has been"},{"line_number":80,"context_line":"            # injected in the guest before we power cycle"},{"line_number":81,"context_line":"            linux_client.validate_authentication()"},{"line_number":82,"context_line":"            disks \u003d linux_client.get_disks()"},{"line_number":83,"context_line":"            disk_list_before_attach \u003d ["},{"line_number":84,"context_line":"                line[0] for line"},{"line_number":85,"context_line":"                in [device_name.split() for device_name in disks.splitlines()]]"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        volume \u003d self.create_volume()"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_1f146940","line":85,"range":{"start_line":82,"start_character":0,"end_line":85,"end_character":79},"in_reply_to":"3fa7e38b_8456d05d","updated":"2019-11-20 15:43:20.000000000","message":"ya that kind of make sense\ni guess this could be a list_disk() function that returns the list of disk names.","commit_id":"830900a9414002a831b8c033508632c4a6c5ecc5"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"e2ba86c6cc7b467213ad188f395b0d70ea0cb0d1","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        volume \u003d self.create_volume()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        # NOTE: As of the 12.0.0 Liberty release, the Nova libvirt driver"},{"line_number":90,"context_line":"        # no longer honors a user-supplied device name, and there can be"},{"line_number":91,"context_line":"        # a mismatch between libvirt provide disk name and actual disk name"},{"line_number":92,"context_line":"        # on instance, hence modified the test acc."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        attachment \u003d self.attach_volume(server, volume)"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_a4d0acc9","line":92,"range":{"start_line":90,"start_character":56,"end_line":92,"end_character":51},"updated":"2019-11-20 15:32:32.000000000","message":"I don\u0027t understand what you\u0027re trying to say here. I think it would better to just highlight that as a result we no longer check for the device using the supplied device name and instead count the number of attached devices before and after the attachment call.","commit_id":"830900a9414002a831b8c033508632c4a6c5ecc5"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"2a4108fcda2c9be592b6f21807c7058977157349","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        volume \u003d self.create_volume()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        # NOTE: As of the 12.0.0 Liberty release, the Nova libvirt driver"},{"line_number":90,"context_line":"        # no longer honors a user-supplied device name, and there can be"},{"line_number":91,"context_line":"        # a mismatch between libvirt provide disk name and actual disk name"},{"line_number":92,"context_line":"        # on instance, hence modified the test acc."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        attachment \u003d self.attach_volume(server, volume)"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_7f031d0d","line":92,"range":{"start_line":90,"start_character":56,"end_line":92,"end_character":51},"in_reply_to":"3fa7e38b_a4d0acc9","updated":"2019-11-20 15:43:34.000000000","message":"I can modify the language here","commit_id":"830900a9414002a831b8c033508632c4a6c5ecc5"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"81edb7dfdb8bf93a83a7cb4a42e403c194468b2f","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        if CONF.validation.run_validation:"},{"line_number":104,"context_line":"            disks_list_after_attach \u003d linux_client.list_disks()"},{"line_number":105,"context_line":"            self.assertGreater("},{"line_number":106,"context_line":"                len(disks_list_after_attach),"},{"line_number":107,"context_line":"                len(disks_list_before_attach))"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        self.servers_client.detach_volume(server[\u0027id\u0027], attachment[\u0027volumeId\u0027])"},{"line_number":110,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_9c4b7226","line":107,"range":{"start_line":105,"start_character":0,"end_line":107,"end_character":45},"updated":"2019-11-21 16:12:10.000000000","message":"Returning a basic disk count would simplify this obviously.","commit_id":"bc4517bb33672bb274b3005b3ba8ab90e11c538e"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"6811e9ec96d44ff2cc0ac418dfa8fe11dd38f75a","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        if CONF.validation.run_validation:"},{"line_number":104,"context_line":"            disks_list_after_attach \u003d linux_client.list_disks()"},{"line_number":105,"context_line":"            self.assertGreater("},{"line_number":106,"context_line":"                len(disks_list_after_attach),"},{"line_number":107,"context_line":"                len(disks_list_before_attach))"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        self.servers_client.detach_volume(server[\u0027id\u0027], attachment[\u0027volumeId\u0027])"},{"line_number":110,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_d773037f","line":107,"range":{"start_line":105,"start_character":0,"end_line":107,"end_character":45},"in_reply_to":"3fa7e38b_9c4b7226","updated":"2019-11-21 16:39:03.000000000","message":"sure","commit_id":"bc4517bb33672bb274b3005b3ba8ab90e11c538e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"df1362f59acb40e1b267a0b1e396943fed3980c3","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        if CONF.validation.run_validation:"},{"line_number":104,"context_line":"            disks_after_attach \u003d linux_client.count_disks()"},{"line_number":105,"context_line":"            self.assertGreater(disks_after_attach, disks_before_attach)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        self.servers_client.detach_volume(server[\u0027id\u0027], attachment[\u0027volumeId\u0027])"},{"line_number":108,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_e34e7094","line":105,"range":{"start_line":104,"start_character":0,"end_line":105,"end_character":71},"updated":"2019-11-22 17:59:05.000000000","message":"agree to count the disk in this tests as the created server is local here and no other tests will attach the disk to that.","commit_id":"acb61a36829ed67508a83cb64ac29aeac5a956cc"}],"tempest/common/utils/linux/remote_client.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"81edb7dfdb8bf93a83a7cb4a42e403c194468b2f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            msg \u003d \"\u0027TYPE\u0027 column is required but the output doesn\u0027t have it: \""},{"line_number":74,"context_line":"            raise tempest.lib.exceptions.TempestException(msg + output)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def list_disks(self):"},{"line_number":77,"context_line":"        disks_list \u003d self.get_disks()"},{"line_number":78,"context_line":"        disks_list \u003d [line[0] for line in"},{"line_number":79,"context_line":"                      [device_name.split()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_1c40e205","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":18},"updated":"2019-11-21 16:12:10.000000000","message":"I\u0027d prefer if this just returned a count, the above method can be used if we needed more detail.","commit_id":"bc4517bb33672bb274b3005b3ba8ab90e11c538e"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"6811e9ec96d44ff2cc0ac418dfa8fe11dd38f75a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            msg \u003d \"\u0027TYPE\u0027 column is required but the output doesn\u0027t have it: \""},{"line_number":74,"context_line":"            raise tempest.lib.exceptions.TempestException(msg + output)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def list_disks(self):"},{"line_number":77,"context_line":"        disks_list \u003d self.get_disks()"},{"line_number":78,"context_line":"        disks_list \u003d [line[0] for line in"},{"line_number":79,"context_line":"                      [device_name.split()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_173d1b8d","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":18},"in_reply_to":"3fa7e38b_1c40e205","updated":"2019-11-21 16:39:03.000000000","message":"I can do that","commit_id":"bc4517bb33672bb274b3005b3ba8ab90e11c538e"}],"tempest/tests/common/utils/linux/test_remote_client.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4c96b360d4d434a82dba46642ba322907a18cd34","unresolved":false,"context_lines":[{"line_number":112,"context_line":"sda          8:0       0  128035676160  0 disk"},{"line_number":113,"context_line":"sdb          8:16      0 1000204886016  0 disk"},{"line_number":114,"context_line":"sr0         11:0       1    1073741312  0 rom\"\"\""},{"line_number":115,"context_line":"        result \u003d 2"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        self.ssh_mock.mock.exec_command.return_value \u003d output_lsblk"},{"line_number":118,"context_line":"        self.assertEqual(self.conn.count_disks(), result)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_ba52dc10","line":115,"range":{"start_line":115,"start_character":1,"end_line":115,"end_character":18},"updated":"2019-11-22 15:53:24.000000000","message":"You don\u0027t need this.","commit_id":"cfdb0376351a7638e120d4c16d36edd55a07b0a2"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4c96b360d4d434a82dba46642ba322907a18cd34","unresolved":false,"context_lines":[{"line_number":113,"context_line":"sdb          8:16      0 1000204886016  0 disk"},{"line_number":114,"context_line":"sr0         11:0       1    1073741312  0 rom\"\"\""},{"line_number":115,"context_line":"        result \u003d 2"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        self.ssh_mock.mock.exec_command.return_value \u003d output_lsblk"},{"line_number":118,"context_line":"        self.assertEqual(self.conn.count_disks(), result)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_7a40e435","line":116,"updated":"2019-11-22 15:53:24.000000000","message":"whitespace","commit_id":"cfdb0376351a7638e120d4c16d36edd55a07b0a2"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4c96b360d4d434a82dba46642ba322907a18cd34","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        result \u003d 2"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        self.ssh_mock.mock.exec_command.return_value \u003d output_lsblk"},{"line_number":118,"context_line":"        self.assertEqual(self.conn.count_disks(), result)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_get_boot_time(self):"},{"line_number":121,"context_line":"        booted_at \u003d 10000"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_9a3b60c6","line":118,"range":{"start_line":118,"start_character":50,"end_line":118,"end_character":56},"updated":"2019-11-22 15:53:24.000000000","message":"2","commit_id":"cfdb0376351a7638e120d4c16d36edd55a07b0a2"}]}