)]}'
{"tempest/scenario/test_volume_boot_pattern.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fea6cee6e46db98b4fabd920a54b248189f652bb","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        created_volume \u003d server_info[\u0027os-extended-volumes:volumes_attached\u0027]"},{"line_number":298,"context_line":"        self.assertEqual(volume[\u0027id\u0027], created_volume[0][\u0027id\u0027])"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    @decorators.idempotent_id(\u0027da57a92c-adc3-4234-9b8f-e3450979cf29\u0027)"},{"line_number":301,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.attach_encrypted_volume,"},{"line_number":302,"context_line":"                          \u0027Encrypted volume attach is not supported\u0027)"},{"line_number":303,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0c3ba9d0","line":300,"updated":"2019-11-25 16:56:42.000000000","message":"Shouldn\u0027t this be marked \u0027slow\u0027? Doesn\u0027t anything involving encrypted volumes take a bit?","commit_id":"02a109df1364171ea15470cb049cb66a3f5506b7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"211a5e71ce021508feded40085a2aefaa5aa404c","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        created_volume \u003d server_info[\u0027os-extended-volumes:volumes_attached\u0027]"},{"line_number":298,"context_line":"        self.assertEqual(volume[\u0027id\u0027], created_volume[0][\u0027id\u0027])"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    @decorators.idempotent_id(\u0027da57a92c-adc3-4234-9b8f-e3450979cf29\u0027)"},{"line_number":301,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.attach_encrypted_volume,"},{"line_number":302,"context_line":"                          \u0027Encrypted volume attach is not supported\u0027)"},{"line_number":303,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0cae49e6","line":300,"in_reply_to":"3fa7e38b_0c3ba9d0","updated":"2019-11-25 17:00:58.000000000","message":"I guess it\u0027s not actually that slow:\n\n2019-11-22 13:32:38.047818 | controller | {0} tempest.scenario.test_volume_boot_pattern.TestVolumeBootPattern.test_boot_server_from_encrypted_snapshot_luks [25.930995s] ... ok\n\nWell, I\u0027m not sure what the QA team considers \"slow\" but I would generally only start applying that tag for tests that take longer than 60 seconds.","commit_id":"02a109df1364171ea15470cb049cb66a3f5506b7"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"24872e6d2c1dd261f7349d302be7fe393efeaed8","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        self.assertEqual(volume[\u0027id\u0027], created_volume[0][\u0027id\u0027])"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    @decorators.idempotent_id(\u0027da57a92c-adc3-4234-9b8f-e3450979cf29\u0027)"},{"line_number":301,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.attach_encrypted_volume,"},{"line_number":302,"context_line":"                          \u0027Encrypted volume attach is not supported\u0027)"},{"line_number":303,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"},{"line_number":304,"context_line":"                          \u0027Cinder volume snapshots are disabled\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_5e193c85","line":301,"range":{"start_line":301,"start_character":55,"end_line":301,"end_character":78},"updated":"2019-11-26 07:58:09.000000000","message":"is attach_encrypted_volume required for booting server from encrypted snapshot?","commit_id":"02a109df1364171ea15470cb049cb66a3f5506b7"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"03be845d5b9eb4d595d6e3e8d35e23e753322d58","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        self.assertEqual(volume[\u0027id\u0027], created_volume[0][\u0027id\u0027])"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    @decorators.idempotent_id(\u0027da57a92c-adc3-4234-9b8f-e3450979cf29\u0027)"},{"line_number":301,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.attach_encrypted_volume,"},{"line_number":302,"context_line":"                          \u0027Encrypted volume attach is not supported\u0027)"},{"line_number":303,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"},{"line_number":304,"context_line":"                          \u0027Cinder volume snapshots are disabled\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a4de2268","line":301,"range":{"start_line":301,"start_character":55,"end_line":301,"end_character":78},"in_reply_to":"3fa7e38b_5e193c85","updated":"2019-11-26 08:22:39.000000000","message":"Yes, this test will exercise most of the same codepaths as a normal attachment of an encrypted volume to an already running instance. I don\u0027t think we need another compute_feature just for booting from an encrypted volume.","commit_id":"02a109df1364171ea15470cb049cb66a3f5506b7"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"026112f7be7cbdf3b194524528518394373bf116","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"},{"line_number":275,"context_line":"                          \u0027Cinder volume snapshots are disabled\u0027)"},{"line_number":276,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027)"},{"line_number":277,"context_line":"    def test_boot_server_from_encrypted_snapshot_luks(self):"},{"line_number":278,"context_line":"        volume \u003d self.create_encrypted_volume(\u0027nova.volume.encryptors.\u0027"},{"line_number":279,"context_line":"                                              \u0027luks.LuksEncryptor\u0027,"},{"line_number":280,"context_line":"                                              volume_type\u003d\u0027luks\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_87273cb7","line":277,"updated":"2020-04-21 14:56:08.000000000","message":"Please create encrypted volume from the image, otherwise, you create an empty volume and nova boot has no meaning. you will try to load an empty device. I think you should verify that nova boot has done successfully","commit_id":"63b57aebf0d331d110222178499a5027edf652de"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c1143b29b608c0977b81ab10751d89ec11ebe349","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"},{"line_number":275,"context_line":"                          \u0027Cinder volume snapshots are disabled\u0027)"},{"line_number":276,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027)"},{"line_number":277,"context_line":"    def test_boot_server_from_encrypted_snapshot_luks(self):"},{"line_number":278,"context_line":"        volume \u003d self.create_encrypted_volume(\u0027nova.volume.encryptors.\u0027"},{"line_number":279,"context_line":"                                              \u0027luks.LuksEncryptor\u0027,"},{"line_number":280,"context_line":"                                              volume_type\u003d\u0027luks\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_c2b132e4","line":277,"in_reply_to":"1f493fa4_87273cb7","updated":"2020-04-21 15:54:57.000000000","message":"It actually exercises a huge amount of code without creating the encrypted volume from an image. The fact that the instance has launched and is ACTIVE is more than enough for this test IMHO.\n\nGiven this is an API test and not a scenario test I wanted to keep this light and avoid any validation within the instance that\u0027s often the source of failures in the gate.","commit_id":"63b57aebf0d331d110222178499a5027edf652de"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"067e73a3a6c020e0b1200bbd5110546ffe5ba0ba","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        volume \u003d self.create_encrypted_volume(\u0027nova.volume.encryptors.\u0027"},{"line_number":279,"context_line":"                                              \u0027luks.LuksEncryptor\u0027,"},{"line_number":280,"context_line":"                                              volume_type\u003d\u0027luks\u0027)"},{"line_number":281,"context_line":"        self.volumes_client.set_bootable_volume(volume[\u0027id\u0027], bootable\u003dTrue)"},{"line_number":282,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume[\u0027id\u0027])"},{"line_number":283,"context_line":"        self.boot_instance_from_resource(source_id\u003dsnapshot[\u0027id\u0027],"},{"line_number":284,"context_line":"                                         source_type\u003d\u0027snapshot\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_ed95e7e5","line":281,"updated":"2020-04-17 16:56:38.000000000","message":"All looks good, but Isn\u0027t it good if we can create a bootable volume from image and then use that too boot an instance ??","commit_id":"63b57aebf0d331d110222178499a5027edf652de"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"2ff5bd0e90a5b0ee50b248a0e2650d6c40fb54be","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        volume \u003d self.create_encrypted_volume(\u0027nova.volume.encryptors.\u0027"},{"line_number":279,"context_line":"                                              \u0027luks.LuksEncryptor\u0027,"},{"line_number":280,"context_line":"                                              volume_type\u003d\u0027luks\u0027)"},{"line_number":281,"context_line":"        self.volumes_client.set_bootable_volume(volume[\u0027id\u0027], bootable\u003dTrue)"},{"line_number":282,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume[\u0027id\u0027])"},{"line_number":283,"context_line":"        self.boot_instance_from_resource(source_id\u003dsnapshot[\u0027id\u0027],"},{"line_number":284,"context_line":"                                         source_type\u003d\u0027snapshot\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_4e2f16f6","line":281,"in_reply_to":"3f4c43b2_ed95e7e5","updated":"2020-04-21 08:30:28.000000000","message":"The volume would still need to be marked as bootable and as we aren\u0027t ssh\u0027ing into the eventual instance I didn\u0027t see the need to create the encrypted volume from the image here tbh.\n\nThis test is really just exercising the code path from bug #1853495, if others want to add additional validation that\u0027s fine but I\u0027d rather it be done as a follow up to this.","commit_id":"63b57aebf0d331d110222178499a5027edf652de"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"026112f7be7cbdf3b194524528518394373bf116","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                                              volume_type\u003d\u0027luks\u0027)"},{"line_number":281,"context_line":"        self.volumes_client.set_bootable_volume(volume[\u0027id\u0027], bootable\u003dTrue)"},{"line_number":282,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume[\u0027id\u0027])"},{"line_number":283,"context_line":"        self.boot_instance_from_resource(source_id\u003dsnapshot[\u0027id\u0027],"},{"line_number":284,"context_line":"                                         source_type\u003d\u0027snapshot\u0027,"},{"line_number":285,"context_line":"                                         delete_on_termination\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_679f90b4","line":283,"updated":"2020-04-21 14:56:08.000000000","message":"Once you boot the instance from snapshot with data , please verify nova shows : ( i dont remember the flags )","commit_id":"63b57aebf0d331d110222178499a5027edf652de"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c1143b29b608c0977b81ab10751d89ec11ebe349","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                                              volume_type\u003d\u0027luks\u0027)"},{"line_number":281,"context_line":"        self.volumes_client.set_bootable_volume(volume[\u0027id\u0027], bootable\u003dTrue)"},{"line_number":282,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume[\u0027id\u0027])"},{"line_number":283,"context_line":"        self.boot_instance_from_resource(source_id\u003dsnapshot[\u0027id\u0027],"},{"line_number":284,"context_line":"                                         source_type\u003d\u0027snapshot\u0027,"},{"line_number":285,"context_line":"                                         delete_on_termination\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_424882cb","line":283,"in_reply_to":"1f493fa4_679f90b4","updated":"2020-04-21 15:54:57.000000000","message":"We can\u0027t validate that here, this request results in Nova itself creating a fresh volume from the snapshot and using that. As a result we don\u0027t know the details of the volume ahead of time.\n\nI can assert that the instance is booting from a volume but that\u0027s about it here.","commit_id":"63b57aebf0d331d110222178499a5027edf652de"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"026112f7be7cbdf3b194524528518394373bf116","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        self.volumes_client.set_bootable_volume(volume[\u0027id\u0027], bootable\u003dTrue)"},{"line_number":282,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume[\u0027id\u0027])"},{"line_number":283,"context_line":"        self.boot_instance_from_resource(source_id\u003dsnapshot[\u0027id\u0027],"},{"line_number":284,"context_line":"                                         source_type\u003d\u0027snapshot\u0027,"},{"line_number":285,"context_line":"                                         delete_on_termination\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_27b58832","line":284,"updated":"2020-04-21 14:56:08.000000000","message":"Once the instance is \"up\" and running, please send a ping to verify that the cirros image is up and running.","commit_id":"63b57aebf0d331d110222178499a5027edf652de"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c1143b29b608c0977b81ab10751d89ec11ebe349","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        self.volumes_client.set_bootable_volume(volume[\u0027id\u0027], bootable\u003dTrue)"},{"line_number":282,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume[\u0027id\u0027])"},{"line_number":283,"context_line":"        self.boot_instance_from_resource(source_id\u003dsnapshot[\u0027id\u0027],"},{"line_number":284,"context_line":"                                         source_type\u003d\u0027snapshot\u0027,"},{"line_number":285,"context_line":"                                         delete_on_termination\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_4221a2fb","line":284,"in_reply_to":"1f493fa4_27b58832","updated":"2020-04-21 15:54:57.000000000","message":"Again I think this is pointless and error prone in API tests.","commit_id":"63b57aebf0d331d110222178499a5027edf652de"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ef3a77530fe650a7f803cffbe054388b979e87ae","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume[\u0027id\u0027])"},{"line_number":283,"context_line":"        self.boot_instance_from_resource(source_id\u003dsnapshot[\u0027id\u0027],"},{"line_number":284,"context_line":"                                         source_type\u003d\u0027snapshot\u0027,"},{"line_number":285,"context_line":"                                         delete_on_termination\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_027aa7ef","line":285,"range":{"start_line":285,"start_character":68,"end_line":285,"end_character":68},"updated":"2020-04-17 10:52:48.000000000","message":"does it make sense to add here a similar assertEqual as is on line 269 but for snapshot or any other check confirming that the server was booted from the snapshot?","commit_id":"63b57aebf0d331d110222178499a5027edf652de"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"df863257a8da0abd692fbc225d5b0bbcc287b954","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume[\u0027id\u0027])"},{"line_number":283,"context_line":"        self.boot_instance_from_resource(source_id\u003dsnapshot[\u0027id\u0027],"},{"line_number":284,"context_line":"                                         source_type\u003d\u0027snapshot\u0027,"},{"line_number":285,"context_line":"                                         delete_on_termination\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_d56357b0","line":285,"range":{"start_line":285,"start_character":68,"end_line":285,"end_character":68},"in_reply_to":"3f4c43b2_027aa7ef","updated":"2020-04-17 11:36:56.000000000","message":"No not in this case, we don\u0027t know the volume_id ahead of time as Nova actually creates a volume for us from the volume snapshot.","commit_id":"63b57aebf0d331d110222178499a5027edf652de"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"13cc27b43379ab123bbe8152cc3a96034f4e9e54","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume[\u0027id\u0027])"},{"line_number":283,"context_line":"        self.boot_instance_from_resource(source_id\u003dsnapshot[\u0027id\u0027],"},{"line_number":284,"context_line":"                                         source_type\u003d\u0027snapshot\u0027,"},{"line_number":285,"context_line":"                                         delete_on_termination\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_d850ae0d","line":285,"range":{"start_line":285,"start_character":68,"end_line":285,"end_character":68},"in_reply_to":"3f4c43b2_d56357b0","updated":"2020-04-17 12:18:51.000000000","message":"I see, thanks","commit_id":"63b57aebf0d331d110222178499a5027edf652de"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"026112f7be7cbdf3b194524528518394373bf116","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume[\u0027id\u0027])"},{"line_number":283,"context_line":"        self.boot_instance_from_resource(source_id\u003dsnapshot[\u0027id\u0027],"},{"line_number":284,"context_line":"                                         source_type\u003d\u0027snapshot\u0027,"},{"line_number":285,"context_line":"                                         delete_on_termination\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_278e2878","line":285,"range":{"start_line":285,"start_character":68,"end_line":285,"end_character":68},"in_reply_to":"3f4c43b2_d850ae0d","updated":"2020-04-21 14:56:08.000000000","message":"Nice to have: try to write data to the instances (volume) , verify that the data is valid and booting the instance again wilh the written data.","commit_id":"63b57aebf0d331d110222178499a5027edf652de"}]}