)]}'
{"tempest/api/network/admin/test_metering.py":[{"author":{"_account_id":8085,"name":"anju Tiwari","email":"anjutiwari5@gmail.com","username":"Anju"},"change_message_id":"5557ec59a85929050f2a0f2caeecb852d548d0ae","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        # Creates a metering label"},{"line_number":78,"context_line":"        name \u003d data_utils.rand_name(\u0027test-metering-label-\u0027)"},{"line_number":79,"context_line":"        resp, created_body \u003d self.admin_client.create_metering_label(name\u003dname)"},{"line_number":80,"context_line":"        created_body \u003d created_body[\u0027metering_label\u0027]"},{"line_number":81,"context_line":"        self.addCleanup(self._delete_metering_label, created_body[\u0027id\u0027])"},{"line_number":82,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":83,"context_line":"        # List all metering label list"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BSic%3D","line":80,"updated":"2014-01-28 11:15:57.000000000","message":"Please use a different variable other than created_body.","commit_id":"44de7dd9e52400cde6c01bef5cd243baa504e082"},{"author":{"_account_id":8085,"name":"anju Tiwari","email":"anjutiwari5@gmail.com","username":"Anju"},"change_message_id":"5557ec59a85929050f2a0f2caeecb852d548d0ae","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        # Creates a metering label"},{"line_number":108,"context_line":"        name \u003d data_utils.rand_name(\u0027test-metering-label-\u0027)"},{"line_number":109,"context_line":"        resp, created_label \u003d self.admin_client.create_metering_label(name\u003dname)"},{"line_number":110,"context_line":"        created_label \u003d created_label[\u0027metering_label\u0027]"},{"line_number":111,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":112,"context_line":"        # Creates a metering label rule"},{"line_number":113,"context_line":"        name \u003d data_utils.rand_name(\u0027test-metering-label-rule-\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BSiI%3D","line":110,"updated":"2014-01-28 11:15:57.000000000","message":"ditto","commit_id":"44de7dd9e52400cde6c01bef5cd243baa504e082"},{"author":{"_account_id":8085,"name":"anju Tiwari","email":"anjutiwari5@gmail.com","username":"Anju"},"change_message_id":"5557ec59a85929050f2a0f2caeecb852d548d0ae","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                                 metering_label_id\u003dcreated_label[\u0027id\u0027],"},{"line_number":116,"context_line":"                                 remote_ip_prefix\u003d\u002710.0.1.0/24\u0027,"},{"line_number":117,"context_line":"                                 direction \u003d \u0027ingress\u0027)"},{"line_number":118,"context_line":"        created_body \u003d created_body[\u0027metering_label_rule\u0027]"},{"line_number":119,"context_line":"        self.addCleanup(self._delete_metering_label_rule, created_body[\u0027id\u0027])"},{"line_number":120,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":121,"context_line":"        # List all metering label rule list"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BSgg%3D","line":118,"updated":"2014-01-28 11:15:57.000000000","message":"ditto","commit_id":"44de7dd9e52400cde6c01bef5cd243baa504e082"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"20acf7cec96c4fc54c763efaeb82e35a6cd3c0f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BNCY%3D","line":1,"updated":"2014-01-29 04:02:06.000000000","message":"please remove this vim line.\n\nWe have removed a lot of this line already.","commit_id":"5f9b1c719af56da269d915668bfaf76e6841383c"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"048e044816719b370c64f957069362ba3868772b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BLfw%3D","line":1,"in_reply_to":"AAAAUH%2F%2BNCY%3D","updated":"2014-01-29 11:36:08.000000000","message":"Removed in patch#3","commit_id":"5f9b1c719af56da269d915668bfaf76e6841383c"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"9ac65e189283611daaff75927c827e695244826b","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.api.network import base"},{"line_number":19,"context_line":"from tempest.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest.test import attr"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class MeterTestJSON(base.BaseAdminNetworkTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BR%2Fk%3D","line":20,"updated":"2014-01-28 12:51:54.000000000","message":"I think we should import a module here.","commit_id":"5f9b1c719af56da269d915668bfaf76e6841383c"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"048e044816719b370c64f957069362ba3868772b","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.api.network import base"},{"line_number":19,"context_line":"from tempest.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest.test import attr"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class MeterTestJSON(base.BaseAdminNetworkTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BLfg%3D","line":20,"in_reply_to":"AAAAUH%2F%2BM2M%3D","updated":"2014-01-29 11:36:08.000000000","message":"completed in patch#3","commit_id":"5f9b1c719af56da269d915668bfaf76e6841383c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8c577044838611705b8019666bb6e698a729dee6","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.api.network import base"},{"line_number":19,"context_line":"from tempest.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest.test import attr"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class MeterTestJSON(base.BaseAdminNetworkTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BM2M%3D","line":20,"in_reply_to":"AAAAUH%2F%2BNAg%3D","updated":"2014-01-29 04:54:55.000000000","message":"attr is not module.\nhere should be:\n\n from tempest import test\n\nhttp://docs.openstack.org/developer/hacking/#imports","commit_id":"5f9b1c719af56da269d915668bfaf76e6841383c"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"68e1c0349c70e66929eeec50739c862367675965","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.api.network import base"},{"line_number":19,"context_line":"from tempest.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest.test import attr"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class MeterTestJSON(base.BaseAdminNetworkTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BNAg%3D","line":20,"in_reply_to":"AAAAUH%2F%2BND0%3D","updated":"2014-01-29 04:47:29.000000000","message":"which module you are talking to import ?","commit_id":"5f9b1c719af56da269d915668bfaf76e6841383c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"20acf7cec96c4fc54c763efaeb82e35a6cd3c0f4","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.api.network import base"},{"line_number":19,"context_line":"from tempest.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest.test import attr"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class MeterTestJSON(base.BaseAdminNetworkTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BND0%3D","line":20,"in_reply_to":"AAAAUH%2F%2BR%2Fk%3D","updated":"2014-01-29 04:02:06.000000000","message":"Yes, right.","commit_id":"5f9b1c719af56da269d915668bfaf76e6841383c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"20acf7cec96c4fc54c763efaeb82e35a6cd3c0f4","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def setUpClass(cls):"},{"line_number":42,"context_line":"        super(MeterTestJSON, cls).setUpClass()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _delete_metering_label(self, label_id):"},{"line_number":45,"context_line":"        # Deletes a metering label and verifies if it is deleted or not"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BNCU%3D","line":42,"updated":"2014-01-29 04:02:06.000000000","message":"This setUpClass seems unnecessary, because it just calls BaseAdminNetworkTest setUpClass()","commit_id":"5f9b1c719af56da269d915668bfaf76e6841383c"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"68e1c0349c70e66929eeec50739c862367675965","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def setUpClass(cls):"},{"line_number":42,"context_line":"        super(MeterTestJSON, cls).setUpClass()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _delete_metering_label(self, label_id):"},{"line_number":45,"context_line":"        # Deletes a metering label and verifies if it is deleted or not"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BNAQ%3D","line":42,"in_reply_to":"AAAAUH%2F%2BNCU%3D","updated":"2014-01-29 04:47:29.000000000","message":"Yes correct.","commit_id":"5f9b1c719af56da269d915668bfaf76e6841383c"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"cc20fe0908866e78c93f989d8a0b08a187dfaaa9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        # Verify the metering label exists in the list of all lables"},{"line_number":89,"context_line":"        found \u003d None"},{"line_number":90,"context_line":"        for n in label_list:"},{"line_number":91,"context_line":"            if (n[\u0027id\u0027] \u003d\u003d created_body[\u0027id\u0027]):"},{"line_number":92,"context_line":"                found \u003d n[\u0027id\u0027]"},{"line_number":93,"context_line":"        self.assertIsNotNone(found, \"list doesn\u0027t contain created label\")"},{"line_number":94,"context_line":"        # Show created metering label"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BLnM%3D","line":91,"updated":"2014-01-29 11:09:41.000000000","message":"Why do you use parentheses here? They are not necessary.","commit_id":"5f9b1c719af56da269d915668bfaf76e6841383c"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"048e044816719b370c64f957069362ba3868772b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        # Verify the metering label exists in the list of all lables"},{"line_number":89,"context_line":"        found \u003d None"},{"line_number":90,"context_line":"        for n in label_list:"},{"line_number":91,"context_line":"            if (n[\u0027id\u0027] \u003d\u003d created_body[\u0027id\u0027]):"},{"line_number":92,"context_line":"                found \u003d n[\u0027id\u0027]"},{"line_number":93,"context_line":"        self.assertIsNotNone(found, \"list doesn\u0027t contain created label\")"},{"line_number":94,"context_line":"        # Show created metering label"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BLfY%3D","line":91,"in_reply_to":"AAAAUH%2F%2BLnM%3D","updated":"2014-01-29 11:36:08.000000000","message":"Incorporated in patch#3","commit_id":"5f9b1c719af56da269d915668bfaf76e6841383c"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"cc20fe0908866e78c93f989d8a0b08a187dfaaa9","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        for n in label_list:"},{"line_number":91,"context_line":"            if (n[\u0027id\u0027] \u003d\u003d created_body[\u0027id\u0027]):"},{"line_number":92,"context_line":"                found \u003d n[\u0027id\u0027]"},{"line_number":93,"context_line":"        self.assertIsNotNone(found, \"list doesn\u0027t contain created label\")"},{"line_number":94,"context_line":"        # Show created metering label"},{"line_number":95,"context_line":"        resp, body \u003d self.admin_client.show_metering_label(created_body[\u0027id\u0027])"},{"line_number":96,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BLn0%3D","line":93,"updated":"2014-01-29 11:09:41.000000000","message":"I wonder why don\u0027t you check this using\n\n     self.assertIn(created_body[\u0027id\u0027], [n[\u0027id\u0027] for n in label_list])?","commit_id":"5f9b1c719af56da269d915668bfaf76e6841383c"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"048e044816719b370c64f957069362ba3868772b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        for n in label_list:"},{"line_number":91,"context_line":"            if (n[\u0027id\u0027] \u003d\u003d created_body[\u0027id\u0027]):"},{"line_number":92,"context_line":"                found \u003d n[\u0027id\u0027]"},{"line_number":93,"context_line":"        self.assertIsNotNone(found, \"list doesn\u0027t contain created label\")"},{"line_number":94,"context_line":"        # Show created metering label"},{"line_number":95,"context_line":"        resp, body \u003d self.admin_client.show_metering_label(created_body[\u0027id\u0027])"},{"line_number":96,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BLfU%3D","line":93,"in_reply_to":"AAAAUH%2F%2BLn0%3D","updated":"2014-01-29 11:36:08.000000000","message":"Incorporated in patch#3","commit_id":"5f9b1c719af56da269d915668bfaf76e6841383c"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"cc20fe0908866e78c93f989d8a0b08a187dfaaa9","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        for n in label_list:"},{"line_number":129,"context_line":"            if (n[\u0027id\u0027] \u003d\u003d created_body[\u0027id\u0027]):"},{"line_number":130,"context_line":"                found \u003d n[\u0027id\u0027]"},{"line_number":131,"context_line":"        self.assertIsNotNone(found, \"list doesn\u0027t contain created label rule\")"},{"line_number":132,"context_line":"        # Show created metering label rule"},{"line_number":133,"context_line":"        resp, show_body \u003d self.admin_client.show_metering_label_rule("},{"line_number":134,"context_line":"            created_body[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BLns%3D","line":131,"updated":"2014-01-29 11:09:41.000000000","message":"And the same here.","commit_id":"5f9b1c719af56da269d915668bfaf76e6841383c"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"048e044816719b370c64f957069362ba3868772b","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        for n in label_list:"},{"line_number":129,"context_line":"            if (n[\u0027id\u0027] \u003d\u003d created_body[\u0027id\u0027]):"},{"line_number":130,"context_line":"                found \u003d n[\u0027id\u0027]"},{"line_number":131,"context_line":"        self.assertIsNotNone(found, \"list doesn\u0027t contain created label rule\")"},{"line_number":132,"context_line":"        # Show created metering label rule"},{"line_number":133,"context_line":"        resp, show_body \u003d self.admin_client.show_metering_label_rule("},{"line_number":134,"context_line":"            created_body[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BLfQ%3D","line":131,"in_reply_to":"AAAAUH%2F%2BLns%3D","updated":"2014-01-29 11:36:08.000000000","message":"Incorporated in patch#3","commit_id":"5f9b1c719af56da269d915668bfaf76e6841383c"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"bf382817d6f139ef99673a762241ed501cd5434f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        resp, all_labels \u003d self.admin_client.list_metering_labels()"},{"line_number":42,"context_line":"        for label in all_labels[\u0027metering_labels\u0027]:"},{"line_number":43,"context_line":"            label_list.append(label[\u0027id\u0027])"},{"line_number":44,"context_line":"        if label_id in label_list:"},{"line_number":45,"context_line":"            resp, _ \u003d self.admin_client.delete_metering_label(label_id)"},{"line_number":46,"context_line":"            self.assertEqual(204, resp.status)"},{"line_number":47,"context_line":"            # Asserting that the label is not found in list after deletion"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BGGA%3D","line":44,"updated":"2014-01-30 06:26:39.000000000","message":"You can create label list:\n\n    label_id \u003d [label[\u0027id\u0027] for label in all_labels[\u0027metering_labels\u0027]]","commit_id":"66c1e6a342d681117a3916661cb92ab0dbc7b6fa"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"636238139d73b99debf41958618fcc1f09c84433","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        resp, all_labels \u003d self.admin_client.list_metering_labels()"},{"line_number":42,"context_line":"        for label in all_labels[\u0027metering_labels\u0027]:"},{"line_number":43,"context_line":"            label_list.append(label[\u0027id\u0027])"},{"line_number":44,"context_line":"        if label_id in label_list:"},{"line_number":45,"context_line":"            resp, _ \u003d self.admin_client.delete_metering_label(label_id)"},{"line_number":46,"context_line":"            self.assertEqual(204, resp.status)"},{"line_number":47,"context_line":"            # Asserting that the label is not found in list after deletion"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BFDs%3D","line":44,"in_reply_to":"AAAAUH%2F%2BGGA%3D","updated":"2014-01-30 11:41:13.000000000","message":"Done","commit_id":"66c1e6a342d681117a3916661cb92ab0dbc7b6fa"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"bf382817d6f139ef99673a762241ed501cd5434f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            resp, all_labels \u003d self.admin_client.list_metering_labels()"},{"line_number":49,"context_line":"            label_id_list \u003d list()"},{"line_number":50,"context_line":"            for i in all_labels[\u0027metering_labels\u0027]:"},{"line_number":51,"context_line":"                label_id_list.append(i[\u0027id\u0027])"},{"line_number":52,"context_line":"            self.assertNotIn(label_id, label_id_list)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _delete_metering_label_rule(self, l_rule_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BGHE%3D","line":51,"updated":"2014-01-30 06:26:39.000000000","message":"this three lines can be moved into one:\n\n    label_id_list \u003d [label[\u0027id\u0027] for label in all_labels[\u0027metering_labels\u0027]]","commit_id":"66c1e6a342d681117a3916661cb92ab0dbc7b6fa"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"636238139d73b99debf41958618fcc1f09c84433","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            resp, all_labels \u003d self.admin_client.list_metering_labels()"},{"line_number":49,"context_line":"            label_id_list \u003d list()"},{"line_number":50,"context_line":"            for i in all_labels[\u0027metering_labels\u0027]:"},{"line_number":51,"context_line":"                label_id_list.append(i[\u0027id\u0027])"},{"line_number":52,"context_line":"            self.assertNotIn(label_id, label_id_list)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _delete_metering_label_rule(self, l_rule_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BFDo%3D","line":51,"in_reply_to":"AAAAUH%2F%2BGHE%3D","updated":"2014-01-30 11:41:13.000000000","message":"Done","commit_id":"66c1e6a342d681117a3916661cb92ab0dbc7b6fa"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"bf382817d6f139ef99673a762241ed501cd5434f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            resp, all_rules \u003d self.admin_client.list_metering_label_rules()"},{"line_number":65,"context_line":"            rule_id_list \u003d list()"},{"line_number":66,"context_line":"            for i in all_rules[\u0027metering_label_rules\u0027]:"},{"line_number":67,"context_line":"                rule_id_list.append(i[\u0027id\u0027])"},{"line_number":68,"context_line":"            self.assertNotIn(l_rule_id, rule_id_list)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BGFk%3D","line":67,"updated":"2014-01-30 06:26:39.000000000","message":"The same here.","commit_id":"66c1e6a342d681117a3916661cb92ab0dbc7b6fa"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"636238139d73b99debf41958618fcc1f09c84433","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            resp, all_rules \u003d self.admin_client.list_metering_label_rules()"},{"line_number":65,"context_line":"            rule_id_list \u003d list()"},{"line_number":66,"context_line":"            for i in all_rules[\u0027metering_label_rules\u0027]:"},{"line_number":67,"context_line":"                rule_id_list.append(i[\u0027id\u0027])"},{"line_number":68,"context_line":"            self.assertNotIn(l_rule_id, rule_id_list)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BFDk%3D","line":67,"in_reply_to":"AAAAUH%2F%2BGFk%3D","updated":"2014-01-30 11:41:13.000000000","message":"Done","commit_id":"66c1e6a342d681117a3916661cb92ab0dbc7b6fa"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"de25ed153e2fb8e3b09144eccacadcb1ad02147e","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        # Verification of metering label rule delete"},{"line_number":125,"context_line":"        resp, body \u003d self.admin_client.delete_metering_label_rule("},{"line_number":126,"context_line":"            show_body[\u0027id\u0027])"},{"line_number":127,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BFBU%3D","line":127,"updated":"2014-01-30 11:52:12.000000000","message":"Why there is no class MeterTestXML?","commit_id":"ef6b84b94fc34206e977c42a4a51862f960ea84f"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"5b19af5b737ecfe6f88330d85370cd2fe54017f3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F9hyU%3D","line":1,"updated":"2014-02-06 11:27:24.000000000","message":"You have to update the year here","commit_id":"15f4716eae1adf7c05ba951391e1b9cf141eb6a6"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"5b19af5b737ecfe6f88330d85370cd2fe54017f3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        if label_id in label_list:"},{"line_number":43,"context_line":"            resp, _ \u003d self.admin_client.delete_metering_label(label_id)"},{"line_number":44,"context_line":"            self.assertEqual(204, resp.status)"},{"line_number":45,"context_line":"            # Asserting that the label is not found in list after deletion"},{"line_number":46,"context_line":"            resp, all_labels \u003d self.admin_client.list_metering_labels()"},{"line_number":47,"context_line":"            id_list \u003d [label[\u0027id\u0027] for label in all_labels[\u0027metering_labels\u0027]]"},{"line_number":48,"context_line":"            self.assertNotIn(label_id, id_list)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F9hTU%3D","line":45,"updated":"2014-02-06 11:27:24.000000000","message":"The purpose of cleanup is cleaning resources after the test has passes or fails. It shouldn\u0027t make any additional checks - their place is in the test itself. So if you want to check that a metering label is not returned by list_...() after deletion you should do it in the test, not here.","commit_id":"15f4716eae1adf7c05ba951391e1b9cf141eb6a6"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"5b19af5b737ecfe6f88330d85370cd2fe54017f3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        if l_rule_id in rules:"},{"line_number":55,"context_line":"            resp, _ \u003d self.admin_client.delete_metering_label_rule(l_rule_id)"},{"line_number":56,"context_line":"            self.assertEqual(204, resp.status)"},{"line_number":57,"context_line":"            # Asserting that the label rule is not found in list after deletion"},{"line_number":58,"context_line":"            resp, rules_ \u003d self.admin_client.list_metering_label_rules()"},{"line_number":59,"context_line":"            rules \u003d [label[\u0027id\u0027] for label in rules_[\u0027metering_label_rules\u0027]]"},{"line_number":60,"context_line":"            self.assertNotIn(l_rule_id, rules)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F9hTY%3D","line":57,"updated":"2014-02-06 11:27:24.000000000","message":"Same comments as in the line 45","commit_id":"15f4716eae1adf7c05ba951391e1b9cf141eb6a6"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"5b19af5b737ecfe6f88330d85370cd2fe54017f3","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        # Creates a metering label"},{"line_number":65,"context_line":"        name \u003d data_utils.rand_name(\u0027test-metering-label-\u0027)"},{"line_number":66,"context_line":"        resp, created_body \u003d self.admin_client.create_metering_label(name\u003dname)"},{"line_number":67,"context_line":"        created_body \u003d created_body[\u0027metering_label\u0027]"},{"line_number":68,"context_line":"        self.addCleanup(self._delete_metering_label, created_body[\u0027id\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":70,"context_line":"        # List all metering label list"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F9hgA%3D","line":67,"updated":"2014-02-06 11:27:24.000000000","message":"Could you change the name to something more appropriate, i.e. \u0027metering_label\u0027 or \u0027label\u0027?","commit_id":"15f4716eae1adf7c05ba951391e1b9cf141eb6a6"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"5b19af5b737ecfe6f88330d85370cd2fe54017f3","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        # Creates a metering label"},{"line_number":91,"context_line":"        name \u003d data_utils.rand_name(\u0027test-metering-label-\u0027)"},{"line_number":92,"context_line":"        resp, label \u003d self.admin_client.create_metering_label(name\u003dname)"},{"line_number":93,"context_line":"        created_label \u003d label[\u0027metering_label\u0027]"},{"line_number":94,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":95,"context_line":"        # Creates a metering label rule"},{"line_number":96,"context_line":"        name \u003d data_utils.rand_name(\u0027test-metering-label-rule-\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F9hf8%3D","line":93,"updated":"2014-02-06 11:27:24.000000000","message":"ditto","commit_id":"15f4716eae1adf7c05ba951391e1b9cf141eb6a6"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"5b19af5b737ecfe6f88330d85370cd2fe54017f3","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                              metering_label_id\u003dcreated_label[\u0027id\u0027],"},{"line_number":99,"context_line":"                              remote_ip_prefix\u003d\u002710.0.1.0/24\u0027,"},{"line_number":100,"context_line":"                              direction\u003d\u0027ingress\u0027))"},{"line_number":101,"context_line":"        created_body \u003d created_body[\u0027metering_label_rule\u0027]"},{"line_number":102,"context_line":"        self.addCleanup(self._delete_metering_label_rule, created_body[\u0027id\u0027])"},{"line_number":103,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":104,"context_line":"        # List all metering label rule list"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F9hf0%3D","line":101,"updated":"2014-02-06 11:27:24.000000000","message":"ditto","commit_id":"15f4716eae1adf7c05ba951391e1b9cf141eb6a6"}]}