)]}'
{"tempest/api/network/test_security_groups.py":[{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"fb4329ff67eab8a8aba24f88180238587a2116dc","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.assertEqual(update_body[\u0027security_group\u0027][\u0027name\u0027], new_name)"},{"line_number":63,"context_line":"        self.assertEqual(update_body[\u0027security_group\u0027][\u0027description\u0027],"},{"line_number":64,"context_line":"             new_description)"},{"line_number":65,"context_line":"        # Show and verify details of the updated security group"},{"line_number":66,"context_line":"        resp, show_body \u003d self.client.show_security_group("},{"line_number":67,"context_line":"            group_create_body[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(show_body[\u0027security_group\u0027][\u0027name\u0027], new_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BS90%3D","line":65,"updated":"2014-01-28 09:36:57.000000000","message":"I think in following code is not required as same things are being checked in line#62-line#64. Show API is being checked in line#41-line#45 and required checks of update is being done in line#61-line#64. \nSo line#65-line#70 is duplicate is unnecessary and duplicate.","commit_id":"fdf3090468ff94ee706ea26a94ce13b911083190"},{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"53a04d10c0d7258a6e7efa6552a7eaf0ba2dc85f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.assertEqual(update_body[\u0027security_group\u0027][\u0027name\u0027], new_name)"},{"line_number":63,"context_line":"        self.assertEqual(update_body[\u0027security_group\u0027][\u0027description\u0027],"},{"line_number":64,"context_line":"             new_description)"},{"line_number":65,"context_line":"        # Show and verify details of the updated security group"},{"line_number":66,"context_line":"        resp, show_body \u003d self.client.show_security_group("},{"line_number":67,"context_line":"            group_create_body[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(show_body[\u0027security_group\u0027][\u0027name\u0027], new_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BSyo%3D","line":65,"in_reply_to":"AAAAUH%2F%2BS90%3D","updated":"2014-01-28 10:22:39.000000000","message":"Hi Raies,\n\nYes I agree the code seems to be duplicate. I think it would be more beneficial to check show after update. I mean, can the lines line#41-line#45 be removed instead of lines line#65-line#70.\nso that we can even check if update has affected properly.\n\nPlease give me your opinion.","commit_id":"fdf3090468ff94ee706ea26a94ce13b911083190"},{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"1fd13a157aae45b328f21e4d7ce80654b65b945f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.assertEqual(update_body[\u0027security_group\u0027][\u0027name\u0027], new_name)"},{"line_number":63,"context_line":"        self.assertEqual(update_body[\u0027security_group\u0027][\u0027description\u0027],"},{"line_number":64,"context_line":"             new_description)"},{"line_number":65,"context_line":"        # Show and verify details of the updated security group"},{"line_number":66,"context_line":"        resp, show_body \u003d self.client.show_security_group("},{"line_number":67,"context_line":"            group_create_body[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(show_body[\u0027security_group\u0027][\u0027name\u0027], new_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BSUI%3D","line":65,"in_reply_to":"AAAAUH%2F%2BSjo%3D","updated":"2014-01-28 11:49:56.000000000","message":"Done","commit_id":"fdf3090468ff94ee706ea26a94ce13b911083190"},{"author":{"_account_id":8085,"name":"anju Tiwari","email":"anjutiwari5@gmail.com","username":"Anju"},"change_message_id":"463feb073c37803737a2792619fc1a633e7c6eb0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.assertEqual(update_body[\u0027security_group\u0027][\u0027name\u0027], new_name)"},{"line_number":63,"context_line":"        self.assertEqual(update_body[\u0027security_group\u0027][\u0027description\u0027],"},{"line_number":64,"context_line":"             new_description)"},{"line_number":65,"context_line":"        # Show and verify details of the updated security group"},{"line_number":66,"context_line":"        resp, show_body \u003d self.client.show_security_group("},{"line_number":67,"context_line":"            group_create_body[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(show_body[\u0027security_group\u0027][\u0027name\u0027], new_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BScU%3D","line":65,"in_reply_to":"AAAAUH%2F%2BSjo%3D","updated":"2014-01-28 11:23:59.000000000","message":"what if someone want to verify the updated values.?","commit_id":"fdf3090468ff94ee706ea26a94ce13b911083190"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"b8cdd0b6a69a59623acaf58775ebdfbde78daecf","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.assertEqual(update_body[\u0027security_group\u0027][\u0027name\u0027], new_name)"},{"line_number":63,"context_line":"        self.assertEqual(update_body[\u0027security_group\u0027][\u0027description\u0027],"},{"line_number":64,"context_line":"             new_description)"},{"line_number":65,"context_line":"        # Show and verify details of the updated security group"},{"line_number":66,"context_line":"        resp, show_body \u003d self.client.show_security_group("},{"line_number":67,"context_line":"            group_create_body[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(show_body[\u0027security_group\u0027][\u0027name\u0027], new_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BSjo%3D","line":65,"in_reply_to":"AAAAUH%2F%2BSyo%3D","updated":"2014-01-28 11:10:59.000000000","message":"Hi rajalakshmi-ganesan,\n\nAny section of duplicate code could be used, provided line#65 should be placed at location of line#62. It will give a better code flow understanding.","commit_id":"fdf3090468ff94ee706ea26a94ce13b911083190"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"8f5f16b13844623ccdad06b14fa9d86a31bf669c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self.assertIsNotNone(found, msg)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":38,"context_line":"    def test_create_show_update_delete_security_group(self):"},{"line_number":39,"context_line":"        group_create_body, name \u003d self._create_security_group()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # List security groups and verify if created group is there in response"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2BNDY%3D","line":38,"updated":"2014-01-29 03:53:58.000000000","message":"In this test, you mentioned create/show/update/delete sub tests as topic.\nBut actually test implemented are create/list/update/show.\n\nSo - \n1. Order of test execution should be as of topic (i.e. create/show/update/delete )\n2. delete sub test is missing.\n\nPlease perform above suggestions also","commit_id":"8eeae179a182ce15d519097995161b06b8c303de"},{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"e8ee838bfc2792e0f23d1be2ac9390dda11cee68","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self.assertIsNotNone(found, msg)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":38,"context_line":"    def test_create_show_update_delete_security_group(self):"},{"line_number":39,"context_line":"        group_create_body, name \u003d self._create_security_group()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # List security groups and verify if created group is there in response"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2BM1A%3D","line":38,"in_reply_to":"AAAAUH%2F%2BNDY%3D","updated":"2014-01-29 05:06:32.000000000","message":"Yes Raies you were right.\n\n1. It would be more meaningful to change the name of test case in the order of implementation. I shall do that.\n\n2. But, we need not include delete sub test logic here as the delete call is made in base_security_groups.py as part of function \"_create_security_group\".\n\nThe delete call happens at the end of completion of test script on the First In Last out basis of resources. This is followed in framework for all test scripts.","commit_id":"8eeae179a182ce15d519097995161b06b8c303de"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"09ef175d5002b82fa0dd57eeadadfb46d7098618","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest.api.network import base_security_groups as base"},{"line_number":17,"context_line":"from tempest.common.utils import data_utils"},{"line_number":18,"context_line":"from tempest.test import attr"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class SecGroupTest(base.BaseSecGroupTest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BGdM%3D","line":18,"updated":"2014-01-30 04:55:52.000000000","message":"attr is not module. here should be:\n\nfrom tempest import test\n\nhttp://docs.openstack.org/developer/hacking/#imports\n\nat other places @test.attr could be used","commit_id":"5e523213ddfd052acf3a08570964728924a214f7"},{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"d73b2485cca12786d6fa103dd982d8cf5260cc5a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest.api.network import base_security_groups as base"},{"line_number":17,"context_line":"from tempest.common.utils import data_utils"},{"line_number":18,"context_line":"from tempest.test import attr"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class SecGroupTest(base.BaseSecGroupTest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BGb8%3D","line":18,"in_reply_to":"AAAAUH%2F%2BGdM%3D","updated":"2014-01-30 05:06:05.000000000","message":"Done","commit_id":"5e523213ddfd052acf3a08570964728924a214f7"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"695c9bec9b1e819320d800c35f9507e9ec0aa6d7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            group_create_body[\u0027security_group\u0027][\u0027id\u0027],"},{"line_number":60,"context_line":"            name\u003dnew_name,"},{"line_number":61,"context_line":"            description\u003dnew_description)"},{"line_number":62,"context_line":"        #Verify if security group is updated"},{"line_number":63,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":64,"context_line":"        self.assertEqual(update_body[\u0027security_group\u0027][\u0027name\u0027], new_name)"},{"line_number":65,"context_line":"        self.assertEqual(update_body[\u0027security_group\u0027][\u0027description\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2Fry4%3D","line":62,"updated":"2014-02-26 12:40:07.000000000","message":"Space after #.","commit_id":"f4c8f897a59c3437563bb73b527d96f90e46726e"}]}