)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"69618919dc906692b5b1779bbfdeb7b8d04c7e1f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove xvpvnc console type tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Support for this Xen based console type is currently being removed from"},{"line_number":10,"context_line":"Nova and as a result should no longer be tested by Tempest."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"A compute-feature-enabled configurable is not being used here as the"},{"line_number":13,"context_line":"test itself only validated the returned URL and overs zero value,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_ebcb4ca1","line":10,"updated":"2019-12-18 16:43:57.000000000","message":"Refer to [1]\n\n[1] https://review.opendev.org/#/c/687909/","commit_id":"45b53ae6770615325c510294f070819bd9763867"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"69618919dc906692b5b1779bbfdeb7b8d04c7e1f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Nova and as a result should no longer be tested by Tempest."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"A compute-feature-enabled configurable is not being used here as the"},{"line_number":13,"context_line":"test itself only validated the returned URL and overs zero value,"},{"line_number":14,"context_line":"especially given the lack of Xen coverage in the gate now."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Part of blueprint remove-xvpvncproxy"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_abd4744c","line":13,"range":{"start_line":13,"start_character":48,"end_line":13,"end_character":53},"updated":"2019-12-18 16:43:57.000000000","message":"overs? covers? has?","commit_id":"45b53ae6770615325c510294f070819bd9763867"}],"releasenotes/notes/xvpvnc-console-compute-feature-config-17167d3b59774d96.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff1960f57c484d17ddad057ffbc7845d82971576","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"     A new compute feature configuration option of"},{"line_number":5,"context_line":"     ``[compute-feature]/xvpvnc_console`` has been introduced. This defaults to"},{"line_number":6,"context_line":"     ``False`` and should only be enabled on releases prior to Ussuri where"},{"line_number":7,"context_line":"     support for this console type has been removed."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_5a8d8cd2","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":23},"updated":"2019-12-18 15:56:45.000000000","message":"compute-feature-enabled","commit_id":"192340a5e4d4daba46b874c15805bc899c6c06f2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff1960f57c484d17ddad057ffbc7845d82971576","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"     A new compute feature configuration option of"},{"line_number":5,"context_line":"     ``[compute-feature]/xvpvnc_console`` has been introduced. This defaults to"},{"line_number":6,"context_line":"     ``False`` and should only be enabled on releases prior to Ussuri where"},{"line_number":7,"context_line":"     support for this console type has been removed."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_1a5e3451","line":7,"range":{"start_line":6,"start_character":54,"end_line":7,"end_character":52},"updated":"2019-12-18 15:56:45.000000000","message":"I read this as support was removed on releases prior to Ussuri, but I know it means support was removed *in* Ussuri. You don\u0027t have to change it though since I don\u0027t have any great suggestions for re-wording.","commit_id":"192340a5e4d4daba46b874c15805bc899c6c06f2"}],"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"33b503ce75f57ad61f5c4204756c25807f000a23","unresolved":false,"context_lines":[{"line_number":709,"context_line":"    def test_get_vnc_console(self):"},{"line_number":710,"context_line":"        # Get the VNC console of type \u0027novnc\u0027 and \u0027xvpvnc\u0027 if configured."},{"line_number":711,"context_line":"        console_types \u003d [\u0027novnc\u0027]"},{"line_number":712,"context_line":"        if CONF.compute_feature_enabled.xvpvnc_console:"},{"line_number":713,"context_line":"            console_types.append(\u0027xvpnc\u0027)"},{"line_number":714,"context_line":"        for console_type in console_types:"},{"line_number":715,"context_line":"            if self.is_requested_microversion_compatible(\u00272.5\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_1fdf620c","line":712,"range":{"start_line":712,"start_character":40,"end_line":712,"end_character":54},"updated":"2019-12-12 00:40:05.000000000","message":"here\u0027s a typo, it should be \"xvpnc_console\"","commit_id":"5d04d0b1f72c85c1c57787b248ec1e2f5d8c3b04"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2b1d92203489d5712e02f356e1156faca4641fd","unresolved":false,"context_lines":[{"line_number":707,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.vnc_console,"},{"line_number":708,"context_line":"                          \u0027VNC Console feature is disabled.\u0027)"},{"line_number":709,"context_line":"    def test_get_vnc_console(self):"},{"line_number":710,"context_line":"        # Get the VNC console of type \u0027novnc\u0027"},{"line_number":711,"context_line":"        console_types \u003d [\u0027novnc\u0027]"},{"line_number":712,"context_line":"        for console_type in console_types:"},{"line_number":713,"context_line":"            if self.is_requested_microversion_compatible(\u00272.5\u0027):"},{"line_number":714,"context_line":"                body \u003d self.client.get_vnc_console("},{"line_number":715,"context_line":"                    self.server_id, type\u003dconsole_type)[\u0027console\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_8bd73851","line":712,"range":{"start_line":710,"start_character":0,"end_line":712,"end_character":42},"updated":"2019-12-18 16:44:55.000000000","message":"Do we want to flatten this down now?","commit_id":"45b53ae6770615325c510294f070819bd9763867"}],"tempest/config.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"1c4fe77c5c009ef29fa04511ac166ccd45287f8a","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                     \u0027nova.conf: serial_console.enabled\u0027),"},{"line_number":505,"context_line":"    cfg.BoolOpt(\u0027xvpvnc_console\u0027,"},{"line_number":506,"context_line":"                default\u003dFalse,"},{"line_number":507,"context_line":"                help\u003d\u0027Enable xvpvnc console. This configuation value should \u0027"},{"line_number":508,"context_line":"                     \u0027be the same as nova.conf: vnc.enabled for releases \u0027"},{"line_number":509,"context_line":"                     \u0027prior to Ussuri where support for this console type was \u0027"},{"line_number":510,"context_line":"                     \u0027removed.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_953bd5c7","line":507,"range":{"start_line":507,"start_character":50,"end_line":507,"end_character":62},"updated":"2019-12-18 16:02:09.000000000","message":"a typo, missing \"r\", should be configuration","commit_id":"192340a5e4d4daba46b874c15805bc899c6c06f2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff1960f57c484d17ddad057ffbc7845d82971576","unresolved":false,"context_lines":[{"line_number":505,"context_line":"    cfg.BoolOpt(\u0027xvpvnc_console\u0027,"},{"line_number":506,"context_line":"                default\u003dFalse,"},{"line_number":507,"context_line":"                help\u003d\u0027Enable xvpvnc console. This configuation value should \u0027"},{"line_number":508,"context_line":"                     \u0027be the same as nova.conf: vnc.enabled for releases \u0027"},{"line_number":509,"context_line":"                     \u0027prior to Ussuri where support for this console type was \u0027"},{"line_number":510,"context_line":"                     \u0027removed.\u0027),"},{"line_number":511,"context_line":"    cfg.BoolOpt(\u0027rescue\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_9a1f8470","line":508,"range":{"start_line":508,"start_character":22,"end_line":508,"end_character":59},"updated":"2019-12-18 15:56:45.000000000","message":"This is a bit confusing since you can have vnc enabled without using xvpvnc, but I guess the caveat is set it to whatever you have prior to Ussuri which should be fine either way.","commit_id":"192340a5e4d4daba46b874c15805bc899c6c06f2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff1960f57c484d17ddad057ffbc7845d82971576","unresolved":false,"context_lines":[{"line_number":506,"context_line":"                default\u003dFalse,"},{"line_number":507,"context_line":"                help\u003d\u0027Enable xvpvnc console. This configuation value should \u0027"},{"line_number":508,"context_line":"                     \u0027be the same as nova.conf: vnc.enabled for releases \u0027"},{"line_number":509,"context_line":"                     \u0027prior to Ussuri where support for this console type was \u0027"},{"line_number":510,"context_line":"                     \u0027removed.\u0027),"},{"line_number":511,"context_line":"    cfg.BoolOpt(\u0027rescue\u0027,"},{"line_number":512,"context_line":"                default\u003dTrue,"},{"line_number":513,"context_line":"                help\u003d\u0027Does the test environment support instance rescue \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_da673c24","line":510,"range":{"start_line":509,"start_character":38,"end_line":510,"end_character":30},"updated":"2019-12-18 15:56:45.000000000","message":"same","commit_id":"192340a5e4d4daba46b874c15805bc899c6c06f2"}],"tempest/lib/api_schema/response/compute/v2_6/servers.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2b1d92203489d5712e02f356e1156faca4641fd","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                \u0027properties\u0027: {"},{"line_number":45,"context_line":"                    \u0027protocol\u0027: {\u0027enum\u0027: [\u0027vnc\u0027, \u0027rdp\u0027, \u0027serial\u0027, \u0027spice\u0027]},"},{"line_number":46,"context_line":"                    \u0027type\u0027: {\u0027enum\u0027: [\u0027novnc\u0027, \u0027rdp-html5\u0027, \u0027spice-html5\u0027,"},{"line_number":47,"context_line":"                                      \u0027serial\u0027]},"},{"line_number":48,"context_line":"                    \u0027url\u0027: {"},{"line_number":49,"context_line":"                        \u0027type\u0027: \u0027string\u0027,"},{"line_number":50,"context_line":"                        \u0027format\u0027: \u0027uri\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_2b05e4c1","line":47,"updated":"2019-12-18 16:44:55.000000000","message":"I don\u0027t think we should revert this since it\u0027s possible for this to be returned on older versions, even if it\u0027s not correct","commit_id":"45b53ae6770615325c510294f070819bd9763867"}]}