)]}'
{"tempest/scenario/test_volume_disk_checks.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"cafea6f38bb5dbcf46fe758d2ef5c1c53abc0c8a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def skip_checks(cls):"},{"line_number":35,"context_line":"        super(TestVolumeDiskSizeWhenAttached, cls).skip_checks()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_de876cb5","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":25},"updated":"2019-11-26 07:50:15.000000000","message":"This method is redundant unless you add a skip condition.","commit_id":"90bd44d2be3b89cf0f6b8948c931fcc32ce2c563"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"de7c269faf9013a490a7f79f488d2fa29ec86561","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def skip_checks(cls):"},{"line_number":35,"context_line":"        super(TestVolumeDiskSizeWhenAttached, cls).skip_checks()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_f98a5418","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":25},"in_reply_to":"3fa7e38b_de876cb5","updated":"2019-11-28 18:04:46.000000000","message":"+1, you do not need this.","commit_id":"90bd44d2be3b89cf0f6b8948c931fcc32ce2c563"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"91044aea3b9668f5d076f0c4c463dfe8b14562b9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def skip_checks(cls):"},{"line_number":35,"context_line":"        super(TestVolumeDiskSizeWhenAttached, cls).skip_checks()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_99b3209b","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":25},"in_reply_to":"3fa7e38b_f98a5418","updated":"2019-11-28 19:13:46.000000000","message":"done","commit_id":"90bd44d2be3b89cf0f6b8948c931fcc32ce2c563"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"de7c269faf9013a490a7f79f488d2fa29ec86561","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        return int(device_disk[0].split()[3])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _get_disk_size(self, volume):"},{"line_number":57,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":58,"context_line":"        security_group \u003d self._create_security_group()"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d98af811","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":22},"updated":"2019-11-28 18:04:46.000000000","message":"function name and what all it does is confusing. Can we rename this and keep this function to create server and attach vol only.\n\n_boot_server_and_attach_volume()","commit_id":"90bd44d2be3b89cf0f6b8948c931fcc32ce2c563"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"91044aea3b9668f5d076f0c4c463dfe8b14562b9","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        return int(device_disk[0].split()[3])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _get_disk_size(self, volume):"},{"line_number":57,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":58,"context_line":"        security_group \u003d self._create_security_group()"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d4fabd0f","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":22},"in_reply_to":"3fa7e38b_d98af811","updated":"2019-11-28 19:13:46.000000000","message":"done","commit_id":"90bd44d2be3b89cf0f6b8948c931fcc32ce2c563"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"de7c269faf9013a490a7f79f488d2fa29ec86561","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.addCleanup(self.nova_volume_detach, server,"},{"line_number":67,"context_line":"                        volume)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        # login to the instance and verify disk size"},{"line_number":70,"context_line":"        instance_ip \u003d self.get_server_ip(server)"},{"line_number":71,"context_line":"        bytes_size \u003d self._get_disk_bytes_size_from_instance("},{"line_number":72,"context_line":"            ip_address\u003dinstance_ip, dev_name\u003dCONF.compute.volume_device_name,"},{"line_number":73,"context_line":"            server\u003dserver, private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":74,"context_line":"        return bytes_size"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @decorators.idempotent_id(\u00273d59f8ef-ff5e-4563-8741-d194cda4ab6a\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_39beacae","line":73,"range":{"start_line":69,"start_character":0,"end_line":73,"end_character":62},"updated":"2019-11-28 18:04:46.000000000","message":"this can go into main tests","commit_id":"90bd44d2be3b89cf0f6b8948c931fcc32ce2c563"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"91044aea3b9668f5d076f0c4c463dfe8b14562b9","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.addCleanup(self.nova_volume_detach, server,"},{"line_number":67,"context_line":"                        volume)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        # login to the instance and verify disk size"},{"line_number":70,"context_line":"        instance_ip \u003d self.get_server_ip(server)"},{"line_number":71,"context_line":"        bytes_size \u003d self._get_disk_bytes_size_from_instance("},{"line_number":72,"context_line":"            ip_address\u003dinstance_ip, dev_name\u003dCONF.compute.volume_device_name,"},{"line_number":73,"context_line":"            server\u003dserver, private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":74,"context_line":"        return bytes_size"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @decorators.idempotent_id(\u00273d59f8ef-ff5e-4563-8741-d194cda4ab6a\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_94044516","line":73,"range":{"start_line":69,"start_character":0,"end_line":73,"end_character":62},"in_reply_to":"3fa7e38b_39beacae","updated":"2019-11-28 19:13:46.000000000","message":"done","commit_id":"90bd44d2be3b89cf0f6b8948c931fcc32ce2c563"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"a5d71984cf39db65591a8c79bb74cd3c2b4eb4f5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        super(TestVolumeDiskSizeWhenAttached, cls).resource_setup()"},{"line_number":33,"context_line":"        cls.VOLUME_SIZE_BYTES \u003d (1024 ** 3) * CONF.volume.volume_size"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def _get_disk_bytes_size_from_instance(self, ip_address, dev_name,"},{"line_number":36,"context_line":"                                           server, private_key\u003dNone):"},{"line_number":37,"context_line":"        ssh_client \u003d self.get_remote_client(ip_address,"},{"line_number":38,"context_line":"                                            private_key\u003dprivate_key,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_35403632","line":35,"range":{"start_line":35,"start_character":61,"end_line":35,"end_character":69},"updated":"2019-12-12 14:25:21.000000000","message":"This needs to be calculated using the lsblk output before/after attach rather than user provided value in tempest.conf","commit_id":"7c6341e0cdbe1574deaca325d13a59ab2e60e0b8"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"a5d71984cf39db65591a8c79bb74cd3c2b4eb4f5","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        instance_ip \u003d self.get_server_ip(server)"},{"line_number":84,"context_line":"        # login to the instance and verify disk size"},{"line_number":85,"context_line":"        bytes_size \u003d self._get_disk_bytes_size_from_instance("},{"line_number":86,"context_line":"            ip_address\u003dinstance_ip, dev_name\u003dCONF.compute.volume_device_name,"},{"line_number":87,"context_line":"            server\u003dserver, private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":88,"context_line":"        self.assertEqual(bytes_size, self.VOLUME_SIZE_BYTES)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_1545fa43","line":86,"range":{"start_line":86,"start_character":45,"end_line":86,"end_character":76},"updated":"2019-12-12 14:25:21.000000000","message":"I am not sure how you are verifying that the dev name (given by user ex- vdb) is the same name which is attached to the instance as  what if the dev vdb was already in use for ex- by config drive in nova.conf if the environment has force_config_Drive \u003d true and the format as vfat . Instance will automatically boot with using vdb as the config drive and thus rather than calculating the attached volume you are calculating the attached config drive size.\n\nPlease see this bug: https://bugs.launchpad.net/tempest/+bug/1852807 for more detail.\n\nThe better way to do this is using lsblk output before and after attach and use that to get the device name of newly added disk. I have already changed one of the testcase in compute https://review.opendev.org/#/c/698598/ which is having something like similar issue.","commit_id":"7c6341e0cdbe1574deaca325d13a59ab2e60e0b8"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"7616f155355b81d1f00dbedf52696651f53ae13e","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        return int(device_disk[0].split()[3])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _get_disks_from_instances(self):"},{"line_number":59,"context_line":"        device_disk \u003d [line.split()[0]"},{"line_number":60,"context_line":"                       for line in self.ssh_client.get_disks().split(\u0027\\n\u0027)"},{"line_number":61,"context_line":"                       if \"NAME\" not in line]"},{"line_number":62,"context_line":"        return device_disk"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _get_device_name(self, disks_before, disks_after):"},{"line_number":65,"context_line":"        dev \u003d list(set(disks_after) - set(disks_before))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_4c307756","line":62,"range":{"start_line":58,"start_character":4,"end_line":62,"end_character":26},"updated":"2019-12-18 17:35:46.000000000","message":"LGTM , I have added one list_disks method in remote_client with unit test in this patch https://review.opendev.org/#/c/698598/ waiting to get merge, if you want you can use that rather than this method. other than than this looks perfect!","commit_id":"dd67858e5e26d148c78f3fee2f2512e31c9109c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4d58420b94598f2e76b5b5ed81808531726edc24","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        * Verify attached volume size with lsblk"},{"line_number":118,"context_line":"        \"\"\""},{"line_number":119,"context_line":"        volume_type \u003d self.create_volume_type()"},{"line_number":120,"context_line":"        kwargs \u003d {\u0027provider\u0027: \u0027nova.volume.encryptors.luks.LuksEncryptor\u0027,"},{"line_number":121,"context_line":"                  \u0027key_size\u0027: 256,"},{"line_number":122,"context_line":"                  \u0027cipher\u0027: \u0027aes-xts-plain64\u0027,"},{"line_number":123,"context_line":"                  \u0027control_location\u0027: \u0027front-end\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_a99675ed","line":120,"range":{"start_line":120,"start_character":31,"end_line":120,"end_character":72},"updated":"2020-01-21 14:34:12.000000000","message":"Just use \u0027luks\u0027 here.","commit_id":"dd67858e5e26d148c78f3fee2f2512e31c9109c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4d58420b94598f2e76b5b5ed81808531726edc24","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        volume_from_snapshot \u003d self.create_volume("},{"line_number":130,"context_line":"            snapshot_id\u003dsnapshot[\u0027id\u0027], volume_type\u003dvolume_type[\u0027id\u0027])"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        self.nova_volume_attach(self.server, volume_from_snapshot)"},{"line_number":133,"context_line":"        self.addCleanup(self.nova_volume_detach, self.server,"},{"line_number":134,"context_line":"                        volume_from_snapshot)"},{"line_number":135,"context_line":"        disks_after_attach \u003d self._get_disks_from_instances()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_e9b9cd7b","line":132,"range":{"start_line":132,"start_character":13,"end_line":132,"end_character":31},"updated":"2020-01-21 14:34:12.000000000","message":"Odd that we\u0027ve created duplicate methods for doing this in EncryptionScenarioTest.","commit_id":"dd67858e5e26d148c78f3fee2f2512e31c9109c1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4d58420b94598f2e76b5b5ed81808531726edc24","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        # login to the instance and verify disk size"},{"line_number":138,"context_line":"        device_name \u003d self._get_device_name(self.disks_before_attach,"},{"line_number":139,"context_line":"                                            disks_after_attach)"},{"line_number":140,"context_line":"        # login to the instance and verify disk size"},{"line_number":141,"context_line":"        bytes_size \u003d self._get_disk_bytes_size_from_instance("},{"line_number":142,"context_line":"            dev_name\u003ddevice_name)"},{"line_number":143,"context_line":"        self.assertEqual(bytes_size, self.VOLUME_SIZE_BYTES)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_29512532","line":143,"range":{"start_line":140,"start_character":0,"end_line":143,"end_character":60},"updated":"2020-01-21 14:34:12.000000000","message":"Shouldn\u0027t this fail for non rbd encrypted volumes?\n\nFor these the exposed disk size is always smaller than the volume size given the LUKS headers.","commit_id":"dd67858e5e26d148c78f3fee2f2512e31c9109c1"}]}