)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"957a20ef1bf54468a0764790292f1676a01fb924","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix test_stamp_pattern to remove dependency of user supplied volume name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This Patch removes CONF.compute.volume_device_name dependency and"},{"line_number":10,"context_line":"use modified list_disks method to get the newly attached"},{"line_number":11,"context_line":"volume name and use that for mkfs rather than the user supplied"},{"line_number":12,"context_line":"voulme name which is based on assumtion."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_bb2c7800","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":10},"updated":"2020-01-21 14:54:54.000000000","message":"patch","commit_id":"1846295d4f7ead771e86e1ac730b1f6c9296ee44"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"28829ac9ab11b2260709671ba252f15eb5f718ee","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix test_stamp_pattern to remove dependency of user supplied volume name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This Patch removes CONF.compute.volume_device_name dependency and"},{"line_number":10,"context_line":"use modified list_disks method to get the newly attached"},{"line_number":11,"context_line":"volume name and use that for mkfs rather than the user supplied"},{"line_number":12,"context_line":"voulme name which is based on assumtion."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_1e001a00","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":10},"in_reply_to":"3fa7e38b_bb2c7800","updated":"2020-01-21 15:14:25.000000000","message":"will change this","commit_id":"1846295d4f7ead771e86e1ac730b1f6c9296ee44"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"957a20ef1bf54468a0764790292f1676a01fb924","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This Patch removes CONF.compute.volume_device_name dependency and"},{"line_number":10,"context_line":"use modified list_disks method to get the newly attached"},{"line_number":11,"context_line":"volume name and use that for mkfs rather than the user supplied"},{"line_number":12,"context_line":"voulme name which is based on assumtion."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also modfied test_attach_detach testcase and unit test"},{"line_number":15,"context_line":"for remote_client accordingly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_1bd4ac1e","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":6},"updated":"2020-01-21 14:54:54.000000000","message":"device","commit_id":"1846295d4f7ead771e86e1ac730b1f6c9296ee44"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"28829ac9ab11b2260709671ba252f15eb5f718ee","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This Patch removes CONF.compute.volume_device_name dependency and"},{"line_number":10,"context_line":"use modified list_disks method to get the newly attached"},{"line_number":11,"context_line":"volume name and use that for mkfs rather than the user supplied"},{"line_number":12,"context_line":"voulme name which is based on assumtion."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also modfied test_attach_detach testcase and unit test"},{"line_number":15,"context_line":"for remote_client accordingly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_fefade0e","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":6},"in_reply_to":"3fa7e38b_1bd4ac1e","updated":"2020-01-21 15:14:25.000000000","message":"sure, I will change this.","commit_id":"1846295d4f7ead771e86e1ac730b1f6c9296ee44"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"957a20ef1bf54468a0764790292f1676a01fb924","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Also modfied test_attach_detach testcase and unit test"},{"line_number":15,"context_line":"for remote_client accordingly."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Note: Other testcase test_minimum_basic is using disks.count"},{"line_number":18,"context_line":"(CONF.compute.volume_device_name) rather than volume name so"},{"line_number":19,"context_line":"that needs no modification"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I862d1ba55f45b09385057a51b0b52a851c19287e"},{"line_number":22,"context_line":"Closes-Bug: #1852807"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_3b4088a3","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":26},"updated":"2020-01-21 14:54:54.000000000","message":"I\u0027m not sure I follow here, can you elaborate?","commit_id":"1846295d4f7ead771e86e1ac730b1f6c9296ee44"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"28829ac9ab11b2260709671ba252f15eb5f718ee","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Also modfied test_attach_detach testcase and unit test"},{"line_number":15,"context_line":"for remote_client accordingly."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Note: Other testcase test_minimum_basic is using disks.count"},{"line_number":18,"context_line":"(CONF.compute.volume_device_name) rather than volume name so"},{"line_number":19,"context_line":"that needs no modification"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I862d1ba55f45b09385057a51b0b52a851c19287e"},{"line_number":22,"context_line":"Closes-Bug: #1852807"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_5bfc640c","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":26},"in_reply_to":"3fa7e38b_3b4088a3","updated":"2020-01-21 15:14:25.000000000","message":"This bug I was addressing initially on the first look I thought it actually affected 3 existing test cases but when I had a closer look the other testcase test_minimium_basic is not actually using the disk count rather than volume device name as others . So this needs no modification . If you want I can remove this whole lines this actually just FYI for this bug.","commit_id":"1846295d4f7ead771e86e1ac730b1f6c9296ee44"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"224b309b886aa6cfacb0fe70348d94e491897a6a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Also modfied test_attach_detach testcase and unit test"},{"line_number":15,"context_line":"for remote_client accordingly."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Note: Other testcase test_minimum_basic is using disks.count"},{"line_number":18,"context_line":"(CONF.compute.volume_device_name) rather than volume name so"},{"line_number":19,"context_line":"that needs no modification"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I862d1ba55f45b09385057a51b0b52a851c19287e"},{"line_number":22,"context_line":"Closes-Bug: #1852807"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_142c79ff","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":26},"in_reply_to":"3fa7e38b_5bfc640c","updated":"2020-01-21 16:58:58.000000000","message":"Yup I\u0027d remove it.","commit_id":"1846295d4f7ead771e86e1ac730b1f6c9296ee44"}],"tempest/common/utils/linux/remote_client.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"957a20ef1bf54468a0764790292f1676a01fb924","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            msg \u003d \"\u0027TYPE\u0027 column is required but the output doesn\u0027t have it: \""},{"line_number":74,"context_line":"            raise tempest.lib.exceptions.TempestException(msg + output)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def list_disks(self):"},{"line_number":77,"context_line":"        disks_list \u003d self.get_disks()"},{"line_number":78,"context_line":"        disks_list \u003d [line[0] for line in"},{"line_number":79,"context_line":"                      [device_name.split()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_7bcb6072","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":18},"updated":"2020-01-21 14:54:54.000000000","message":"You could just keep count_disks and return len(list_disks()), just avoids having to use len() everywhere in the tests.","commit_id":"1846295d4f7ead771e86e1ac730b1f6c9296ee44"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"28829ac9ab11b2260709671ba252f15eb5f718ee","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            msg \u003d \"\u0027TYPE\u0027 column is required but the output doesn\u0027t have it: \""},{"line_number":74,"context_line":"            raise tempest.lib.exceptions.TempestException(msg + output)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def list_disks(self):"},{"line_number":77,"context_line":"        disks_list \u003d self.get_disks()"},{"line_number":78,"context_line":"        disks_list \u003d [line[0] for line in"},{"line_number":79,"context_line":"                      [device_name.split()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_9e62cad8","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":18},"in_reply_to":"3fa7e38b_7bcb6072","updated":"2020-01-21 15:14:25.000000000","message":"No The test needs device name so to get the device name I need the list of device name not the length. so thus we changed it to return the list of device name before/after attached and grab the one which is the new one added. Though for the other function test_attach_detach count_disk method was suffice but test_stamp_pattern this method looks more sense hence we agreed on having the list_disk as the method and then we can modify according to the usecase.","commit_id":"1846295d4f7ead771e86e1ac730b1f6c9296ee44"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"224b309b886aa6cfacb0fe70348d94e491897a6a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            msg \u003d \"\u0027TYPE\u0027 column is required but the output doesn\u0027t have it: \""},{"line_number":74,"context_line":"            raise tempest.lib.exceptions.TempestException(msg + output)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def list_disks(self):"},{"line_number":77,"context_line":"        disks_list \u003d self.get_disks()"},{"line_number":78,"context_line":"        disks_list \u003d [line[0] for line in"},{"line_number":79,"context_line":"                      [device_name.split()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_d4aee17e","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":18},"in_reply_to":"3fa7e38b_9e62cad8","updated":"2020-01-21 16:58:58.000000000","message":"I\u0027d rather keep both and avoid the changes in tempest/api/compute/volumes/test_attach_volume.py.\n\nAs I said before all count_disks needs to do is return len(list_disks).","commit_id":"1846295d4f7ead771e86e1ac730b1f6c9296ee44"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"81772c6c21f389701ac09065d6558fdcf87f4584","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            msg \u003d \"\u0027TYPE\u0027 column is required but the output doesn\u0027t have it: \""},{"line_number":74,"context_line":"            raise tempest.lib.exceptions.TempestException(msg + output)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def list_disks(self):"},{"line_number":77,"context_line":"        disks_list \u003d self.get_disks()"},{"line_number":78,"context_line":"        disks_list \u003d [line[0] for line in"},{"line_number":79,"context_line":"                      [device_name.split()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_62ab68d6","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":18},"in_reply_to":"3fa7e38b_d4aee17e","updated":"2020-01-27 16:43:52.000000000","message":"I think keeping both will not be required. Having a common method to do the most stuff and user can use them for counting or getting device name.","commit_id":"1846295d4f7ead771e86e1ac730b1f6c9296ee44"}],"tempest/scenario/test_stamp_pattern.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6ffa417ad7fe95ee5d57fd40ae912fb692e2d4f6","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _list_disks(self, ip_address, private_key):"},{"line_number":57,"context_line":"        ssh \u003d self.get_remote_client(ip_address, private_key\u003dprivate_key)"},{"line_number":58,"context_line":"        disks \u003d ssh.get_disks()"},{"line_number":59,"context_line":"        disks \u003d [line[0] for line in"},{"line_number":60,"context_line":"                 [device_name.split() for device_name in"},{"line_number":61,"context_line":"                  disks.splitlines()][1:]]"},{"line_number":62,"context_line":"        return disks"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":65,"context_line":"    @decorators.idempotent_id(\u002710fd234a-515c-41e5-b092-8323060598c5\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_47a8a9d7","line":62,"range":{"start_line":58,"start_character":0,"end_line":62,"end_character":20},"updated":"2019-12-12 15:48:20.000000000","message":"Looking at your previous review [1] I see that this part of the code is almost identical to count_disks [2].\nWouldn\u0027t it be better to rename count_disks to list_disks and make it return a list of the disks instead of their count? In that case you could reuse that method here and parts of the code which use \"count_disks()\" would be edited to len(list_disks()).\n\n[1] https://opendev.org/openstack/tempest/commit/f11856505fcfb85f1ad4fde4bf68078c63be787a\n[2] https://opendev.org/openstack/tempest/src/commit/f11856505fcfb85f1ad4fde4bf68078c63be787a/tempest/common/utils/linux/remote_client.py#L76-L81","commit_id":"56c8fe32b137942fd9adc51052f73c63a9bba55e"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"083f4e62a8c26ab8b4b7063e62813b0b884282f1","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _list_disks(self, ip_address, private_key):"},{"line_number":57,"context_line":"        ssh \u003d self.get_remote_client(ip_address, private_key\u003dprivate_key)"},{"line_number":58,"context_line":"        disks \u003d ssh.get_disks()"},{"line_number":59,"context_line":"        disks \u003d [line[0] for line in"},{"line_number":60,"context_line":"                 [device_name.split() for device_name in"},{"line_number":61,"context_line":"                  disks.splitlines()][1:]]"},{"line_number":62,"context_line":"        return disks"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":65,"context_line":"    @decorators.idempotent_id(\u002710fd234a-515c-41e5-b092-8323060598c5\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_aa2cc449","line":62,"range":{"start_line":58,"start_character":0,"end_line":62,"end_character":20},"in_reply_to":"3fa7e38b_47a8a9d7","updated":"2019-12-12 16:24:49.000000000","message":"Yeah I actually did that in my last commit  but there was suggestion to have one unit test case for counting the number of disks as well and anyways we are already getting the output from get_disks and use it any form according to the output.  I am lucky that this same method helped me here to achieve the goal:) But yes to answer your question yes we can do that but then I need to change the unit test to list disk as well or else we can keep it like this and use count disk for other test attach detach testcases where we don\u0027t need the device name and then use get_disk to get the device name.","commit_id":"56c8fe32b137942fd9adc51052f73c63a9bba55e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a9f4a6f869cd6390d8ef894b18deb4ca023ba52c","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _list_disks(self, ip_address, private_key):"},{"line_number":57,"context_line":"        ssh \u003d self.get_remote_client(ip_address, private_key\u003dprivate_key)"},{"line_number":58,"context_line":"        disks \u003d ssh.get_disks()"},{"line_number":59,"context_line":"        disks \u003d [line[0] for line in"},{"line_number":60,"context_line":"                 [device_name.split() for device_name in"},{"line_number":61,"context_line":"                  disks.splitlines()][1:]]"},{"line_number":62,"context_line":"        return disks"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":65,"context_line":"    @decorators.idempotent_id(\u002710fd234a-515c-41e5-b092-8323060598c5\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_3d1f8e72","line":62,"range":{"start_line":58,"start_character":0,"end_line":62,"end_character":20},"in_reply_to":"3fa7e38b_7108fb7e","updated":"2019-12-16 18:27:48.000000000","message":"I think we did not know the use of disk name. Let\u0027s go with what Martin suggested here and use len(list_disks()) in the previous changed test.","commit_id":"56c8fe32b137942fd9adc51052f73c63a9bba55e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7084e721a3f2383a2e8cd85b1e28859c8995d236","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _list_disks(self, ip_address, private_key):"},{"line_number":57,"context_line":"        ssh \u003d self.get_remote_client(ip_address, private_key\u003dprivate_key)"},{"line_number":58,"context_line":"        disks \u003d ssh.get_disks()"},{"line_number":59,"context_line":"        disks \u003d [line[0] for line in"},{"line_number":60,"context_line":"                 [device_name.split() for device_name in"},{"line_number":61,"context_line":"                  disks.splitlines()][1:]]"},{"line_number":62,"context_line":"        return disks"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":65,"context_line":"    @decorators.idempotent_id(\u002710fd234a-515c-41e5-b092-8323060598c5\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7108fb7e","line":62,"range":{"start_line":58,"start_character":0,"end_line":62,"end_character":20},"in_reply_to":"3fa7e38b_aa2cc449","updated":"2019-12-12 21:35:16.000000000","message":"I see, i didn\u0027t go through the whole discussion there .. ok then, let\u0027s keep it as is.","commit_id":"56c8fe32b137942fd9adc51052f73c63a9bba55e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a9f4a6f869cd6390d8ef894b18deb4ca023ba52c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        disks_list_after_attach \u003d self._list_disks("},{"line_number":93,"context_line":"            ip_for_server, keypair[\u0027private_key\u0027])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # Get the newly attached volume name from the instance"},{"line_number":96,"context_line":"        volume_name \u003d [item for item in disks_list_after_attach"},{"line_number":97,"context_line":"                       if item not in disks_list_before_attach][0]"},{"line_number":98,"context_line":"        timestamp \u003d self.create_timestamp(ip_for_server,"},{"line_number":99,"context_line":"                                          volume_name,"},{"line_number":100,"context_line":"                                          private_key\u003dkeypair[\u0027private_key\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a056f504","line":97,"range":{"start_line":95,"start_character":0,"end_line":97,"end_character":66},"updated":"2019-12-16 18:27:48.000000000","message":"this can lead to index error. let\u0027 add below check before getting the name\n            self.assertGreater(ln(disks_after_attach), len(disks_before_attach))","commit_id":"56c8fe32b137942fd9adc51052f73c63a9bba55e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a9f4a6f869cd6390d8ef894b18deb4ca023ba52c","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.nova_volume_attach(server_from_snapshot, volume_from_snapshot)"},{"line_number":134,"context_line":"        disks_list_after_attach \u003d self._list_disks("},{"line_number":135,"context_line":"            ip_for_snapshot, keypair[\u0027private_key\u0027])"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # Get the newly attached volume name from the instance"},{"line_number":138,"context_line":"        volume_name \u003d [item for item in disks_list_after_attach"},{"line_number":139,"context_line":"                       if item not in disks_list_before_attach][0]"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # check the existence of the timestamp file in the volume2"},{"line_number":142,"context_line":"        timestamp2 \u003d self.get_timestamp(ip_for_snapshot,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_403b81c8","line":139,"range":{"start_line":136,"start_character":0,"end_line":139,"end_character":66},"updated":"2019-12-16 18:27:48.000000000","message":"ditto","commit_id":"56c8fe32b137942fd9adc51052f73c63a9bba55e"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"365722fe604bf5030eb59959c86d0dfcfa03d328","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            self, disks_list_before_attach, ip_address, private_key):"},{"line_number":58,"context_line":"        ssh \u003d self.get_remote_client(ip_address, private_key\u003dprivate_key)"},{"line_number":59,"context_line":"        disks_list_after_attach \u003d ssh.list_disks()"},{"line_number":60,"context_line":"        self.assertGreater("},{"line_number":61,"context_line":"            len(disks_list_after_attach),"},{"line_number":62,"context_line":"            len(disks_list_before_attach))"},{"line_number":63,"context_line":"        volume_name \u003d [item for item in disks_list_after_attach"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_607960c4","line":60,"updated":"2020-01-02 15:06:50.000000000","message":"Nothing guarantee the disk will show up the first early list.\n\nThe hypervisor cannot really know when the guest fully initialized a new device.\n  \nThis listing should be retied until growth or timeout.","commit_id":"897942ba326193d2860d89102d3d9bec3f690411"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"957a20ef1bf54468a0764790292f1676a01fb924","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            server\u003dserver)"},{"line_number":101,"context_line":"        disks_list_before_attach \u003d linux_client.list_disks()"},{"line_number":102,"context_line":"        self.nova_volume_attach(server, volume)"},{"line_number":103,"context_line":"        volume_name \u003d self._attached_volume_name("},{"line_number":104,"context_line":"            disks_list_before_attach, ip_for_server, keypair[\u0027private_key\u0027])"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        timestamp \u003d self.create_timestamp(ip_for_server,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_9bc41c43","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":19},"updated":"2020-01-21 14:54:54.000000000","message":"Given this is within the instance shouldn\u0027t this be device_name?","commit_id":"1846295d4f7ead771e86e1ac730b1f6c9296ee44"}]}