)]}'
{".zuul.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"58d638f487a8b68bb3fe15f6eea104504c7f2b8b","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        * gate-tempest-dsvm-py35"},{"line_number":167,"context_line":"    vars:"},{"line_number":168,"context_line":"      tox_envlist: full"},{"line_number":169,"context_line":"      run_tempest_cleanup: true"},{"line_number":170,"context_line":"      devstack_localrc:"},{"line_number":171,"context_line":"        USE_PYTHON3: true"},{"line_number":172,"context_line":"        FORCE_CONFIG_DRIVE: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_6897463b","line":169,"range":{"start_line":169,"start_character":4,"end_line":169,"end_character":31},"updated":"2020-03-24 13:37:29.000000000","message":"can we add this in tempest-full-parallel job initially which run on tempest gate only","commit_id":"7559f6ecaaae5fa07d1a06e88b2bf3bd58569e26"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"15684458bdf3fb414582212d4f2cca7738c040ba","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    timeout: 9000"},{"line_number":158,"context_line":"    vars:"},{"line_number":159,"context_line":"      tox_envlist: full-parallel"},{"line_number":160,"context_line":"      run_tempest_cleanup: true"},{"line_number":161,"context_line":"      devstack_localrc:"},{"line_number":162,"context_line":"        USE_PYTHON3: True"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1f493fa4_24f76f5b","line":160,"range":{"start_line":160,"start_character":1,"end_line":160,"end_character":31},"updated":"2020-04-30 21:16:29.000000000","message":"we can enable the dry run also here.","commit_id":"b380fbb957860b4cc2a7825eeea167bcf733d514"}],"playbooks/devstack-tempest.yaml":[{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"6c6152c0c46d200dfdfc5b05b586a70b74a18300","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  tasks:"},{"line_number":16,"context_line":"    - name: Setup Tempest Run Directory"},{"line_number":17,"context_line":"      include_role:"},{"line_number":18,"context_line":"        name: setup-tempest-run-dir"},{"line_number":19,"context_line":"    - name: Setup Tempest Data Directory"},{"line_number":20,"context_line":"      include_role:"},{"line_number":21,"context_line":"        name: setup-tempest-data-dir"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_9d59e28e","line":18,"updated":"2020-01-31 10:39:28.000000000","message":"Just a stetical change, I would add empty line between the tasks, to keep in sync with the other yaml files but I won\u0027t block because of this.","commit_id":"df5821b783654e476b4b17d7b89130cfe0f1a68b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0b991e509812fe2b9d741ac3d0d21df3f6b0fad8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  tasks:"},{"line_number":16,"context_line":"    - name: Setup Tempest Run Directory"},{"line_number":17,"context_line":"      include_role:"},{"line_number":18,"context_line":"        name: setup-tempest-run-dir"},{"line_number":19,"context_line":"    - name: Setup Tempest Data Directory"},{"line_number":20,"context_line":"      include_role:"},{"line_number":21,"context_line":"        name: setup-tempest-data-dir"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_9680dfc0","line":18,"in_reply_to":"3fa7e38b_9d59e28e","updated":"2020-01-31 14:37:13.000000000","message":"sure, I\u0027ll change it, it\u0027ll be better and also I need to recheck this anyway (after the python35 issue is fixed)","commit_id":"df5821b783654e476b4b17d7b89130cfe0f1a68b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"68cb4b4256221dfe589b32e640f0f27422c7b56a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      include_role:"},{"line_number":41,"context_line":"        name: tempest-cleanup"},{"line_number":42,"context_line":"      vars:"},{"line_number":43,"context_line":"        dry_run: true"},{"line_number":44,"context_line":"      when: run_tempest_cleanup is defined"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"df33271e_10b6363f","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":21},"updated":"2020-03-31 03:36:33.000000000","message":"we are not doing actual cleanup ? i think after dry run we should run actual cleanup","commit_id":"a6187175a078cc9c31c5088859c0f89c1ef5140e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e15177b4685d4fa4b4667d6c3924d726722a58d0","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      include_role:"},{"line_number":41,"context_line":"        name: tempest-cleanup"},{"line_number":42,"context_line":"      vars:"},{"line_number":43,"context_line":"        dry_run: true"},{"line_number":44,"context_line":"      when: run_tempest_cleanup is defined"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"df33271e_59a7420c","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":21},"in_reply_to":"df33271e_10b6363f","updated":"2020-03-31 11:49:39.000000000","message":"Done","commit_id":"a6187175a078cc9c31c5088859c0f89c1ef5140e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"68cb4b4256221dfe589b32e640f0f27422c7b56a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    - name: Run tempest cleanup dry-run"},{"line_number":40,"context_line":"      include_role:"},{"line_number":41,"context_line":"        name: tempest-cleanup"},{"line_number":42,"context_line":"      vars:"},{"line_number":43,"context_line":"        dry_run: true"},{"line_number":44,"context_line":"      when: run_tempest_cleanup is defined"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"df33271e_509c3ebf","line":44,"range":{"start_line":42,"start_character":0,"end_line":44,"end_character":42},"updated":"2020-03-31 03:36:33.000000000","message":"this seems no resource leak which seems doubtful :)\n\nhttps://zuul.opendev.org/t/openstack/build/0ab02b09988b46e3a7081ad091991964/log/job-output.txt#36812","commit_id":"a6187175a078cc9c31c5088859c0f89c1ef5140e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dd4c7a3eabe6db7181bf5fe5e819b603db686080","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    - name: Run tempest cleanup dry-run"},{"line_number":40,"context_line":"      include_role:"},{"line_number":41,"context_line":"        name: tempest-cleanup"},{"line_number":42,"context_line":"      vars:"},{"line_number":43,"context_line":"        dry_run: true"},{"line_number":44,"context_line":"      when: run_tempest_cleanup is defined"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"df33271e_1b68a01f","line":44,"range":{"start_line":42,"start_character":0,"end_line":44,"end_character":42},"in_reply_to":"df33271e_19ef7a1e","updated":"2020-04-05 00:21:29.000000000","message":"let\u0027s check here - https://review.opendev.org/#/c/717518/","commit_id":"a6187175a078cc9c31c5088859c0f89c1ef5140e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e15177b4685d4fa4b4667d6c3924d726722a58d0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    - name: Run tempest cleanup dry-run"},{"line_number":40,"context_line":"      include_role:"},{"line_number":41,"context_line":"        name: tempest-cleanup"},{"line_number":42,"context_line":"      vars:"},{"line_number":43,"context_line":"        dry_run: true"},{"line_number":44,"context_line":"      when: run_tempest_cleanup is defined"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"df33271e_19ef7a1e","line":44,"range":{"start_line":42,"start_character":0,"end_line":44,"end_character":42},"in_reply_to":"df33271e_509c3ebf","updated":"2020-03-31 11:49:39.000000000","message":"I found it weird too, but I thought that all the resources got properly cleaned by tests or in tear down as all the tests passed successfully","commit_id":"a6187175a078cc9c31c5088859c0f89c1ef5140e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b3b67ee5415efce64cd405df45e3c946ae003e20","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        name: tempest-cleanup"},{"line_number":31,"context_line":"      vars:"},{"line_number":32,"context_line":"        init_saved_state: true"},{"line_number":33,"context_line":"      when: run_tempest_cleanup is defined"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    - name: Run Tempest"},{"line_number":36,"context_line":"      include_role:"},{"line_number":37,"context_line":"        name: run-tempest"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    - name: Run tempest cleanup dry-run"},{"line_number":40,"context_line":"      include_role:"},{"line_number":41,"context_line":"        name: tempest-cleanup"},{"line_number":42,"context_line":"      vars:"},{"line_number":43,"context_line":"        dry_run: true"},{"line_number":44,"context_line":"      when: run_tempest_cleanup is defined"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    - name: Run tempest cleanup"},{"line_number":47,"context_line":"      include_role:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3f4c43b2_742c5e99","line":44,"range":{"start_line":33,"start_character":0,"end_line":44,"end_character":42},"updated":"2020-04-13 15:00:18.000000000","message":"let\u0027s control these two operation where we collect pre-cleanup data and do not run actual cleanup via separate variable so that any job want to test the resource leak only data.\n\nsomething :\n\nwhen: run_tempest_pre_cleanup is defined","commit_id":"b1d6c50edc4800298063319eaf26bdc7bca8f379"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8b2953773e9813353515114bdc4f8156ff05a265","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        name: tempest-cleanup"},{"line_number":31,"context_line":"      vars:"},{"line_number":32,"context_line":"        init_saved_state: true"},{"line_number":33,"context_line":"      when: run_tempest_cleanup is defined"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    - name: Run Tempest"},{"line_number":36,"context_line":"      include_role:"},{"line_number":37,"context_line":"        name: run-tempest"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    - name: Run tempest cleanup dry-run"},{"line_number":40,"context_line":"      include_role:"},{"line_number":41,"context_line":"        name: tempest-cleanup"},{"line_number":42,"context_line":"      vars:"},{"line_number":43,"context_line":"        dry_run: true"},{"line_number":44,"context_line":"      when: run_tempest_cleanup is defined"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    - name: Run tempest cleanup"},{"line_number":47,"context_line":"      include_role:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3f4c43b2_f4dcdc19","line":44,"range":{"start_line":33,"start_character":0,"end_line":44,"end_character":42},"in_reply_to":"3f4c43b2_742c5e99","updated":"2020-04-14 10:47:22.000000000","message":"sure, I\u0027ll add a new variable to control this.","commit_id":"b1d6c50edc4800298063319eaf26bdc7bca8f379"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b3b67ee5415efce64cd405df45e3c946ae003e20","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        dry_run: true"},{"line_number":44,"context_line":"      when: run_tempest_cleanup is defined"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    - name: Run tempest cleanup"},{"line_number":47,"context_line":"      include_role:"},{"line_number":48,"context_line":"        name: tempest-cleanup"},{"line_number":49,"context_line":"      when: run_tempest_cleanup is defined"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3f4c43b2_348e5678","line":49,"range":{"start_line":46,"start_character":0,"end_line":49,"end_character":42},"updated":"2020-04-13 15:00:18.000000000","message":"this is a thought we should think as next (not in this patch)\n- verify if all leaked resource are cleaned up properly or not. FOr example verify the dry run data.\n- make a flag where cleanup can start failing the job if any leaked resource so that we can fix the tests causing resource leak. If not failing then somewhere to capture the data.","commit_id":"b1d6c50edc4800298063319eaf26bdc7bca8f379"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"15684458bdf3fb414582212d4f2cca7738c040ba","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      include_role:"},{"line_number":26,"context_line":"        name: acl-devstack-files"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    - name: Run tempest cleanup init-saved-state"},{"line_number":29,"context_line":"      include_role:"},{"line_number":30,"context_line":"        name: tempest-cleanup"},{"line_number":31,"context_line":"      vars:"},{"line_number":32,"context_line":"        init_saved_state: true"},{"line_number":33,"context_line":"      when:"},{"line_number":34,"context_line":"        - run_tempest_pre_cleanup is defined"},{"line_number":35,"context_line":"        - run_tempest_cleanup is defined"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    - name: Run Tempest"},{"line_number":38,"context_line":"      include_role:"},{"line_number":39,"context_line":"        name: run-tempest"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    - name: Run tempest cleanup dry-run"},{"line_number":42,"context_line":"      include_role:"},{"line_number":43,"context_line":"        name: tempest-cleanup"},{"line_number":44,"context_line":"      vars:"},{"line_number":45,"context_line":"        dry_run: true"},{"line_number":46,"context_line":"      when:"},{"line_number":47,"context_line":"        - run_tempest_pre_cleanup is defined"},{"line_number":48,"context_line":"        - run_tempest_cleanup is defined"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    - name: Run tempest cleanup"},{"line_number":51,"context_line":"      include_role:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1f493fa4_2415afe5","line":48,"range":{"start_line":28,"start_character":0,"end_line":48,"end_character":40},"updated":"2020-04-30 21:16:29.000000000","message":"we can make these two separate. I am sorry if it was not clear in previous comment. \n\nFor users of cleanup, we need to give clear interface for 1. dry run 2. actual cleanup. dry cleanup things i am thinking from 3rd party CI point of view when they do not want to do actual cleanup but checking the resource cleanup I was thinking to do via two var:\n\n1. run_tempest_cleanup : this will do init-saved-state and then run actual cleanup\n\n2. run_tempest_dry_cleanup : this will do init-saved-state and then run dry cleanup\n\n    - name: Run tempest cleanup init-saved-state\n      include_role:\n        name: tempest-cleanup\n      vars:\n        init_saved_state: true\n      when:\n        - run_tempest_cleanup is defined\n        - run_tempest_dry_cleanup is defined\n\n    - name: Run Tempest\n      include_role:\n        name: run-tempest\n\n    - name: Run tempest cleanup dry-run\n      include_role:\n        name: tempest-cleanup\n      vars:\n        dry_run: true\n      when:\n        - run_tempest_dry_cleanup is defined","commit_id":"b380fbb957860b4cc2a7825eeea167bcf733d514"}],"roles/tempest-cleanup/defaults/main.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b3b67ee5415efce64cd405df45e3c946ae003e20","unresolved":false,"context_lines":[{"line_number":1,"context_line":"devstack_base_dir: /opt/stack"},{"line_number":2,"context_line":"init_saved_state: false"},{"line_number":3,"context_line":"dry_run: false"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3f4c43b2_713590f7","line":2,"range":{"start_line":2,"start_character":17,"end_line":2,"end_character":23},"updated":"2020-04-13 15:00:18.000000000","message":"this should be true as if we run cleanup without init_saved_state, it can delete the non-tests resources.","commit_id":"b1d6c50edc4800298063319eaf26bdc7bca8f379"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8b2953773e9813353515114bdc4f8156ff05a265","unresolved":false,"context_lines":[{"line_number":1,"context_line":"devstack_base_dir: /opt/stack"},{"line_number":2,"context_line":"init_saved_state: false"},{"line_number":3,"context_line":"dry_run: false"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3f4c43b2_b4ac148d","line":2,"range":{"start_line":2,"start_character":17,"end_line":2,"end_character":23},"in_reply_to":"3f4c43b2_713590f7","updated":"2020-04-14 10:47:22.000000000","message":"see my other inline comment","commit_id":"b1d6c50edc4800298063319eaf26bdc7bca8f379"}],"roles/tempest-cleanup/tasks/main.yaml":[{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"870c09479fa0d2e182c8957c05ba5d3b6be06705","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  - name: Cat dry_run.json"},{"line_number":29,"context_line":"    command: cat \"{{devstack_base_dir}}/tempest/dry_run.json\""},{"line_number":30,"context_line":"  when: dry_run"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Run tempest cleanup"},{"line_number":33,"context_line":"  become: yes"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_a1d29e31","line":30,"updated":"2020-01-29 12:12:00.000000000","message":"I would sugest to move this when up, I almost though it was indent error","commit_id":"ca2c251adf1ccc2f8b0ba8c3d12a397e56c72d8e"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"2f44110c1f66f8deebaf90ba1f1480a690f92ce1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  args:"},{"line_number":37,"context_line":"    chdir: \"{{devstack_base_dir}}/tempest\""},{"line_number":38,"context_line":"  when: not dry_run and not init_saved_state"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa7e38b_c82f8855","line":39,"updated":"2020-02-03 08:31:45.000000000","message":"2 empty lines","commit_id":"ab9d75af3b5780c326da6febc42eaf86716e6b34"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"68cb4b4256221dfe589b32e640f0f27422c7b56a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Prepare tempest venv"},{"line_number":2,"context_line":"  become: yes"},{"line_number":3,"context_line":"  become_user: tempest"},{"line_number":4,"context_line":"  command: tox -r --notest -efull"},{"line_number":5,"context_line":"  args:"},{"line_number":6,"context_line":"    chdir: \"{{devstack_base_dir}}/tempest\""},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"df33271e_70806247","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":33},"updated":"2020-03-31 03:36:33.000000000","message":"this seems recreating the tempest venv every time which is not right and can cause:\n- undo the tempest plugins installations\n- might use different stable constraint than what devstack did. \n\nI think we can just skip this tasks and  let\u0027s ty tox -evenv-tempest in each tasks further.","commit_id":"a6187175a078cc9c31c5088859c0f89c1ef5140e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e15177b4685d4fa4b4667d6c3924d726722a58d0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Prepare tempest venv"},{"line_number":2,"context_line":"  become: yes"},{"line_number":3,"context_line":"  become_user: tempest"},{"line_number":4,"context_line":"  command: tox -r --notest -efull"},{"line_number":5,"context_line":"  args:"},{"line_number":6,"context_line":"    chdir: \"{{devstack_base_dir}}/tempest\""},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"df33271e_19665ac2","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":33},"in_reply_to":"df33271e_70806247","updated":"2020-03-31 11:49:39.000000000","message":"oh, right.","commit_id":"a6187175a078cc9c31c5088859c0f89c1ef5140e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b3b67ee5415efce64cd405df45e3c946ae003e20","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  command: tox -evenv-tempest -- tempest cleanup"},{"line_number":29,"context_line":"  args:"},{"line_number":30,"context_line":"    chdir: \"{{devstack_base_dir}}/tempest\""},{"line_number":31,"context_line":"  when: not dry_run and not init_saved_state"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3f4c43b2_f109a031","line":31,"range":{"start_line":31,"start_character":24,"end_line":31,"end_character":44},"updated":"2020-04-13 15:00:18.000000000","message":"s/not init_saved_state/init_saved_state\n\nlet\u0027s run actual cleanup only if init_saved_state is done otherwise we will end up deleting the non-test resource. In gate it is ok as after tests we anyways delete the tested node but still if some post-script want to capture some of the resource data then it should not delete them.","commit_id":"b1d6c50edc4800298063319eaf26bdc7bca8f379"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"15684458bdf3fb414582212d4f2cca7738c040ba","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  command: tox -evenv-tempest -- tempest cleanup"},{"line_number":29,"context_line":"  args:"},{"line_number":30,"context_line":"    chdir: \"{{devstack_base_dir}}/tempest\""},{"line_number":31,"context_line":"  when: not dry_run and not init_saved_state"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f493fa4_c4e84b7d","line":31,"range":{"start_line":31,"start_character":24,"end_line":31,"end_character":44},"in_reply_to":"3f4c43b2_3499246e","updated":"2020-04-30 21:16:29.000000000","message":"agree, as we will do init saved file in both case, these condition lgtm.","commit_id":"b1d6c50edc4800298063319eaf26bdc7bca8f379"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8b2953773e9813353515114bdc4f8156ff05a265","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  command: tox -evenv-tempest -- tempest cleanup"},{"line_number":29,"context_line":"  args:"},{"line_number":30,"context_line":"    chdir: \"{{devstack_base_dir}}/tempest\""},{"line_number":31,"context_line":"  when: not dry_run and not init_saved_state"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3f4c43b2_3499246e","line":31,"range":{"start_line":31,"start_character":24,"end_line":31,"end_character":44},"in_reply_to":"3f4c43b2_f109a031","updated":"2020-04-14 10:47:22.000000000","message":"This role is ran at least twice, first it\u0027s supposed to be run to generate saved_state.json only and then again to run --dry-run or actual cleanup. It\u0027s due to the reason that a user essentially runs tempest in between those two runs because this role doesn\u0027t run tempest, it runs only \u0027tempest cleanup\u0027.\n\n\nThis role can be used by anyone and it\u0027s purpose is to run \u0027tempest cleanup\u0027. It\u0027s documented in the role README that saved_state should be generated prior actual cleanup. \nThe role is controlled by variables, if init_saved_state is true, only --init-saved-state is executed (so it\u0027ll generate saved_state.json), the same for --dry-run, if none of the variables is defined (therefore both of them are by default false) it makes sense that \u0027tempest cleanup\u0027 is run as the role is called tempest-cleanup - me as a role user would definitely expect that if I run it as is (without specifying other variables) it would run the cleanup.\n\n\nIn order to provide a safe usage in the gates, we\u0027ll use pre_cleanup and cleanup variables within devstack-tempest.yaml playbook as you suggested so that the usage of the role is clear to everyone whose job inherits from devstack-tempest one. \n\nBut if anyone uses the role directly they should get familiar with the README first, essentially they use the role on their own risk.","commit_id":"b1d6c50edc4800298063319eaf26bdc7bca8f379"}]}