)]}'
{"releasenotes/notes/account_generator-6eb03f664a448c35.yaml":[{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"ea05165f8965e15ae574708c652b611368ab49f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove the deprecated CLI ``tempest-account-generator`` in favour of"},{"line_number":5,"context_line":"    ``tempest account-generator`` command."},{"line_number":6,"context_line":"    You can use ``tempest account-generator`` CLI to generate the accounts"},{"line_number":7,"context_line":"    yaml file."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_a5a7d5bb","line":4,"updated":"2020-02-19 08:47:36.000000000","message":"in favor of","commit_id":"70db66588e52c63e1925fcea0e47f6252ef6c50b"}],"tempest/cmd/account_generator.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7e4770d57b795969c1bcbe2e849a079e6d3b8ef2","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                        help\u003d\u0027Output accounts yaml file\u0027)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"def get_options():"},{"line_number":260,"context_line":"    usage_string \u003d (\u0027tempest account-generator [-h] \u003cARG\u003e ...\\n\\n\u0027"},{"line_number":261,"context_line":"                    \u0027To see help on specific argument, do:\\n\u0027"},{"line_number":262,"context_line":"                    \u0027tempest account-generator \u003cARG\u003e -h\u0027)"},{"line_number":263,"context_line":"    parser \u003d argparse.ArgumentParser("},{"line_number":264,"context_line":"        description\u003dDESCRIPTION,"},{"line_number":265,"context_line":"        formatter_class\u003dargparse.ArgumentDefaultsHelpFormatter,"},{"line_number":266,"context_line":"        usage\u003dusage_string"},{"line_number":267,"context_line":"    )"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    _parser_add_args(parser)"},{"line_number":270,"context_line":"    opts \u003d parser.parse_args()"},{"line_number":271,"context_line":"    return opts"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"class TempestAccountGenerator(command.Command):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_49ec4cbb","side":"PARENT","line":271,"range":{"start_line":259,"start_character":0,"end_line":271,"end_character":15},"updated":"2020-01-28 02:54:01.000000000","message":"I believe we still need this. See comments below.","commit_id":"e459e0d4489f7bc1eb7a821a9def0721a8f94c6a"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7e4770d57b795969c1bcbe2e849a079e6d3b8ef2","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    if log_warning:"},{"line_number":302,"context_line":"        LOG.warning(\"Use of: \u0027tempest-account-generator\u0027 is deprecated, \""},{"line_number":303,"context_line":"                    \"please use: \u0027tempest account-generator\u0027\")"},{"line_number":304,"context_line":"    if opts.os_tenant_name:"},{"line_number":305,"context_line":"        LOG.warning(\"\u0027os-tenant-name\u0027 and \u0027OS_TENANT_NAME\u0027 are both \""},{"line_number":306,"context_line":"                    \"deprecated, please use \u0027os-project-name\u0027 or \""},{"line_number":307,"context_line":"                    \"\u0027OS_PROJECT_NAME\u0027 instead\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_a9f14098","side":"PARENT","line":304,"range":{"start_line":304,"start_character":4,"end_line":304,"end_character":27},"updated":"2020-01-28 02:54:01.000000000","message":"This will blow up since opts is None here and we no longer call opts \u003d get_options() so this needs to  be fixed.","commit_id":"e459e0d4489f7bc1eb7a821a9def0721a8f94c6a"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"ef474f7931a5a64af2d229bb47df0ac1fd1b3165","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    if log_warning:"},{"line_number":302,"context_line":"        LOG.warning(\"Use of: \u0027tempest-account-generator\u0027 is deprecated, \""},{"line_number":303,"context_line":"                    \"please use: \u0027tempest account-generator\u0027\")"},{"line_number":304,"context_line":"    if opts.os_tenant_name:"},{"line_number":305,"context_line":"        LOG.warning(\"\u0027os-tenant-name\u0027 and \u0027OS_TENANT_NAME\u0027 are both \""},{"line_number":306,"context_line":"                    \"deprecated, please use \u0027os-project-name\u0027 or \""},{"line_number":307,"context_line":"                    \"\u0027OS_PROJECT_NAME\u0027 instead\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9c5a4b5b","side":"PARENT","line":304,"range":{"start_line":304,"start_character":4,"end_line":304,"end_character":27},"in_reply_to":"3fa7e38b_a9f14098","updated":"2020-02-18 07:43:20.000000000","message":"I will fix this in updated patch.","commit_id":"e459e0d4489f7bc1eb7a821a9def0721a8f94c6a"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7e4770d57b795969c1bcbe2e849a079e6d3b8ef2","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    dump_accounts(resources, opts.identity_version, opts.accounts)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":317,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_e9fbb876","side":"PARENT","line":317,"range":{"start_line":316,"start_character":0,"end_line":317,"end_character":10},"updated":"2020-01-28 02:54:01.000000000","message":"I do not think we should remove this since this is an entrypoint for CLI scripts that execute this file directly. See this: https://stackoverflow.com/a/419189","commit_id":"e459e0d4489f7bc1eb7a821a9def0721a8f94c6a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95a7083e1830a64f41bc30f5af7638861bf8eea7","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    dump_accounts(resources, opts.identity_version, opts.accounts)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":317,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_467ba38a","side":"PARENT","line":317,"range":{"start_line":316,"start_character":0,"end_line":317,"end_character":10},"in_reply_to":"3f4c43b2_d8180083","updated":"2020-04-30 18:26:50.000000000","message":"true, we do not need to support script run.","commit_id":"e459e0d4489f7bc1eb7a821a9def0721a8f94c6a"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"ef474f7931a5a64af2d229bb47df0ac1fd1b3165","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    dump_accounts(resources, opts.identity_version, opts.accounts)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":317,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ff57b1f4","side":"PARENT","line":317,"range":{"start_line":316,"start_character":0,"end_line":317,"end_character":10},"in_reply_to":"3fa7e38b_e9fbb876","updated":"2020-02-18 07:43:20.000000000","message":"We need to remove this because we want to run this script as utility of tempest and not as a console based script. The script earlier had both the code embedded in it. But, if we look at the deprecation message, we are clearly specifying that \u0027Use of \u0027tempest-account-generator\u0027 is deprecated\u0027. If it is deprecated then we obviously need to remove the code related to it.","commit_id":"e459e0d4489f7bc1eb7a821a9def0721a8f94c6a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e4ef5b082b507dcc4e35f3844e97396cc2ff83eb","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    dump_accounts(resources, opts.identity_version, opts.accounts)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":317,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_d8180083","side":"PARENT","line":317,"range":{"start_line":316,"start_character":0,"end_line":317,"end_character":10},"in_reply_to":"3fa7e38b_ff57b1f4","updated":"2020-04-13 22:12:14.000000000","message":"I agree with Soniya. Also direct usage of this file in a script is not recommended as we have official tempest CLI - the tool should be executed as \u0027tempest account-generator\u0027. It\u0027s the same with tempest cleanup for example.","commit_id":"e459e0d4489f7bc1eb7a821a9def0721a8f94c6a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"119adb5db0f44f8bd2621ec3df808b3557ef89ef","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        return DESCRIPTION"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"def main(opts\u003dNone):"},{"line_number":271,"context_line":"    if opts.config_file:"},{"line_number":272,"context_line":"        config.CONF.set_config_path(opts.config_file)"},{"line_number":273,"context_line":"    setup_logging()"},{"line_number":274,"context_line":"    resources \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_019b42c9","line":271,"range":{"start_line":270,"start_character":0,"end_line":271,"end_character":24},"updated":"2020-02-25 16:41:21.000000000","message":"this looks a little bit strange, as if you look only at this method without realizing context, opts is set to None but then on the first line of the method we can see \u0027opts.config_file\u0027. \n\nOf course when I realize the context I see that opts is always set, because the method is called from TempestAccountGenerator.take_action, but until then it looks suspicious. \nMaybe it would make sense to remove main method entirely and move it\u0027s content directly to try block in TempestAccountGenerator.take_action method?\n\nI\u0027ll lightly -1 as it\u0027s better to avoid a suspicious code. Apart from this the change works perfectly and this suspicious part of the code doesn\u0027t have any effect on the behavior of the script.","commit_id":"d5fee8fabfed79d236163dd6552e241a9929337a"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"3109577f924a2b0887132bfd3dbb103b9250b755","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        return DESCRIPTION"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"def main(opts\u003dNone):"},{"line_number":271,"context_line":"    if opts.config_file:"},{"line_number":272,"context_line":"        config.CONF.set_config_path(opts.config_file)"},{"line_number":273,"context_line":"    setup_logging()"},{"line_number":274,"context_line":"    resources \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_4ce94118","line":271,"range":{"start_line":270,"start_character":0,"end_line":271,"end_character":24},"in_reply_to":"1fa4df85_019b42c9","updated":"2020-02-28 06:49:05.000000000","message":"Yeah, exactly. Moving the code of main() to try block is a good idea.","commit_id":"d5fee8fabfed79d236163dd6552e241a9929337a"}]}