)]}'
{"tempest/tests/test_wrappers.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"a69d769930d3d69fb98e5da31a43f70a9440d8c8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        # Setup test dirs"},{"line_number":29,"context_line":"        self.directory \u003d tempfile.mkdtemp(prefix\u003d\u0027tempest-unit\u0027)"},{"line_number":30,"context_line":"        self.test_dir \u003d os.path.join(self.directory, \u0027tests\u0027)"},{"line_number":31,"context_line":"        self.addCleanup(shutil.rmtree, self.test_dir)"},{"line_number":32,"context_line":"        os.mkdir(self.test_dir)"},{"line_number":33,"context_line":"        # Setup Test files"},{"line_number":34,"context_line":"        self.testr_conf_file \u003d os.path.join(self.directory, \u0027.testr.conf\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BB%2FY%3D","line":31,"updated":"2014-01-30 20:26:26.000000000","message":"Shouldn\u0027t this be after the mkdir below?","commit_id":"caeac29834c64928036aa878a1fa7076a3390609"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8f605410340fe89d03a85badcb2e07f4d8f2048b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        # Setup test dirs"},{"line_number":29,"context_line":"        self.directory \u003d tempfile.mkdtemp(prefix\u003d\u0027tempest-unit\u0027)"},{"line_number":30,"context_line":"        self.test_dir \u003d os.path.join(self.directory, \u0027tests\u0027)"},{"line_number":31,"context_line":"        self.addCleanup(shutil.rmtree, self.test_dir)"},{"line_number":32,"context_line":"        os.mkdir(self.test_dir)"},{"line_number":33,"context_line":"        # Setup Test files"},{"line_number":34,"context_line":"        self.testr_conf_file \u003d os.path.join(self.directory, \u0027.testr.conf\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BB%2BQ%3D","line":31,"in_reply_to":"AAAAUH%2F%2BB%2FY%3D","updated":"2014-01-30 20:30:35.000000000","message":"any reason why? I actually like registering cleanup of resources before we actually create them, as even if os.mkdir has a non atomic fail, it will ensure that the directory is gone.","commit_id":"caeac29834c64928036aa878a1fa7076a3390609"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"166a2f71f69b563bcffa2679e996b62897ac0e5a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        # Setup test dirs"},{"line_number":29,"context_line":"        self.directory \u003d tempfile.mkdtemp(prefix\u003d\u0027tempest-unit\u0027)"},{"line_number":30,"context_line":"        self.test_dir \u003d os.path.join(self.directory, \u0027tests\u0027)"},{"line_number":31,"context_line":"        self.addCleanup(shutil.rmtree, self.test_dir, True)"},{"line_number":32,"context_line":"        os.mkdir(self.test_dir)"},{"line_number":33,"context_line":"        # Setup Test files"},{"line_number":34,"context_line":"        self.testr_conf_file \u003d os.path.join(self.directory, \u0027.testr.conf\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2BBy8%3D","line":31,"updated":"2014-01-30 21:06:57.000000000","message":"Shouldn\u0027t this be cleaning up self.directory? Thats the root dir thats created...","commit_id":"ab57f5526e038ed2f06f07149c28210b9778276b"}]}
