)]}'
{"tempest/common/waiters.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f248e2d4586afb785f6de3e5dd9ce2a79f447de9","unresolved":false,"context_lines":[{"line_number":217,"context_line":"             resource_name, resource_id, status, time.time() - start)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"def wait_for_volume_attachment_delete(client, volume_id, attachment_id):"},{"line_number":221,"context_line":"    \"\"\"Waits for a volume attachment to be removed from a given volume.\"\"\""},{"line_number":222,"context_line":"    start \u003d int(time.time())"},{"line_number":223,"context_line":"    attachments \u003d client.show_volume(volume_id)[\u0027volume\u0027][\u0027attachments\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_9e5306df","line":220,"range":{"start_line":220,"start_character":4,"end_line":220,"end_character":37},"updated":"2020-01-14 23:42:20.000000000","message":"delete in the name sounds like this is deleting the attachment ( deleting server) not detaching. How about naming this method to wait_for_volume_attachment_remove or simply wait_for_volume_detach","commit_id":"b4bd09ee6b2c7c990dfd21e40881fc91ca1927cc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"244eda80eea3bb73d5ccb1e82ae066b35136c2e6","unresolved":false,"context_lines":[{"line_number":217,"context_line":"             resource_name, resource_id, status, time.time() - start)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"def wait_for_volume_attachment_delete(client, volume_id, attachment_id):"},{"line_number":221,"context_line":"    \"\"\"Waits for a volume attachment to be removed from a given volume.\"\"\""},{"line_number":222,"context_line":"    start \u003d int(time.time())"},{"line_number":223,"context_line":"    attachments \u003d client.show_volume(volume_id)[\u0027volume\u0027][\u0027attachments\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_5d191185","line":220,"range":{"start_line":220,"start_character":4,"end_line":220,"end_character":37},"in_reply_to":"3fa7e38b_9e5306df","updated":"2020-01-15 08:39:40.000000000","message":"Yeah that\u0027s fair, in terms of the v3 cinder API we are DELETE\u0027ing the attachment but you\u0027re right that this is just a detach. I\u0027ll rename now.","commit_id":"b4bd09ee6b2c7c990dfd21e40881fc91ca1927cc"}]}