)]}'
{"tempest/api/compute/admin/test_live_migration.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"54d6a15dc96db19d62569068a56f8eb4f783d440","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class LiveMigrationTestBase(base.BaseV2ComputeAdminTest):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    # These tests don\u0027t attempt any SSH validation nor do they use"},{"line_number":35,"context_line":"    # floating IPs on the instance, so all we need is a network and"},{"line_number":36,"context_line":"    # a subnet so the instance being migrated has a single port, but"},{"line_number":37,"context_line":"    # we need that to make sure we are properly updating the port"},{"line_number":38,"context_line":"    # host bindings during the live migration."},{"line_number":39,"context_line":"    create_default_network \u003d True"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7d31b457","line":38,"range":{"start_line":34,"start_character":4,"end_line":38,"end_character":46},"updated":"2020-01-09 18:52:25.000000000","message":"i dont think we can assume that as you can ennable ssh verification for all the test using \n\nhttps://github.com/openstack/tempest/blob/97052fae121174b9d6daa51684c03f730dc74683/tempest/config.py#L770-L775\nand specify the network with \nhttps://github.com/openstack/tempest/blob/97052fae121174b9d6daa51684c03f730dc74683/tempest/config.py#L831-L834\n\ni think if we have ssh verifcation enabeld we need to create a router if the connection  connect_method\u003dfloating\nhttps://github.com/openstack/tempest/blob/master/tempest/config.py#L782-L787\nand if its is fixed we need to not create a network and instead used the fixed network if fixed_network_name is defiend\nhttps://github.com/openstack/tempest/blob/97052fae121174b9d6daa51684c03f730dc74683/tempest/config.py#L303-L309\n\nif fixed network name is defiend we proably never want to auto create a network as in that case it will not fail with the multiple network error anyway.","commit_id":"ca2ba6baef26aa500d6deb0ecf7b6cf7abeb2f5c"}]}