)]}'
{"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"7993fcfacd8b65f9d2be08a4710c63ff22af35f1","unresolved":false,"context_lines":[{"line_number":606,"context_line":""},{"line_number":607,"context_line":"        expected_servers \u003d [initial_dns_server]"},{"line_number":608,"context_line":"        actual_servers \u003d ssh_client.get_dns_servers()"},{"line_number":609,"context_line":"        for dns_server in expected_servers:"},{"line_number":610,"context_line":"            self.assertIn(dns_server, actual_servers,"},{"line_number":611,"context_line":"                          \u0027Looking for server: {trgt_serv}. \u0027"},{"line_number":612,"context_line":"                          \u0027Retrieved DNS nameservers: {act_serv} \u0027"},{"line_number":613,"context_line":"                          \u0027From host: {host}.\u0027"},{"line_number":614,"context_line":"                          .format(host\u003dssh_client.ssh_client.host,"},{"line_number":615,"context_line":"                                  act_serv\u003dactual_servers,"},{"line_number":616,"context_line":"                                  trgt_serv\u003ddns_server))"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        self.subnet \u003d self.subnets_client.update_subnet("},{"line_number":619,"context_line":"            self.subnet[\u0027id\u0027], dns_nameservers\u003d[alt_dns_server])[\u0027subnet\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_dab06e00","line":616,"range":{"start_line":609,"start_character":0,"end_line":616,"end_character":56},"updated":"2020-01-19 01:50:54.000000000","message":"1. How about:\nself.assertTrue(set(expected_servers).issubset(set(actual_servers)),\n                \u0027some log info\u0027)?\n\n2. Would it be better to put a comment above this, explaining why \"issubset\" while not \"equal\"?","commit_id":"2822dd1be590e67efd0dcc5fedf957fb6357077c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"72fc9c2c0b20d6a0a3e4c5b516747c77051cbbce","unresolved":false,"context_lines":[{"line_number":606,"context_line":""},{"line_number":607,"context_line":"        expected_servers \u003d [initial_dns_server]"},{"line_number":608,"context_line":"        actual_servers \u003d ssh_client.get_dns_servers()"},{"line_number":609,"context_line":"        for dns_server in expected_servers:"},{"line_number":610,"context_line":"            self.assertIn(dns_server, actual_servers,"},{"line_number":611,"context_line":"                          \u0027Looking for server: {trgt_serv}. \u0027"},{"line_number":612,"context_line":"                          \u0027Retrieved DNS nameservers: {act_serv} \u0027"},{"line_number":613,"context_line":"                          \u0027From host: {host}.\u0027"},{"line_number":614,"context_line":"                          .format(host\u003dssh_client.ssh_client.host,"},{"line_number":615,"context_line":"                                  act_serv\u003dactual_servers,"},{"line_number":616,"context_line":"                                  trgt_serv\u003ddns_server))"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        self.subnet \u003d self.subnets_client.update_subnet("},{"line_number":619,"context_line":"            self.subnet[\u0027id\u0027], dns_nameservers\u003d[alt_dns_server])[\u0027subnet\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4da60a57","line":616,"range":{"start_line":609,"start_character":0,"end_line":616,"end_character":56},"in_reply_to":"3fa7e38b_dab06e00","updated":"2020-01-19 09:54:30.000000000","message":"That\u0027s good idea. I changed it and added comment.","commit_id":"2822dd1be590e67efd0dcc5fedf957fb6357077c"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"5c39771e82bef3227295c5b9265fcc8b31598e03","unresolved":false,"context_lines":[{"line_number":607,"context_line":"        expected_dns_servers \u003d [initial_dns_server]"},{"line_number":608,"context_line":"        actual_dns_servers \u003d ssh_client.get_dns_servers()"},{"line_number":609,"context_line":"        # NOTE(slaweq): In some cases there can be some additional nameservers"},{"line_number":610,"context_line":"        # configured in /etc/resolv.conf in quest OS, so we should only check"},{"line_number":611,"context_line":"        # if all expected_dns_servers are in the list of actual dns servers"},{"line_number":612,"context_line":"        # configured on guest"},{"line_number":613,"context_line":"        self.assertTrue("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_dc93864d","line":610,"range":{"start_line":610,"start_character":44,"end_line":610,"end_character":49},"updated":"2020-01-20 08:55:58.000000000","message":"guest?","commit_id":"aa0f82e01f04ac5adff64dce6c8e2ad7907e0fb6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e94e65366392af92364c16edf75527fbdd6da90e","unresolved":false,"context_lines":[{"line_number":607,"context_line":"        expected_dns_servers \u003d [initial_dns_server]"},{"line_number":608,"context_line":"        actual_dns_servers \u003d ssh_client.get_dns_servers()"},{"line_number":609,"context_line":"        # NOTE(slaweq): In some cases there can be some additional nameservers"},{"line_number":610,"context_line":"        # configured in /etc/resolv.conf in quest OS, so we should only check"},{"line_number":611,"context_line":"        # if all expected_dns_servers are in the list of actual dns servers"},{"line_number":612,"context_line":"        # configured on guest"},{"line_number":613,"context_line":"        self.assertTrue("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_6b4ac724","line":610,"range":{"start_line":610,"start_character":44,"end_line":610,"end_character":49},"in_reply_to":"3fa7e38b_dc93864d","updated":"2020-01-21 09:33:47.000000000","message":"right, sorry for this typo :)","commit_id":"aa0f82e01f04ac5adff64dce6c8e2ad7907e0fb6"}]}