)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"30c4ea4c02ad7dc3bb165995adb0c11969b9f9f7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add tempest test for retype volume with attach"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add API admin tempest test for retype with attach afterwards."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I8dac1dc7e894af03d743117b42fb802c44a20f2b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_2af24d6a","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":0},"updated":"2020-01-23 16:16:36.000000000","message":"I think we should link https://bugs.launchpad.net/cinder/+bug/1843495 \n\nIn order to do so, I think you can add \"Closes-Bug: #1843495\". However, the launchpad bug is from cinder and not from tempest project, I\u0027m not so sure if the link will work, but you can try it.","commit_id":"48bd62f39593d48e38fe79de799d011af73114a6"}],"tempest/api/volume/admin/test_volume_retype.py":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8b7a5659e8d384c481661494d941a74fd41a7d6e","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self._retype_volume(src_vol, migration_policy\u003d\u0027never\u0027)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"class VolumeRetypeWithoutMigrationTestWithAttach("},{"line_number":184,"context_line":"        VolumeRetypeWithoutMigrationTest):"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @decorators.idempotent_id(\u0027ddf8b89e-0b1e-4a17-aeae-47f5fec970ab\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_9c3e12b4","line":183,"range":{"start_line":183,"start_character":34,"end_line":183,"end_character":38},"updated":"2020-01-26 20:04:32.000000000","message":"this should be the last word in the class name","commit_id":"97bdc4e2c15674c1b2cdb135cb9fc34fa06daec0"},{"author":{"_account_id":31055,"name":"Anastasiya Zhyrkevich","email":"Anastasiya.Zhyrkevich@gmail.com","username":"anastzhyr"},"change_message_id":"d6bf0daf3b4cd654965275d77974ede0d5a8d5e9","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self._retype_volume(src_vol, migration_policy\u003d\u0027never\u0027)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"class VolumeRetypeWithoutMigrationTestWithAttach("},{"line_number":184,"context_line":"        VolumeRetypeWithoutMigrationTest):"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @decorators.idempotent_id(\u0027ddf8b89e-0b1e-4a17-aeae-47f5fec970ab\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_1c0b02d4","line":183,"range":{"start_line":183,"start_character":34,"end_line":183,"end_character":38},"in_reply_to":"3fa7e38b_9c3e12b4","updated":"2020-01-26 21:05:29.000000000","message":"Updated :) Thank you","commit_id":"97bdc4e2c15674c1b2cdb135cb9fc34fa06daec0"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"d2441a09c146dc9b8494e2317228233d985fa15f","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self._retype_volume(src_vol, migration_policy\u003d\u0027never\u0027)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"class VolumeRetypeWithoutMigrationWithAttachTest("},{"line_number":184,"context_line":"        VolumeRetypeWithoutMigrationTest):"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @decorators.idempotent_id(\u0027ddf8b89e-0b1e-4a17-aeae-47f5fec970ab\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_72d25d5d","line":183,"updated":"2020-01-27 08:36:34.000000000","message":"Wondering why a new class and not just add the test in VolumeRetypeWithoutMigrationTest","commit_id":"73a063e6ddd4160d3acc8d9cca7fda408117908b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7afd534d5c0d7ed64884466b55b14c7c22d0a84d","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self._retype_volume(src_vol, migration_policy\u003d\u0027never\u0027)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"class VolumeRetypeWithoutMigrationWithAttachTest("},{"line_number":184,"context_line":"        VolumeRetypeWithoutMigrationTest):"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @decorators.idempotent_id(\u0027ddf8b89e-0b1e-4a17-aeae-47f5fec970ab\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_3d1d4e78","line":183,"in_reply_to":"3fa7e38b_72d25d5d","updated":"2020-01-31 10:51:52.000000000","message":"Test looks fine and it works, but why is this new class here when it\u0027s inherited from the one above? \n\nThe inheritance makes the test (test_available_volume_retype) from the above class executed twice (once as a test of VolumeRetypeWithoutMigrationTest and the other as a test of VolumeRetypeWithoutMigrationWithAttachTest):\n\n2020-01-27 18:52:50.091237 | controller | {0} tempest.api.volume.admin.test_volume_retype.VolumeRetypeWithoutMigrationWithAttachTest.test_attach_after_retype [29.035336s] ... ok\n2020-01-27 18:52:54.290103 | controller | {0} tempest.api.volume.admin.test_volume_retype.VolumeRetypeWithoutMigrationWithAttachTest.test_available_volume_retype [4.202340s] ... ok\n\n\u003coutput omitted\u003e\n\n2020-01-27 19:09:50.843561 | controller | {1} tempest.api.volume.admin.test_volume_retype.VolumeRetypeWithoutMigrationTest.test_available_volume_retype [3.302972s] ... ok\n\n\nI think that the new test can be moved to the class above - VolumeRetypeWithoutMigrationTest.","commit_id":"73a063e6ddd4160d3acc8d9cca7fda408117908b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ef0d98889fe2130ce050ba6961240637ae671925","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        # Check volume status"},{"line_number":194,"context_line":"        vols \u003d self.volumes_client.list_volumes(detail\u003dTrue)[\u0027volumes\u0027]"},{"line_number":195,"context_line":"        self.assertEqual(len(vols), 1)"},{"line_number":196,"context_line":"        self.assertEqual(vols[0][\u0027status\u0027], \u0027in-use\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_039c605b","line":196,"range":{"start_line":195,"start_character":0,"end_line":196,"end_character":53},"updated":"2020-04-08 14:51:06.000000000","message":"Have you considered asserts done a different way? .. because lately we were fixing some assertions in a certain tests due to race conditions - the assert checking if there is just one volume created caught my attention - what if the tests are running in parallel, can happen a situation when there would be more volumes present (created by another test/s)?","commit_id":"5f2b81726976a6813ce98a859669c4d39d011ca9"}]}