)]}'
{"tempest/tests/lib/services/network/test_routers_client.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b716472927ca58944daa47c274519b406bcc0d5b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    FAKE_UPDATE_ROUTER \u003d {"},{"line_number":58,"context_line":"        \"router\": {"},{"line_number":59,"context_line":"            \"distributed\": False,"},{"line_number":60,"context_line":"            \"external_gateway_info\": {"},{"line_number":61,"context_line":"                \"network_id\": \"ae34051f-aa6c-4c75-abf5-50dc9ac99ef3\","},{"line_number":62,"context_line":"                \"enable_snat\": True,"},{"line_number":63,"context_line":"                \"external_fixed_ips\": ["},{"line_number":64,"context_line":"                    {"},{"line_number":65,"context_line":"                        \"ip_address\": \"172.24.4.6\","},{"line_number":66,"context_line":"                        \"subnet_id\": \"b930d7f6-ceb7-40a0-8b81-a425dd994ccf\""},{"line_number":67,"context_line":"                    }"},{"line_number":68,"context_line":"                ],"},{"line_number":69,"context_line":"                \"routes\": ["},{"line_number":70,"context_line":"                    {"},{"line_number":71,"context_line":"                        \"destination\": \"179.24.1.0/24\","},{"line_number":72,"context_line":"                        \"nexthop\": \"172.24.3.99\""},{"line_number":73,"context_line":"                    }"},{"line_number":74,"context_line":"                ]"},{"line_number":75,"context_line":"            }"},{"line_number":76,"context_line":"        }"},{"line_number":77,"context_line":"    }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def setUp(self):"},{"line_number":80,"context_line":"        super(TestRoutersClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ea937158","line":77,"range":{"start_line":57,"start_character":0,"end_line":77,"end_character":5},"updated":"2020-01-31 00:59:58.000000000","message":"I guess this is copied from the request body not response.\nSo, this string should be copied from this response example instead? https://docs.openstack.org/api-ref/network/v2/index.html?expanded\u003dcreate-router-detail,update-router-detail#id214","commit_id":"5ed161464a91e9416695cf8bc1bc456dd469c43d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c624b7b35fe419e0f6217096dd42a54956acb781","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    FAKE_UPDATE_ROUTER \u003d {"},{"line_number":58,"context_line":"        \"router\": {"},{"line_number":59,"context_line":"            \"distributed\": False,"},{"line_number":60,"context_line":"            \"external_gateway_info\": {"},{"line_number":61,"context_line":"                \"network_id\": \"ae34051f-aa6c-4c75-abf5-50dc9ac99ef3\","},{"line_number":62,"context_line":"                \"enable_snat\": True,"},{"line_number":63,"context_line":"                \"external_fixed_ips\": ["},{"line_number":64,"context_line":"                    {"},{"line_number":65,"context_line":"                        \"ip_address\": \"172.24.4.6\","},{"line_number":66,"context_line":"                        \"subnet_id\": \"b930d7f6-ceb7-40a0-8b81-a425dd994ccf\""},{"line_number":67,"context_line":"                    }"},{"line_number":68,"context_line":"                ],"},{"line_number":69,"context_line":"                \"routes\": ["},{"line_number":70,"context_line":"                    {"},{"line_number":71,"context_line":"                        \"destination\": \"179.24.1.0/24\","},{"line_number":72,"context_line":"                        \"nexthop\": \"172.24.3.99\""},{"line_number":73,"context_line":"                    }"},{"line_number":74,"context_line":"                ]"},{"line_number":75,"context_line":"            }"},{"line_number":76,"context_line":"        }"},{"line_number":77,"context_line":"    }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def setUp(self):"},{"line_number":80,"context_line":"        super(TestRoutersClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b0bba672","line":77,"range":{"start_line":57,"start_character":0,"end_line":77,"end_character":5},"in_reply_to":"3fa7e38b_ea937158","updated":"2020-01-31 08:25:11.000000000","message":"right, thanks!","commit_id":"5ed161464a91e9416695cf8bc1bc456dd469c43d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"478ab637a6a8418106714a8f01eff8843ec8283f","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    FAKE_UPDATE_ROUTER \u003d {"},{"line_number":58,"context_line":"        \"router\": {"},{"line_number":59,"context_line":"            \"admin_state_up\": True,"},{"line_number":60,"context_line":"            \"availability_zone_hints\": [],"},{"line_number":61,"context_line":"            \"availability_zones\": ["},{"line_number":62,"context_line":"                \"nova\""},{"line_number":63,"context_line":"            ],"},{"line_number":64,"context_line":"            \"created_at\": \"2018-03-19T19:17:04Z\","},{"line_number":65,"context_line":"            \"description\": \"\","},{"line_number":66,"context_line":"            \"distributed\": False,"},{"line_number":67,"context_line":"            \"external_gateway_info\": {"},{"line_number":68,"context_line":"                \"enable_snat\": True,"},{"line_number":69,"context_line":"                \"external_fixed_ips\": ["},{"line_number":70,"context_line":"                    {"},{"line_number":71,"context_line":"                        \"ip_address\": \"172.24.4.6\","},{"line_number":72,"context_line":"                        \"subnet_id\": \"b930d7f6-ceb7-40a0-8b81-a425dd994ccf\""},{"line_number":73,"context_line":"                    }"},{"line_number":74,"context_line":"                ],"},{"line_number":75,"context_line":"                \"network_id\": \"ae34051f-aa6c-4c75-abf5-50dc9ac99ef3\""},{"line_number":76,"context_line":"            },"},{"line_number":77,"context_line":"            \"flavor_id\": \"f7b14d9a-b0dc-4fbe-bb14-a0f4970a69e0\","},{"line_number":78,"context_line":"            \"ha\": False,"},{"line_number":79,"context_line":"            \"id\": \"f8a44de0-fc8e-45df-93c7-f79bf3b01c95\","},{"line_number":80,"context_line":"            \"name\": \"router1\","},{"line_number":81,"context_line":"            \"revision_number\": 3,"},{"line_number":82,"context_line":"            \"routes\": ["},{"line_number":83,"context_line":"                {"},{"line_number":84,"context_line":"                    \"destination\": \"179.24.1.0/24\","},{"line_number":85,"context_line":"                    \"nexthop\": \"172.24.3.99\""},{"line_number":86,"context_line":"                }"},{"line_number":87,"context_line":"            ],"},{"line_number":88,"context_line":"            \"status\": \"ACTIVE\","},{"line_number":89,"context_line":"            \"updated_at\": \"2018-03-19T19:17:22Z\","},{"line_number":90,"context_line":"            \"project_id\": \"0bd18306d801447bb457a46252d82d13\","},{"line_number":91,"context_line":"            \"tenant_id\": \"0bd18306d801447bb457a46252d82d13\","},{"line_number":92,"context_line":"            \"service_type_id\": None,"},{"line_number":93,"context_line":"            \"tags\": [\"tag1,tag2\"],"},{"line_number":94,"context_line":"            \"conntrack_helpers\": []"},{"line_number":95,"context_line":"        }"},{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def setUp(self):"},{"line_number":99,"context_line":"        super(TestRoutersClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_6249afb7","line":96,"range":{"start_line":57,"start_character":25,"end_line":96,"end_character":5},"updated":"2020-02-20 22:08:05.000000000","message":"nit: If this is identical to the other payload can just copy.deepcopy(self.FAKE_CREATE_ROUTER) to reduce lines of code.","commit_id":"d19d7f8dc429275e802d1ce549592f8416c7e076"}]}