)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"703ea2574e92fdb28b2cd81f6604ed732c141303","unresolved":false,"context_lines":[{"line_number":1010,"context_line":"                             .format(fp\u003dfloating_ip, cst\u003dfloating_ip[\u0027status\u0027],"},{"line_number":1011,"context_line":"                                     st\u003dstatus))"},{"line_number":1012,"context_line":"        LOG.info(\"FloatingIP: {fp} is at status: {st}\""},{"line_number":1013,"context_line":"                 .format(fp\u003dfloating_ip, st\u003dfloating_ip[\u0027status\u0027]))"},{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"    def check_tenant_network_connectivity(self, server,"},{"line_number":1016,"context_line":"                                          username,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1c9d4d6b","line":1013,"range":{"start_line":1013,"start_character":44,"end_line":1013,"end_character":65},"updated":"2020-02-12 08:45:23.000000000","message":"if floating_ip[\u0027status\u0027] !\u003d status, the assert state will fail in Line 1007, so, floating_ip[\u0027status\u0027] will always be same as status here.","commit_id":"bdd8073ebc606c3c6bd84296f61b2f4390e7bbd6"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"16d6bc6cb730055ce0da16515d5ef348666e8527","unresolved":false,"context_lines":[{"line_number":1010,"context_line":"                             .format(fp\u003dfloating_ip, cst\u003dfloating_ip[\u0027status\u0027],"},{"line_number":1011,"context_line":"                                     st\u003dstatus))"},{"line_number":1012,"context_line":"        LOG.info(\"FloatingIP: {fp} is at status: {st}\""},{"line_number":1013,"context_line":"                 .format(fp\u003dfloating_ip, st\u003dfloating_ip[\u0027status\u0027]))"},{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"    def check_tenant_network_connectivity(self, server,"},{"line_number":1016,"context_line":"                                          username,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_42e8be13","line":1013,"range":{"start_line":1013,"start_character":44,"end_line":1013,"end_character":65},"in_reply_to":"3fa7e38b_1c9d4d6b","updated":"2020-02-12 10:55:22.000000000","message":"oh, right, I chose a wrong log output .. then the only way how the bug could happen is that the floating_ip was already ACTIVE when check_floating_ip_status was called and somehow during refresh it went to DOWN state for some reason, hm, that probably doesn\u0027t happen often","commit_id":"bdd8073ebc606c3c6bd84296f61b2f4390e7bbd6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aecd4f435d2f56b24c505439d12a77dc4aa80e69","unresolved":false,"context_lines":[{"line_number":995,"context_line":"        floatingip_id \u003d floating_ip[\u0027id\u0027]"},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"        def refresh():"},{"line_number":998,"context_line":"            result \u003d (self.floating_ips_client."},{"line_number":999,"context_line":"                      show_floatingip(floatingip_id)[\u0027floatingip\u0027])"},{"line_number":1000,"context_line":"            return status \u003d\u003d result[\u0027status\u0027]"},{"line_number":1001,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_269137f2","line":998,"range":{"start_line":998,"start_character":12,"end_line":998,"end_character":18},"updated":"2020-04-30 18:32:40.000000000","message":"floating_ip","commit_id":"783a9659c4595bfd9a123ea41717bd9a4e1ff2f4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aecd4f435d2f56b24c505439d12a77dc4aa80e69","unresolved":false,"context_lines":[{"line_number":997,"context_line":"        def refresh():"},{"line_number":998,"context_line":"            result \u003d (self.floating_ips_client."},{"line_number":999,"context_line":"                      show_floatingip(floatingip_id)[\u0027floatingip\u0027])"},{"line_number":1000,"context_line":"            return status \u003d\u003d result[\u0027status\u0027]"},{"line_number":1001,"context_line":""},{"line_number":1002,"context_line":"        if not test_utils.call_until_true(refresh,"},{"line_number":1003,"context_line":"                                          CONF.network.build_timeout,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_068cfbd4","line":1000,"range":{"start_line":1000,"start_character":29,"end_line":1000,"end_character":35},"updated":"2020-04-30 18:32:40.000000000","message":"floating_ip","commit_id":"783a9659c4595bfd9a123ea41717bd9a4e1ff2f4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aecd4f435d2f56b24c505439d12a77dc4aa80e69","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"                                     \"failed  to reach status: {st}\""},{"line_number":1010,"context_line":"                             .format(fp\u003dfloating_ip, cst\u003dfloating_ip[\u0027status\u0027],"},{"line_number":1011,"context_line":"                                     st\u003dstatus))"},{"line_number":1012,"context_line":"        floating_ip \u003d self.floating_ips_client.show_floatingip("},{"line_number":1013,"context_line":"            floatingip_id)[\u0027floatingip\u0027]"},{"line_number":1014,"context_line":"        LOG.info(\"FloatingIP: {fp} is at status: {st}\""},{"line_number":1015,"context_line":"                 .format(fp\u003dfloating_ip, st\u003dstatus))"},{"line_number":1016,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_e68aafbc","line":1013,"range":{"start_line":1012,"start_character":0,"end_line":1013,"end_character":40},"updated":"2020-04-30 18:32:40.000000000","message":"this will be duplicate call to get the fip. we can store the already fetched FIP and use here.","commit_id":"783a9659c4595bfd9a123ea41717bd9a4e1ff2f4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a8b5f99278a85a2ecfd5e57705a9038765d40d59","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"                                     \"failed  to reach status: {st}\""},{"line_number":1010,"context_line":"                             .format(fp\u003dfloating_ip, cst\u003dfloating_ip[\u0027status\u0027],"},{"line_number":1011,"context_line":"                                     st\u003dstatus))"},{"line_number":1012,"context_line":"        floating_ip \u003d self.floating_ips_client.show_floatingip("},{"line_number":1013,"context_line":"            floatingip_id)[\u0027floatingip\u0027]"},{"line_number":1014,"context_line":"        LOG.info(\"FloatingIP: {fp} is at status: {st}\""},{"line_number":1015,"context_line":"                 .format(fp\u003dfloating_ip, st\u003dstatus))"},{"line_number":1016,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_bab4ea36","line":1013,"range":{"start_line":1012,"start_character":0,"end_line":1013,"end_character":40},"in_reply_to":"1f493fa4_4e39eda1","updated":"2020-05-13 17:03:02.000000000","message":"is it? does not it update the arg floating_ip?","commit_id":"783a9659c4595bfd9a123ea41717bd9a4e1ff2f4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"35dd4cba5b9af98804c971b0acda809f0560e549","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"                                     \"failed  to reach status: {st}\""},{"line_number":1010,"context_line":"                             .format(fp\u003dfloating_ip, cst\u003dfloating_ip[\u0027status\u0027],"},{"line_number":1011,"context_line":"                                     st\u003dstatus))"},{"line_number":1012,"context_line":"        floating_ip \u003d self.floating_ips_client.show_floatingip("},{"line_number":1013,"context_line":"            floatingip_id)[\u0027floatingip\u0027]"},{"line_number":1014,"context_line":"        LOG.info(\"FloatingIP: {fp} is at status: {st}\""},{"line_number":1015,"context_line":"                 .format(fp\u003dfloating_ip, st\u003dstatus))"},{"line_number":1016,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_4e39eda1","line":1013,"range":{"start_line":1012,"start_character":0,"end_line":1013,"end_character":40},"in_reply_to":"1f493fa4_7c42a710","updated":"2020-05-01 14:07:32.000000000","message":"still, refresh method is a different scope, the value obtained in that method won\u0027t get to the floating_ip outside of the method\n.. unless we use \u0027global\u0027 within refresh","commit_id":"783a9659c4595bfd9a123ea41717bd9a4e1ff2f4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a6cb3b055242edd51b343a47c35e37d82caf9be2","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"                                     \"failed  to reach status: {st}\""},{"line_number":1010,"context_line":"                             .format(fp\u003dfloating_ip, cst\u003dfloating_ip[\u0027status\u0027],"},{"line_number":1011,"context_line":"                                     st\u003dstatus))"},{"line_number":1012,"context_line":"        floating_ip \u003d self.floating_ips_client.show_floatingip("},{"line_number":1013,"context_line":"            floatingip_id)[\u0027floatingip\u0027]"},{"line_number":1014,"context_line":"        LOG.info(\"FloatingIP: {fp} is at status: {st}\""},{"line_number":1015,"context_line":"                 .format(fp\u003dfloating_ip, st\u003dstatus))"},{"line_number":1016,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_65b902e8","line":1013,"range":{"start_line":1012,"start_character":0,"end_line":1013,"end_character":40},"in_reply_to":"1f493fa4_bab4ea36","updated":"2020-05-13 17:23:52.000000000","message":"seems not, also when you look at the comments in the next (3rd) patch-set, the example with global by zhufl didn\u0027t work ..\n\nhttps://review.opendev.org/#/c/704293/3/tempest/scenario/manager.py@998","commit_id":"783a9659c4595bfd9a123ea41717bd9a4e1ff2f4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"57bfbce95d3f5842053e59bd1f183aff00723778","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"                                     \"failed  to reach status: {st}\""},{"line_number":1010,"context_line":"                             .format(fp\u003dfloating_ip, cst\u003dfloating_ip[\u0027status\u0027],"},{"line_number":1011,"context_line":"                                     st\u003dstatus))"},{"line_number":1012,"context_line":"        floating_ip \u003d self.floating_ips_client.show_floatingip("},{"line_number":1013,"context_line":"            floatingip_id)[\u0027floatingip\u0027]"},{"line_number":1014,"context_line":"        LOG.info(\"FloatingIP: {fp} is at status: {st}\""},{"line_number":1015,"context_line":"                 .format(fp\u003dfloating_ip, st\u003dstatus))"},{"line_number":1016,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_7c42a710","line":1013,"range":{"start_line":1012,"start_character":0,"end_line":1013,"end_character":40},"in_reply_to":"1f493fa4_e4d747be","updated":"2020-05-01 00:50:19.000000000","message":"in this proposed case, we will be calling show API before log which is not needed if we store the show FIP result in floating_ip in refresh method so that floating_ip used in log is always latest.","commit_id":"783a9659c4595bfd9a123ea41717bd9a4e1ff2f4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2a28fcad455c22b53f6f539651a6e05da1c9929e","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"                                     \"failed  to reach status: {st}\""},{"line_number":1010,"context_line":"                             .format(fp\u003dfloating_ip, cst\u003dfloating_ip[\u0027status\u0027],"},{"line_number":1011,"context_line":"                                     st\u003dstatus))"},{"line_number":1012,"context_line":"        floating_ip \u003d self.floating_ips_client.show_floatingip("},{"line_number":1013,"context_line":"            floatingip_id)[\u0027floatingip\u0027]"},{"line_number":1014,"context_line":"        LOG.info(\"FloatingIP: {fp} is at status: {st}\""},{"line_number":1015,"context_line":"                 .format(fp\u003dfloating_ip, st\u003dstatus))"},{"line_number":1016,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_e4d747be","line":1013,"range":{"start_line":1012,"start_character":0,"end_line":1013,"end_character":40},"in_reply_to":"1f493fa4_e68aafbc","updated":"2020-04-30 20:09:44.000000000","message":"It won\u0027t be duplicate in matter of being called twice in one run. If refresh method returns (as a final return) false (we haven\u0027t got to the wanted state), the code execution gets to the conditional branch where it fails the assert, so the second show_floatingip won\u0027t happen.\n\nIf refresh method returns true (we\u0027ve got to the wanted state), the conditional branch is skipped (so the first show_floatingip call won\u0027t happen) and in order to log correctly we need to call show_floatingip to get the latest state to log out.","commit_id":"783a9659c4595bfd9a123ea41717bd9a4e1ff2f4"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"575eda391d66d18d1f3d1935ae0ae9bf2c8adc4d","unresolved":false,"context_lines":[{"line_number":995,"context_line":"        floatingip_id \u003d floating_ip[\u0027id\u0027]"},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"        def refresh():"},{"line_number":998,"context_line":"            global floating_ip"},{"line_number":999,"context_line":"            floating_ip \u003d (self.floating_ips_client."},{"line_number":1000,"context_line":"                           show_floatingip(floatingip_id)[\u0027floatingip\u0027])"},{"line_number":1001,"context_line":"            return status \u003d\u003d floating_ip[\u0027status\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_2488bd1d","line":998,"range":{"start_line":998,"start_character":12,"end_line":998,"end_character":30},"updated":"2020-05-06 03:33:58.000000000","message":"def test2(name):\n    def _rename():\n        global name\n        name \u003d \"pear\"\n    _rename()\n    print(name)\n\nname \u003d \"apple\"\ntest2(name)\n\n# executing this we will get:\n\"apple\"","commit_id":"81963e086feb7ab04fcd8ee0f0aeaca90409ebbc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a8b5f99278a85a2ecfd5e57705a9038765d40d59","unresolved":false,"context_lines":[{"line_number":995,"context_line":"        floatingip_id \u003d floating_ip[\u0027id\u0027]"},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"        def refresh():"},{"line_number":998,"context_line":"            global floating_ip"},{"line_number":999,"context_line":"            floating_ip \u003d (self.floating_ips_client."},{"line_number":1000,"context_line":"                           show_floatingip(floatingip_id)[\u0027floatingip\u0027])"},{"line_number":1001,"context_line":"            return status \u003d\u003d floating_ip[\u0027status\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_fa9e72b6","line":998,"range":{"start_line":998,"start_character":0,"end_line":998,"end_character":30},"updated":"2020-05-13 17:03:02.000000000","message":"instead of all this new class and all we can just move the  log inside the refresh and remove from L1012.\n\n        def refresh():\n            success \u003d False\n            result \u003d (self.floating_ips_client.\n                      show_floatingip(floatingip_id)[\u0027floatingip\u0027])\n            if status \u003d\u003d result[\u0027status\u0027]:\n                LOG.info(\"FloatingIP: {fp} is at status: {st}\"\n                 .format(fp\u003dfloating_ip, st\u003dstatus))\n                success \u003d True\n            return success","commit_id":"81963e086feb7ab04fcd8ee0f0aeaca90409ebbc"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"22f8e8143338cd5273cdb7062f5f38e5e997ab23","unresolved":false,"context_lines":[{"line_number":995,"context_line":"        floatingip_id \u003d floating_ip[\u0027id\u0027]"},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"        def refresh():"},{"line_number":998,"context_line":"            global floating_ip"},{"line_number":999,"context_line":"            floating_ip \u003d (self.floating_ips_client."},{"line_number":1000,"context_line":"                           show_floatingip(floatingip_id)[\u0027floatingip\u0027])"},{"line_number":1001,"context_line":"            return status \u003d\u003d floating_ip[\u0027status\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_532aec7d","line":998,"range":{"start_line":998,"start_character":12,"end_line":998,"end_character":30},"in_reply_to":"1f493fa4_2488bd1d","updated":"2020-05-06 07:35:56.000000000","message":"you\u0027re right, i tested it in a slightly different scope which seems wasn\u0027t just slightly different for global usage :/","commit_id":"81963e086feb7ab04fcd8ee0f0aeaca90409ebbc"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"7aa83d5e61792c845bdc0fd1f8d763f43d68dba7","unresolved":false,"context_lines":[{"line_number":995,"context_line":"        floatingip_id \u003d floating_ip[\u0027id\u0027]"},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"        def refresh():"},{"line_number":998,"context_line":"            global floating_ip"},{"line_number":999,"context_line":"            floating_ip \u003d (self.floating_ips_client."},{"line_number":1000,"context_line":"                           show_floatingip(floatingip_id)[\u0027floatingip\u0027])"},{"line_number":1001,"context_line":"            return status \u003d\u003d floating_ip[\u0027status\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_73ef2887","line":998,"range":{"start_line":998,"start_character":12,"end_line":998,"end_character":30},"in_reply_to":"1f493fa4_532aec7d","updated":"2020-05-06 08:32:37.000000000","message":"\"nonlocal floating_ip\" can work, but it can only work in py3.","commit_id":"81963e086feb7ab04fcd8ee0f0aeaca90409ebbc"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"16fafbc57dd8221545ff7bf42c0475afda2ebd33","unresolved":false,"context_lines":[{"line_number":995,"context_line":"        floatingip_id \u003d floating_ip[\u0027id\u0027]"},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"        def refresh():"},{"line_number":998,"context_line":"            global floating_ip"},{"line_number":999,"context_line":"            floating_ip \u003d (self.floating_ips_client."},{"line_number":1000,"context_line":"                           show_floatingip(floatingip_id)[\u0027floatingip\u0027])"},{"line_number":1001,"context_line":"            return status \u003d\u003d floating_ip[\u0027status\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_96d3c2d5","line":998,"range":{"start_line":998,"start_character":12,"end_line":998,"end_character":30},"in_reply_to":"1f493fa4_73ef2887","updated":"2020-05-06 09:34:18.000000000","message":"hmm, I tried in the next patchset using a class for exchanging the data, maybe that\u0027s less disturbing than using global/nonlocal .. etc?","commit_id":"81963e086feb7ab04fcd8ee0f0aeaca90409ebbc"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a6cb3b055242edd51b343a47c35e37d82caf9be2","unresolved":false,"context_lines":[{"line_number":995,"context_line":"        floatingip_id \u003d floating_ip[\u0027id\u0027]"},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"        def refresh():"},{"line_number":998,"context_line":"            global floating_ip"},{"line_number":999,"context_line":"            floating_ip \u003d (self.floating_ips_client."},{"line_number":1000,"context_line":"                           show_floatingip(floatingip_id)[\u0027floatingip\u0027])"},{"line_number":1001,"context_line":"            return status \u003d\u003d floating_ip[\u0027status\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_850ff6df","line":998,"range":{"start_line":998,"start_character":0,"end_line":998,"end_character":30},"in_reply_to":"1f493fa4_fa9e72b6","updated":"2020-05-13 17:23:52.000000000","message":"we can but in that case the log msg will be printed out repeatedly with every refresh method run .. from the original code I got an impression, that\u0027s not wanted, but if we want to print it multiple times (usually the refresh method is probably not executed that many times) it would very much simplify everything","commit_id":"81963e086feb7ab04fcd8ee0f0aeaca90409ebbc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb84aab6da5236b3a68148ba492ceb8be5389bf5","unresolved":false,"context_lines":[{"line_number":995,"context_line":"        floatingip_id \u003d floating_ip[\u0027id\u0027]"},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"        def refresh():"},{"line_number":998,"context_line":"            global floating_ip"},{"line_number":999,"context_line":"            floating_ip \u003d (self.floating_ips_client."},{"line_number":1000,"context_line":"                           show_floatingip(floatingip_id)[\u0027floatingip\u0027])"},{"line_number":1001,"context_line":"            return status \u003d\u003d floating_ip[\u0027status\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_b7ccf1bc","line":998,"range":{"start_line":998,"start_character":0,"end_line":998,"end_character":30},"in_reply_to":"ff570b3c_850ff6df","updated":"2020-05-13 17:48:15.000000000","message":"we can make it only log when it reach to requested status with if condition I mentioned in comment.","commit_id":"81963e086feb7ab04fcd8ee0f0aeaca90409ebbc"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d243be1dd27f0202f5f2a12ad9a3abe00d080a09","unresolved":false,"context_lines":[{"line_number":995,"context_line":"        floatingip_id \u003d floating_ip[\u0027id\u0027]"},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"        def refresh():"},{"line_number":998,"context_line":"            global floating_ip"},{"line_number":999,"context_line":"            floating_ip \u003d (self.floating_ips_client."},{"line_number":1000,"context_line":"                           show_floatingip(floatingip_id)[\u0027floatingip\u0027])"},{"line_number":1001,"context_line":"            return status \u003d\u003d floating_ip[\u0027status\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_07e120d1","line":998,"range":{"start_line":998,"start_character":0,"end_line":998,"end_character":30},"in_reply_to":"ff570b3c_b7ccf1bc","updated":"2020-05-14 07:41:15.000000000","message":"agree , let\u0027s do it that way .. i got carried away by the class and it end up more complicated than one condition in the refresh method.","commit_id":"81963e086feb7ab04fcd8ee0f0aeaca90409ebbc"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"5793a62acfdcf448520f225655b1b8d17e042206","unresolved":false,"context_lines":[{"line_number":1003,"context_line":"        fip \u003d FIP(floating_ip)"},{"line_number":1004,"context_line":""},{"line_number":1005,"context_line":"        def refresh(fip):"},{"line_number":1006,"context_line":"            fip.floating_ip \u003d (self.floating_ips_client."},{"line_number":1007,"context_line":"                               show_floatingip(floatingip_id)[\u0027floatingip\u0027])"},{"line_number":1008,"context_line":"            return status \u003d\u003d fip.floating_ip[\u0027status\u0027]"},{"line_number":1009,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_b6b7de86","line":1006,"range":{"start_line":1006,"start_character":12,"end_line":1006,"end_character":27},"updated":"2020-05-06 09:40:23.000000000","message":"Maybe we can use self.floating_ip directly?","commit_id":"06107d983c40c479ce478bf3163f7f028c09babe"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a257efc8484b5d2f09c7a2e6e4fa4dcc609dc7dc","unresolved":false,"context_lines":[{"line_number":1003,"context_line":"        fip \u003d FIP(floating_ip)"},{"line_number":1004,"context_line":""},{"line_number":1005,"context_line":"        def refresh(fip):"},{"line_number":1006,"context_line":"            fip.floating_ip \u003d (self.floating_ips_client."},{"line_number":1007,"context_line":"                               show_floatingip(floatingip_id)[\u0027floatingip\u0027])"},{"line_number":1008,"context_line":"            return status \u003d\u003d fip.floating_ip[\u0027status\u0027]"},{"line_number":1009,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_64f5a1cb","line":1006,"range":{"start_line":1006,"start_character":12,"end_line":1006,"end_character":27},"in_reply_to":"1f493fa4_b6b7de86","updated":"2020-05-12 17:58:42.000000000","message":"right, let\u0027s edit it even more then","commit_id":"06107d983c40c479ce478bf3163f7f028c09babe"}]}