)]}'
{"roles/run-tempest/README.rst":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6d73e4ebb94f45f6b20bf4447eadb23698caabd4","unresolved":false,"context_lines":[{"line_number":76,"context_line":".. zuul:rolevar:: use_stable_constraint"},{"line_number":77,"context_line":"   :default: \u0027\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"   Upper constraint to be used for stable branch till stable/rocky."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":".. zuul:rolevar:: tempest_tox_environment"},{"line_number":82,"context_line":"   :default: \u0027\u0027"}],"source_content_type":"text/x-rst","patch_set":23,"id":"3fa7e38b_043b129b","line":79,"range":{"start_line":79,"start_character":9,"end_line":79,"end_character":19},"updated":"2020-02-06 00:57:47.000000000","message":"\"constraints file\"","commit_id":"0a6b955e08be9a879d4583c32a3594c8941dc25a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9af6aeeeee670246969365ad650b6a37c860c619","unresolved":false,"context_lines":[{"line_number":76,"context_line":".. zuul:rolevar:: use_stable_constraint"},{"line_number":77,"context_line":"   :default: \u0027\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"   Upper constraint to be used for stable branch till stable/rocky."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":".. zuul:rolevar:: tempest_tox_environment"},{"line_number":82,"context_line":"   :default: \u0027\u0027"}],"source_content_type":"text/x-rst","patch_set":23,"id":"3fa7e38b_84bf02aa","line":79,"range":{"start_line":79,"start_character":9,"end_line":79,"end_character":19},"in_reply_to":"3fa7e38b_043b129b","updated":"2020-02-06 01:13:00.000000000","message":"Done","commit_id":"0a6b955e08be9a879d4583c32a3594c8941dc25a"}],"roles/run-tempest/defaults/main.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6d73e4ebb94f45f6b20bf4447eadb23698caabd4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"tempest_black_regex: \u0027\u0027"},{"line_number":5,"context_line":"tox_extra_args: \u0027\u0027"},{"line_number":6,"context_line":"tempest_test_timeout: \u0027\u0027"},{"line_number":7,"context_line":"use_stable_constraint: \"{{ devstack_base_dir }}/requirements/upper-constraints.txt\""},{"line_number":8,"context_line":"target_branch: \"{{ zuul.branch }}\""},{"line_number":9,"context_line":"tempest_tox_environment: {}"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_848b8267","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":22},"updated":"2020-02-06 00:57:47.000000000","message":"use_xxxx is usually used for boolean variables, but it contains a path to a constraints file. \"constraints_file\" or \"stable_constraints_file\" looks better.","commit_id":"0a6b955e08be9a879d4583c32a3594c8941dc25a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9af6aeeeee670246969365ad650b6a37c860c619","unresolved":false,"context_lines":[{"line_number":4,"context_line":"tempest_black_regex: \u0027\u0027"},{"line_number":5,"context_line":"tox_extra_args: \u0027\u0027"},{"line_number":6,"context_line":"tempest_test_timeout: \u0027\u0027"},{"line_number":7,"context_line":"use_stable_constraint: \"{{ devstack_base_dir }}/requirements/upper-constraints.txt\""},{"line_number":8,"context_line":"target_branch: \"{{ zuul.branch }}\""},{"line_number":9,"context_line":"tempest_tox_environment: {}"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_44d7caf5","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":22},"in_reply_to":"3fa7e38b_848b8267","updated":"2020-02-06 01:13:00.000000000","message":"make sense. done","commit_id":"0a6b955e08be9a879d4583c32a3594c8941dc25a"}],"roles/run-tempest/tasks/main.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ea5ec70c1da515caefe02e480e7db494d9eccae1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  set_fact:"},{"line_number":25,"context_line":"    use_stable_constraint: \"{{ devstack_base_dir }}/requirements/upper-constraints.txt\""},{"line_number":26,"context_line":"  when: \u003e"},{"line_number":27,"context_line":"    zuul.branch \u003d\u003d \"stable/ocata or zuul.branch \u003d\u003d \"stable/pike or zuul.branch \u003d\u003d \"stable/queens or zuul.branch \u003d\u003d \"stable/rocky or"},{"line_number":28,"context_line":"    (zuul.override_checkout is defined and (zuul.override_checkout \u003d\u003d \"stable/ocata or zuul.override_checkout \u003d\u003d \"stable/pike or zuul.override_checkout \u003d\u003d \"stable/queens or zuul.override_checkout \u003d\u003d \"stable/rocky))"},{"line_number":29,"context_line":"  environment: \u0027{{ {\"UPPER_CONSTRAINTS_FILE\": use_stable_constraint} if use_stable_constraint else {} }}\u0027"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_fea76c09","line":27,"updated":"2020-02-05 16:24:23.000000000","message":"No closing double quote. Is it right?","commit_id":"13c6ef2169642d902de9da325a3a836766342cae"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3de2645d2bbbfd39db7ece335aca93132685fd6f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  set_fact:"},{"line_number":25,"context_line":"    use_stable_constraint: \"{{ devstack_base_dir }}/requirements/upper-constraints.txt\""},{"line_number":26,"context_line":"  when: \u003e"},{"line_number":27,"context_line":"    zuul.branch \u003d\u003d \"stable/ocata or zuul.branch \u003d\u003d \"stable/pike or zuul.branch \u003d\u003d \"stable/queens or zuul.branch \u003d\u003d \"stable/rocky or"},{"line_number":28,"context_line":"    (zuul.override_checkout is defined and (zuul.override_checkout \u003d\u003d \"stable/ocata or zuul.override_checkout \u003d\u003d \"stable/pike or zuul.override_checkout \u003d\u003d \"stable/queens or zuul.override_checkout \u003d\u003d \"stable/rocky))"},{"line_number":29,"context_line":"  environment: \u0027{{ {\"UPPER_CONSTRAINTS_FILE\": use_stable_constraint} if use_stable_constraint else {} }}\u0027"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_9eb8b8e7","line":27,"in_reply_to":"3fa7e38b_fea76c09","updated":"2020-02-05 16:38:11.000000000","message":"oh, i missed that. thanks","commit_id":"13c6ef2169642d902de9da325a3a836766342cae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ea5ec70c1da515caefe02e480e7db494d9eccae1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    use_stable_constraint: \"{{ devstack_base_dir }}/requirements/upper-constraints.txt\""},{"line_number":26,"context_line":"  when: \u003e"},{"line_number":27,"context_line":"    zuul.branch \u003d\u003d \"stable/ocata or zuul.branch \u003d\u003d \"stable/pike or zuul.branch \u003d\u003d \"stable/queens or zuul.branch \u003d\u003d \"stable/rocky or"},{"line_number":28,"context_line":"    (zuul.override_checkout is defined and (zuul.override_checkout \u003d\u003d \"stable/ocata or zuul.override_checkout \u003d\u003d \"stable/pike or zuul.override_checkout \u003d\u003d \"stable/queens or zuul.override_checkout \u003d\u003d \"stable/rocky))"},{"line_number":29,"context_line":"  environment: \u0027{{ {\"UPPER_CONSTRAINTS_FILE\": use_stable_constraint} if use_stable_constraint else {} }}\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- when:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_bedfb465","line":28,"updated":"2020-02-05 16:24:23.000000000","message":"In this case, it is better to prepare a variable which contains the target branch first.\n\n - set_fact:\n     target_branch: \"{{ zuul.override_checkout }}\"\n   when zuul.override_checkout is defined\n - set_fact:\n     target_branch: \"{{ zuu.branch }}\"\n   when zuul.override_checkout is not defined\n - set_fact:\n     use_stable_constrant: ....","commit_id":"13c6ef2169642d902de9da325a3a836766342cae"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3de2645d2bbbfd39db7ece335aca93132685fd6f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    use_stable_constraint: \"{{ devstack_base_dir }}/requirements/upper-constraints.txt\""},{"line_number":26,"context_line":"  when: \u003e"},{"line_number":27,"context_line":"    zuul.branch \u003d\u003d \"stable/ocata or zuul.branch \u003d\u003d \"stable/pike or zuul.branch \u003d\u003d \"stable/queens or zuul.branch \u003d\u003d \"stable/rocky or"},{"line_number":28,"context_line":"    (zuul.override_checkout is defined and (zuul.override_checkout \u003d\u003d \"stable/ocata or zuul.override_checkout \u003d\u003d \"stable/pike or zuul.override_checkout \u003d\u003d \"stable/queens or zuul.override_checkout \u003d\u003d \"stable/rocky))"},{"line_number":29,"context_line":"  environment: \u0027{{ {\"UPPER_CONSTRAINTS_FILE\": use_stable_constraint} if use_stable_constraint else {} }}\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- when:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_1e892828","line":28,"in_reply_to":"3fa7e38b_bedfb465","updated":"2020-02-05 16:38:11.000000000","message":"yeah, this is much better","commit_id":"13c6ef2169642d902de9da325a3a836766342cae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ea5ec70c1da515caefe02e480e7db494d9eccae1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  when: \u003e"},{"line_number":27,"context_line":"    zuul.branch \u003d\u003d \"stable/ocata or zuul.branch \u003d\u003d \"stable/pike or zuul.branch \u003d\u003d \"stable/queens or zuul.branch \u003d\u003d \"stable/rocky or"},{"line_number":28,"context_line":"    (zuul.override_checkout is defined and (zuul.override_checkout \u003d\u003d \"stable/ocata or zuul.override_checkout \u003d\u003d \"stable/pike or zuul.override_checkout \u003d\u003d \"stable/queens or zuul.override_checkout \u003d\u003d \"stable/rocky))"},{"line_number":29,"context_line":"  environment: \u0027{{ {\"UPPER_CONSTRAINTS_FILE\": use_stable_constraint} if use_stable_constraint else {} }}\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- when:"},{"line_number":32,"context_line":"    - tempest_test_blacklist is defined"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_fe43ec10","line":29,"updated":"2020-02-05 16:24:23.000000000","message":"What is this \"environment\" state for? \"environment\" affects a specific task. This set_fact task refers to nothing, so it looks unnecessary.\n\nPerhaps you would like to pass UPPER_CONSTRAINTS_FILE to \"Run Tempest\" task below.","commit_id":"13c6ef2169642d902de9da325a3a836766342cae"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3de2645d2bbbfd39db7ece335aca93132685fd6f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  when: \u003e"},{"line_number":27,"context_line":"    zuul.branch \u003d\u003d \"stable/ocata or zuul.branch \u003d\u003d \"stable/pike or zuul.branch \u003d\u003d \"stable/queens or zuul.branch \u003d\u003d \"stable/rocky or"},{"line_number":28,"context_line":"    (zuul.override_checkout is defined and (zuul.override_checkout \u003d\u003d \"stable/ocata or zuul.override_checkout \u003d\u003d \"stable/pike or zuul.override_checkout \u003d\u003d \"stable/queens or zuul.override_checkout \u003d\u003d \"stable/rocky))"},{"line_number":29,"context_line":"  environment: \u0027{{ {\"UPPER_CONSTRAINTS_FILE\": use_stable_constraint} if use_stable_constraint else {} }}\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- when:"},{"line_number":32,"context_line":"    - tempest_test_blacklist is defined"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_fe8d2c36","line":29,"in_reply_to":"3fa7e38b_fe43ec10","updated":"2020-02-05 16:38:11.000000000","message":"Done","commit_id":"13c6ef2169642d902de9da325a3a836766342cae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ea5ec70c1da515caefe02e480e7db494d9eccae1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    chdir: \"{{devstack_base_dir}}/tempest\""},{"line_number":51,"context_line":"  become: true"},{"line_number":52,"context_line":"  become_user: tempest"},{"line_number":53,"context_line":"  environment: \u0027{{ {\"OS_TEST_TIMEOUT\": tempest_test_timeout} if tempest_test_timeout else {} }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_5ed9e052","line":53,"updated":"2020-02-05 16:24:23.000000000","message":"I think we need to pass UPPER_CONSTRAINTS_FILE envvar here.\nYou can use dict style.\nhttps://docs.ansible.com/ansible/latest/user_guide/playbooks_environment.html\n\n  environment:\n     OS_TEST_TIMEOUT: \"{{ tempest_test_timeout|default(omit) }}\"\n     UPPER_CONSTRAINTS_FILE: \"{{ use_stable_constraint|default(omit) }}\"\n\nI haven\u0027t tested if \"default(omit)\" works in \"environment\" specification though.\n https://docs.ansible.com/ansible/latest/user_guide/playbooks_filters.html#omitting-parameters","commit_id":"13c6ef2169642d902de9da325a3a836766342cae"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3de2645d2bbbfd39db7ece335aca93132685fd6f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    chdir: \"{{devstack_base_dir}}/tempest\""},{"line_number":51,"context_line":"  become: true"},{"line_number":52,"context_line":"  become_user: tempest"},{"line_number":53,"context_line":"  environment: \u0027{{ {\"OS_TEST_TIMEOUT\": tempest_test_timeout} if tempest_test_timeout else {} }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_5ea7a0bc","line":53,"in_reply_to":"3fa7e38b_5ed9e052","updated":"2020-02-05 16:38:11.000000000","message":"yeah omit is not supported in env we can use {}","commit_id":"13c6ef2169642d902de9da325a3a836766342cae"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d4fb0610a84f6ceb3e84422670ccbd76a8d98ca4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"- name: Use stable branch upper-constraint till stable/rocky"},{"line_number":29,"context_line":"  set_fact:"},{"line_number":30,"context_line":"    use_stable_constraint: \"{{ devstack_base_dir }}/requirements/upper-constraints.txt\""},{"line_number":31,"context_line":"  when: target_branch \u003d\u003d \"stable/ocata\" or target_branch \u003d\u003d \"stable/pike\" or target_branch \u003d\u003d \"stable/queens\" or target_branch \u003d\u003d \"stable/rocky\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- when:"},{"line_number":34,"context_line":"    - tempest_test_blacklist is defined"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_b95cae1a","line":31,"updated":"2020-02-05 16:52:46.000000000","message":"when: target_branch in [\u0027stable/ocata\u0027, ...]\n\n(though a regex on stable/ should be better)","commit_id":"6d308e285f533f41e3ed0c1d69f3dd567cf62c77"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8b51ed14acf8c717b6ac739c8d0a0f3e48ed961b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"- name: Use stable branch upper-constraint till stable/rocky"},{"line_number":29,"context_line":"  set_fact:"},{"line_number":30,"context_line":"    use_stable_constraint: \"{{ devstack_base_dir }}/requirements/upper-constraints.txt\""},{"line_number":31,"context_line":"  when: target_branch \u003d\u003d \"stable/ocata\" or target_branch \u003d\u003d \"stable/pike\" or target_branch \u003d\u003d \"stable/queens\" or target_branch \u003d\u003d \"stable/rocky\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- when:"},{"line_number":34,"context_line":"    - tempest_test_blacklist is defined"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_d9616aa4","line":31,"in_reply_to":"3fa7e38b_b95cae1a","updated":"2020-02-05 16:55:04.000000000","message":"yeah, tried few regex way. let\u0027s check if plain comparison work and then we can convert to more regex way","commit_id":"6d308e285f533f41e3ed0c1d69f3dd567cf62c77"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d4fb0610a84f6ceb3e84422670ccbd76a8d98ca4","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  become: true"},{"line_number":54,"context_line":"  become_user: tempest"},{"line_number":55,"context_line":"  environment:"},{"line_number":56,"context_line":"     \u0027{{ {\"OS_TEST_TIMEOUT\": tempest_test_timeout} if tempest_test_timeout else {} }}\u0027"},{"line_number":57,"context_line":"     \u0027{{ {\"UPPER_CONSTRAINTS_FILE\": use_stable_constraint} if use_stable_constraint else {} }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_39699ebf","line":56,"updated":"2020-02-05 16:52:46.000000000","message":"not going to work this way, please see the commits of mine which you have reverted","commit_id":"6d308e285f533f41e3ed0c1d69f3dd567cf62c77"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"230e09128ddf80a530fc22149d060ce64da78875","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  become: true"},{"line_number":54,"context_line":"  become_user: tempest"},{"line_number":55,"context_line":"  environment:"},{"line_number":56,"context_line":"     \u0027{{ {\"OS_TEST_TIMEOUT\": tempest_test_timeout} if tempest_test_timeout else {} }}\u0027"},{"line_number":57,"context_line":"     \u0027{{ {\"UPPER_CONSTRAINTS_FILE\": use_stable_constraint} if use_stable_constraint else {} }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_1919428a","line":56,"in_reply_to":"3fa7e38b_39699ebf","updated":"2020-02-05 17:18:16.000000000","message":"let me combine that.","commit_id":"6d308e285f533f41e3ed0c1d69f3dd567cf62c77"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6d73e4ebb94f45f6b20bf4447eadb23698caabd4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    target_branch: \"{{ zuul.override_checkout }}\""},{"line_number":26,"context_line":"  when: zuul.override_checkout is defined"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Use stable branch upper-constraint till stable/rocky"},{"line_number":29,"context_line":"  set_fact:"},{"line_number":30,"context_line":"    tempest_tox_environment: \"{{ tempest_tox_environment | combine({\u0027UPPER_CONSTRAINTS_FILE\u0027:use_stable_constraint}) }}\""},{"line_number":31,"context_line":"  when: target_branch in [\"stable/ocata\", \"stable/pike\", \"stable/queens\", \"stable/rocky\"]"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_24f08efc","line":28,"range":{"start_line":28,"start_character":32,"end_line":28,"end_character":43},"updated":"2020-02-06 00:57:47.000000000","message":"-\u003e constraints","commit_id":"0a6b955e08be9a879d4583c32a3594c8941dc25a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9af6aeeeee670246969365ad650b6a37c860c619","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    target_branch: \"{{ zuul.override_checkout }}\""},{"line_number":26,"context_line":"  when: zuul.override_checkout is defined"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Use stable branch upper-constraint till stable/rocky"},{"line_number":29,"context_line":"  set_fact:"},{"line_number":30,"context_line":"    tempest_tox_environment: \"{{ tempest_tox_environment | combine({\u0027UPPER_CONSTRAINTS_FILE\u0027:use_stable_constraint}) }}\""},{"line_number":31,"context_line":"  when: target_branch in [\"stable/ocata\", \"stable/pike\", \"stable/queens\", \"stable/rocky\"]"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_64da061d","line":28,"range":{"start_line":28,"start_character":32,"end_line":28,"end_character":43},"in_reply_to":"3fa7e38b_24f08efc","updated":"2020-02-06 01:13:00.000000000","message":"Done","commit_id":"0a6b955e08be9a879d4583c32a3594c8941dc25a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6d73e4ebb94f45f6b20bf4447eadb23698caabd4","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Use stable branch upper-constraint till stable/rocky"},{"line_number":29,"context_line":"  set_fact:"},{"line_number":30,"context_line":"    tempest_tox_environment: \"{{ tempest_tox_environment | combine({\u0027UPPER_CONSTRAINTS_FILE\u0027:use_stable_constraint}) }}\""},{"line_number":31,"context_line":"  when: target_branch in [\"stable/ocata\", \"stable/pike\", \"stable/queens\", \"stable/rocky\"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Set OS_TEST_TIMEOUT if requested"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_a4db1e78","line":30,"range":{"start_line":30,"start_character":92,"end_line":30,"end_character":93},"updated":"2020-02-06 00:57:47.000000000","message":"It is better to have a space after the colon.","commit_id":"0a6b955e08be9a879d4583c32a3594c8941dc25a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9af6aeeeee670246969365ad650b6a37c860c619","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Use stable branch upper-constraint till stable/rocky"},{"line_number":29,"context_line":"  set_fact:"},{"line_number":30,"context_line":"    tempest_tox_environment: \"{{ tempest_tox_environment | combine({\u0027UPPER_CONSTRAINTS_FILE\u0027:use_stable_constraint}) }}\""},{"line_number":31,"context_line":"  when: target_branch in [\"stable/ocata\", \"stable/pike\", \"stable/queens\", \"stable/rocky\"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Set OS_TEST_TIMEOUT if requested"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_04e1d2cf","line":30,"range":{"start_line":30,"start_character":92,"end_line":30,"end_character":93},"in_reply_to":"3fa7e38b_a4db1e78","updated":"2020-02-06 01:13:00.000000000","message":"Done","commit_id":"0a6b955e08be9a879d4583c32a3594c8941dc25a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6d73e4ebb94f45f6b20bf4447eadb23698caabd4","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Set OS_TEST_TIMEOUT if requested"},{"line_number":34,"context_line":"  set_fact:"},{"line_number":35,"context_line":"    tempest_tox_environment: \"{{ tempest_tox_run_environment | combine({\u0027OS_TEST_TIMEOUT\u0027:tempest_test_timeout}) }}\""},{"line_number":36,"context_line":"  when: tempest_test_timeout !\u003d \u0027\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- when:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_44ccaabd","line":35,"range":{"start_line":35,"start_character":89,"end_line":35,"end_character":90},"updated":"2020-02-06 00:57:47.000000000","message":"ditto","commit_id":"0a6b955e08be9a879d4583c32a3594c8941dc25a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9af6aeeeee670246969365ad650b6a37c860c619","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Set OS_TEST_TIMEOUT if requested"},{"line_number":34,"context_line":"  set_fact:"},{"line_number":35,"context_line":"    tempest_tox_environment: \"{{ tempest_tox_run_environment | combine({\u0027OS_TEST_TIMEOUT\u0027:tempest_test_timeout}) }}\""},{"line_number":36,"context_line":"  when: tempest_test_timeout !\u003d \u0027\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- when:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_24e40edf","line":35,"range":{"start_line":35,"start_character":89,"end_line":35,"end_character":90},"in_reply_to":"3fa7e38b_44ccaabd","updated":"2020-02-06 01:13:00.000000000","message":"Done","commit_id":"0a6b955e08be9a879d4583c32a3594c8941dc25a"}]}