)]}'
{"tempest/api/volume/admin/test_encrypted_volumes_extend.py":[{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"30b91258312cedbbde7342cdbc7b736336ead961","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class EncryptedVolumesExtendAttachedTest(extend.BaseVolumesExtendAttachedTest,"},{"line_number":25,"context_line":"                                         base.BaseVolumeAdminTest):"},{"line_number":26,"context_line":"    \"\"\"Tests extending the size of an attached encrypted volume.\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @decorators.idempotent_id(\u0027e93243ec-7c37-4b5b-a099-ebf052c13216\u0027)"},{"line_number":29,"context_line":"    @testtools.skipUnless("},{"line_number":30,"context_line":"        CONF.volume_feature_enabled.extend_attached_encrypted_volume,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_9135a7fa","line":27,"updated":"2020-06-16 19:12:14.000000000","message":"Since extending attached encrypted volumes are supported since api version 3.42, shouldn\u0027t there be a:\n`min_microversion \u003d 3.42` Using a lower api microversion gives me this error:\nFailed to set volume size: Volume is in in-use state, it must be available before size can be extended\nOne or more of the set operations failed\n\n\n[1] https://docs.openstack.org/api-ref/block-storage/api_microversion_history.html","commit_id":"4bd9edbd3bf7ef1a40cb55714cbaadfbd37368d1"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"2ed38228b2ba3d3fffdc2f2f2df50095ae0e1f23","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class EncryptedVolumesExtendAttachedTest(extend.BaseVolumesExtendAttachedTest,"},{"line_number":25,"context_line":"                                         base.BaseVolumeAdminTest):"},{"line_number":26,"context_line":"    \"\"\"Tests extending the size of an attached encrypted volume.\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @decorators.idempotent_id(\u0027e93243ec-7c37-4b5b-a099-ebf052c13216\u0027)"},{"line_number":29,"context_line":"    @testtools.skipUnless("},{"line_number":30,"context_line":"        CONF.volume_feature_enabled.extend_attached_encrypted_volume,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_970c3743","line":27,"in_reply_to":"bf51134e_376f2bfd","updated":"2020-07-23 14:44:16.000000000","message":"yes but wouldn\u0027t it be better to it here too? what\u0027s the possibility of bumping the min-microversion in base class?","commit_id":"4bd9edbd3bf7ef1a40cb55714cbaadfbd37368d1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"eaaf64ae382b2cfe985e1102ed6269db0d148ca5","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class EncryptedVolumesExtendAttachedTest(extend.BaseVolumesExtendAttachedTest,"},{"line_number":25,"context_line":"                                         base.BaseVolumeAdminTest):"},{"line_number":26,"context_line":"    \"\"\"Tests extending the size of an attached encrypted volume.\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @decorators.idempotent_id(\u0027e93243ec-7c37-4b5b-a099-ebf052c13216\u0027)"},{"line_number":29,"context_line":"    @testtools.skipUnless("},{"line_number":30,"context_line":"        CONF.volume_feature_enabled.extend_attached_encrypted_volume,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_376f2bfd","line":27,"in_reply_to":"bf51134e_89983475","updated":"2020-07-23 14:40:42.000000000","message":"That\u0027s already set in the parent BaseVolumesExtendAttachedTest class:\n\nhttps://github.com/openstack/tempest/blob/master/tempest/api/volume/test_volumes_extend.py#L81-L84","commit_id":"4bd9edbd3bf7ef1a40cb55714cbaadfbd37368d1"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"bf6fd97dd5793ceb5afb8670376ba28382770246","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class EncryptedVolumesExtendAttachedTest(extend.BaseVolumesExtendAttachedTest,"},{"line_number":25,"context_line":"                                         base.BaseVolumeAdminTest):"},{"line_number":26,"context_line":"    \"\"\"Tests extending the size of an attached encrypted volume.\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @decorators.idempotent_id(\u0027e93243ec-7c37-4b5b-a099-ebf052c13216\u0027)"},{"line_number":29,"context_line":"    @testtools.skipUnless("},{"line_number":30,"context_line":"        CONF.volume_feature_enabled.extend_attached_encrypted_volume,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_89983475","line":27,"in_reply_to":"bf51134e_9135a7fa","updated":"2020-06-25 21:44:54.000000000","message":"good catch! the other tempest/api/volume/admin/* tests have that var specified, this one should have it too","commit_id":"4bd9edbd3bf7ef1a40cb55714cbaadfbd37368d1"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"cb813aed14fc11d337694c4c7fd0590b2599232b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class EncryptedVolumesExtendAttachedTest(extend.BaseVolumesExtendAttachedTest,"},{"line_number":25,"context_line":"                                         base.BaseVolumeAdminTest):"},{"line_number":26,"context_line":"    \"\"\"Tests extending the size of an attached encrypted volume.\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @decorators.idempotent_id(\u0027e93243ec-7c37-4b5b-a099-ebf052c13216\u0027)"},{"line_number":29,"context_line":"    @testtools.skipUnless("},{"line_number":30,"context_line":"        CONF.volume_feature_enabled.extend_attached_encrypted_volume,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_f2002103","line":27,"in_reply_to":"bf51134e_970c3743","updated":"2020-07-23 14:45:12.000000000","message":"\u003e yes but wouldn\u0027t it be better to it here too? what\u0027s the\n \u003e possibility of bumping up the min-microversion in base class?","commit_id":"4bd9edbd3bf7ef1a40cb55714cbaadfbd37368d1"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"ad70ee12ea51e556b9b063395dde580dd5393566","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class EncryptedVolumesExtendAttachedTest(extend.BaseVolumesExtendAttachedTest,"},{"line_number":25,"context_line":"                                         base.BaseVolumeAdminTest):"},{"line_number":26,"context_line":"    \"\"\"Tests extending the size of an attached encrypted volume.\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @decorators.idempotent_id(\u0027e93243ec-7c37-4b5b-a099-ebf052c13216\u0027)"},{"line_number":29,"context_line":"    @testtools.skipUnless("},{"line_number":30,"context_line":"        CONF.volume_feature_enabled.extend_attached_encrypted_volume,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_eed03d56","line":27,"in_reply_to":"bf51134e_f2002103","updated":"2020-07-23 17:33:23.000000000","message":"oh nvm, bumping up is fine","commit_id":"4bd9edbd3bf7ef1a40cb55714cbaadfbd37368d1"}],"tempest/config.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c8ed92f81d326cc9da0a33f99583f89bd3fdcee5","unresolved":false,"context_lines":[{"line_number":979,"context_line":"                                  \"volume tests will run against v3 API. \""},{"line_number":980,"context_line":"                                  \"Use ``CONF.volume.catalog_type`` to run \""},{"line_number":981,"context_line":"                                  \"the Tempest against volume v2 or v3 API\"),"},{"line_number":982,"context_line":"    cfg.BoolOpt(\u0027extend_attached_volume\u0027,"},{"line_number":983,"context_line":"                default\u003dFalse,"},{"line_number":984,"context_line":"                help\u003d\u0027Does the cloud support extending the size of a volume \u0027"},{"line_number":985,"context_line":"                     \u0027which is currently attached to a server instance? This \u0027"},{"line_number":986,"context_line":"                     \u0027depends on the 3.42 volume API microversion and the \u0027"},{"line_number":987,"context_line":"                     \u00272.51 compute API microversion. Also, not all volume or \u0027"},{"line_number":988,"context_line":"                     \u0027compute backends support this operation.\u0027),"},{"line_number":989,"context_line":"    cfg.BoolOpt(\u0027extend_attached_encrypted_volume\u0027,"},{"line_number":990,"context_line":"                default\u003dFalse,"},{"line_number":991,"context_line":"                help\u003d\u0027Does the cloud support extending the size of an \u0027"},{"line_number":992,"context_line":"                     \u0027encrypted volume  which is currently attached to a \u0027"},{"line_number":993,"context_line":"                     \u0027server instance? This depends on the 3.42 volume API \u0027"},{"line_number":994,"context_line":"                     \u0027microversion and the 2.51 compute API microversion. \u0027"},{"line_number":995,"context_line":"                     \u0027Also, not all volume or compute backends support this \u0027"},{"line_number":996,"context_line":"                     \u0027operation.\u0027)"},{"line_number":997,"context_line":"]"},{"line_number":998,"context_line":""},{"line_number":999,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_f5f3aae5","line":996,"range":{"start_line":982,"start_character":0,"end_line":996,"end_character":34},"updated":"2020-09-23 14:47:12.000000000","message":"is extending the volume depends on backend also? If min microversions are only min requirement then we do not need to introduce the config option and control the test via min_microversion.","commit_id":"4bd9edbd3bf7ef1a40cb55714cbaadfbd37368d1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"29e0f07c18c926d26b4502e730afe47f7110e9de","unresolved":false,"context_lines":[{"line_number":979,"context_line":"                                  \"volume tests will run against v3 API. \""},{"line_number":980,"context_line":"                                  \"Use ``CONF.volume.catalog_type`` to run \""},{"line_number":981,"context_line":"                                  \"the Tempest against volume v2 or v3 API\"),"},{"line_number":982,"context_line":"    cfg.BoolOpt(\u0027extend_attached_volume\u0027,"},{"line_number":983,"context_line":"                default\u003dFalse,"},{"line_number":984,"context_line":"                help\u003d\u0027Does the cloud support extending the size of a volume \u0027"},{"line_number":985,"context_line":"                     \u0027which is currently attached to a server instance? This \u0027"},{"line_number":986,"context_line":"                     \u0027depends on the 3.42 volume API microversion and the \u0027"},{"line_number":987,"context_line":"                     \u00272.51 compute API microversion. Also, not all volume or \u0027"},{"line_number":988,"context_line":"                     \u0027compute backends support this operation.\u0027),"},{"line_number":989,"context_line":"    cfg.BoolOpt(\u0027extend_attached_encrypted_volume\u0027,"},{"line_number":990,"context_line":"                default\u003dFalse,"},{"line_number":991,"context_line":"                help\u003d\u0027Does the cloud support extending the size of an \u0027"},{"line_number":992,"context_line":"                     \u0027encrypted volume  which is currently attached to a \u0027"},{"line_number":993,"context_line":"                     \u0027server instance? This depends on the 3.42 volume API \u0027"},{"line_number":994,"context_line":"                     \u0027microversion and the 2.51 compute API microversion. \u0027"},{"line_number":995,"context_line":"                     \u0027Also, not all volume or compute backends support this \u0027"},{"line_number":996,"context_line":"                     \u0027operation.\u0027)"},{"line_number":997,"context_line":"]"},{"line_number":998,"context_line":""},{"line_number":999,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_15261e17","line":996,"range":{"start_line":982,"start_character":0,"end_line":996,"end_character":34},"in_reply_to":"9f560f44_f5f3aae5","updated":"2020-09-23 14:54:31.000000000","message":"quickly checked with cinder team and yes it is depends on backlends so config option is good here.","commit_id":"4bd9edbd3bf7ef1a40cb55714cbaadfbd37368d1"}]}