)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c23347dd996f706fc949a27035a2616410b802d9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove deprecated scenario image options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Let\u0027s remove deprecated scenario image options which have been"},{"line_number":10,"context_line":"deprecated for more than 4 years."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I96d26ad3889f55d867fdea016953cce522a6fbdf"},{"line_number":13,"context_line":"Related-Bug: #1393881"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bf51134e_8389c827","line":10,"range":{"start_line":10,"start_character":32,"end_line":10,"end_character":33},"updated":"2020-07-03 18:05:32.000000000","message":"it will be good to mention the change in default value of img_file","commit_id":"57eac231804fb92d08e96260855bfd00920ffe5b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6e39bdca0890889b53b7221acc0a411a4323ea08","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove deprecated scenario image options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Let\u0027s remove deprecated scenario image options which have been"},{"line_number":10,"context_line":"deprecated for more than 4 years."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I96d26ad3889f55d867fdea016953cce522a6fbdf"},{"line_number":13,"context_line":"Related-Bug: #1393881"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bf51134e_e3d404be","line":10,"range":{"start_line":10,"start_character":32,"end_line":10,"end_character":33},"in_reply_to":"bf51134e_8389c827","updated":"2020-07-03 18:37:31.000000000","message":"Done","commit_id":"57eac231804fb92d08e96260855bfd00920ffe5b"}],"releasenotes/notes/Remove-deprecated-image-scenario-options-b573c60e873ab451.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c23347dd996f706fc949a27035a2616410b802d9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The following deprecated image scenario options are removed after a ~4"},{"line_number":5,"context_line":"    year deprecation period."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ``ami_img_file``"},{"line_number":8,"context_line":"    * ``ari_img_file``"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_03949843","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":28},"updated":"2020-07-03 18:05:32.000000000","message":"we need to add the default change for img_file","commit_id":"57eac231804fb92d08e96260855bfd00920ffe5b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6e39bdca0890889b53b7221acc0a411a4323ea08","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The following deprecated image scenario options are removed after a ~4"},{"line_number":5,"context_line":"    year deprecation period."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ``ami_img_file``"},{"line_number":8,"context_line":"    * ``ari_img_file``"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_c3d0e0cc","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":28},"in_reply_to":"bf51134e_03949843","updated":"2020-07-03 18:37:31.000000000","message":"Done","commit_id":"57eac231804fb92d08e96260855bfd00920ffe5b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fa74685bc6c0f72151ca2cd9353119fad7f730ca","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    for the image. CONF.scenario.img_dir was deprecated and will be removed"},{"line_number":13,"context_line":"    in the next release. Till Tempest 25.0.0, old behavior is maintained and"},{"line_number":14,"context_line":"    keep working but starting Tempest 26.0.0, you need to specify the full path"},{"line_number":15,"context_line":"    in CONF.scenario.img_file config option.\u0027)"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_491cf169","line":15,"range":{"start_line":15,"start_character":44,"end_line":15,"end_character":46},"updated":"2020-07-03 21:09:19.000000000","message":"this is not needed","commit_id":"5af2fef4a3069360e8b1d6a4115ff37b3846f132"}],"tempest/config.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"461516e769e4702719b0721b740150d2be4850d9","unresolved":false,"context_lines":[{"line_number":1058,"context_line":"    cfg.StrOpt(\u0027img_dir\u0027,"},{"line_number":1059,"context_line":"               default\u003d\u0027/opt/stack/new/devstack/files/images/\u0027"},{"line_number":1060,"context_line":"               \u0027cirros-0.3.1-x86_64-uec\u0027,"},{"line_number":1061,"context_line":"               help\u003d\u0027Directory containing image files\u0027,"},{"line_number":1062,"context_line":"               deprecated_for_removal\u003dTrue),"},{"line_number":1063,"context_line":"    cfg.StrOpt(\u0027img_file\u0027, deprecated_name\u003d\u0027qcow2_img_file\u0027,"},{"line_number":1064,"context_line":"               default\u003d\u0027/opt/stack/new/devstack/files/images\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_832a68e4","line":1061,"range":{"start_line":1061,"start_character":21,"end_line":1061,"end_character":53},"updated":"2020-07-03 18:08:24.000000000","message":"can you update this also to mention that img_file option to mention full path instead of this.","commit_id":"57eac231804fb92d08e96260855bfd00920ffe5b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6e39bdca0890889b53b7221acc0a411a4323ea08","unresolved":false,"context_lines":[{"line_number":1058,"context_line":"    cfg.StrOpt(\u0027img_dir\u0027,"},{"line_number":1059,"context_line":"               default\u003d\u0027/opt/stack/new/devstack/files/images/\u0027"},{"line_number":1060,"context_line":"               \u0027cirros-0.3.1-x86_64-uec\u0027,"},{"line_number":1061,"context_line":"               help\u003d\u0027Directory containing image files\u0027,"},{"line_number":1062,"context_line":"               deprecated_for_removal\u003dTrue),"},{"line_number":1063,"context_line":"    cfg.StrOpt(\u0027img_file\u0027, deprecated_name\u003d\u0027qcow2_img_file\u0027,"},{"line_number":1064,"context_line":"               default\u003d\u0027/opt/stack/new/devstack/files/images\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_e3fd243c","line":1061,"range":{"start_line":1061,"start_character":21,"end_line":1061,"end_character":53},"in_reply_to":"bf51134e_832a68e4","updated":"2020-07-03 18:37:31.000000000","message":"Done","commit_id":"57eac231804fb92d08e96260855bfd00920ffe5b"}],"tempest/scenario/manager.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"7d2e1348f67b6ede158fe475fe6b12b92bfb665d","unresolved":false,"context_lines":[{"line_number":533,"context_line":""},{"line_number":534,"context_line":"    def glance_image_create(self):"},{"line_number":535,"context_line":"        img_path \u003d CONF.scenario.img_file"},{"line_number":536,"context_line":"        # TODO: remove this condition after tempest 25 is released so that"},{"line_number":537,"context_line":"        # there is one release which accepts both behaviors in order to avoid"},{"line_number":538,"context_line":"        # many failures across CIs and etc."},{"line_number":539,"context_line":"        if \u0027/\u0027 not in img_path:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_e4a4f84d","line":536,"updated":"2020-06-11 19:09:10.000000000","message":"pep8: H101: Use TODO(NAME)","commit_id":"509b4a03840692663672898190954eb7f5ed2345"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c23347dd996f706fc949a27035a2616410b802d9","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        # TODO(kopecmartin): remove this condition after tempest 25 is released"},{"line_number":537,"context_line":"        # so that there is one release which accepts both behaviors in order"},{"line_number":538,"context_line":"        # to avoid many failures across CIs and etc."},{"line_number":539,"context_line":"        if \u0027/\u0027 not in img_path:"},{"line_number":540,"context_line":"            # it\u0027s not a full path"},{"line_number":541,"context_line":"            LOG.error(\u0027CONF.scenario.img_file does not contain a full path \u0027"},{"line_number":542,"context_line":"                      \u0027which is a DEPRECATED behavior, please, update ASAP!\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_8375489b","line":539,"range":{"start_line":539,"start_character":0,"end_line":539,"end_character":31},"updated":"2020-07-03 18:05:32.000000000","message":"this does not guarantee if it is full valid path or not. How about checking if file exist and based on that we can log warning now and configerror in next release.\n\nif not os.path.exists(img_path)","commit_id":"57eac231804fb92d08e96260855bfd00920ffe5b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6e39bdca0890889b53b7221acc0a411a4323ea08","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        # TODO(kopecmartin): remove this condition after tempest 25 is released"},{"line_number":537,"context_line":"        # so that there is one release which accepts both behaviors in order"},{"line_number":538,"context_line":"        # to avoid many failures across CIs and etc."},{"line_number":539,"context_line":"        if \u0027/\u0027 not in img_path:"},{"line_number":540,"context_line":"            # it\u0027s not a full path"},{"line_number":541,"context_line":"            LOG.error(\u0027CONF.scenario.img_file does not contain a full path \u0027"},{"line_number":542,"context_line":"                      \u0027which is a DEPRECATED behavior, please, update ASAP!\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_a35e8c73","line":539,"range":{"start_line":539,"start_character":0,"end_line":539,"end_character":31},"in_reply_to":"bf51134e_8375489b","updated":"2020-07-03 18:37:31.000000000","message":"Done","commit_id":"57eac231804fb92d08e96260855bfd00920ffe5b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c23347dd996f706fc949a27035a2616410b802d9","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        # to avoid many failures across CIs and etc."},{"line_number":539,"context_line":"        if \u0027/\u0027 not in img_path:"},{"line_number":540,"context_line":"            # it\u0027s not a full path"},{"line_number":541,"context_line":"            LOG.error(\u0027CONF.scenario.img_file does not contain a full path \u0027"},{"line_number":542,"context_line":"                      \u0027which is a DEPRECATED behavior, please, update ASAP!\u0027)"},{"line_number":543,"context_line":"            LOG.warning(\u0027CONF.scenario.img_dir will not be accepted \u0027"},{"line_number":544,"context_line":"                        \u0027in the next release!\u0027)"},{"line_number":545,"context_line":"            img_path \u003d os.path.join(CONF.scenario.img_dir, img_path)"},{"line_number":546,"context_line":"        img_container_format \u003d CONF.scenario.img_container_format"},{"line_number":547,"context_line":"        img_disk_format \u003d CONF.scenario.img_disk_format"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_634f546a","line":544,"range":{"start_line":541,"start_character":0,"end_line":544,"end_character":47},"updated":"2020-07-03 18:05:32.000000000","message":"We are not checking if CONF.scenario.img_dir is or not. So let\u0027s combine these two LOG into single warning.\n\n\nLOG.warning(\u0027Starting Tempest 25.0.0 release, CONF.scenario.img_file need a full path for the image. CONF.scenario.img_dir was deprecated and will be removed in the next release. Till Tempest 25.0.0, old behavior is maintained and keep working but starting Tempest 26.0.0,  you need to specify the full path in CONF.scenario.img_file config option.\u0027)","commit_id":"57eac231804fb92d08e96260855bfd00920ffe5b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6e39bdca0890889b53b7221acc0a411a4323ea08","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        # to avoid many failures across CIs and etc."},{"line_number":539,"context_line":"        if \u0027/\u0027 not in img_path:"},{"line_number":540,"context_line":"            # it\u0027s not a full path"},{"line_number":541,"context_line":"            LOG.error(\u0027CONF.scenario.img_file does not contain a full path \u0027"},{"line_number":542,"context_line":"                      \u0027which is a DEPRECATED behavior, please, update ASAP!\u0027)"},{"line_number":543,"context_line":"            LOG.warning(\u0027CONF.scenario.img_dir will not be accepted \u0027"},{"line_number":544,"context_line":"                        \u0027in the next release!\u0027)"},{"line_number":545,"context_line":"            img_path \u003d os.path.join(CONF.scenario.img_dir, img_path)"},{"line_number":546,"context_line":"        img_container_format \u003d CONF.scenario.img_container_format"},{"line_number":547,"context_line":"        img_disk_format \u003d CONF.scenario.img_disk_format"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_6364744a","line":544,"range":{"start_line":541,"start_character":0,"end_line":544,"end_character":47},"in_reply_to":"bf51134e_634f546a","updated":"2020-07-03 18:37:31.000000000","message":"Done","commit_id":"57eac231804fb92d08e96260855bfd00920ffe5b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fa74685bc6c0f72151ca2cd9353119fad7f730ca","unresolved":false,"context_lines":[{"line_number":533,"context_line":""},{"line_number":534,"context_line":"    def glance_image_create(self):"},{"line_number":535,"context_line":"        img_path \u003d CONF.scenario.img_file"},{"line_number":536,"context_line":"        # TODO(kopecmartin): remove this condition after tempest 25 is released"},{"line_number":537,"context_line":"        # so that there is one release which accepts both behaviors in order"},{"line_number":538,"context_line":"        # to avoid many failures across CIs and etc."},{"line_number":539,"context_line":"        if not os.path.exists(img_path):"},{"line_number":540,"context_line":"            # it\u0027s not a full path"},{"line_number":541,"context_line":"            LOG.warning("}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_c92121a2","line":538,"range":{"start_line":536,"start_character":0,"end_line":538,"end_character":52},"updated":"2020-07-03 21:09:19.000000000","message":"i think this need to be at L541 and with TODO of raising the InvalidConfiguration exception instead of warning","commit_id":"5af2fef4a3069360e8b1d6a4115ff37b3846f132"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"68cbe95d0acf26ef4efc84e8ec3e6d7ab3c46773","unresolved":false,"context_lines":[{"line_number":533,"context_line":""},{"line_number":534,"context_line":"    def glance_image_create(self):"},{"line_number":535,"context_line":"        img_path \u003d CONF.scenario.img_file"},{"line_number":536,"context_line":"        # TODO(kopecmartin): remove this condition after tempest 25 is released"},{"line_number":537,"context_line":"        # so that there is one release which accepts both behaviors in order"},{"line_number":538,"context_line":"        # to avoid many failures across CIs and etc."},{"line_number":539,"context_line":"        if not os.path.exists(img_path):"},{"line_number":540,"context_line":"            # it\u0027s not a full path"},{"line_number":541,"context_line":"            LOG.warning("}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_d5b1aee3","line":538,"range":{"start_line":536,"start_character":0,"end_line":538,"end_character":52},"in_reply_to":"bf51134e_9a7805f9","updated":"2020-07-05 17:50:50.000000000","message":"yeah, that is the plan and add TODO to raise the error on future.","commit_id":"5af2fef4a3069360e8b1d6a4115ff37b3846f132"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"43af2422fd04b9cf9a01e76be50e982def12eff6","unresolved":false,"context_lines":[{"line_number":533,"context_line":""},{"line_number":534,"context_line":"    def glance_image_create(self):"},{"line_number":535,"context_line":"        img_path \u003d CONF.scenario.img_file"},{"line_number":536,"context_line":"        # TODO(kopecmartin): remove this condition after tempest 25 is released"},{"line_number":537,"context_line":"        # so that there is one release which accepts both behaviors in order"},{"line_number":538,"context_line":"        # to avoid many failures across CIs and etc."},{"line_number":539,"context_line":"        if not os.path.exists(img_path):"},{"line_number":540,"context_line":"            # it\u0027s not a full path"},{"line_number":541,"context_line":"            LOG.warning("}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_9a7805f9","line":538,"range":{"start_line":536,"start_character":0,"end_line":538,"end_character":52},"in_reply_to":"bf51134e_c92121a2","updated":"2020-07-05 10:13:16.000000000","message":"I changed the LOG.warning to raise lib_exc.InvalidConfiguration in the patchset 8, but the jobs are failing then because img_file is not used everywhere as the full path as it should be from now on ... I think we should go with LOG.warning here for now and change it to raising an exception (InvalidConfiguration) after we stop supporting both behaviors - starting Tempest 26.0.0","commit_id":"5af2fef4a3069360e8b1d6a4115ff37b3846f132"}]}