)]}'
{"tempest/scenario/test_volume_boot_pattern.py":[{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"0c6c6ab44fa05cd8530b637fcf0e00def41db05d","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        # Assert that the underlying volume is gone before class tearDown"},{"line_number":174,"context_line":"        # to prevent snapshot deletion from failing"},{"line_number":175,"context_line":"        self.volumes_client.wait_for_resource_deletion(created_volume[0][\u0027id\u0027])"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @decorators.idempotent_id(\u002736c34c67-7b54-4b59-b188-02a2f458a63b\u0027)"},{"line_number":178,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_8b3831a0","line":175,"updated":"2020-03-04 17:46:15.000000000","message":"So, _delete_server wait for the server get deleted, so, when tearDown is called, for sure the server is already deleted, and volume will call this wait_for_resource_deletion function, so I think it\u0027s not needed here correct?","commit_id":"0d2b331cc4ec431e6dad944240a9b241b9b5b6d4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e77f1608b405bd974505a4d27ce85a807b83be0b","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        # Assert that the underlying volume is gone before class tearDown"},{"line_number":174,"context_line":"        # to prevent snapshot deletion from failing"},{"line_number":175,"context_line":"        self.volumes_client.wait_for_resource_deletion(created_volume[0][\u0027id\u0027])"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @decorators.idempotent_id(\u002736c34c67-7b54-4b59-b188-02a2f458a63b\u0027)"},{"line_number":178,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_45b42a80","line":175,"in_reply_to":"1fa4df85_6532b912","updated":"2020-03-09 16:25:37.000000000","message":"yeah, we do not wait for bootable volume to be deleted while deleting server during this cleanup [1]. Volume deletion is by Cinder service which can take more time than server is cleanup by nova.\n\nI have seen this bootable volume cleanup issue before also I think API tests which we fixed. We have to check for volume cleanup during server creation common method. I will try to push that sometime this week which can solve more hidden cases also. \nFor now, fixing this test lgtm.\n\n[1] https://github.com/openstack/tempest/blob/f61e18ff7bd848ef1dd4669f2c7c2fd9a73e3b9b/tempest/scenario/manager.py#L288","commit_id":"0d2b331cc4ec431e6dad944240a9b241b9b5b6d4"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"65b8b0fa840c6abce610e8d81f32d9f685d02231","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        # Assert that the underlying volume is gone before class tearDown"},{"line_number":174,"context_line":"        # to prevent snapshot deletion from failing"},{"line_number":175,"context_line":"        self.volumes_client.wait_for_resource_deletion(created_volume[0][\u0027id\u0027])"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @decorators.idempotent_id(\u002736c34c67-7b54-4b59-b188-02a2f458a63b\u0027)"},{"line_number":178,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_6532b912","line":175,"in_reply_to":"1fa4df85_8b3831a0","updated":"2020-03-05 10:28:16.000000000","message":"answering here to make sure other reviewers can see the conversation; we want to wait for the bootable volume to be gone before letting tearDown try to delete the snapshot from which the bootable volume was created","commit_id":"0d2b331cc4ec431e6dad944240a9b241b9b5b6d4"}]}