)]}'
{"tempest/api/network/admin/test_floating_ips_admin_actions.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"ec7e6ef8cb13e312b5aaf91a25818e151c91ac75","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.assertNotIn(floating_ip_alt[\u0027id\u0027], floating_ip_ids)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":71,"context_line":"    def test_create_show_floating_ip_another_tenant_admin(self):"},{"line_number":72,"context_line":"        # Create floating ip in another tenant"},{"line_number":73,"context_line":"        resp, body \u003d self.alt_client.create_floatingip("},{"line_number":74,"context_line":"            floating_network_id\u003dself.ext_net_id)"}],"source_content_type":"text/x-python","patch_set":19,"id":"7adec928_eea5bdb5","line":71,"updated":"2014-05-14 05:02:44.000000000","message":"Is this test case test anything not tested by the test_list_floating_ips_from_admin_and_nonadmin ?","commit_id":"c29b1e888cc7a2ec96f5179a4ce45bee8120eea1"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"63a0c81775c4fd8c1e482479c3fc3c91148dda45","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.assertNotIn(floating_ip_alt[\u0027id\u0027], floating_ip_ids)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":71,"context_line":"    def test_create_show_floating_ip_another_tenant_admin(self):"},{"line_number":72,"context_line":"        # Create floating ip in another tenant"},{"line_number":73,"context_line":"        resp, body \u003d self.alt_client.create_floatingip("},{"line_number":74,"context_line":"            floating_network_id\u003dself.ext_net_id)"}],"source_content_type":"text/x-python","patch_set":19,"id":"7adec928_4e5f9141","line":71,"in_reply_to":"7adec928_eea5bdb5","updated":"2014-05-14 07:32:33.000000000","message":"Remove this test.","commit_id":"c29b1e888cc7a2ec96f5179a4ce45bee8120eea1"}],"tempest/api/network/test_floating_ips.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b48d15670ad83eba1d025da1b679bba9d3e3fad6","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        fixed_ips \u003d [{\u0027ip_address\u0027: list_ips[0]}, {\u0027ip_address\u0027: list_ips[1]}]"},{"line_number":199,"context_line":"        # Create port"},{"line_number":200,"context_line":"        resp, body \u003d self.client.create_port(network_id\u003dself.network[\u0027id\u0027],"},{"line_number":201,"context_line":"                                             fixed_ips\u003dfixed_ips)"},{"line_number":202,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":203,"context_line":"        self.addCleanup(self.client.delete_port, port[\u0027id\u0027])"},{"line_number":204,"context_line":"        # Create floating ip"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9lK8%3D","line":201,"updated":"2014-02-05 22:09:22.000000000","message":"Please add:\n\nself.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])","commit_id":"4d47090738e2f22e220e85cd54b1710d9d8c29bb"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b48d15670ad83eba1d025da1b679bba9d3e3fad6","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        # Update floating ip"},{"line_number":214,"context_line":"        resp, body \u003d self.client.update_floatingip("},{"line_number":215,"context_line":"            floating_ip[\u0027id\u0027], port_id\u003dport[\u0027id\u0027],"},{"line_number":216,"context_line":"            fixed_ip_address\u003dlist_ips[1])"},{"line_number":217,"context_line":"        update_floating_ip \u003d body[\u0027floatingip\u0027]"},{"line_number":218,"context_line":"        self.assertEqual(update_floating_ip[\u0027fixed_ip_address\u0027],"},{"line_number":219,"context_line":"                         list_ips[1])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9lJ0%3D","line":216,"updated":"2014-02-05 22:09:22.000000000","message":"self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])","commit_id":"4d47090738e2f22e220e85cd54b1710d9d8c29bb"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b48d15670ad83eba1d025da1b679bba9d3e3fad6","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        floating_ip_admin \u003d body[\u0027floatingip\u0027]"},{"line_number":276,"context_line":"        self.addCleanup(self.admin_client.delete_floatingip,"},{"line_number":277,"context_line":"                        floating_ip_admin[\u0027id\u0027])"},{"line_number":278,"context_line":"        resp, body \u003d self.admin_client.show_floatingip(floating_ip_admin[\u0027id\u0027])"},{"line_number":279,"context_line":"        shown_floatingip \u003d body[\u0027floatingip\u0027]"},{"line_number":280,"context_line":"        for key, value in floating_ip_admin.iteritems():"},{"line_number":281,"context_line":"            self.assertEqual(value, shown_floatingip[key])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9lJg%3D","line":278,"updated":"2014-02-05 22:09:22.000000000","message":"Please add \n\nself.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])","commit_id":"4d47090738e2f22e220e85cd54b1710d9d8c29bb"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0ddef41ec1c5f2fde441262f49a44c9e0f354257","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        # Update floating ip"},{"line_number":215,"context_line":"        resp, body \u003d self.client.update_floatingip("},{"line_number":216,"context_line":"            floating_ip[\u0027id\u0027], port_id\u003dport[\u0027id\u0027],"},{"line_number":217,"context_line":"            fixed_ip_address\u003dlist_ips[1])"},{"line_number":218,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":219,"context_line":"        update_floating_ip \u003d body[\u0027floatingip\u0027]"},{"line_number":220,"context_line":"        self.assertEqual(update_floating_ip[\u0027fixed_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2F04g%3D","line":217,"updated":"2014-02-10 15:27:33.000000000","message":"It looks like the NSX plugin is complaining about you trying to use the same floating ip with two different fixed ips on the same port. This should not be allowed.","commit_id":"5b3efc661ce01115ffe81f4913a237fab2e8eb05"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"fd98887a773f5853166dd6c1259db5b4780ecf56","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        # Update floating ip"},{"line_number":215,"context_line":"        resp, body \u003d self.client.update_floatingip("},{"line_number":216,"context_line":"            floating_ip[\u0027id\u0027], port_id\u003dport[\u0027id\u0027],"},{"line_number":217,"context_line":"            fixed_ip_address\u003dlist_ips[1])"},{"line_number":218,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":219,"context_line":"        update_floating_ip \u003d body[\u0027floatingip\u0027]"},{"line_number":220,"context_line":"        self.assertEqual(update_floating_ip[\u0027fixed_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FzT8%3D","line":217,"in_reply_to":"AAAAUX%2F%2F04g%3D","updated":"2014-02-10 18:27:22.000000000","message":"It seems the NSX plugin does not support this scenario (re-association on same port with different IP).\nBut this can be easily fixed.","commit_id":"5b3efc661ce01115ffe81f4913a237fab2e8eb05"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"bf62ce1b637b0eb00a47cfc1ad344c1e68b10286","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        # Update floating ip"},{"line_number":215,"context_line":"        resp, body \u003d self.client.update_floatingip("},{"line_number":216,"context_line":"            floating_ip[\u0027id\u0027], port_id\u003dport[\u0027id\u0027],"},{"line_number":217,"context_line":"            fixed_ip_address\u003dlist_ips[1])"},{"line_number":218,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":219,"context_line":"        update_floating_ip \u003d body[\u0027floatingip\u0027]"},{"line_number":220,"context_line":"        self.assertEqual(update_floating_ip[\u0027fixed_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FysQ%3D","line":217,"in_reply_to":"AAAAUX%2F%2FzT8%3D","updated":"2014-02-10 19:41:02.000000000","message":"cool, thanks for looking into this.","commit_id":"5b3efc661ce01115ffe81f4913a237fab2e8eb05"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"0423944f94c8a52180ea9d9b16886ff9d13c7725","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    def test_create_update_floatingip_with_port_multiple_ip_address(self):"},{"line_number":199,"context_line":"        # Find out ips that can be used for tests"},{"line_number":200,"context_line":"        ips \u003d list(netaddr.IPNetwork(self.subnet[\u0027cidr\u0027]))"},{"line_number":201,"context_line":"        list_ips \u003d [str(ips[len(ips) - 2]), str(ips[len(ips) - 3])]"},{"line_number":202,"context_line":"        fixed_ips \u003d [{\u0027ip_address\u0027: list_ips[0]}, {\u0027ip_address\u0027: list_ips[1]}]"},{"line_number":203,"context_line":"        # Create port"},{"line_number":204,"context_line":"        resp, body \u003d self.client.create_port(network_id\u003dself.network[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":20,"id":"7adec928_774fc0bd","line":201,"updated":"2014-05-14 10:54:14.000000000","message":"may be would be better [-1] and [-2] instead [len(ips) - 2] [len(ips) - 3]?","commit_id":"5dbff8f2eaf6d0adc830499c8e5bc233c10d9df9"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"7d382d53009d3226490215870553bb6e79d43396","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    def test_create_update_floatingip_with_port_multiple_ip_address(self):"},{"line_number":199,"context_line":"        # Find out ips that can be used for tests"},{"line_number":200,"context_line":"        ips \u003d list(netaddr.IPNetwork(self.subnet[\u0027cidr\u0027]))"},{"line_number":201,"context_line":"        list_ips \u003d [str(ips[len(ips) - 2]), str(ips[len(ips) - 3])]"},{"line_number":202,"context_line":"        fixed_ips \u003d [{\u0027ip_address\u0027: list_ips[0]}, {\u0027ip_address\u0027: list_ips[1]}]"},{"line_number":203,"context_line":"        # Create port"},{"line_number":204,"context_line":"        resp, body \u003d self.client.create_port(network_id\u003dself.network[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":20,"id":"7adec928_f76e7000","line":201,"in_reply_to":"7adec928_17d67cc5","updated":"2014-05-14 11:14:29.000000000","message":"No, it would not be better to use [-1] and [-2], as [-1] is not valid IP address for this networks subnet.","commit_id":"5dbff8f2eaf6d0adc830499c8e5bc233c10d9df9"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"32e00dbb5c8fc476916d3034ea69bcacd14c41c6","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    def test_create_update_floatingip_with_port_multiple_ip_address(self):"},{"line_number":199,"context_line":"        # Find out ips that can be used for tests"},{"line_number":200,"context_line":"        ips \u003d list(netaddr.IPNetwork(self.subnet[\u0027cidr\u0027]))"},{"line_number":201,"context_line":"        list_ips \u003d [str(ips[len(ips) - 2]), str(ips[len(ips) - 3])]"},{"line_number":202,"context_line":"        fixed_ips \u003d [{\u0027ip_address\u0027: list_ips[0]}, {\u0027ip_address\u0027: list_ips[1]}]"},{"line_number":203,"context_line":"        # Create port"},{"line_number":204,"context_line":"        resp, body \u003d self.client.create_port(network_id\u003dself.network[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":20,"id":"7adec928_17d67cc5","line":201,"in_reply_to":"7adec928_774fc0bd","updated":"2014-05-14 10:57:35.000000000","message":"[-2]and [-3]","commit_id":"5dbff8f2eaf6d0adc830499c8e5bc233c10d9df9"}]}