)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"970c586363613514ff4b26e236f472b191c95181","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is shared amongs multiple test cases which may ask for ip"},{"line_number":12,"context_line":"address in parallel to this test case execution and might end"},{"line_number":13,"context_line":"up in race condition."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ibf5ad52062b3719899a123a799f5f4f8e961f609"},{"line_number":16,"context_line":"Closes-bug: #1676207"},{"line_number":17,"context_line":"Logs: https://bugs.launchpad.net/tempest/+bug/1676207/comments/13"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ff570b3c_0ab9352d","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":0},"updated":"2020-05-13 16:36:12.000000000","message":"can you add the test moving note also and say interop or any other user does not use this test location so we are good to move.\n\nI have checked and interop and any other user not using this test to we are good to move\n- http://codesearch.openstack.org/?q\u003dtest_create_router_set_gateway_with_fixed_ip\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","commit_id":"06ee41a31c87b707491de516e90037ad8b16f0bc"}],"tempest/api/network/admin/test_routers.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"969ce7c50ab3abd2b9b9f0871161c670e4990ed8","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        self.assertEqual(router[\u0027external_gateway_info\u0027]["},{"line_number":246,"context_line":"                         \u0027external_fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":247,"context_line":"                         fixed_ip[\u0027ip_address\u0027])"},{"line_number":248,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":249,"context_line":"                        self.admin_subnets_client.delete_subnet, subnet[\u0027id\u0027])"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"class RoutersIpV6AdminTest(RoutersAdminTest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_27675e28","line":249,"range":{"start_line":248,"start_character":8,"end_line":249,"end_character":78},"updated":"2020-03-20 16:41:52.000000000","message":"any reason addCleanup for subnet is put at the end of the test while addCleanup for network is put right after the network is created?","commit_id":"66f2e0d0c768c8c87f74368932f1090b78ffdf5f"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"d8a41d5f4b7a3963aafc57a9a42091eec0c6ee7f","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        self.assertEqual(router[\u0027external_gateway_info\u0027]["},{"line_number":246,"context_line":"                         \u0027external_fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":247,"context_line":"                         fixed_ip[\u0027ip_address\u0027])"},{"line_number":248,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":249,"context_line":"                        self.admin_subnets_client.delete_subnet, subnet[\u0027id\u0027])"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"class RoutersIpV6AdminTest(RoutersAdminTest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_b28720d8","line":249,"range":{"start_line":248,"start_character":8,"end_line":249,"end_character":78},"in_reply_to":"df33271e_27675e28","updated":"2020-03-23 01:12:50.000000000","message":"Ahh , I don\u0027t think so that matters. I can move the network here as well","commit_id":"66f2e0d0c768c8c87f74368932f1090b78ffdf5f"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"fdf121da8ab4d374be955946ea166cf2345087b8","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                         fixed_ip[\u0027ip_address\u0027])"},{"line_number":248,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":249,"context_line":"                        self.admin_subnets_client.delete_subnet, subnet[\u0027id\u0027])"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"class RoutersIpV6AdminTest(RoutersAdminTest):"},{"line_number":253,"context_line":"    _ip_version \u003d 6"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4c43b2_20b8c674","line":250,"updated":"2020-04-14 08:46:30.000000000","message":"I would add in the beginning, if something fails in the middle, this will not be cleaned","commit_id":"66f2e0d0c768c8c87f74368932f1090b78ffdf5f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"970c586363613514ff4b26e236f472b191c95181","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    @utils.requires_ext(extension\u003d\u0027ext-gw-mode\u0027, service\u003d\u0027network\u0027)"},{"line_number":217,"context_line":"    def test_create_router_set_gateway_with_fixed_ip(self):"},{"line_number":218,"context_line":"        # At first create an external network and then use that"},{"line_number":219,"context_line":"        # to create public_network and delete"},{"line_number":220,"context_line":"        network_name \u003d data_utils.rand_name(self.__class__.__name__)"},{"line_number":221,"context_line":"        network_1 \u003d self.admin_networks_client.create_network("},{"line_number":222,"context_line":"            name\u003dnetwork_name, **{\u0027router:external\u0027: True})[\u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_0a1db565","line":219,"range":{"start_line":219,"start_character":20,"end_line":219,"end_character":34},"updated":"2020-05-13 16:36:12.000000000","message":"you mean \u0027address\u0027 not public_network itself","commit_id":"06ee41a31c87b707491de516e90037ad8b16f0bc"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"471e33449d039585ebd86023034cb4166668cf1e","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    @utils.requires_ext(extension\u003d\u0027ext-gw-mode\u0027, service\u003d\u0027network\u0027)"},{"line_number":217,"context_line":"    def test_create_router_set_gateway_with_fixed_ip(self):"},{"line_number":218,"context_line":"        # At first create an external network and then use that"},{"line_number":219,"context_line":"        # to create public_network and delete"},{"line_number":220,"context_line":"        network_name \u003d data_utils.rand_name(self.__class__.__name__)"},{"line_number":221,"context_line":"        network_1 \u003d self.admin_networks_client.create_network("},{"line_number":222,"context_line":"            name\u003dnetwork_name, **{\u0027router:external\u0027: True})[\u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_4faa03d2","line":219,"range":{"start_line":219,"start_character":20,"end_line":219,"end_character":34},"in_reply_to":"ff570b3c_0a1db565","updated":"2020-05-14 17:45:46.000000000","message":"correct, let me change this","commit_id":"06ee41a31c87b707491de516e90037ad8b16f0bc"}]}
