)]}'
{"tempest/lib/api_schema/response/compute/v2_59/migrations.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"0eaa4190db6d65c972ea045048c68f082d6ff3a0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import copy"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib.api_schema.response.compute.v2_23 import migrations \\"},{"line_number":16,"context_line":"    as uuidv223"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"###########################################################################"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_da9524e6","line":16,"range":{"start_line":16,"start_character":7,"end_line":16,"end_character":15},"updated":"2020-04-09 04:56:24.000000000","message":"nit: I see why this is like this but IMO migrations_v223 or just migrations is more intuitive.","commit_id":"77e6b0609f2c35466b96d32485870230ccffeead"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"68972f04cf244bc5b5f6912ba26daa795a8f1887","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import copy"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib.api_schema.response.compute.v2_23 import migrations \\"},{"line_number":16,"context_line":"    as uuidv223"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"###########################################################################"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_e1885fc7","line":16,"range":{"start_line":16,"start_character":7,"end_line":16,"end_character":15},"in_reply_to":"df33271e_da9524e6","updated":"2020-05-14 00:51:45.000000000","message":"+1","commit_id":"77e6b0609f2c35466b96d32485870230ccffeead"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"5aec77d9fce1e42fc1ecd29229631846e32b24f9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import copy"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib.api_schema.response.compute.v2_23 import migrations \\"},{"line_number":16,"context_line":"    as uuidv223"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"###########################################################################"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_7937dce4","line":16,"range":{"start_line":16,"start_character":7,"end_line":16,"end_character":15},"in_reply_to":"ff570b3c_e1885fc7","updated":"2020-05-14 14:19:23.000000000","message":"Done","commit_id":"77e6b0609f2c35466b96d32485870230ccffeead"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"0eaa4190db6d65c972ea045048c68f082d6ff3a0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# - GET /os-migrations"},{"line_number":27,"context_line":"# - GET /servers/{server_id}/migrations/{migration_id}"},{"line_number":28,"context_line":"# - GET GET /servers/{server_id}/migrations"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"###########################################################################"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_5ab2b495","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":7},"updated":"2020-04-09 04:56:24.000000000","message":"nit: GET is repeated twice","commit_id":"77e6b0609f2c35466b96d32485870230ccffeead"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"68972f04cf244bc5b5f6912ba26daa795a8f1887","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# migration id for the following API responses:"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# - GET /os-migrations"},{"line_number":27,"context_line":"# - GET /servers/{server_id}/migrations/{migration_id}"},{"line_number":28,"context_line":"# - GET GET /servers/{server_id}/migrations"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"###########################################################################"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_219377fc","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":43},"updated":"2020-05-14 00:51:45.000000000","message":"you are not updating schema for these API ?","commit_id":"77e6b0609f2c35466b96d32485870230ccffeead"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"5aec77d9fce1e42fc1ecd29229631846e32b24f9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# migration id for the following API responses:"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# - GET /os-migrations"},{"line_number":27,"context_line":"# - GET /servers/{server_id}/migrations/{migration_id}"},{"line_number":28,"context_line":"# - GET GET /servers/{server_id}/migrations"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"###########################################################################"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_b9e2142e","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":43},"in_reply_to":"ff570b3c_219377fc","updated":"2020-05-14 14:19:23.000000000","message":"Correct, the migrations client only ever uses list_migrations and does not use the other api calls.  I can remove the reference of the other API calls here if you prefer for clarity.","commit_id":"77e6b0609f2c35466b96d32485870230ccffeead"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8274f0bda9f7d441b7beeef4ad055b5afb9a935e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# migration id for the following API responses:"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# - GET /os-migrations"},{"line_number":27,"context_line":"# - GET /servers/{server_id}/migrations/{migration_id}"},{"line_number":28,"context_line":"# - GET GET /servers/{server_id}/migrations"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"###########################################################################"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_20e87cb2","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":43},"in_reply_to":"ff570b3c_b9e2142e","updated":"2020-05-14 20:36:49.000000000","message":"ah, we do not have service client for GET server migrate API. I think ref here is fine in case we add those client to reuse this schema.","commit_id":"77e6b0609f2c35466b96d32485870230ccffeead"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"0eaa4190db6d65c972ea045048c68f082d6ff3a0","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"uuid \u003d {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"list_migrations \u003d copy.deepcopy(uuidv223.list_migrations)"},{"line_number":35,"context_line":"list_migrations[\u0027response_body\u0027][\u0027properties\u0027][\u0027migrations\u0027][\u0027items\u0027]["},{"line_number":36,"context_line":"    \u0027properties\u0027].update({\u0027uuid\u0027: uuid})"},{"line_number":37,"context_line":"list_migrations[\u0027response_body\u0027][\u0027properties\u0027][\u0027migrations\u0027][\u0027items\u0027]["},{"line_number":38,"context_line":"    \u0027required\u0027].append(\u0027uuid\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_9a56fc29","line":38,"range":{"start_line":34,"start_character":0,"end_line":38,"end_character":30},"updated":"2020-04-09 04:56:24.000000000","message":"LGTM as per https://docs.openstack.org/api-ref/compute/?expanded\u003dlist-migrations-detail#id317","commit_id":"77e6b0609f2c35466b96d32485870230ccffeead"}]}