)]}'
{"tempest/cmd/cleanup.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"15af13d8378974d9441c9db853e746bab1115642","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                                   indent\u003d2, separators\u003d(\u0027,\u0027, \u0027: \u0027)))"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def _clean_project(self, project):"},{"line_number":208,"context_line":"        LOG.debug(\"Cleaning project:  %s \", project[\u0027name\u0027])"},{"line_number":209,"context_line":"        is_dry_run \u003d self.options.dry_run"},{"line_number":210,"context_line":"        dry_run_data \u003d self.dry_run_data"},{"line_number":211,"context_line":"        is_preserve \u003d not self.options.delete_tempest_conf_objects"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_4ebc2a05","line":208,"range":{"start_line":208,"start_character":8,"end_line":208,"end_character":17},"updated":"2020-04-14 00:04:17.000000000","message":"Why is only here debug?","commit_id":"2c88bc59bdef528a1dcef6e952ded6f86d8e72d9"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9d968ab95602a4b368acb82479a44e322a09bd0f","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                                   indent\u003d2, separators\u003d(\u0027,\u0027, \u0027: \u0027)))"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def _clean_project(self, project):"},{"line_number":208,"context_line":"        LOG.debug(\"Cleaning project:  %s \", project[\u0027name\u0027])"},{"line_number":209,"context_line":"        is_dry_run \u003d self.options.dry_run"},{"line_number":210,"context_line":"        dry_run_data \u003d self.dry_run_data"},{"line_number":211,"context_line":"        is_preserve \u003d not self.options.delete_tempest_conf_objects"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_3abc7404","line":208,"range":{"start_line":208,"start_character":8,"end_line":208,"end_character":17},"in_reply_to":"3f4c43b2_4ebc2a05","updated":"2020-04-14 08:39:27.000000000","message":"I thought that info messages are good for just informing user what\u0027s going on in the background (like processing projects, processing global services ...) and debug ones for informing a user what\u0027s being deleted. \n\ninfo messages are printed always as it informs about the progress and it\u0027s not lots of them. debug messages on the other hand offers more information and it\u0027s lots of them, therefore I marked all the messages which inform about the resources being deleted as debug ones so that they are printed only when --debug argument is used.\n\nBut I\u0027m OK if want to let printing of the projects which are being deleted all the time.","commit_id":"2c88bc59bdef528a1dcef6e952ded6f86d8e72d9"}],"tempest/cmd/cleanup_service.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"15af13d8378974d9441c9db853e746bab1115642","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        if self.is_preserve:"},{"line_number":430,"context_line":"            networks \u003d [network for network in networks"},{"line_number":431,"context_line":"                        if network[\u0027id\u0027] not in CONF_NETWORKS]"},{"line_number":432,"context_line":"        LOG.debug(\"List count, %s Networks\", len(networks))"},{"line_number":433,"context_line":"        return networks"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    def delete(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_8ed6324f","line":432,"range":{"start_line":432,"start_character":44,"end_line":432,"end_character":59},"updated":"2020-04-14 00:04:17.000000000","message":"I feel just `networks` can provide better information than `len(networks)`? The message \"List count, %s Networks\" is inappropriate in that case though.","commit_id":"2c88bc59bdef528a1dcef6e952ded6f86d8e72d9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"30c07ab75c0adc821ee7a90a02e253b10186e08f","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        if self.is_preserve:"},{"line_number":430,"context_line":"            networks \u003d [network for network in networks"},{"line_number":431,"context_line":"                        if network[\u0027id\u0027] not in CONF_NETWORKS]"},{"line_number":432,"context_line":"        LOG.debug(\"List count, %s Networks\", len(networks))"},{"line_number":433,"context_line":"        return networks"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    def delete(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_da1bb670","line":432,"range":{"start_line":432,"start_character":44,"end_line":432,"end_character":59},"in_reply_to":"3f4c43b2_40e35206","updated":"2020-05-05 18:45:49.000000000","message":"I think it is fine as list is called from delete where we log the ids. if needed we can log full resource in delete itself.","commit_id":"2c88bc59bdef528a1dcef6e952ded6f86d8e72d9"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9d968ab95602a4b368acb82479a44e322a09bd0f","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        if self.is_preserve:"},{"line_number":430,"context_line":"            networks \u003d [network for network in networks"},{"line_number":431,"context_line":"                        if network[\u0027id\u0027] not in CONF_NETWORKS]"},{"line_number":432,"context_line":"        LOG.debug(\"List count, %s Networks\", len(networks))"},{"line_number":433,"context_line":"        return networks"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    def delete(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_40e35206","line":432,"range":{"start_line":432,"start_character":44,"end_line":432,"end_character":59},"in_reply_to":"3f4c43b2_8ed6324f","updated":"2020-04-14 08:39:27.000000000","message":"any suggestion what else would be better to print here? We print number of the resources in all list methods and id of the resource in all delete methods.","commit_id":"2c88bc59bdef528a1dcef6e952ded6f86d8e72d9"}]}