)]}'
{"id":"openstack%2Ftempest~719873","triplet_id":"openstack%2Ftempest~master~If24913b7097c5252a214bb780fc786aa0c3f983b","project":"openstack/tempest","branch":"master","topic":"ironic","hashtags":[],"change_id":"If24913b7097c5252a214bb780fc786aa0c3f983b","subject":"Explicitly handle baremetal ports when checking if they are active","status":"MERGED","created":"2020-04-14 10:18:09.000000000","updated":"2020-04-15 05:58:36.000000000","submitted":"2020-04-15 05:55:50.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"719873-1586930150521-69063b05","meta_rev_id":"e6e1ebc046fa1b50e0d9c2e8f5f4467633c5801d","_number":719873,"virtual_id_number":719873,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-04-15 05:55:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"all":[{"value":2,"date":"2020-04-15 01:55:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":2,"date":"2020-04-15 01:52:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"all":[{"value":1,"date":"2020-04-15 01:55:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Release Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-14 10:23:57.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2020-04-15 01:52:01.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2020-04-15 01:55:32.000000000","updated_by":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"reviewer":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"state":"REVIEWER"},{"updated":"2020-04-15 05:55:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9af31aabd925d58f28967fb8c982bf3bb5726afb","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-04-14 10:18:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e55e52ebc25337f1af740c99cafd4cfd0f8e793d","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-04-14 10:23:57.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"735739e46acd535b488a5d9dbe0fd551531544c1","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-04-14 15:05:16.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nlooks good but inactive ports need fix.","accounts_in_message":[],"_revision_number":1},{"id":"623b6ec2cf3646bfae8de7364ef19f064dbf68e6","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-04-14 15:10:42.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"014e55ff14cbdaa98672110043faeb3a2d59f8ff","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-04-14 16:12:26.000000000","message":"Patch Set 2: Code-Review+1\n\nThanks. lgtm, waiting for gate result and we are good to go.","accounts_in_message":[],"_revision_number":2},{"id":"28aa2cbb55d6af2edf550ce591d1ddb541db2234","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-15 00:00:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/eca2d2e555994939852319e0f95c8047 : SUCCESS in 1h 23m 19s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/01e76c5538fe44e5a8843e75d12296b6 : SUCCESS in 1h 32m 55s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/734eb6510e464c10acfed783feaba1d0 : SUCCESS in 4m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e445df8806ce49278625b9ee4c2ab51a : SUCCESS in 5m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/50a40cbc14134b3db23a551bea62eac1 : SUCCESS in 4m 22s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/17dd891eedc148108ccb06c141b2c692 : SUCCESS in 7m 22s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/844d2c2cc6064bec828bdb07a5e8ddcb : SUCCESS in 7m 03s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/00e4c34e4b984e0a9b87a67724ab1d10 : SUCCESS in 10m 21s\n- tempest-full-parallel https://zuul.opendev.org/t/openstack/build/3c5ea9702fcd426884feb5d8cf349e74 : TIMED_OUT in 2h 07m 55s (non-voting)\n- tempest-full-py3-ipv6 https://zuul.opendev.org/t/openstack/build/6657a452e7f5466a8d164477877c71cf : SUCCESS in 1h 25m 09s (non-voting)\n- tempest-full-train-py3 https://zuul.opendev.org/t/openstack/build/3430c033dcb94b5b8e795b3b16e3a755 : SUCCESS in 1h 18m 21s\n- tempest-full-stein-py3 https://zuul.opendev.org/t/openstack/build/a12dd0d66b7a4499a26a2ae6b6c3524c : SUCCESS in 1h 48m 10s\n- tempest-full-rocky-py3 https://zuul.opendev.org/t/openstack/build/17015d059091428a95b1318b36afb48f : SUCCESS in 1h 17m 33s\n- tempest-multinode-full-py3 https://zuul.opendev.org/t/openstack/build/bf92579762454d7d9b99386c61a34e94 : SUCCESS in 1h 46m 08s\n- tempest-tox-plugin-sanity-check https://zuul.opendev.org/t/openstack/build/f560665660ba4f109df1a54bbf40584a : SUCCESS in 48m 49s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c0228834ebfd4ba595b385494eb933ab : SUCCESS in 1h 02m 26s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/c5b50ab4b8814c0ea4fe5e4d67dc4167 : SUCCESS in 2h 40m 35s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/50a51b72abc34f2889c1c0557791b08f : SUCCESS in 55m 36s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/9e8c7a556bee4597a8f0f80b0b0457b8 : SUCCESS in 1h 09m 36s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/a9e047843cf94ddcaa01ec04eccc9d31 : SUCCESS in 1h 22m 16s\n- neutron-tempest-dvr https://zuul.opendev.org/t/openstack/build/8116c3dfa21043238973ee50af401c4c : SUCCESS in 1h 24m 26s\n- interop-tempest-consistency https://zuul.opendev.org/t/openstack/build/2d71ced0a1724929b5827e812335218e : SUCCESS in 4m 38s\n- tempest-full-test-account-py3 https://zuul.opendev.org/t/openstack/build/5db64f34eb0b473aae5f67a1eece7db5 : SUCCESS in 1h 15m 50s (non-voting)\n- tempest-full-test-account-no-admin-py3 https://zuul.opendev.org/t/openstack/build/3cbf8df5b17c4407a26600751eaa21f2 : SUCCESS in 1h 13m 07s (non-voting)\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/c6221197fc044d12bebc61167c6bbd8a : SUCCESS in 5m 12s","accounts_in_message":[],"_revision_number":2},{"id":"d9cb3c8218f17dab3f29b2fb3c136dabd8a3ca88","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-04-15 01:52:01.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"16ea31727edc93b540efd9c5026e7e80ddc6fcb4","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-04-15 01:52:38.000000000","message":"Patch Set 2:\n\ntest result for stein grenade job- https://review.opendev.org/#/c/719895/","accounts_in_message":[],"_revision_number":2},{"id":"eef5a693bc86a6aab7d3f02b47943c5de300f498","author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"date":"2020-04-15 01:55:32.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"38b49d4216b8f96cff230e8244948b31d9781596","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-15 01:56:02.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"2f57a6c8ac5ddf97c78797fb16b34be130848f35","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-15 05:55:50.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"77b7dfcac053023935a4ea23b86fa300da3e948a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-15 05:55:50.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/8b67006a7fa34a8d923a59261e0ce48e : SUCCESS in 59m 42s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/89a04f197fe94269b9790f31ae65279d : SUCCESS in 1h 26m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9cb2c8b8cef4483286a1e2e0f8cabd4f : SUCCESS in 4m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5ff9cc7c0ff94727b9d9c02e7c8981af : SUCCESS in 5m 17s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/d5091657437a4c089b1059475ef55f2e : SUCCESS in 4m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fc677828774d4c00aaf0f7e4a89a993e : SUCCESS in 8m 27s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/08f6897d9aed4740aa243f7808ca78db : SUCCESS in 2h 19m 52s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/00f96ff89d2f4eb28050bff909d0e274 : SUCCESS in 1h 20m 04s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/856f1bf14732409dbcb4395a976fb2e6 : SUCCESS in 1h 04m 45s","accounts_in_message":[],"_revision_number":2},{"id":"780479566277a1cb8350a6ad37953c4d133b7bc3","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-15 05:58:36.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e3d2f97414cc49e0963c8169d3b03538 : SUCCESS in 2m 06s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5c191faae78f52f876edba72484ea644d3df04fd","revisions":{"69697ceade0902ba946a876c162ac9aa6ccaeb27":{"kind":"REWORK","_number":1,"created":"2020-04-14 10:18:09.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/73/719873/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tempest","ref":"refs/changes/73/719873/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tempest refs/changes/73/719873/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tempest refs/changes/73/719873/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tempest refs/changes/73/719873/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tempest refs/changes/73/719873/1"}}},"commit":{"parents":[{"commit":"3d13f07ed64c3f8c5ae1b6366600841366e713d2","subject":"Merge \"Fix deletion of network quotas\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/3d13f07ed64c3f8c5ae1b6366600841366e713d2"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-04-14 10:13:09.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-04-14 10:17:59.000000000","tz":120},"subject":"Explicitly handle baremetal ports when checking if they are active","message":"Explicitly handle baremetal ports when checking if they are active\n\nCurrently we rely on [service_available]ironic which\n1) will give incorrect results in a mixed environment\n2) doesn\u0027t work in grenade jobs\n\nThis change only allows ports to be DOWN when they have VNIC type\nof baremetal.\n\nChange-Id: If24913b7097c5252a214bb780fc786aa0c3f983b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/69697ceade0902ba946a876c162ac9aa6ccaeb27"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/69697ceade0902ba946a876c162ac9aa6ccaeb27"}]},"branch":"refs/heads/master"},"5c191faae78f52f876edba72484ea644d3df04fd":{"kind":"REWORK","_number":2,"created":"2020-04-14 15:10:42.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/73/719873/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tempest","ref":"refs/changes/73/719873/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tempest refs/changes/73/719873/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tempest refs/changes/73/719873/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tempest refs/changes/73/719873/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tempest refs/changes/73/719873/2"}}},"commit":{"parents":[{"commit":"3d13f07ed64c3f8c5ae1b6366600841366e713d2","subject":"Merge \"Fix deletion of network quotas\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/3d13f07ed64c3f8c5ae1b6366600841366e713d2"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-04-14 10:13:09.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-04-14 15:10:20.000000000","tz":120},"subject":"Explicitly handle baremetal ports when checking if they are active","message":"Explicitly handle baremetal ports when checking if they are active\n\nCurrently we rely on [service_available]ironic which\n1) will give incorrect results in a mixed environment\n2) doesn\u0027t work in grenade jobs\n\nThis change only allows ports to be DOWN when they have VNIC type\nof baremetal.\n\nChange-Id: If24913b7097c5252a214bb780fc786aa0c3f983b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/5c191faae78f52f876edba72484ea644d3df04fd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/5c191faae78f52f876edba72484ea644d3df04fd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}